[{"id":1768056,"web_url":"http://patchwork.ozlabs.org/comment/1768056/","msgid":"","list_archive_url":null,"date":"2017-09-13T17:39:48","subject":"Re: [Qemu-devel] [PATCH v2] accel: default to an actually available\n\taccelerator","submitter":{"id":66152,"url":"http://patchwork.ozlabs.org/api/people/66152/","name":"Thomas Huth","email":"thuth@redhat.com"},"content":"On 13.09.2017 19:29, Cornelia Huck wrote:\n> configure_accelerator() falls back to tcg if no accelerator has\n> been specified. Formerly, we could be sure that tcg is always\n> available; however, with --disable-tcg, this is not longer true,\n> and you are not able to start qemu without explicitly specifying\n> another accelerator on those builds.\n> \n> Instead, choose an accelerator in the order tcg->kvm->hax.\n> \n> Signed-off-by: Cornelia Huck \n> ---\n> RFC->v2:\n> - drop xen from the list of fallbacks\n> - use comma-delimited list of accelerators (much easier)\n> - changed one place in qemu-options.hx that had been missed\n> ---\n> accel/accel.c | 3 +--\n> qemu-options.hx | 8 +++++---\n> 2 files changed, 6 insertions(+), 5 deletions(-)\n> \n> diff --git a/accel/accel.c b/accel/accel.c\n> index 8ae40e1e13..e8a3121d06 100644\n> --- a/accel/accel.c\n> +++ b/accel/accel.c\n> @@ -79,8 +79,7 @@ void configure_accelerator(MachineState *ms)\n> \n> accel = qemu_opt_get(qemu_get_machine_opts(), \"accel\");\n> if (accel == NULL) {\n> - /* Use the default \"accelerator\", tcg */\n> - accel = \"tcg\";\n> + accel = \"tcg:kvm:hax\";\n> }\n> \n> p = accel;\n> diff --git a/qemu-options.hx b/qemu-options.hx\n> index 9f6e2adfff..2ff88389e0 100644\n> --- a/qemu-options.hx\n> +++ b/qemu-options.hx\n> @@ -31,7 +31,7 @@ DEF(\"machine\", HAS_ARG, QEMU_OPTION_machine, \\\n> \"-machine [type=]name[,prop[=value][,...]]\\n\"\n> \" selects emulated machine ('-machine help' for list)\\n\"\n> \" property accel=accel1[:accel2[:...]] selects accelerator\\n\"\n> - \" supported accelerators are kvm, xen, hax or tcg (default: tcg)\\n\"\n> + \" supported accelerators are kvm, xen, hax or tcg (default: tcg:kvm:hax)\\n\"\n> \" kernel_irqchip=on|off|split controls accelerated irqchip support (default=off)\\n\"\n> \" vmport=on|off|auto controls emulation of vmport (default: auto)\\n\"\n> \" kvm_shadow_mem=size of KVM shadow MMU in bytes\\n\"\n> @@ -66,7 +66,8 @@ Supported machine properties are:\n> @table @option\n> @item accel=@var{accels1}[:@var{accels2}[:...]]\n> This is used to enable an accelerator. Depending on the target architecture,\n> -kvm, xen, hax or tcg can be available. By default, tcg is used. If there is\n> +kvm, xen, hax or tcg can be available. By default, the first one available\n> +out of tcg, kvm, hax (in that order) is used. If there is\n> more than one accelerator specified, the next one is used if the previous one\n> fails to initialize.\n> @item kernel_irqchip=on|off\n> @@ -126,7 +127,8 @@ STEXI\n> @item -accel @var{name}[,prop=@var{value}[,...]]\n> @findex -accel\n> This is used to enable an accelerator. Depending on the target architecture,\n> -kvm, xen, hax or tcg can be available. By default, tcg is used. If there is\n> +kvm, xen, hax or tcg can be available. By default, the first one available\n> +out of tcg, kvm, hax (in that order) is used. If there is\n> more than one accelerator specified, the next one is used if the previous one\n> fails to initialize.\n> @table @option\n\nReviewed-by: Thomas Huth ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=thuth@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xsppW6bZkz9sNw\n\tfor ;\n\tThu, 14 Sep 2017 03:40:19 +1000 (AEST)","from localhost ([::1]:43855 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dsBe6-000355-3F\n\tfor incoming@patchwork.ozlabs.org; Wed, 13 Sep 2017 13:40:18 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:47512)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dsBdl-00034d-T8\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 13:39:59 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dsBdi-00025A-JO\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 13:39:57 -0400","from mx1.redhat.com ([209.132.183.28]:38744)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dsBdi-00024B-AW\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 13:39:54 -0400","from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 1A257C0587C5;\n\tWed, 13 Sep 2017 17:39:53 +0000 (UTC)","from [10.36.116.123] (ovpn-116-123.ams2.redhat.com [10.36.116.123])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id C0D7361799;\n\tWed, 13 Sep 2017 17:39:49 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 1A257C0587C5","To":"Cornelia Huck , qemu-devel@nongnu.org","References":"<20170913172941.5470-1-cohuck@redhat.com>","From":"Thomas Huth ","Message-ID":"","Date":"Wed, 13 Sep 2017 19:39:48 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170913172941.5470-1-cohuck@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.16","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.32]);\n\tWed, 13 Sep 2017 17:39:53 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v2] accel: default to an actually available\n\taccelerator","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"lvivier@redhat.com, peter.maydell@linaro.org,\n\trichard.henderson@linaro.org, \n\tmreitz@redhat.com, kwolf@redhat.com, pbonzini@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1768075,"web_url":"http://patchwork.ozlabs.org/comment/1768075/","msgid":"","list_archive_url":null,"date":"2017-09-13T18:09:04","subject":"Re: [Qemu-devel] [PATCH v2] accel: default to an actually available\n\taccelerator","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/people/72104/","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"content":"On 09/13/2017 10:29 AM, Cornelia Huck wrote:\n> configure_accelerator() falls back to tcg if no accelerator has\n> been specified. Formerly, we could be sure that tcg is always\n> available; however, with --disable-tcg, this is not longer true,\n> and you are not able to start qemu without explicitly specifying\n> another accelerator on those builds.\n> \n> Instead, choose an accelerator in the order tcg->kvm->hax.\n> \n> Signed-off-by: Cornelia Huck \n> ---\n> RFC->v2:\n> - drop xen from the list of fallbacks\n> - use comma-delimited list of accelerators (much easier)\n> - changed one place in qemu-options.hx that had been missed\n\nQueued to tcg-next. Thanks,\n\n\nr~","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"CV2Oep7X\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xsqST1vgcz9s7v\n\tfor ;\n\tThu, 14 Sep 2017 04:09:41 +1000 (AEST)","from localhost ([::1]:43941 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dsC6T-0001Xb-SI\n\tfor incoming@patchwork.ozlabs.org; Wed, 13 Sep 2017 14:09:37 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:60889)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dsC67-0001XK-0m\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 14:09:15 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dsC63-00033a-Sc\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 14:09:14 -0400","from mail-qt0-x232.google.com ([2607:f8b0:400d:c0d::232]:45813)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1dsC63-00033O-OZ\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 14:09:11 -0400","by mail-qt0-x232.google.com with SMTP id t46so2481268qtj.2\n\tfor ; Wed, 13 Sep 2017 11:09:11 -0700 (PDT)","from bigtime.twiddle.net (184-217-192-88.pools.spcsdns.net.\n\t[184.217.192.88]) by smtp.gmail.com with ESMTPSA id\n\tp25sm10201348qte.28.2017.09.13.11.09.08\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 13 Sep 2017 11:09:10 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=RgGhRG0L0BFvliN+3ruzJXUp27AKeWQZGCmdIB3dRH0=;\n\tb=CV2Oep7Xee4rEkkls+Glr/8UHikxzmxAvugK08c3urbVpkJlOX3smEZcoiWakMw8yv\n\t420w4pKhKUrCm5mXeYozSEToqhqlWiUMxlxSodzGM5el7NyOz4nS/ONaa3/mcSt0Zx9T\n\ttPNRWCIfjJW7mz5HMMiFk3IuwVUqVr7O9/gAk=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=RgGhRG0L0BFvliN+3ruzJXUp27AKeWQZGCmdIB3dRH0=;\n\tb=OxSmXU1MfybVvfORiyIxhAJqiyuw8dTp26UeNcQMJPG7HF/UIbrHEK70yc+pyjS59v\n\tPUD1n5ya9lOEpfFAYO2zY7SWZxOUtam1YFG/eDc0Zio0AMQv6FfwBqA9naCQnxg0pX2m\n\tu1gu/hIg2DjUNsLHeNhWnpmyRpXCcyZ+yVNeH4HL4Mjb/4RVCPIhvFZ5ySt8mDDT2sas\n\taJbXp3+2CmhQq9jVp8trnOlBjCjajTXr7mIiD460DRv00KR1rFMLKk0rk2EsHHwlHAuZ\n\tx8Lz17w312I1rqft3RHGMrBy3JjbbKnckbM3LoZh19kKl4veqXqjtN9UdmwHDhVyMMbS\n\tByEg==","X-Gm-Message-State":"AHPjjUji/3B2tX7Cky91iPc/TEXcyqIbkKmwf/T32x5oeMQayoUcCm+0\n\tkKE92NCwX0UjHJYu","X-Google-Smtp-Source":"AOwi7QDIV1js/q6FCg7U5M3qppfB09a+X6oTSpImAowfMCOpdqs7+YB++klel7Y616xwF447rZc8fQ==","X-Received":"by 10.200.38.68 with SMTP id v4mr15429498qtv.128.1505326151332; \n\tWed, 13 Sep 2017 11:09:11 -0700 (PDT)","To":"Cornelia Huck , qemu-devel@nongnu.org","References":"<20170913172941.5470-1-cohuck@redhat.com>","From":"Richard Henderson ","Message-ID":"","Date":"Wed, 13 Sep 2017 11:09:04 -0700","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170913172941.5470-1-cohuck@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2607:f8b0:400d:c0d::232","Subject":"Re: [Qemu-devel] [PATCH v2] accel: default to an actually available\n\taccelerator","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"lvivier@redhat.com, peter.maydell@linaro.org, thuth@redhat.com,\n\tmreitz@redhat.com, kwolf@redhat.com, pbonzini@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1800689,"web_url":"http://patchwork.ozlabs.org/comment/1800689/","msgid":"<20171107175922.201c2055.cohuck@redhat.com>","list_archive_url":null,"date":"2017-11-07T16:59:22","subject":"Re: [Qemu-devel] [PATCH v2] accel: default to an actually available\n\taccelerator","submitter":{"id":71914,"url":"http://patchwork.ozlabs.org/api/people/71914/","name":"Cornelia Huck","email":"cohuck@redhat.com"},"content":"On Wed, 13 Sep 2017 11:09:04 -0700\nRichard Henderson wrote:\n\n> On 09/13/2017 10:29 AM, Cornelia Huck wrote:\n> > configure_accelerator() falls back to tcg if no accelerator has\n> > been specified. Formerly, we could be sure that tcg is always\n> > available; however, with --disable-tcg, this is not longer true,\n> > and you are not able to start qemu without explicitly specifying\n> > another accelerator on those builds.\n> > \n> > Instead, choose an accelerator in the order tcg->kvm->hax.\n> > \n> > Signed-off-by: Cornelia Huck \n> > ---\n> > RFC->v2:\n> > - drop xen from the list of fallbacks\n> > - use comma-delimited list of accelerators (much easier)\n> > - changed one place in qemu-options.hx that had been missed \n> \n> Queued to tcg-next. Thanks,\n\nHm, has this fallen through the cracks?","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx04.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx04.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=cohuck@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yWbK12R8Rz9s4q\n\tfor ;\n\tWed, 8 Nov 2017 04:00:19 +1100 (AEDT)","from localhost ([::1]:54408 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1eC7EX-00059o-2b\n\tfor incoming@patchwork.ozlabs.org; Tue, 07 Nov 2017 12:00:17 -0500","from eggs.gnu.org ([2001:4830:134:3::10]:43149)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1eC7Dr-00058K-Vy\n\tfor qemu-devel@nongnu.org; Tue, 07 Nov 2017 11:59:36 -0500","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1eC7Do-00006H-4t\n\tfor qemu-devel@nongnu.org; Tue, 07 Nov 2017 11:59:36 -0500","from mx1.redhat.com ([209.132.183.28]:52712)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1eC7Dn-00005q-V7\n\tfor qemu-devel@nongnu.org; Tue, 07 Nov 2017 11:59:32 -0500","from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 9DC7E7E380;\n\tTue, 7 Nov 2017 16:59:30 +0000 (UTC)","from gondolin (ovpn-117-156.ams2.redhat.com [10.36.117.156])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 7A31F60264;\n\tTue, 7 Nov 2017 16:59:24 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 9DC7E7E380","Date":"Tue, 7 Nov 2017 17:59:22 +0100","From":"Cornelia Huck ","To":"Richard Henderson ","Message-ID":"<20171107175922.201c2055.cohuck@redhat.com>","In-Reply-To":"","References":"<20170913172941.5470-1-cohuck@redhat.com>\n\t","Organization":"Red Hat GmbH","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.12","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.28]);\n\tTue, 07 Nov 2017 16:59:30 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v2] accel: default to an actually available\n\taccelerator","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"lvivier@redhat.com, kwolf@redhat.com, thuth@redhat.com,\n\tpeter.maydell@linaro.org, qemu-devel@nongnu.org,\n\tmreitz@redhat.com, pbonzini@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]