[{"id":1768631,"web_url":"http://patchwork.ozlabs.org/comment/1768631/","msgid":"<20170914162603.1cdabd09.cohuck@redhat.com>","list_archive_url":null,"date":"2017-09-14T14:26:03","subject":"Re: [Qemu-devel] [PATCH 1/2] s390x/ccs: add ccw-tester emulated\n\tdevice","submitter":{"id":71914,"url":"http://patchwork.ozlabs.org/api/people/71914/","name":"Cornelia Huck","email":"cohuck@redhat.com"},"content":"On Wed, 13 Sep 2017 15:27:51 +0200\nHalil Pasic wrote:\n\n> Add a fake device meant for testing the correctness of our css emulation.\n> \n> What we currently have is writing a Fibonacci sequence of uint32_t to the\n> device via ccw write. The write is going to fail if it ain't a Fibonacci\n> and indicate a device exception in scsw together with the proper residual\n> count.\n> \n> Of course lot's of invalid inputs (besides basic data processing) can be\n> tested with that as well.\n> \n> Usage:\n> 1) fire up a qemu with something like -device ccw-tester,devno=fe.0.0001\n> on the command line\n> 2) exercise the device from the guest\n> \n> Signed-off-by: Halil Pasic \n> ---\n> \n> Depends on the series 'add CCW indirect data access support'\n> \n> ---\n> hw/s390x/Makefile.objs | 1 +\n> hw/s390x/ccw-tester.c | 179 +++++++++++++++++++++++++++++++++++++++++++++++++\n> 2 files changed, 180 insertions(+)\n> create mode 100644 hw/s390x/ccw-tester.c\n> \n\n> +static int ccw_tester_write_fib(SubchDev *sch, CCW1 ccw)\n> +{\n> + CcwTesterDevice *d = sch->driver_data;\n> + bool is_fib = true;\n> + uint32_t sum;\n> + int ret = 0;\n> +\n> + ccw_dstream_init(&sch->cds, &ccw, &sch->orb);\n> + d->fib.next = 0;\n> + while (ccw_dstream_avail(&sch->cds) > 0) {\n> + ret = ccw_dstream_read(&sch->cds,\n> + d->fib.ring[abs_to_ring(d->fib.next)]);\n> + if (ret) {\n> + error(0, -ret, \"fib\");\n> + break;\n> + }\n> + if (d->fib.next > 2) {\n> + sum = (d->fib.ring[abs_to_ring(d->fib.next - 1)]\n> + + d->fib.ring[abs_to_ring(d->fib.next - 2)]);\n> + is_fib = sum == d->fib.ring[abs_to_ring(d->fib.next)];\n\nThis is not endian-safe (noticed while testing on my laptop). Trivial\nto fix:\n\ndiff --git a/hw/s390x/ccw-tester.c b/hw/s390x/ccw-tester.c\nindex c8017818c4..a425daaa34 100644\n--- a/hw/s390x/ccw-tester.c\n+++ b/hw/s390x/ccw-tester.c\n@@ -58,9 +58,9 @@ static int ccw_tester_write_fib(SubchDev *sch, CCW1 ccw)\n break;\n }\n if (d->fib.next > 2) {\n- sum = (d->fib.ring[abs_to_ring(d->fib.next - 1)]\n- + d->fib.ring[abs_to_ring(d->fib.next - 2)]);\n- is_fib = sum == d->fib.ring[abs_to_ring(d->fib.next)];\n+ sum = be32_to_cpu(d->fib.ring[abs_to_ring(d->fib.next - 1)])\n+ + be32_to_cpu(d->fib.ring[abs_to_ring(d->fib.next - 2)]);\n+ is_fib = sum == be32_to_cpu(d->fib.ring[abs_to_ring(d->fib.next)]);\n if (!is_fib) {\n break;\n }\n\n> + if (!is_fib) {\n> + break;\n> + }\n> + }\n> + ++(d->fib.next);\n> + }\n> + if (!is_fib) {\n> + sch->curr_status.scsw.ctrl &= ~SCSW_ACTL_START_PEND;\n> + sch->curr_status.scsw.ctrl |= SCSW_STCTL_PRIMARY |\n> + SCSW_STCTL_SECONDARY |\n> + SCSW_STCTL_ALERT |\n> + SCSW_STCTL_STATUS_PEND;\n> + sch->curr_status.scsw.count = ccw_dstream_residual_count(&sch->cds);\n> + sch->curr_status.scsw.cpa = sch->channel_prog + 8;\n> + sch->curr_status.scsw.dstat = SCSW_DSTAT_UNIT_EXCEP;\n> + return -EIO;\n> + }\n> + return ret;\n> +}\n> +\n(...)\n> +static Property ccw_tester_properties[] = {\n> + DEFINE_PROP_UINT16(\"cu_type\", CcwTesterDevice, cu_type,\n> + 0x3831),\n\n0x4711 would be nice :)\n\nIf we want to follow up on that testdev idea (and I think we should),\nit might make sense to have a proper type reserve to prevent accidental\nclashes.\n\n(Or is there already something reserved for \"hypervisor use\" or\nwhatever?)\n\n> + DEFINE_PROP_UINT8(\"chpid_type\", CcwTesterDevice, chpid_type,\n> + 0x98),\n> + DEFINE_PROP_END_OF_LIST(),\n> +};\n\nIIUC, pci-testdev provides some unit tests to testers (like kvm-tests)\nitself. This might be an idea to follow up on for ccw as well.\n\nThere's quite some potential in this. We may want to make this a\npermanent addition.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx03.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx03.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=cohuck@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xtLSZ0j0Mz9s4s\n\tfor ;\n\tFri, 15 Sep 2017 00:26:38 +1000 (AEST)","from localhost ([::1]:48111 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dsV6C-0006EQ-6W\n\tfor incoming@patchwork.ozlabs.org; Thu, 14 Sep 2017 10:26:36 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:37969)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dsV5p-0006CL-9N\n\tfor qemu-devel@nongnu.org; Thu, 14 Sep 2017 10:26:14 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dsV5m-0007fo-2g\n\tfor qemu-devel@nongnu.org; Thu, 14 Sep 2017 10:26:13 -0400","from mx1.redhat.com ([209.132.183.28]:38216)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dsV5l-0007fA-QX\n\tfor qemu-devel@nongnu.org; Thu, 14 Sep 2017 10:26:10 -0400","from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id C8CC783F40;\n\tThu, 14 Sep 2017 14:26:08 +0000 (UTC)","from gondolin (ovpn-204-195.brq.redhat.com [10.40.204.195])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 5FAB7617A8;\n\tThu, 14 Sep 2017 14:26:07 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com C8CC783F40","Date":"Thu, 14 Sep 2017 16:26:03 +0200","From":"Cornelia Huck ","To":"Halil Pasic ","Message-ID":"<20170914162603.1cdabd09.cohuck@redhat.com>","In-Reply-To":"<20170913132752.8484-2-pasic@linux.vnet.ibm.com>","References":"<20170913132752.8484-1-pasic@linux.vnet.ibm.com>\n\t<20170913132752.8484-2-pasic@linux.vnet.ibm.com>","Organization":"Red Hat GmbH","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.16","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.27]);\n\tThu, 14 Sep 2017 14:26:08 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH 1/2] s390x/ccs: add ccw-tester emulated\n\tdevice","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Dong Jia Shi ,\n\tPierre Morel , qemu-devel@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1768727,"web_url":"http://patchwork.ozlabs.org/comment/1768727/","msgid":"<0b42ef59-4366-175f-8dc7-bc3ed02e2fb4@linux.vnet.ibm.com>","list_archive_url":null,"date":"2017-09-14T16:50:29","subject":"Re: [Qemu-devel] [PATCH 1/2] s390x/ccs: add ccw-tester emulated\n\tdevice","submitter":{"id":68297,"url":"http://patchwork.ozlabs.org/api/people/68297/","name":"Halil Pasic","email":"pasic@linux.vnet.ibm.com"},"content":"On 09/14/2017 04:26 PM, Cornelia Huck wrote:\n> On Wed, 13 Sep 2017 15:27:51 +0200\n> Halil Pasic wrote:\n> \n>> Add a fake device meant for testing the correctness of our css emulation.\n>>\n>> What we currently have is writing a Fibonacci sequence of uint32_t to the\n>> device via ccw write. The write is going to fail if it ain't a Fibonacci\n>> and indicate a device exception in scsw together with the proper residual\n>> count.\n>>\n>> Of course lot's of invalid inputs (besides basic data processing) can be\n>> tested with that as well.\n>>\n>> Usage:\n>> 1) fire up a qemu with something like -device ccw-tester,devno=fe.0.0001\n>> on the command line\n>> 2) exercise the device from the guest\n>>\n>> Signed-off-by: Halil Pasic \n>> ---\n>>\n>> Depends on the series 'add CCW indirect data access support'\n>>\n>> ---\n>> hw/s390x/Makefile.objs | 1 +\n>> hw/s390x/ccw-tester.c | 179 +++++++++++++++++++++++++++++++++++++++++++++++++\n>> 2 files changed, 180 insertions(+)\n>> create mode 100644 hw/s390x/ccw-tester.c\n>>\n> \n>> +static int ccw_tester_write_fib(SubchDev *sch, CCW1 ccw)\n>> +{\n>> + CcwTesterDevice *d = sch->driver_data;\n>> + bool is_fib = true;\n>> + uint32_t sum;\n>> + int ret = 0;\n>> +\n>> + ccw_dstream_init(&sch->cds, &ccw, &sch->orb);\n>> + d->fib.next = 0;\n>> + while (ccw_dstream_avail(&sch->cds) > 0) {\n>> + ret = ccw_dstream_read(&sch->cds,\n>> + d->fib.ring[abs_to_ring(d->fib.next)]);\n>> + if (ret) {\n>> + error(0, -ret, \"fib\");\n>> + break;\n>> + }\n>> + if (d->fib.next > 2) {\n>> + sum = (d->fib.ring[abs_to_ring(d->fib.next - 1)]\n>> + + d->fib.ring[abs_to_ring(d->fib.next - 2)]);\n>> + is_fib = sum == d->fib.ring[abs_to_ring(d->fib.next)];\n> \n> This is not endian-safe (noticed while testing on my laptop). Trivial\n> to fix:\n> \n> diff --git a/hw/s390x/ccw-tester.c b/hw/s390x/ccw-tester.c\n> index c8017818c4..a425daaa34 100644\n> --- a/hw/s390x/ccw-tester.c\n> +++ b/hw/s390x/ccw-tester.c\n> @@ -58,9 +58,9 @@ static int ccw_tester_write_fib(SubchDev *sch, CCW1 ccw)\n> break;\n> }\n> if (d->fib.next > 2) {\n> - sum = (d->fib.ring[abs_to_ring(d->fib.next - 1)]\n> - + d->fib.ring[abs_to_ring(d->fib.next - 2)]);\n> - is_fib = sum == d->fib.ring[abs_to_ring(d->fib.next)];\n> + sum = be32_to_cpu(d->fib.ring[abs_to_ring(d->fib.next - 1)])\n> + + be32_to_cpu(d->fib.ring[abs_to_ring(d->fib.next - 2)]);\n> + is_fib = sum == be32_to_cpu(d->fib.ring[abs_to_ring(d->fib.next)]);\n> if (!is_fib) {\n> break;\n> }\n> \n\nNod. \n\n>> + if (!is_fib) {\n>> + break;\n>> + }\n>> + }\n>> + ++(d->fib.next);\n>> + }\n>> + if (!is_fib) {\n>> + sch->curr_status.scsw.ctrl &= ~SCSW_ACTL_START_PEND;\n>> + sch->curr_status.scsw.ctrl |= SCSW_STCTL_PRIMARY |\n>> + SCSW_STCTL_SECONDARY |\n>> + SCSW_STCTL_ALERT |\n>> + SCSW_STCTL_STATUS_PEND;\n>> + sch->curr_status.scsw.count = ccw_dstream_residual_count(&sch->cds);\n>> + sch->curr_status.scsw.cpa = sch->channel_prog + 8;\n>> + sch->curr_status.scsw.dstat = SCSW_DSTAT_UNIT_EXCEP;\n>> + return -EIO;\n>> + }\n>> + return ret;\n>> +}\n>> +\n> (...)\n>> +static Property ccw_tester_properties[] = {\n>> + DEFINE_PROP_UINT16(\"cu_type\", CcwTesterDevice, cu_type,\n>> + 0x3831),\n> \n> 0x4711 would be nice :)\n\nI don't understand the joke/pun/whatever if there is one,\nbut I'm fine with changing this too.\n\n> \n> If we want to follow up on that testdev idea (and I think we should),\n> it might make sense to have a proper type reserve to prevent accidental\n> clashes.\n\nI agree. Although I would still keep the cu_type configurable,\nbecause it might make sense to test a particular 'real' driver\n(and not a test driver like here). I haven't really thought\nthis through, but it was an idea I had while agonizing over\nnot having a proper type reserved.\n\nI suppose you did something like that for virtio, or? I'm in dark\nwhen it comes to the question what process do we/I have to go to\nget a type,for example 0x4711, reserved.\n\n> \n> (Or is there already something reserved for \"hypervisor use\" or\n> whatever?)\n\nNot that I know. I can't recall encountering a list of reserved\ntypes. Honestly I've hoped to leverage your experience (again\nbecause of virtio-ccw).\n\n> \n>> + DEFINE_PROP_UINT8(\"chpid_type\", CcwTesterDevice, chpid_type,\n>> + 0x98),\n>> + DEFINE_PROP_END_OF_LIST(),\n>> +};\n> \n> IIUC, pci-testdev provides some unit tests to testers (like kvm-tests)\n> itself. This might be an idea to follow up on for ccw as well.\n> \n\nI've just had a first look at pci-testdev, and it does appear to be a similar\nconcept. \n\n> There's quite some potential in this. We may want to make this a\n> permanent addition.\n> \n\nI'm happy to contribute! I'm not sure how shall we proceed though.\nMaybe with making a todo list?","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xtPh83Xvdz9s83\n\tfor ;\n\tFri, 15 Sep 2017 02:51:51 +1000 (AEST)","from localhost ([::1]:48937 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dsXMi-0000eB-Jj\n\tfor incoming@patchwork.ozlabs.org; Thu, 14 Sep 2017 12:51:48 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:37038)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dsXLg-0000Jc-HM\n\tfor qemu-devel@nongnu.org; Thu, 14 Sep 2017 12:50:45 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dsXLc-0007h5-93\n\tfor qemu-devel@nongnu.org; Thu, 14 Sep 2017 12:50:44 -0400","from mx0a-001b2d01.pphosted.com ([148.163.156.1]:34406)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dsXLb-0007fN-GK\n\tfor qemu-devel@nongnu.org; Thu, 14 Sep 2017 12:50:40 -0400","from pps.filterd (m0098410.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv8EGoXwX064038\n\tfor ; Thu, 14 Sep 2017 12:50:37 -0400","from e06smtp15.uk.ibm.com (e06smtp15.uk.ibm.com [195.75.94.111])\n\tby mx0a-001b2d01.pphosted.com with ESMTP id 2cyu309k4v-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor ; Thu, 14 Sep 2017 12:50:37 -0400","from localhost\n\tby e06smtp15.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor from ;\n\tThu, 14 Sep 2017 17:50:33 +0100","from b06cxnps4074.portsmouth.uk.ibm.com (9.149.109.196)\n\tby e06smtp15.uk.ibm.com (192.168.101.145) with IBM ESMTP SMTP\n\tGateway: Authorized Use Only! Violators will be prosecuted; \n\tThu, 14 Sep 2017 17:50:30 +0100","from d06av23.portsmouth.uk.ibm.com (d06av23.portsmouth.uk.ibm.com\n\t[9.149.105.59])\n\tby b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with\n\tESMTP id v8EGoUFc12124264; Thu, 14 Sep 2017 16:50:30 GMT","from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 0388FA4040;\n\tThu, 14 Sep 2017 17:46:39 +0100 (BST)","from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id B09C1A4053;\n\tThu, 14 Sep 2017 17:46:38 +0100 (BST)","from oc3836556865.ibm.com (unknown [9.152.224.207])\n\tby d06av23.portsmouth.uk.ibm.com (Postfix) with ESMTP;\n\tThu, 14 Sep 2017 17:46:38 +0100 (BST)"],"To":"Cornelia Huck ","References":"<20170913132752.8484-1-pasic@linux.vnet.ibm.com>\n\t<20170913132752.8484-2-pasic@linux.vnet.ibm.com>\n\t<20170914162603.1cdabd09.cohuck@redhat.com>","From":"Halil Pasic ","Date":"Thu, 14 Sep 2017 18:50:29 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.0","MIME-Version":"1.0","In-Reply-To":"<20170914162603.1cdabd09.cohuck@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"8bit","X-TM-AS-GCONF":"00","x-cbid":"17091416-0020-0000-0000-000003B805CF","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17091416-0021-0000-0000-000042498247","Message-Id":"<0b42ef59-4366-175f-8dc7-bc3ed02e2fb4@linux.vnet.ibm.com>","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-09-14_05:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=0\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1709140251","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy]","X-Received-From":"148.163.156.1","Subject":"Re: [Qemu-devel] [PATCH 1/2] s390x/ccs: add ccw-tester emulated\n\tdevice","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Dong Jia Shi ,\n\tPierre Morel , qemu-devel@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1768989,"web_url":"http://patchwork.ozlabs.org/comment/1768989/","msgid":"<20170915092758.16ea52fc.cohuck@redhat.com>","list_archive_url":null,"date":"2017-09-15T07:27:58","subject":"Re: [Qemu-devel] [PATCH 1/2] s390x/ccs: add ccw-tester emulated\n\tdevice","submitter":{"id":71914,"url":"http://patchwork.ozlabs.org/api/people/71914/","name":"Cornelia Huck","email":"cohuck@redhat.com"},"content":"On Thu, 14 Sep 2017 18:50:29 +0200\nHalil Pasic wrote:\n\n> On 09/14/2017 04:26 PM, Cornelia Huck wrote:\n> > On Wed, 13 Sep 2017 15:27:51 +0200\n> > Halil Pasic wrote:\n\n> >> +static Property ccw_tester_properties[] = {\n> >> + DEFINE_PROP_UINT16(\"cu_type\", CcwTesterDevice, cu_type,\n> >> + 0x3831), \n> > \n> > 0x4711 would be nice :) \n> \n> I don't understand the joke/pun/whatever if there is one,\n> but I'm fine with changing this too.\n\nhttps://en.wikipedia.org/wiki/4711\n\nThat's my default if I need a four-digit number :)\n\n> \n> > \n> > If we want to follow up on that testdev idea (and I think we should),\n> > it might make sense to have a proper type reserve to prevent accidental\n> > clashes. \n> \n> I agree. Although I would still keep the cu_type configurable,\n> because it might make sense to test a particular 'real' driver\n> (and not a test driver like here). I haven't really thought\n> this through, but it was an idea I had while agonizing over\n> not having a proper type reserved.\n> \n> I suppose you did something like that for virtio, or? I'm in dark\n> when it comes to the question what process do we/I have to go to\n> get a type,for example 0x4711, reserved.\n\n4711 is more a joke :) It might be worth trying the same channels as\nfor virtio-ccw.\n\nChristian should know more about that.\n\n> \n> > \n> > (Or is there already something reserved for \"hypervisor use\" or\n> > whatever?) \n> \n> Not that I know. I can't recall encountering a list of reserved\n> types. Honestly I've hoped to leverage your experience (again\n> because of virtio-ccw).\n\nMy thought was that the z/VM folks already might have something\n(type-wise) that we could use as well. There's a surprising amount of\nvalues that are reserved for one use or the other. But obviously, I\ncan't find out about that.\n\n> \n> > \n> >> + DEFINE_PROP_UINT8(\"chpid_type\", CcwTesterDevice, chpid_type,\n> >> + 0x98),\n\nThis might also need re-evaluation - we should not really need a new\nchpid type.\n\n> >> + DEFINE_PROP_END_OF_LIST(),\n> >> +}; \n> > \n> > IIUC, pci-testdev provides some unit tests to testers (like kvm-tests)\n> > itself. This might be an idea to follow up on for ccw as well.\n> > \n> \n> I've just had a first look at pci-testdev, and it does appear to be a similar\n> concept. \n> \n> > There's quite some potential in this. We may want to make this a\n> > permanent addition.\n> > \n> \n> I'm happy to contribute! I'm not sure how shall we proceed though.\n> Maybe with making a todo list?\n\nI think the first step would be to figure out the ids so we don't step\non anyone's toes. Then maybe refactor a bit so that other testers can\nbe added easily.\n\nFor ideas about things to be tested, maybe put a list into the wiki?","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=cohuck@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xtn7r2d1Wz9sPs\n\tfor ;\n\tFri, 15 Sep 2017 17:28:40 +1000 (AEST)","from localhost ([::1]:51732 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dsl3G-0000c0-Eq\n\tfor incoming@patchwork.ozlabs.org; Fri, 15 Sep 2017 03:28:38 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:46132)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dsl2j-0000a1-R0\n\tfor qemu-devel@nongnu.org; Fri, 15 Sep 2017 03:28:09 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dsl2i-0007qA-OI\n\tfor qemu-devel@nongnu.org; Fri, 15 Sep 2017 03:28:05 -0400","from mx1.redhat.com ([209.132.183.28]:57090)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dsl2i-0007pt-Ew\n\tfor qemu-devel@nongnu.org; Fri, 15 Sep 2017 03:28:04 -0400","from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 6B8C2883C4;\n\tFri, 15 Sep 2017 07:28:03 +0000 (UTC)","from gondolin (ovpn-117-60.ams2.redhat.com [10.36.117.60])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 77723177F3;\n\tFri, 15 Sep 2017 07:28:01 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 6B8C2883C4","Date":"Fri, 15 Sep 2017 09:27:58 +0200","From":"Cornelia Huck ","To":"Halil Pasic ","Message-ID":"<20170915092758.16ea52fc.cohuck@redhat.com>","In-Reply-To":"<0b42ef59-4366-175f-8dc7-bc3ed02e2fb4@linux.vnet.ibm.com>","References":"<20170913132752.8484-1-pasic@linux.vnet.ibm.com>\n\t<20170913132752.8484-2-pasic@linux.vnet.ibm.com>\n\t<20170914162603.1cdabd09.cohuck@redhat.com>\n\t<0b42ef59-4366-175f-8dc7-bc3ed02e2fb4@linux.vnet.ibm.com>","Organization":"Red Hat GmbH","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.16","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.26]);\n\tFri, 15 Sep 2017 07:28:03 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH 1/2] s390x/ccs: add ccw-tester emulated\n\tdevice","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Christian Borntraeger ,\n\tDong Jia Shi ,\n\tPierre Morel , qemu-devel@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1769309,"web_url":"http://patchwork.ozlabs.org/comment/1769309/","msgid":"<20170915190118.03dc1b57.cohuck@redhat.com>","list_archive_url":null,"date":"2017-09-15T17:01:18","subject":"Re: [Qemu-devel] [PATCH 1/2] s390x/ccs: add ccw-tester emulated\n\tdevice","submitter":{"id":71914,"url":"http://patchwork.ozlabs.org/api/people/71914/","name":"Cornelia Huck","email":"cohuck@redhat.com"},"content":"On Fri, 15 Sep 2017 09:27:58 +0200\nCornelia Huck wrote:\n\n> On Thu, 14 Sep 2017 18:50:29 +0200\n> Halil Pasic wrote:\n> \n> > On 09/14/2017 04:26 PM, Cornelia Huck wrote: \n\n> > > There's quite some potential in this. We may want to make this a\n> > > permanent addition.\n> > > \n> > \n> > I'm happy to contribute! I'm not sure how shall we proceed though.\n> > Maybe with making a todo list? \n> \n> I think the first step would be to figure out the ids so we don't step\n> on anyone's toes. Then maybe refactor a bit so that other testers can\n> be added easily.\n> \n> For ideas about things to be tested, maybe put a list into the wiki?\n\nOK, I've created https://wiki.qemu.org/Testing/CCWTestDevice - let me\nknow if you need an account.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=cohuck@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xv1wG209zz9s7m\n\tfor ;\n\tSat, 16 Sep 2017 03:04:30 +1000 (AEST)","from localhost ([::1]:54300 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dsu2W-0001Ts-DZ\n\tfor incoming@patchwork.ozlabs.org; Fri, 15 Sep 2017 13:04:28 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:50800)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dstzc-00070f-Tr\n\tfor qemu-devel@nongnu.org; Fri, 15 Sep 2017 13:01:34 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dstzY-0005PK-Qn\n\tfor qemu-devel@nongnu.org; Fri, 15 Sep 2017 13:01:29 -0400","from mx1.redhat.com ([209.132.183.28]:40620)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dstzY-0005O3-KU\n\tfor qemu-devel@nongnu.org; Fri, 15 Sep 2017 13:01:24 -0400","from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 5BDE5356F8;\n\tFri, 15 Sep 2017 17:01:23 +0000 (UTC)","from gondolin (ovpn-116-44.ams2.redhat.com [10.36.116.44])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id E72BB70475;\n\tFri, 15 Sep 2017 17:01:21 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 5BDE5356F8","Date":"Fri, 15 Sep 2017 19:01:18 +0200","From":"Cornelia Huck ","To":"Halil Pasic ","Message-ID":"<20170915190118.03dc1b57.cohuck@redhat.com>","In-Reply-To":"<20170915092758.16ea52fc.cohuck@redhat.com>","References":"<20170913132752.8484-1-pasic@linux.vnet.ibm.com>\n\t<20170913132752.8484-2-pasic@linux.vnet.ibm.com>\n\t<20170914162603.1cdabd09.cohuck@redhat.com>\n\t<0b42ef59-4366-175f-8dc7-bc3ed02e2fb4@linux.vnet.ibm.com>\n\t<20170915092758.16ea52fc.cohuck@redhat.com>","Organization":"Red Hat GmbH","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.11","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.30]);\n\tFri, 15 Sep 2017 17:01:23 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH 1/2] s390x/ccs: add ccw-tester emulated\n\tdevice","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Christian Borntraeger ,\n\tDong Jia Shi ,\n\tPierre Morel , qemu-devel@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1769975,"web_url":"http://patchwork.ozlabs.org/comment/1769975/","msgid":"<5626693c-d7be-7c21-37e3-27625e9fbf2b@de.ibm.com>","list_archive_url":null,"date":"2017-09-18T08:30:32","subject":"Re: [Qemu-devel] [PATCH 1/2] s390x/ccs: add ccw-tester emulated\n\tdevice","submitter":{"id":590,"url":"http://patchwork.ozlabs.org/api/people/590/","name":"Christian Borntraeger","email":"borntraeger@de.ibm.com"},"content":"On 09/15/2017 09:27 AM, Cornelia Huck wrote:\n> On Thu, 14 Sep 2017 18:50:29 +0200\n> Halil Pasic wrote:\n> \n>> On 09/14/2017 04:26 PM, Cornelia Huck wrote:\n>>> On Wed, 13 Sep 2017 15:27:51 +0200\n>>> Halil Pasic wrote:\n> \n>>>> +static Property ccw_tester_properties[] = {\n>>>> + DEFINE_PROP_UINT16(\"cu_type\", CcwTesterDevice, cu_type,\n>>>> + 0x3831), \n>>>\n>>> 0x4711 would be nice :) \n>>\n>> I don't understand the joke/pun/whatever if there is one,\n>> but I'm fine with changing this too.\n> \n> https://en.wikipedia.org/wiki/4711\n> \n> That's my default if I need a four-digit number :)\n> \n>>\n>>>\n>>> If we want to follow up on that testdev idea (and I think we should),\n>>> it might make sense to have a proper type reserve to prevent accidental\n>>> clashes. \n>>\n>> I agree. Although I would still keep the cu_type configurable,\n>> because it might make sense to test a particular 'real' driver\n>> (and not a test driver like here). I haven't really thought\n>> this through, but it was an idea I had while agonizing over\n>> not having a proper type reserved.\n>>\n>> I suppose you did something like that for virtio, or? I'm in dark\n>> when it comes to the question what process do we/I have to go to\n>> get a type,for example 0x4711, reserved.\n> \n> 4711 is more a joke :) It might be worth trying the same channels as\n> for virtio-ccw.\n> \n> Christian should know more about that.\n\nGetting a new number was very easy (because it is attached to a machine type\nnumber). I I remember correctly, only numerical values are uses, so maybe\nwe can use ffff as there will never be such a real value?","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xwfNV3Yd4z9s7M\n\tfor ;\n\tMon, 18 Sep 2017 18:31:06 +1000 (AEST)","from localhost ([::1]:35229 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dtrSK-0007MQ-K7\n\tfor incoming@patchwork.ozlabs.org; Mon, 18 Sep 2017 04:31:04 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:40097)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dtrRz-0007MF-OP\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 04:30:45 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dtrRv-0005sO-MS\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 04:30:43 -0400","from mx0a-001b2d01.pphosted.com ([148.163.156.1]:43220)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dtrRv-0005fO-DS\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 04:30:39 -0400","from pps.filterd (m0098404.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv8I8U0bo095598\n\tfor ; Mon, 18 Sep 2017 04:30:37 -0400","from e06smtp15.uk.ibm.com (e06smtp15.uk.ibm.com [195.75.94.111])\n\tby mx0a-001b2d01.pphosted.com with ESMTP id 2d285rqh4u-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor ; Mon, 18 Sep 2017 04:30:37 -0400","from localhost\n\tby e06smtp15.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor from ;\n\tMon, 18 Sep 2017 09:30:35 +0100","from b06cxnps3075.portsmouth.uk.ibm.com (9.149.109.195)\n\tby e06smtp15.uk.ibm.com (192.168.101.145) with IBM ESMTP SMTP\n\tGateway: Authorized Use Only! Violators will be prosecuted; \n\tMon, 18 Sep 2017 09:30:33 +0100","from d06av21.portsmouth.uk.ibm.com (d06av21.portsmouth.uk.ibm.com\n\t[9.149.105.232])\n\tby b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with\n\tESMTP id v8I8UWCF24379444; Mon, 18 Sep 2017 08:30:32 GMT","from d06av21.portsmouth.uk.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id D4A3D52043;\n\tMon, 18 Sep 2017 08:25:33 +0100 (BST)","from oc7330422307.ibm.com (unknown [9.152.224.66])\n\tby d06av21.portsmouth.uk.ibm.com (Postfix) with ESMTP id 9AB685203F; \n\tMon, 18 Sep 2017 08:25:33 +0100 (BST)"],"To":"Cornelia Huck , Halil Pasic ","References":"<20170913132752.8484-1-pasic@linux.vnet.ibm.com>\n\t<20170913132752.8484-2-pasic@linux.vnet.ibm.com>\n\t<20170914162603.1cdabd09.cohuck@redhat.com>\n\t<0b42ef59-4366-175f-8dc7-bc3ed02e2fb4@linux.vnet.ibm.com>\n\t<20170915092758.16ea52fc.cohuck@redhat.com>","From":"Christian Borntraeger ","Date":"Mon, 18 Sep 2017 10:30:32 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.0","MIME-Version":"1.0","In-Reply-To":"<20170915092758.16ea52fc.cohuck@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-TM-AS-GCONF":"00","x-cbid":"17091808-0020-0000-0000-000003B8AF45","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17091808-0021-0000-0000-0000424A4461","Message-Id":"<5626693c-d7be-7c21-37e3-27625e9fbf2b@de.ibm.com>","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-09-18_02:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=0\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1709180121","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy]","X-Received-From":"148.163.156.1","Subject":"Re: [Qemu-devel] [PATCH 1/2] s390x/ccs: add ccw-tester emulated\n\tdevice","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Dong Jia Shi ,\n\tPierre Morel , qemu-devel@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1769987,"web_url":"http://patchwork.ozlabs.org/comment/1769987/","msgid":"<20170918104229.4eadb172.cohuck@redhat.com>","list_archive_url":null,"date":"2017-09-18T08:42:29","subject":"Re: [Qemu-devel] [PATCH 1/2] s390x/ccs: add ccw-tester emulated\n\tdevice","submitter":{"id":71914,"url":"http://patchwork.ozlabs.org/api/people/71914/","name":"Cornelia Huck","email":"cohuck@redhat.com"},"content":"On Mon, 18 Sep 2017 10:30:32 +0200\nChristian Borntraeger wrote:\n\n> On 09/15/2017 09:27 AM, Cornelia Huck wrote:\n> > On Thu, 14 Sep 2017 18:50:29 +0200\n> > Halil Pasic wrote:\n> > \n> >> On 09/14/2017 04:26 PM, Cornelia Huck wrote: \n> >>> On Wed, 13 Sep 2017 15:27:51 +0200\n> >>> Halil Pasic wrote: \n> > \n> >>>> +static Property ccw_tester_properties[] = {\n> >>>> + DEFINE_PROP_UINT16(\"cu_type\", CcwTesterDevice, cu_type,\n> >>>> + 0x3831), \n> >>>\n> >>> 0x4711 would be nice :) \n> >>\n> >> I don't understand the joke/pun/whatever if there is one,\n> >> but I'm fine with changing this too. \n> > \n> > https://en.wikipedia.org/wiki/4711\n> > \n> > That's my default if I need a four-digit number :)\n> > \n> >> \n> >>>\n> >>> If we want to follow up on that testdev idea (and I think we should),\n> >>> it might make sense to have a proper type reserve to prevent accidental\n> >>> clashes. \n> >>\n> >> I agree. Although I would still keep the cu_type configurable,\n> >> because it might make sense to test a particular 'real' driver\n> >> (and not a test driver like here). I haven't really thought\n> >> this through, but it was an idea I had while agonizing over\n> >> not having a proper type reserved.\n> >>\n> >> I suppose you did something like that for virtio, or? I'm in dark\n> >> when it comes to the question what process do we/I have to go to\n> >> get a type,for example 0x4711, reserved. \n> > \n> > 4711 is more a joke :) It might be worth trying the same channels as\n> > for virtio-ccw.\n> > \n> > Christian should know more about that. \n> \n> Getting a new number was very easy (because it is attached to a machine type\n> number). I I remember correctly, only numerical values are uses, so maybe\n> we can use ffff as there will never be such a real value?\n> \n\nYes, that sounds like the easiest way to do that.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=cohuck@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xwffM3zCKz9s3T\n\tfor ;\n\tMon, 18 Sep 2017 18:43:06 +1000 (AEST)","from localhost ([::1]:35274 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dtrds-0003TJ-TL\n\tfor incoming@patchwork.ozlabs.org; Mon, 18 Sep 2017 04:43:00 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:42858)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dtrdX-0003T8-In\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 04:42:40 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dtrdU-0001OW-Bs\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 04:42:39 -0400","from mx1.redhat.com ([209.132.183.28]:44800)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dtrdU-0001Ea-4z\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 04:42:36 -0400","from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 12D9A4ACA4;\n\tMon, 18 Sep 2017 08:42:34 +0000 (UTC)","from gondolin (dhcp-192-215.str.redhat.com [10.33.192.215])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id D716D60468;\n\tMon, 18 Sep 2017 08:42:31 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 12D9A4ACA4","Date":"Mon, 18 Sep 2017 10:42:29 +0200","From":"Cornelia Huck ","To":"Christian Borntraeger ","Message-ID":"<20170918104229.4eadb172.cohuck@redhat.com>","In-Reply-To":"<5626693c-d7be-7c21-37e3-27625e9fbf2b@de.ibm.com>","References":"<20170913132752.8484-1-pasic@linux.vnet.ibm.com>\n\t<20170913132752.8484-2-pasic@linux.vnet.ibm.com>\n\t<20170914162603.1cdabd09.cohuck@redhat.com>\n\t<0b42ef59-4366-175f-8dc7-bc3ed02e2fb4@linux.vnet.ibm.com>\n\t<20170915092758.16ea52fc.cohuck@redhat.com>\n\t<5626693c-d7be-7c21-37e3-27625e9fbf2b@de.ibm.com>","Organization":"Red Hat GmbH","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.11","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.38]);\n\tMon, 18 Sep 2017 08:42:35 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH 1/2] s390x/ccs: add ccw-tester emulated\n\tdevice","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Halil Pasic ,\n\tPierre Morel ,\n\tDong Jia Shi , qemu-devel@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1771070,"web_url":"http://patchwork.ozlabs.org/comment/1771070/","msgid":"<1301a0dc-755f-1670-1062-b70ea86802e0@linux.vnet.ibm.com>","list_archive_url":null,"date":"2017-09-19T14:20:16","subject":"Re: [Qemu-devel] [PATCH 1/2] s390x/ccs: add ccw-tester emulated\n\tdevice","submitter":{"id":66825,"url":"http://patchwork.ozlabs.org/api/people/66825/","name":"Pierre Morel","email":"pmorel@linux.vnet.ibm.com"},"content":"On 15/09/2017 19:01, Cornelia Huck wrote:\n> On Fri, 15 Sep 2017 09:27:58 +0200\n> Cornelia Huck wrote:\n> \n>> On Thu, 14 Sep 2017 18:50:29 +0200\n>> Halil Pasic wrote:\n>>\n>>> On 09/14/2017 04:26 PM, Cornelia Huck wrote:\n> \n>>>> There's quite some potential in this. We may want to make this a\n>>>> permanent addition.\n>>>> \n>>>\n>>> I'm happy to contribute! I'm not sure how shall we proceed though.\n>>> Maybe with making a todo list?\n>>\n>> I think the first step would be to figure out the ids so we don't step\n>> on anyone's toes. Then maybe refactor a bit so that other testers can\n>> be added easily.\n>>\n>> For ideas about things to be tested, maybe put a list into the wiki?\n> \n> OK, I've created https://wiki.qemu.org/Testing/CCWTestDevice - let me\n> know if you need an account.\n> \n\nGreat!\nI just saw your email, it was waiting in my inbox.\nstrange things happens some time. A good serie. strange things.\nneverless...\n\nSeriously.\nYes, I definitively need an account!\n\n\nPierre","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xxQ5r6nbPz9s7h\n\tfor ;\n\tWed, 20 Sep 2017 00:21:04 +1000 (AEST)","from localhost ([::1]:43197 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1duJOZ-0000vZ-3i\n\tfor incoming@patchwork.ozlabs.org; Tue, 19 Sep 2017 10:21:03 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:49284)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1duJOG-0000vQ-7J\n\tfor qemu-devel@nongnu.org; Tue, 19 Sep 2017 10:20:45 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1duJOD-0000os-AB\n\tfor qemu-devel@nongnu.org; Tue, 19 Sep 2017 10:20:44 -0400","from mx0b-001b2d01.pphosted.com ([148.163.158.5]:37396\n\thelo=mx0a-001b2d01.pphosted.com)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1duJOC-0000oT-Oy\n\tfor qemu-devel@nongnu.org; Tue, 19 Sep 2017 10:20:41 -0400","from pps.filterd (m0098419.ppops.net [127.0.0.1])\n\tby mx0b-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv8JEJhkI113730\n\tfor ; Tue, 19 Sep 2017 10:20:40 -0400","from e06smtp13.uk.ibm.com (e06smtp13.uk.ibm.com [195.75.94.109])\n\tby mx0b-001b2d01.pphosted.com with ESMTP id 2d313wf4re-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor ; Tue, 19 Sep 2017 10:20:36 -0400","from localhost\n\tby e06smtp13.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor from ;\n\tTue, 19 Sep 2017 15:20:19 +0100","from b06cxnps4074.portsmouth.uk.ibm.com (9.149.109.196)\n\tby e06smtp13.uk.ibm.com (192.168.101.143) with IBM ESMTP SMTP\n\tGateway: Authorized Use Only! Violators will be prosecuted; \n\tTue, 19 Sep 2017 15:20:17 +0100","from d06av23.portsmouth.uk.ibm.com (d06av23.portsmouth.uk.ibm.com\n\t[9.149.105.59])\n\tby b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with\n\tESMTP id v8JEKHQv24445120; Tue, 19 Sep 2017 14:20:17 GMT","from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 1B6F5A4051;\n\tTue, 19 Sep 2017 15:16:19 +0100 (BST)","from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id D60D2A4040;\n\tTue, 19 Sep 2017 15:16:18 +0100 (BST)","from [9.145.21.76] (unknown [9.145.21.76])\n\tby d06av23.portsmouth.uk.ibm.com (Postfix) with ESMTP;\n\tTue, 19 Sep 2017 15:16:18 +0100 (BST)"],"To":"Cornelia Huck , Halil Pasic ","References":"<20170913132752.8484-1-pasic@linux.vnet.ibm.com>\n\t<20170913132752.8484-2-pasic@linux.vnet.ibm.com>\n\t<20170914162603.1cdabd09.cohuck@redhat.com>\n\t<0b42ef59-4366-175f-8dc7-bc3ed02e2fb4@linux.vnet.ibm.com>\n\t<20170915092758.16ea52fc.cohuck@redhat.com>\n\t<20170915190118.03dc1b57.cohuck@redhat.com>","From":"Pierre Morel ","Date":"Tue, 19 Sep 2017 16:20:16 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20170915190118.03dc1b57.cohuck@redhat.com>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Language":"en-US","X-TM-AS-GCONF":"00","x-cbid":"17091914-0012-0000-0000-0000057A6B56","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17091914-0013-0000-0000-000018F39F87","Message-Id":"<1301a0dc-755f-1670-1062-b70ea86802e0@linux.vnet.ibm.com>","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-09-19_06:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=0\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1709190203","Content-Transfer-Encoding":"quoted-printable","X-MIME-Autoconverted":"from 8bit to quoted-printable by\n\tmx0b-001b2d01.pphosted.com id v8JEJhkI113730","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy]","X-Received-From":"148.163.158.5","Subject":"Re: [Qemu-devel] [PATCH 1/2] s390x/ccs: add ccw-tester emulated\n\tdevice","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Christian Borntraeger ,\n\tDong Jia Shi , qemu-devel@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1771080,"web_url":"http://patchwork.ozlabs.org/comment/1771080/","msgid":"<7f8340e7-068d-3740-81ac-c9d22fd6b6c7@linux.vnet.ibm.com>","list_archive_url":null,"date":"2017-09-19T14:26:09","subject":"Re: [Qemu-devel] [PATCH 1/2] s390x/ccs: add ccw-tester emulated\n\tdevice","submitter":{"id":66825,"url":"http://patchwork.ozlabs.org/api/people/66825/","name":"Pierre Morel","email":"pmorel@linux.vnet.ibm.com"},"content":"On 14/09/2017 16:26, Cornelia Huck wrote:\n> On Wed, 13 Sep 2017 15:27:51 +0200\n> Halil Pasic wrote:\n> \n>> Add a fake device meant for testing the correctness of our css emulation.\n>>\n>> What we currently have is writing a Fibonacci sequence of uint32_t to the\n>> device via ccw write. The write is going to fail if it ain't a Fibonacci\n>> and indicate a device exception in scsw together with the proper residual\n>> count.\n>>\n>> Of course lot's of invalid inputs (besides basic data processing) can be\n>> tested with that as well.\n>>\n>> Usage:\n>> 1) fire up a qemu with something like -device ccw-tester,devno=fe.0.0001\n>> on the command line\n>> 2) exercise the device from the guest\n>>\n>> Signed-off-by: Halil Pasic \n>> ---\n>>\n>> Depends on the series 'add CCW indirect data access support'\n>>\n>> ---\n>> hw/s390x/Makefile.objs | 1 +\n>> hw/s390x/ccw-tester.c | 179 +++++++++++++++++++++++++++++++++++++++++++++++++\n>> 2 files changed, 180 insertions(+)\n>> create mode 100644 hw/s390x/ccw-tester.c\n>>\n> \n>> +static int ccw_tester_write_fib(SubchDev *sch, CCW1 ccw)\n>> +{\n>> + CcwTesterDevice *d = sch->driver_data;\n>> + bool is_fib = true;\n>> + uint32_t sum;\n>> + int ret = 0;\n>> +\n>> + ccw_dstream_init(&sch->cds, &ccw, &sch->orb);\n>> + d->fib.next = 0;\n>> + while (ccw_dstream_avail(&sch->cds) > 0) {\n>> + ret = ccw_dstream_read(&sch->cds,\n>> + d->fib.ring[abs_to_ring(d->fib.next)]);\n>> + if (ret) {\n>> + error(0, -ret, \"fib\");\n>> + break;\n>> + }\n>> + if (d->fib.next > 2) {\n>> + sum = (d->fib.ring[abs_to_ring(d->fib.next - 1)]\n>> + + d->fib.ring[abs_to_ring(d->fib.next - 2)]);\n>> + is_fib = sum == d->fib.ring[abs_to_ring(d->fib.next)];\n> \n> This is not endian-safe (noticed while testing on my laptop). Trivial\n> to fix:\n> \n> diff --git a/hw/s390x/ccw-tester.c b/hw/s390x/ccw-tester.c\n> index c8017818c4..a425daaa34 100644\n> --- a/hw/s390x/ccw-tester.c\n> +++ b/hw/s390x/ccw-tester.c\n> @@ -58,9 +58,9 @@ static int ccw_tester_write_fib(SubchDev *sch, CCW1 ccw)\n> break;\n> }\n> if (d->fib.next > 2) {\n> - sum = (d->fib.ring[abs_to_ring(d->fib.next - 1)]\n> - + d->fib.ring[abs_to_ring(d->fib.next - 2)]);\n> - is_fib = sum == d->fib.ring[abs_to_ring(d->fib.next)];\n> + sum = be32_to_cpu(d->fib.ring[abs_to_ring(d->fib.next - 1)])\n> + + be32_to_cpu(d->fib.ring[abs_to_ring(d->fib.next - 2)]);\n> + is_fib = sum == be32_to_cpu(d->fib.ring[abs_to_ring(d->fib.next)]);\n> if (!is_fib) {\n> break;\n> }\n> \n>> + if (!is_fib) {\n>> + break;\n>> + }\n>> + }\n>> + ++(d->fib.next);\n>> + }\n>> + if (!is_fib) {\n>> + sch->curr_status.scsw.ctrl &= ~SCSW_ACTL_START_PEND;\n>> + sch->curr_status.scsw.ctrl |= SCSW_STCTL_PRIMARY |\n>> + SCSW_STCTL_SECONDARY |\n>> + SCSW_STCTL_ALERT |\n>> + SCSW_STCTL_STATUS_PEND;\n>> + sch->curr_status.scsw.count = ccw_dstream_residual_count(&sch->cds);\n>> + sch->curr_status.scsw.cpa = sch->channel_prog + 8;\n>> + sch->curr_status.scsw.dstat = SCSW_DSTAT_UNIT_EXCEP;\n>> + return -EIO;\n>> + }\n>> + return ret;\n>> +}\n>> +\n> (...)\n>> +static Property ccw_tester_properties[] = {\n>> + DEFINE_PROP_UINT16(\"cu_type\", CcwTesterDevice, cu_type,\n>> + 0x3831),\n> \n> 0x4711 would be nice :)\n\nThe C0C0 channel would be nice too.\nSorry.\n\n> \n> If we want to follow up on that testdev idea (and I think we should),\n> it might make sense to have a proper type reserve to prevent accidental\n> clashes.\n> \n> (Or is there already something reserved for \"hypervisor use\" or\n> whatever?)\n> \n>> + DEFINE_PROP_UINT8(\"chpid_type\", CcwTesterDevice, chpid_type,\n>> + 0x98),\n>> + DEFINE_PROP_END_OF_LIST(),\n>> +};\n> \n> IIUC, pci-testdev provides some unit tests to testers (like kvm-tests)\n> itself. This might be an idea to follow up on for ccw as well.\n> \n> There's quite some potential in this. We may want to make this a\n> permanent addition.\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xxQDl4n8Cz9s7m\n\tfor ;\n\tWed, 20 Sep 2017 00:27:03 +1000 (AEST)","from localhost ([::1]:43224 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1duJUL-00057O-P7\n\tfor incoming@patchwork.ozlabs.org; Tue, 19 Sep 2017 10:27:01 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:52391)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1duJTd-00054Z-MW\n\tfor qemu-devel@nongnu.org; Tue, 19 Sep 2017 10:26:18 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1duJTb-0003lY-0J\n\tfor qemu-devel@nongnu.org; Tue, 19 Sep 2017 10:26:17 -0400","from mx0b-001b2d01.pphosted.com ([148.163.158.5]:42830\n\thelo=mx0a-001b2d01.pphosted.com)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1duJTa-0003lB-Re\n\tfor qemu-devel@nongnu.org; Tue, 19 Sep 2017 10:26:14 -0400","from pps.filterd (m0098416.ppops.net [127.0.0.1])\n\tby mx0b-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv8JEP1IT141503\n\tfor ; Tue, 19 Sep 2017 10:26:14 -0400","from e06smtp11.uk.ibm.com (e06smtp11.uk.ibm.com [195.75.94.107])\n\tby mx0b-001b2d01.pphosted.com with ESMTP id 2d33dret08-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor ; Tue, 19 Sep 2017 10:26:13 -0400","from localhost\n\tby e06smtp11.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor from ;\n\tTue, 19 Sep 2017 15:26:12 +0100","from b06cxnps3074.portsmouth.uk.ibm.com (9.149.109.194)\n\tby e06smtp11.uk.ibm.com (192.168.101.141) with IBM ESMTP SMTP\n\tGateway: Authorized Use Only! Violators will be prosecuted; \n\tTue, 19 Sep 2017 15:26:10 +0100","from d06av23.portsmouth.uk.ibm.com (d06av23.portsmouth.uk.ibm.com\n\t[9.149.105.59])\n\tby b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with\n\tESMTP id v8JEQA2W19792112; Tue, 19 Sep 2017 14:26:10 GMT","from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 46EC1A404D;\n\tTue, 19 Sep 2017 15:22:12 +0100 (BST)","from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 15153A4040;\n\tTue, 19 Sep 2017 15:22:12 +0100 (BST)","from [9.145.21.76] (unknown [9.145.21.76])\n\tby d06av23.portsmouth.uk.ibm.com (Postfix) with ESMTP;\n\tTue, 19 Sep 2017 15:22:12 +0100 (BST)"],"To":"Cornelia Huck , Halil Pasic ","References":"<20170913132752.8484-1-pasic@linux.vnet.ibm.com>\n\t<20170913132752.8484-2-pasic@linux.vnet.ibm.com>\n\t<20170914162603.1cdabd09.cohuck@redhat.com>","From":"Pierre Morel ","Date":"Tue, 19 Sep 2017 16:26:09 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20170914162603.1cdabd09.cohuck@redhat.com>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Language":"en-US","X-TM-AS-GCONF":"00","x-cbid":"17091914-0040-0000-0000-000003FB628F","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17091914-0041-0000-0000-0000209C9471","Message-Id":"<7f8340e7-068d-3740-81ac-c9d22fd6b6c7@linux.vnet.ibm.com>","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-09-19_06:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=0\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1709190204","Content-Transfer-Encoding":"quoted-printable","X-MIME-Autoconverted":"from 8bit to quoted-printable by\n\tmx0b-001b2d01.pphosted.com id v8JEP1IT141503","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy]","X-Received-From":"148.163.158.5","Subject":"Re: [Qemu-devel] [PATCH 1/2] s390x/ccs: add ccw-tester emulated\n\tdevice","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Dong Jia Shi , qemu-devel@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1774783,"web_url":"http://patchwork.ozlabs.org/comment/1774783/","msgid":"<2ec0f5a8-b12e-1b4a-8d6f-ecddedeecc78@linux.vnet.ibm.com>","list_archive_url":null,"date":"2017-09-25T15:06:01","subject":"Re: [Qemu-devel] [PATCH 1/2] s390x/ccs: add ccw-tester emulated\n\tdevice","submitter":{"id":68297,"url":"http://patchwork.ozlabs.org/api/people/68297/","name":"Halil Pasic","email":"pasic@linux.vnet.ibm.com"},"content":"On 09/19/2017 04:20 PM, Pierre Morel wrote:\n> On 15/09/2017 19:01, Cornelia Huck wrote:\n>> On Fri, 15 Sep 2017 09:27:58 +0200\n>> Cornelia Huck wrote:\n>>\n>>> On Thu, 14 Sep 2017 18:50:29 +0200\n>>> Halil Pasic wrote:\n>>>\n>>>> On 09/14/2017 04:26 PM, Cornelia Huck wrote:\n>>\n>>>>> There's quite some potential in this. We may want to make this a\n>>>>> permanent addition.\n>>>>>      \n>>>>\n>>>> I'm happy to contribute! I'm not sure how shall we proceed though.\n>>>> Maybe with making a todo list?\n>>>\n>>> I think the first step would be to figure out the ids so we don't step\n>>> on anyone's toes. Then maybe refactor a bit so that other testers can\n>>> be added easily.\n>>>\n>>> For ideas about things to be tested, maybe put a list into the wiki?\n>>\n>> OK, I've created https://wiki.qemu.org/Testing/CCWTestDevice - let me\n>> know if you need an account.\n>>\n> \n> Great!\n> I just saw your email, it was waiting in my inbox.\n> strange things happens some time. A good serie. strange things.\n> neverless...\n> \n> Seriously.\n> Yes, I definitively need an account!\n> \n> \n> Pierre\n> \n\n@Connie\nI would also like to have an account. I would also like to do a\nv2 of this somewhere in the not too distant future. I intend\nto address the issues pointed out by you here (chpid_type,\ncu_type). Another question is whether this should go under\nhw/misc/ like the pci-testdev? ccw-testdev would also probably\nbe a better file name (that ccw-tester) regardless of in which\nfolder does this belong. One more thing I am considering for\nv2 is this make it extensible argument. I had something like\nmode on my mind from the very beginning (fib would be one mode).\nThe idea was to provide a control ccw for setting/getting the mode\n(something like virtio) as well as a device property for setting\nthe initial mode (so that guest does not have to know about it).\n\nRegards,\nHalil","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y16sT1Xfwz9t67\n\tfor ;\n\tTue, 26 Sep 2017 01:08:13 +1000 (AEST)","from localhost ([::1]:42892 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dwUzT-0000SE-7l\n\tfor incoming@patchwork.ozlabs.org; Mon, 25 Sep 2017 11:08:11 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:57836)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dwUxa-0007v6-Fy\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 11:06:15 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dwUxW-0008VH-9v\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 11:06:14 -0400","from mx0b-001b2d01.pphosted.com ([148.163.158.5]:38488\n\thelo=mx0a-001b2d01.pphosted.com)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dwUxW-0008Uy-3q\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 11:06:10 -0400","from pps.filterd (m0098414.ppops.net [127.0.0.1])\n\tby mx0b-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv8PF3dEL143813\n\tfor ; Mon, 25 Sep 2017 11:06:07 -0400","from e06smtp12.uk.ibm.com (e06smtp12.uk.ibm.com [195.75.94.108])\n\tby mx0b-001b2d01.pphosted.com with ESMTP id 2d71c84ajm-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor ; Mon, 25 Sep 2017 11:06:06 -0400","from localhost\n\tby e06smtp12.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor from ;\n\tMon, 25 Sep 2017 16:06:05 +0100","from b06cxnps3074.portsmouth.uk.ibm.com (9.149.109.194)\n\tby e06smtp12.uk.ibm.com (192.168.101.142) with IBM ESMTP SMTP\n\tGateway: Authorized Use Only! Violators will be prosecuted; \n\tMon, 25 Sep 2017 16:06:02 +0100","from d06av26.portsmouth.uk.ibm.com (d06av26.portsmouth.uk.ibm.com\n\t[9.149.105.62])\n\tby b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with\n\tESMTP id v8PF62tN16646312; Mon, 25 Sep 2017 15:06:02 GMT","from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id A1BCBAE04D;\n\tMon, 25 Sep 2017 16:00:46 +0100 (BST)","from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 2D413AE045;\n\tMon, 25 Sep 2017 16:00:46 +0100 (BST)","from oc3836556865.ibm.com (unknown [9.152.224.207])\n\tby d06av26.portsmouth.uk.ibm.com (Postfix) with ESMTP;\n\tMon, 25 Sep 2017 16:00:46 +0100 (BST)"],"To":"Pierre Morel ,\n\tCornelia Huck ","References":"<20170913132752.8484-1-pasic@linux.vnet.ibm.com>\n\t<20170913132752.8484-2-pasic@linux.vnet.ibm.com>\n\t<20170914162603.1cdabd09.cohuck@redhat.com>\n\t<0b42ef59-4366-175f-8dc7-bc3ed02e2fb4@linux.vnet.ibm.com>\n\t<20170915092758.16ea52fc.cohuck@redhat.com>\n\t<20170915190118.03dc1b57.cohuck@redhat.com>\n\t<1301a0dc-755f-1670-1062-b70ea86802e0@linux.vnet.ibm.com>","From":"Halil Pasic ","Date":"Mon, 25 Sep 2017 17:06:01 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<1301a0dc-755f-1670-1062-b70ea86802e0@linux.vnet.ibm.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","X-TM-AS-GCONF":"00","x-cbid":"17092515-0008-0000-0000-00000499E7BC","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17092515-0009-0000-0000-00001E2B2EE5","Message-Id":"<2ec0f5a8-b12e-1b4a-8d6f-ecddedeecc78@linux.vnet.ibm.com>","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-09-25_06:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=0\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1709250229","Content-Transfer-Encoding":"quoted-printable","X-MIME-Autoconverted":"from 8bit to quoted-printable by\n\tmx0b-001b2d01.pphosted.com id v8PF3dEL143813","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy]","X-Received-From":"148.163.158.5","Subject":"Re: [Qemu-devel] [PATCH 1/2] s390x/ccs: add ccw-tester emulated\n\tdevice","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Christian Borntraeger ,\n\tDong Jia Shi , qemu-devel@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1774813,"web_url":"http://patchwork.ozlabs.org/comment/1774813/","msgid":"<20170925173954.11fba063.cohuck@redhat.com>","list_archive_url":null,"date":"2017-09-25T15:39:54","subject":"Re: [Qemu-devel] [PATCH 1/2] s390x/ccs: add ccw-tester emulated\n\tdevice","submitter":{"id":71914,"url":"http://patchwork.ozlabs.org/api/people/71914/","name":"Cornelia Huck","email":"cohuck@redhat.com"},"content":"On Mon, 25 Sep 2017 17:06:01 +0200\nHalil Pasic wrote:\n\n> @Connie\n> I would also like to have an account. \n\nDone (for both of you).\n\n> I would also like to do a\n> v2 of this somewhere in the not too distant future. I intend\n> to address the issues pointed out by you here (chpid_type,\n> cu_type). Another question is whether this should go under\n> hw/misc/ like the pci-testdev? ccw-testdev would also probably\n> be a better file name (that ccw-tester) regardless of in which\n> folder does this belong. \n\nProbably not a bad idea to follow pci here.\n\n> One more thing I am considering for\n> v2 is this make it extensible argument. I had something like\n> mode on my mind from the very beginning (fib would be one mode).\n> The idea was to provide a control ccw for setting/getting the mode\n> (something like virtio) as well as a device property for setting\n> the initial mode (so that guest does not have to know about it).\n\nYes, a control ccw sounds nice, we should just make sure that it\ndoesn't collide with future tests (e.g. if we want to do some channel\nprogram fuzzing). Alternatively, this could be controled by a diagnose,\nwhich would be out of band (we can use a high function code for diag\n500 that is unlikely to collide with future extensions).","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=cohuck@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y17Zt2BgMz9sRW\n\tfor ;\n\tTue, 26 Sep 2017 01:40:38 +1000 (AEST)","from localhost ([::1]:43094 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dwVUq-0005PR-EY\n\tfor incoming@patchwork.ozlabs.org; Mon, 25 Sep 2017 11:40:36 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:41713)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dwVUI-0005OH-GS\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 11:40:03 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dwVUF-00060k-Er\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 11:40:02 -0400","from mx1.redhat.com ([209.132.183.28]:46765)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dwVUF-00060R-8N\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 11:39:59 -0400","from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 474957F41B;\n\tMon, 25 Sep 2017 15:39:58 +0000 (UTC)","from gondolin (dhcp-192-215.str.redhat.com [10.33.192.215])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 3775A779CF;\n\tMon, 25 Sep 2017 15:39:57 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 474957F41B","Date":"Mon, 25 Sep 2017 17:39:54 +0200","From":"Cornelia Huck ","To":"Halil Pasic ","Message-ID":"<20170925173954.11fba063.cohuck@redhat.com>","In-Reply-To":"<2ec0f5a8-b12e-1b4a-8d6f-ecddedeecc78@linux.vnet.ibm.com>","References":"<20170913132752.8484-1-pasic@linux.vnet.ibm.com>\n\t<20170913132752.8484-2-pasic@linux.vnet.ibm.com>\n\t<20170914162603.1cdabd09.cohuck@redhat.com>\n\t<0b42ef59-4366-175f-8dc7-bc3ed02e2fb4@linux.vnet.ibm.com>\n\t<20170915092758.16ea52fc.cohuck@redhat.com>\n\t<20170915190118.03dc1b57.cohuck@redhat.com>\n\t<1301a0dc-755f-1670-1062-b70ea86802e0@linux.vnet.ibm.com>\n\t<2ec0f5a8-b12e-1b4a-8d6f-ecddedeecc78@linux.vnet.ibm.com>","Organization":"Red Hat GmbH","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.13","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.25]);\n\tMon, 25 Sep 2017 15:39:58 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH 1/2] s390x/ccs: add ccw-tester emulated\n\tdevice","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Christian Borntraeger ,\n\tDong Jia Shi ,\n\tPierre Morel , qemu-devel@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1790787,"web_url":"http://patchwork.ozlabs.org/comment/1790787/","msgid":"<711b1e41-693a-de7d-9c13-fbe0f964c53c@linux.vnet.ibm.com>","list_archive_url":null,"date":"2017-10-19T16:39:37","subject":"Re: [Qemu-devel] [PATCH 1/2] s390x/ccs: add ccw-tester emulated\n\tdevice","submitter":{"id":68297,"url":"http://patchwork.ozlabs.org/api/people/68297/","name":"Halil Pasic","email":"pasic@linux.vnet.ibm.com"},"content":"On 09/15/2017 09:27 AM, Cornelia Huck wrote:\n>>> \n>>>> + DEFINE_PROP_UINT8(\"chpid_type\", CcwTesterDevice, chpid_type,\n>>>> + 0x98),\n> This might also need re-evaluation - we should not really need a new\n> chpid type.\n> \n\nI'm back at ccw-tester again (for v2). I've realized we did not agree\non what to use here (chpid_type). Shall I use 0x25 (Fibre Channel) or\nEMULATED_CCW_3270_CHPID_TYPE, or even 0x32 (virtio-ccw) as a default\nvalue? And should EMULATED_CCW_3270_CHPID_TYPE be called like that\n(is it really supposed to be specific to 3270?\n\nSorry I did not notice sooner.\n\nRegards,\nHalil","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yHwQM2cwNz9tX8\n\tfor ;\n\tFri, 20 Oct 2017 04:09:31 +1100 (AEDT)","from localhost ([::1]:50323 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1e5EK1-0003yy-CG\n\tfor incoming@patchwork.ozlabs.org; Thu, 19 Oct 2017 13:09:29 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:34351)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1e5DrM-00046L-BL\n\tfor qemu-devel@nongnu.org; Thu, 19 Oct 2017 12:39:55 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1e5DrH-0005rl-CJ\n\tfor qemu-devel@nongnu.org; Thu, 19 Oct 2017 12:39:52 -0400","from mx0b-001b2d01.pphosted.com ([148.163.158.5]:42446\n\thelo=mx0a-001b2d01.pphosted.com)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1e5DrH-0005rF-5x\n\tfor qemu-devel@nongnu.org; Thu, 19 Oct 2017 12:39:47 -0400","from pps.filterd (m0098419.ppops.net [127.0.0.1])\n\tby mx0b-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv9JGd55s027571\n\tfor ; Thu, 19 Oct 2017 12:39:43 -0400","from e06smtp15.uk.ibm.com (e06smtp15.uk.ibm.com [195.75.94.111])\n\tby mx0b-001b2d01.pphosted.com with ESMTP id 2dpyrmg0u7-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor ; Thu, 19 Oct 2017 12:39:42 -0400","from localhost\n\tby e06smtp15.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor from ;\n\tThu, 19 Oct 2017 17:39:41 +0100","from b06cxnps3075.portsmouth.uk.ibm.com (9.149.109.195)\n\tby e06smtp15.uk.ibm.com (192.168.101.145) with IBM ESMTP SMTP\n\tGateway: Authorized Use Only! Violators will be prosecuted; \n\tThu, 19 Oct 2017 17:39:39 +0100","from d06av24.portsmouth.uk.ibm.com (mk.ibm.com [9.149.105.60])\n\tby b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with\n\tESMTP id v9JGdcND25428046; Thu, 19 Oct 2017 16:39:38 GMT","from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id B60174203F;\n\tThu, 19 Oct 2017 17:35:09 +0100 (BST)","from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 2D71142042;\n\tThu, 19 Oct 2017 17:35:09 +0100 (BST)","from oc3836556865.ibm.com (unknown [9.152.224.140])\n\tby d06av24.portsmouth.uk.ibm.com (Postfix) with ESMTP;\n\tThu, 19 Oct 2017 17:35:09 +0100 (BST)"],"To":"Cornelia Huck ","References":"<20170913132752.8484-1-pasic@linux.vnet.ibm.com>\n\t<20170913132752.8484-2-pasic@linux.vnet.ibm.com>\n\t<20170914162603.1cdabd09.cohuck@redhat.com>\n\t<0b42ef59-4366-175f-8dc7-bc3ed02e2fb4@linux.vnet.ibm.com>\n\t<20170915092758.16ea52fc.cohuck@redhat.com>","From":"Halil Pasic ","Date":"Thu, 19 Oct 2017 18:39:37 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170915092758.16ea52fc.cohuck@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"8bit","X-TM-AS-GCONF":"00","x-cbid":"17101916-0020-0000-0000-000003C27656","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17101916-0021-0000-0000-000042570E75","Message-Id":"<711b1e41-693a-de7d-9c13-fbe0f964c53c@linux.vnet.ibm.com>","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-10-19_08:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=0\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1710190229","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy]","X-Received-From":"148.163.158.5","Subject":"Re: [Qemu-devel] [PATCH 1/2] s390x/ccs: add ccw-tester emulated\n\tdevice","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Christian Borntraeger ,\n\tDong Jia Shi ,\n\tPierre Morel , qemu-devel@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1791450,"web_url":"http://patchwork.ozlabs.org/comment/1791450/","msgid":"<20171020150043.383b2117.cohuck@redhat.com>","list_archive_url":null,"date":"2017-10-20T13:00:43","subject":"Re: [Qemu-devel] [PATCH 1/2] s390x/ccs: add ccw-tester emulated\n\tdevice","submitter":{"id":71914,"url":"http://patchwork.ozlabs.org/api/people/71914/","name":"Cornelia Huck","email":"cohuck@redhat.com"},"content":"On Thu, 19 Oct 2017 18:39:37 +0200\nHalil Pasic wrote:\n\n> On 09/15/2017 09:27 AM, Cornelia Huck wrote:\n> >>> \n> >>>> + DEFINE_PROP_UINT8(\"chpid_type\", CcwTesterDevice, chpid_type,\n> >>>> + 0x98), \n> > This might also need re-evaluation - we should not really need a new\n> > chpid type.\n> > \n> \n> I'm back at ccw-tester again (for v2). I've realized we did not agree\n> on what to use here (chpid_type). Shall I use 0x25 (Fibre Channel) or\n> EMULATED_CCW_3270_CHPID_TYPE, or even 0x32 (virtio-ccw) as a default\n> value? And should EMULATED_CCW_3270_CHPID_TYPE be called like that\n> (is it really supposed to be specific to 3270?\n> \n> Sorry I did not notice sooner.\n\nIt might make sense to pick whatever z/VM commonly uses for emulated\ndevices. (Or ask them if they reserved something explicitly for testing\n-- that would be an even better match.)","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx05.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx05.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=cohuck@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yJQsT0QJXz9t3f\n\tfor ;\n\tSat, 21 Oct 2017 00:01:13 +1100 (AEDT)","from localhost ([::1]:53973 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1e5WvG-0007oB-K9\n\tfor incoming@patchwork.ozlabs.org; Fri, 20 Oct 2017 09:01:10 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:54852)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1e5Wuy-0007o5-CX\n\tfor qemu-devel@nongnu.org; Fri, 20 Oct 2017 09:00:53 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1e5Wuv-00078n-6R\n\tfor qemu-devel@nongnu.org; Fri, 20 Oct 2017 09:00:52 -0400","from mx1.redhat.com ([209.132.183.28]:60990)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1e5Wuu-00078U-W5\n\tfor qemu-devel@nongnu.org; Fri, 20 Oct 2017 09:00:49 -0400","from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 45A59A8F2;\n\tFri, 20 Oct 2017 13:00:47 +0000 (UTC)","from gondolin (dhcp-192-222.str.redhat.com [10.33.192.222])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 3B83B60BE1;\n\tFri, 20 Oct 2017 13:00:46 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 45A59A8F2","Date":"Fri, 20 Oct 2017 15:00:43 +0200","From":"Cornelia Huck ","To":"Halil Pasic ","Message-ID":"<20171020150043.383b2117.cohuck@redhat.com>","In-Reply-To":"<711b1e41-693a-de7d-9c13-fbe0f964c53c@linux.vnet.ibm.com>","References":"<20170913132752.8484-1-pasic@linux.vnet.ibm.com>\n\t<20170913132752.8484-2-pasic@linux.vnet.ibm.com>\n\t<20170914162603.1cdabd09.cohuck@redhat.com>\n\t<0b42ef59-4366-175f-8dc7-bc3ed02e2fb4@linux.vnet.ibm.com>\n\t<20170915092758.16ea52fc.cohuck@redhat.com>\n\t<711b1e41-693a-de7d-9c13-fbe0f964c53c@linux.vnet.ibm.com>","Organization":"Red Hat GmbH","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.12","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.29]);\n\tFri, 20 Oct 2017 13:00:47 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH 1/2] s390x/ccs: add ccw-tester emulated\n\tdevice","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Christian Borntraeger ,\n\tDong Jia Shi ,\n\tPierre Morel , qemu-devel@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1791515,"web_url":"http://patchwork.ozlabs.org/comment/1791515/","msgid":"","list_archive_url":null,"date":"2017-10-20T14:33:47","subject":"Re: [Qemu-devel] [PATCH 1/2] s390x/ccs: add ccw-tester emulated\n\tdevice","submitter":{"id":68297,"url":"http://patchwork.ozlabs.org/api/people/68297/","name":"Halil Pasic","email":"pasic@linux.vnet.ibm.com"},"content":"On 10/20/2017 03:00 PM, Cornelia Huck wrote:\n> On Thu, 19 Oct 2017 18:39:37 +0200\n> Halil Pasic wrote:\n> \n>> On 09/15/2017 09:27 AM, Cornelia Huck wrote:\n>>>>> \n>>>>>> + DEFINE_PROP_UINT8(\"chpid_type\", CcwTesterDevice, chpid_type,\n>>>>>> + 0x98), \n>>> This might also need re-evaluation - we should not really need a new\n>>> chpid type.\n>>> \n>>\n>> I'm back at ccw-tester again (for v2). I've realized we did not agree\n>> on what to use here (chpid_type). Shall I use 0x25 (Fibre Channel) or\n>> EMULATED_CCW_3270_CHPID_TYPE, or even 0x32 (virtio-ccw) as a default\n>> value? And should EMULATED_CCW_3270_CHPID_TYPE be called like that\n>> (is it really supposed to be specific to 3270?\n>>\n>> Sorry I did not notice sooner.\n> \n> It might make sense to pick whatever z/VM commonly uses for emulated\n> devices. (Or ask them if they reserved something explicitly for testing\n> -- that would be an even better match.)\n> \n\nOK, I will approach the z/VM guys. About EMULATED_CCW_3270_CHPID_TYPE,\ndoes it really make sense to have a separate chpid type for 3270? (You\nhave missed that question, so I'm asking it again).\n\nHalil","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yJSx96dxXz9t38\n\tfor ;\n\tSat, 21 Oct 2017 01:34:37 +1100 (AEDT)","from localhost ([::1]:54287 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1e5YNg-0001Ak-2I\n\tfor incoming@patchwork.ozlabs.org; Fri, 20 Oct 2017 10:34:36 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:51518)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1e5YN9-00019o-51\n\tfor qemu-devel@nongnu.org; Fri, 20 Oct 2017 10:34:05 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1e5YN6-0007GM-1P\n\tfor qemu-devel@nongnu.org; Fri, 20 Oct 2017 10:34:03 -0400","from mx0a-001b2d01.pphosted.com ([148.163.156.1]:50970)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1e5YN5-0007Fn-P3\n\tfor qemu-devel@nongnu.org; Fri, 20 Oct 2017 10:33:59 -0400","from pps.filterd (m0098393.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv9KEUnkK104087\n\tfor ; Fri, 20 Oct 2017 10:33:55 -0400","from e06smtp12.uk.ibm.com (e06smtp12.uk.ibm.com [195.75.94.108])\n\tby mx0a-001b2d01.pphosted.com with ESMTP id 2dqe5q76mg-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor ; Fri, 20 Oct 2017 10:33:54 -0400","from localhost\n\tby e06smtp12.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor from ;\n\tFri, 20 Oct 2017 15:33:52 +0100","from b06cxnps3074.portsmouth.uk.ibm.com (9.149.109.194)\n\tby e06smtp12.uk.ibm.com (192.168.101.142) with IBM ESMTP SMTP\n\tGateway: Authorized Use Only! Violators will be prosecuted; \n\tFri, 20 Oct 2017 15:33:49 +0100","from d06av22.portsmouth.uk.ibm.com (d06av22.portsmouth.uk.ibm.com\n\t[9.149.105.58])\n\tby b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with\n\tESMTP id v9KEXn6O28377108; Fri, 20 Oct 2017 14:33:49 GMT","from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id EDCC64C052;\n\tFri, 20 Oct 2017 15:29:33 +0100 (BST)","from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 0AB944C046;\n\tFri, 20 Oct 2017 15:29:33 +0100 (BST)","from oc3836556865.ibm.com (unknown [9.152.224.140])\n\tby d06av22.portsmouth.uk.ibm.com (Postfix) with ESMTP;\n\tFri, 20 Oct 2017 15:29:32 +0100 (BST)"],"To":"Cornelia Huck ","References":"<20170913132752.8484-1-pasic@linux.vnet.ibm.com>\n\t<20170913132752.8484-2-pasic@linux.vnet.ibm.com>\n\t<20170914162603.1cdabd09.cohuck@redhat.com>\n\t<0b42ef59-4366-175f-8dc7-bc3ed02e2fb4@linux.vnet.ibm.com>\n\t<20170915092758.16ea52fc.cohuck@redhat.com>\n\t<711b1e41-693a-de7d-9c13-fbe0f964c53c@linux.vnet.ibm.com>\n\t<20171020150043.383b2117.cohuck@redhat.com>","From":"Halil Pasic ","Date":"Fri, 20 Oct 2017 16:33:47 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20171020150043.383b2117.cohuck@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-TM-AS-GCONF":"00","x-cbid":"17102014-0008-0000-0000-000004A1D6B7","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17102014-0009-0000-0000-00001E343285","Message-Id":"","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-10-20_08:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=0\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1710200204","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy]","X-Received-From":"148.163.156.1","Subject":"Re: [Qemu-devel] [PATCH 1/2] s390x/ccs: add ccw-tester emulated\n\tdevice","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Christian Borntraeger ,\n\tDong Jia Shi ,\n\tPierre Morel , qemu-devel@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1791563,"web_url":"http://patchwork.ozlabs.org/comment/1791563/","msgid":"<20171020174642.7e045af4.cohuck@redhat.com>","list_archive_url":null,"date":"2017-10-20T15:46:42","subject":"Re: [Qemu-devel] [PATCH 1/2] s390x/ccs: add ccw-tester emulated\n\tdevice","submitter":{"id":71914,"url":"http://patchwork.ozlabs.org/api/people/71914/","name":"Cornelia Huck","email":"cohuck@redhat.com"},"content":"On Fri, 20 Oct 2017 16:33:47 +0200\nHalil Pasic wrote:\n\n> OK, I will approach the z/VM guys. About EMULATED_CCW_3270_CHPID_TYPE,\n> does it really make sense to have a separate chpid type for 3270? (You\n> have missed that question, so I'm asking it again).\n\nI had not. But my resources are depleted.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=cohuck@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yJVXx65yVz9t3B\n\tfor ;\n\tSat, 21 Oct 2017 02:47:13 +1100 (AEDT)","from localhost ([::1]:54575 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1e5ZVw-0005Mp-16\n\tfor incoming@patchwork.ozlabs.org; Fri, 20 Oct 2017 11:47:12 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:41634)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1e5ZVY-0005Ly-W1\n\tfor qemu-devel@nongnu.org; Fri, 20 Oct 2017 11:46:52 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1e5ZVY-0006O9-94\n\tfor qemu-devel@nongnu.org; Fri, 20 Oct 2017 11:46:49 -0400","from mx1.redhat.com ([209.132.183.28]:45944)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1e5ZVY-0006Nq-2V\n\tfor qemu-devel@nongnu.org; Fri, 20 Oct 2017 11:46:48 -0400","from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 631DC85363;\n\tFri, 20 Oct 2017 15:46:46 +0000 (UTC)","from gondolin (ovpn-116-115.ams2.redhat.com [10.36.116.115])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 2A2A7648A0;\n\tFri, 20 Oct 2017 15:46:44 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 631DC85363","Date":"Fri, 20 Oct 2017 17:46:42 +0200","From":"Cornelia Huck ","To":"Halil Pasic ","Message-ID":"<20171020174642.7e045af4.cohuck@redhat.com>","In-Reply-To":"","References":"<20170913132752.8484-1-pasic@linux.vnet.ibm.com>\n\t<20170913132752.8484-2-pasic@linux.vnet.ibm.com>\n\t<20170914162603.1cdabd09.cohuck@redhat.com>\n\t<0b42ef59-4366-175f-8dc7-bc3ed02e2fb4@linux.vnet.ibm.com>\n\t<20170915092758.16ea52fc.cohuck@redhat.com>\n\t<711b1e41-693a-de7d-9c13-fbe0f964c53c@linux.vnet.ibm.com>\n\t<20171020150043.383b2117.cohuck@redhat.com>\n\t","Organization":"Red Hat GmbH","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.13","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.25]);\n\tFri, 20 Oct 2017 15:46:46 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH 1/2] s390x/ccs: add ccw-tester emulated\n\tdevice","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Christian Borntraeger ,\n\tDong Jia Shi ,\n\tPierre Morel , qemu-devel@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]