[{"id":1767923,"web_url":"http://patchwork.ozlabs.org/comment/1767923/","msgid":"","list_archive_url":null,"date":"2017-09-13T14:27:16","subject":"Re: [Qemu-devel] [PATCH v5 07/22] target/s390x: move some s390x\n\ttypedefs to cpu-qom.h","submitter":{"id":66152,"url":"http://patchwork.ozlabs.org/api/people/66152/","name":"Thomas Huth","email":"thuth@redhat.com"},"content":"On 13.09.2017 15:24, David Hildenbrand wrote:\n> This allows us to drop inclusion of cpu_models.h in cpu-qom.h, and\n> prepares for using cpu-qom.h as a s390 specific version of typedefs.h\n> \n> Signed-off-by: David Hildenbrand \n> ---\n> target/s390x/cpu-qom.h | 5 ++++-\n> target/s390x/cpu.h | 5 +++--\n> target/s390x/cpu_models.h | 8 ++++----\n> 3 files changed, 11 insertions(+), 7 deletions(-)\n[...]\n> diff --git a/target/s390x/cpu.h b/target/s390x/cpu.h\n> index 372f7d8885..4a0a59dfbc 100644\n> --- a/target/s390x/cpu.h\n> +++ b/target/s390x/cpu.h\n> @@ -25,6 +25,7 @@\n> \n> #include \"qemu-common.h\"\n> #include \"cpu-qom.h\"\n> +#include \"cpu_models.h\"\n\nDo we really need to include cpu_models.h here? Looking at your changes\nbelow, it does not seem to be necessary?\n\n> #define TARGET_LONG_BITS 64\n> \n> @@ -80,7 +81,7 @@ typedef struct MchkQueue {\n> uint16_t type;\n> } MchkQueue;\n> \n> -typedef struct CPUS390XState {\n> +struct CPUS390XState {\n> uint64_t regs[16]; /* GP registers */\n> /*\n> * The floating point registers are part of the vector registers.\n> @@ -174,7 +175,7 @@ typedef struct CPUS390XState {\n> /* currently processed sigp order */\n> uint8_t sigp_order;\n> \n> -} CPUS390XState;\n> +};\n> \n> static inline CPU_DoubleU *get_freg(CPUS390XState *cs, int nr)\n> {\n\n Thomas","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx04.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx04.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=thuth@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xskXg4cCcz9sNr\n\tfor ;\n\tThu, 14 Sep 2017 00:28:03 +1000 (AEST)","from localhost ([::1]:42818 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1ds8e1-0002H1-Ov\n\tfor incoming@patchwork.ozlabs.org; Wed, 13 Sep 2017 10:28:01 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:38108)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1ds8dQ-00028R-7o\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 10:27:25 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1ds8dP-0000H2-Bg\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 10:27:24 -0400","from mx1.redhat.com ([209.132.183.28]:43306)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1ds8dP-0000Gc-5L\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 10:27:23 -0400","from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 4006D7EA91;\n\tWed, 13 Sep 2017 14:27:22 +0000 (UTC)","from [10.36.116.123] (ovpn-116-123.ams2.redhat.com [10.36.116.123])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 1520360600;\n\tWed, 13 Sep 2017 14:27:17 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 4006D7EA91","To":"David Hildenbrand , qemu-devel@nongnu.org","References":"<20170913132417.24384-1-david@redhat.com>\n\t<20170913132417.24384-8-david@redhat.com>","From":"Thomas Huth ","Message-ID":"","Date":"Wed, 13 Sep 2017 16:27:16 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170913132417.24384-8-david@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.13","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.28]);\n\tWed, 13 Sep 2017 14:27:22 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v5 07/22] target/s390x: move some s390x\n\ttypedefs to cpu-qom.h","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Matthew Rosato ,\n\tEduardo Habkost , cohuck@redhat.com,\n\tRichard Henderson ,\n\tAlexander Graf ,\n\tMarkus Armbruster , borntraeger@de.ibm.com,\n\tIgor Mammedov , Paolo Bonzini ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1767941,"web_url":"http://patchwork.ozlabs.org/comment/1767941/","msgid":"<18cfdcde-da7f-cf42-2d44-a1ea866fde0c@redhat.com>","list_archive_url":null,"date":"2017-09-13T14:44:25","subject":"Re: [Qemu-devel] [PATCH v5 07/22] target/s390x: move some s390x\n\ttypedefs to cpu-qom.h","submitter":{"id":70402,"url":"http://patchwork.ozlabs.org/api/people/70402/","name":"David Hildenbrand","email":"david@redhat.com"},"content":"On 13.09.2017 16:27, Thomas Huth wrote:\n> On 13.09.2017 15:24, David Hildenbrand wrote:\n>> This allows us to drop inclusion of cpu_models.h in cpu-qom.h, and\n>> prepares for using cpu-qom.h as a s390 specific version of typedefs.h\n>>\n>> Signed-off-by: David Hildenbrand \n>> ---\n>> target/s390x/cpu-qom.h | 5 ++++-\n>> target/s390x/cpu.h | 5 +++--\n>> target/s390x/cpu_models.h | 8 ++++----\n>> 3 files changed, 11 insertions(+), 7 deletions(-)\n> [...]\n>> diff --git a/target/s390x/cpu.h b/target/s390x/cpu.h\n>> index 372f7d8885..4a0a59dfbc 100644\n>> --- a/target/s390x/cpu.h\n>> +++ b/target/s390x/cpu.h\n>> @@ -25,6 +25,7 @@\n>> \n>> #include \"qemu-common.h\"\n>> #include \"cpu-qom.h\"\n>> +#include \"cpu_models.h\"\n> \n> Do we really need to include cpu_models.h here? Looking at your changes\n> below, it does not seem to be necessary?\n\nYes, due to s390_has_feat(), and I want to avoid cleaning all the other\ncalling places up in this patch.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=david@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xskw92dHlz9sNr\n\tfor ;\n\tThu, 14 Sep 2017 00:44:57 +1000 (AEST)","from localhost ([::1]:42926 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1ds8uN-0007gt-HA\n\tfor incoming@patchwork.ozlabs.org; Wed, 13 Sep 2017 10:44:55 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:44886)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1ds8u3-0007Zq-KL\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 10:44:36 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1ds8tz-0003ur-Lr\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 10:44:35 -0400","from mx1.redhat.com ([209.132.183.28]:1447)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1ds8tz-0003uF-GV\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 10:44:31 -0400","from smtp.corp.redhat.com\n\t(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 7F5FD9C51;\n\tWed, 13 Sep 2017 14:44:30 +0000 (UTC)","from [10.36.116.230] (ovpn-116-230.ams2.redhat.com [10.36.116.230])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id CDE6860C3A;\n\tWed, 13 Sep 2017 14:44:26 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 7F5FD9C51","To":"Thomas Huth , qemu-devel@nongnu.org","References":"<20170913132417.24384-1-david@redhat.com>\n\t<20170913132417.24384-8-david@redhat.com>\n\t","From":"David Hildenbrand ","Organization":"Red Hat GmbH","Message-ID":"<18cfdcde-da7f-cf42-2d44-a1ea866fde0c@redhat.com>","Date":"Wed, 13 Sep 2017 16:44:25 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.14","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.26]);\n\tWed, 13 Sep 2017 14:44:30 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v5 07/22] target/s390x: move some s390x\n\ttypedefs to cpu-qom.h","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Matthew Rosato ,\n\tEduardo Habkost , cohuck@redhat.com,\n\tRichard Henderson ,\n\tAlexander Graf ,\n\tMarkus Armbruster , borntraeger@de.ibm.com,\n\tIgor Mammedov , Paolo Bonzini ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1767956,"web_url":"http://patchwork.ozlabs.org/comment/1767956/","msgid":"","list_archive_url":null,"date":"2017-09-13T15:04:43","subject":"Re: [Qemu-devel] [PATCH v5 07/22] target/s390x: move some s390x\n\ttypedefs to cpu-qom.h","submitter":{"id":66152,"url":"http://patchwork.ozlabs.org/api/people/66152/","name":"Thomas Huth","email":"thuth@redhat.com"},"content":"On 13.09.2017 16:44, David Hildenbrand wrote:\n> On 13.09.2017 16:27, Thomas Huth wrote:\n>> On 13.09.2017 15:24, David Hildenbrand wrote:\n>>> This allows us to drop inclusion of cpu_models.h in cpu-qom.h, and\n>>> prepares for using cpu-qom.h as a s390 specific version of typedefs.h\n>>>\n>>> Signed-off-by: David Hildenbrand \n>>> ---\n>>> target/s390x/cpu-qom.h | 5 ++++-\n>>> target/s390x/cpu.h | 5 +++--\n>>> target/s390x/cpu_models.h | 8 ++++----\n>>> 3 files changed, 11 insertions(+), 7 deletions(-)\n>> [...]\n>>> diff --git a/target/s390x/cpu.h b/target/s390x/cpu.h\n>>> index 372f7d8885..4a0a59dfbc 100644\n>>> --- a/target/s390x/cpu.h\n>>> +++ b/target/s390x/cpu.h\n>>> @@ -25,6 +25,7 @@\n>>> \n>>> #include \"qemu-common.h\"\n>>> #include \"cpu-qom.h\"\n>>> +#include \"cpu_models.h\"\n>>\n>> Do we really need to include cpu_models.h here? Looking at your changes\n>> below, it does not seem to be necessary?\n> \n> Yes, due to s390_has_feat(), and I want to avoid cleaning all the other\n> calling places up in this patch.\n\nOK, I just checked and it indeed blows up in a lot of places, so I think\nthis include here is justified.\n\nReviewed-by: Thomas Huth ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=thuth@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xslMn5z99z9s76\n\tfor ;\n\tThu, 14 Sep 2017 01:05:24 +1000 (AEST)","from localhost ([::1]:42996 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1ds9EA-0001qt-8m\n\tfor incoming@patchwork.ozlabs.org; Wed, 13 Sep 2017 11:05:22 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:52751)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1ds9Dk-0001qX-Aq\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 11:05:01 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1ds9Dh-0001GY-6f\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 11:04:56 -0400","from mx1.redhat.com ([209.132.183.28]:57746)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1ds9Dh-0001GH-0f\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 11:04:53 -0400","from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 0AFB3C04B924;\n\tWed, 13 Sep 2017 15:04:52 +0000 (UTC)","from [10.36.116.123] (ovpn-116-123.ams2.redhat.com [10.36.116.123])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id D9B1960600;\n\tWed, 13 Sep 2017 15:04:44 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 0AFB3C04B924","To":"David Hildenbrand , qemu-devel@nongnu.org","References":"<20170913132417.24384-1-david@redhat.com>\n\t<20170913132417.24384-8-david@redhat.com>\n\t\n\t<18cfdcde-da7f-cf42-2d44-a1ea866fde0c@redhat.com>","From":"Thomas Huth ","Message-ID":"","Date":"Wed, 13 Sep 2017 17:04:43 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<18cfdcde-da7f-cf42-2d44-a1ea866fde0c@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.13","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.31]);\n\tWed, 13 Sep 2017 15:04:52 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v5 07/22] target/s390x: move some s390x\n\ttypedefs to cpu-qom.h","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Matthew Rosato ,\n\tEduardo Habkost , cohuck@redhat.com,\n\tRichard Henderson ,\n\tAlexander Graf ,\n\tMarkus Armbruster , borntraeger@de.ibm.com,\n\tIgor Mammedov , Paolo Bonzini ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]