[{"id":1776786,"web_url":"http://patchwork.ozlabs.org/comment/1776786/","msgid":"","list_archive_url":null,"date":"2017-09-28T06:01:25","subject":"Re: [Qemu-devel] [PATCH v5 16/22] s390x: allow cpu hotplug via\n\tdevice_add","submitter":{"id":66152,"url":"http://patchwork.ozlabs.org/api/people/66152/","name":"Thomas Huth","email":"thuth@redhat.com"},"content":"On 13.09.2017 15:24, David Hildenbrand wrote:\n> E.g. the following now works:\n> device_add host-s390-cpu,id=cpu1,core-id=1\n\n Hi David,\n\nFYI, this introduced a possibility to crash QEMU with the none machine:\n\n$ s390x-softmmu/qemu-system-s390x -M none -nographic\nQEMU 2.10.50 monitor - type 'help' for more information\n(qemu) device_add qemu-s390-cpu\nSegmentation fault (core dumped)\n\n Thomas","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=thuth@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y2kc06gdDz9t38\n\tfor ;\n\tThu, 28 Sep 2017 16:02:06 +1000 (AEST)","from localhost ([::1]:57542 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dxRtc-000256-1w\n\tfor incoming@patchwork.ozlabs.org; Thu, 28 Sep 2017 02:02:04 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:44122)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dxRtA-000250-IT\n\tfor qemu-devel@nongnu.org; Thu, 28 Sep 2017 02:01:40 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dxRt7-0006dy-Gy\n\tfor qemu-devel@nongnu.org; Thu, 28 Sep 2017 02:01:36 -0400","from mx1.redhat.com ([209.132.183.28]:41496)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dxRt7-0006dj-AV\n\tfor qemu-devel@nongnu.org; Thu, 28 Sep 2017 02:01:33 -0400","from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 1702E3F77D9;\n\tThu, 28 Sep 2017 06:01:32 +0000 (UTC)","from [10.36.116.86] (ovpn-116-86.ams2.redhat.com [10.36.116.86])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id CCD3782328;\n\tThu, 28 Sep 2017 06:01:26 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 1702E3F77D9","To":"David Hildenbrand , qemu-devel@nongnu.org","References":"<20170913132417.24384-1-david@redhat.com>\n\t<20170913132417.24384-17-david@redhat.com>","From":"Thomas Huth ","Message-ID":"","Date":"Thu, 28 Sep 2017 08:01:25 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170913132417.24384-17-david@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.12","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.30]);\n\tThu, 28 Sep 2017 06:01:32 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v5 16/22] s390x: allow cpu hotplug via\n\tdevice_add","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Matthew Rosato ,\n\tEduardo Habkost , cohuck@redhat.com,\n\tRichard Henderson ,\n\tMarkus Armbruster ,\n\tAlexander Graf , borntraeger@de.ibm.com,\n\tPaolo Bonzini , Igor Mammedov ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1777012,"web_url":"http://patchwork.ozlabs.org/comment/1777012/","msgid":"","list_archive_url":null,"date":"2017-09-28T13:00:26","subject":"Re: [Qemu-devel] [PATCH v5 16/22] s390x: allow cpu hotplug via\n\tdevice_add","submitter":{"id":70402,"url":"http://patchwork.ozlabs.org/api/people/70402/","name":"David Hildenbrand","email":"david@redhat.com"},"content":"On 28.09.2017 08:01, Thomas Huth wrote:\n> On 13.09.2017 15:24, David Hildenbrand wrote:\n>> E.g. the following now works:\n>> device_add host-s390-cpu,id=cpu1,core-id=1\n> \n> Hi David,\n> \n> FYI, this introduced a possibility to crash QEMU with the none machine:\n> \n> $ s390x-softmmu/qemu-system-s390x -M none -nographic\n> QEMU 2.10.50 monitor - type 'help' for more information\n> (qemu) device_add qemu-s390-cpu\n> Segmentation fault (core dumped)\n> \n> Thomas\n> \n\nInteresting, x86 shields hotplug for none completely.\n\nt460s: ~/git/qemu s390x_lap $ sudo qemu-system-x86_64 -M none -smp\n1,maxcpus=4 -monitor stdio -Sqemu-system-x86_64: Number of SMP CPUs\nrequested (4) exceeds max CPUs supported by machine 'none' (1)\n\nWill send a patch.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx04.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx04.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=david@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y2vvR2PQ2z9s06\n\tfor ;\n\tThu, 28 Sep 2017 23:01:06 +1000 (AEST)","from localhost ([::1]:59188 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dxYR5-0002ZF-AA\n\tfor incoming@patchwork.ozlabs.org; Thu, 28 Sep 2017 09:01:03 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:58385)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dxYQi-0002Z3-Ng\n\tfor qemu-devel@nongnu.org; Thu, 28 Sep 2017 09:00:44 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dxYQe-0005L0-D8\n\tfor qemu-devel@nongnu.org; Thu, 28 Sep 2017 09:00:40 -0400","from mx1.redhat.com ([209.132.183.28]:42748)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dxYQe-0005Kn-6Q\n\tfor qemu-devel@nongnu.org; Thu, 28 Sep 2017 09:00:36 -0400","from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 09BE610C353;\n\tThu, 28 Sep 2017 13:00:35 +0000 (UTC)","from [10.36.117.191] (ovpn-117-191.ams2.redhat.com [10.36.117.191])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 5954918ED0;\n\tThu, 28 Sep 2017 13:00:26 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 09BE610C353","To":"Thomas Huth , qemu-devel@nongnu.org","References":"<20170913132417.24384-1-david@redhat.com>\n\t<20170913132417.24384-17-david@redhat.com>\n\t","From":"David Hildenbrand ","Organization":"Red Hat GmbH","Message-ID":"","Date":"Thu, 28 Sep 2017 15:00:26 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.13","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.28]);\n\tThu, 28 Sep 2017 13:00:35 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v5 16/22] s390x: allow cpu hotplug via\n\tdevice_add","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Matthew Rosato ,\n\tEduardo Habkost , cohuck@redhat.com,\n\tRichard Henderson ,\n\tMarkus Armbruster ,\n\tAlexander Graf , borntraeger@de.ibm.com,\n\tPaolo Bonzini , Igor Mammedov ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1777032,"web_url":"http://patchwork.ozlabs.org/comment/1777032/","msgid":"<27e86935-880b-1bee-bf25-35652e5b5d1d@redhat.com>","list_archive_url":null,"date":"2017-09-28T13:36:35","subject":"Re: [Qemu-devel] [PATCH v5 16/22] s390x: allow cpu hotplug via\n\tdevice_add","submitter":{"id":70402,"url":"http://patchwork.ozlabs.org/api/people/70402/","name":"David Hildenbrand","email":"david@redhat.com"},"content":"On 28.09.2017 08:01, Thomas Huth wrote:\n> On 13.09.2017 15:24, David Hildenbrand wrote:\n>> E.g. the following now works:\n>> device_add host-s390-cpu,id=cpu1,core-id=1\n> \n> Hi David,\n> \n> FYI, this introduced a possibility to crash QEMU with the none machine:\n> \n> $ s390x-softmmu/qemu-system-s390x -M none -nographic\n> QEMU 2.10.50 monitor - type 'help' for more information\n> (qemu) device_add qemu-s390-cpu\n> Segmentation fault (core dumped)\n> \n> Thomas\n> \n\nInterestingly, this is already fixed by my patch\n\ns390x: raise CPU hotplug irq after really hotplugged\n\npart of the SMP series.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=david@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y2wjD5spYz9t48\n\tfor ;\n\tThu, 28 Sep 2017 23:37:10 +1000 (AEST)","from localhost ([::1]:59282 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dxYzx-0004It-Qx\n\tfor incoming@patchwork.ozlabs.org; Thu, 28 Sep 2017 09:37:05 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:39132)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dxYzd-0004Io-0O\n\tfor qemu-devel@nongnu.org; Thu, 28 Sep 2017 09:36:45 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dxYzZ-0006P4-4V\n\tfor qemu-devel@nongnu.org; Thu, 28 Sep 2017 09:36:45 -0400","from mx1.redhat.com ([209.132.183.28]:47142)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dxYzY-0006Oi-Sz\n\tfor qemu-devel@nongnu.org; Thu, 28 Sep 2017 09:36:41 -0400","from smtp.corp.redhat.com\n\t(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 2D0A4C0C4C29;\n\tThu, 28 Sep 2017 13:36:39 +0000 (UTC)","from [10.36.117.191] (ovpn-117-191.ams2.redhat.com [10.36.117.191])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 2CCE57DD87;\n\tThu, 28 Sep 2017 13:36:35 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 2D0A4C0C4C29","To":"Thomas Huth , qemu-devel@nongnu.org","References":"<20170913132417.24384-1-david@redhat.com>\n\t<20170913132417.24384-17-david@redhat.com>\n\t","From":"David Hildenbrand ","Organization":"Red Hat GmbH","Message-ID":"<27e86935-880b-1bee-bf25-35652e5b5d1d@redhat.com>","Date":"Thu, 28 Sep 2017 15:36:35 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.14","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.32]);\n\tThu, 28 Sep 2017 13:36:39 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v5 16/22] s390x: allow cpu hotplug via\n\tdevice_add","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Matthew Rosato ,\n\tEduardo Habkost , cohuck@redhat.com,\n\tRichard Henderson ,\n\tMarkus Armbruster ,\n\tAlexander Graf , borntraeger@de.ibm.com,\n\tPaolo Bonzini , Igor Mammedov ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]