[{"id":1768012,"web_url":"http://patchwork.ozlabs.org/comment/1768012/","msgid":"<17d817d4-bfce-98aa-7841-2136cb8dcfc6@redhat.com>","list_archive_url":null,"date":"2017-09-13T16:34:27","subject":"Re: [Qemu-devel] [PATCH v5 03/22] s390x: get rid of s390-virtio.c","submitter":{"id":70402,"url":"http://patchwork.ozlabs.org/api/people/70402/","name":"David Hildenbrand","email":"david@redhat.com"},"content":"On 13.09.2017 15:23, David Hildenbrand wrote:\n> It is a leftover from the days where we had still the !ccw virtio\n> machine. As this one is long gone, let's move everything to> s390-virtio-ccw.c.\n\nWhoops, another thing to fix up:\n\nhw/s390x/s390-virtio.c is not compiled any more but not completely deleted.\n\n> \n> Suggested-by: Cornelia Huck \n> Reviewed-by: Thomas Huth \n> Acked-by: Christian Borntraeger \n> Signed-off-by: David Hildenbrand \n> ---\n> hw/s390x/Makefile.objs | 1 -\n> hw/s390x/s390-virtio-ccw.c | 157 ++++++++++++++++++++++++++++++++++++++++++++-\n> hw/s390x/s390-virtio.c | 37 -----------\n> hw/s390x/s390-virtio.h | 15 -----\n> 4 files changed, 156 insertions(+), 54 deletions(-)\n> \n> diff --git a/hw/s390x/Makefile.objs b/hw/s390x/Makefile.objs\n> index 7ee19d3abc..dc704b57d6 100644\n> --- a/hw/s390x/Makefile.objs\n> +++ b/hw/s390x/Makefile.objs\n> @@ -1,4 +1,3 @@\n> -obj-y += s390-virtio.o\n> obj-y += s390-virtio-hcall.o\n> obj-y += sclp.o\n> obj-y += event-facility.o\n> diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c\n> index dd504dd5ae..4c3a3e177b 100644\n> --- a/hw/s390x/s390-virtio-ccw.c\n> +++ b/hw/s390x/s390-virtio-ccw.c\n> @@ -2,6 +2,7 @@\n> * virtio ccw machine\n> *\n> * Copyright 2012 IBM Corp.\n> + * Copyright (c) 2009 Alexander Graf \n> * Author(s): Cornelia Huck \n> *\n> * This work is licensed under the terms of the GNU GPL, version 2 or (at\n> @@ -31,6 +32,46 @@\n> #include \"hw/s390x/css-bridge.h\"\n> #include \"migration/register.h\"\n> #include \"cpu_models.h\"\n> +#include \"qapi/qmp/qerror.h\"\n> +#include \"hw/nmi.h\"\n> +\n> +static S390CPU **cpu_states;\n> +\n> +S390CPU *s390_cpu_addr2state(uint16_t cpu_addr)\n> +{\n> + if (cpu_addr >= max_cpus) {\n> + return NULL;\n> + }\n> +\n> + /* Fast lookup via CPU ID */\n> + return cpu_states[cpu_addr];\n> +}\n> +\n> +static void s390_init_cpus(MachineState *machine)\n> +{\n> + int i;\n> + gchar *name;\n> +\n> + if (machine->cpu_model == NULL) {\n> + machine->cpu_model = s390_default_cpu_model_name();\n> + }\n> +\n> + cpu_states = g_new0(S390CPU *, max_cpus);\n> +\n> + for (i = 0; i < max_cpus; i++) {\n> + name = g_strdup_printf(\"cpu[%i]\", i);\n> + object_property_add_link(OBJECT(machine), name, TYPE_S390_CPU,\n> + (Object **) &cpu_states[i],\n> + object_property_allow_set_link,\n> + OBJ_PROP_LINK_UNREF_ON_RELEASE,\n> + &error_abort);\n> + g_free(name);\n> + }\n> +\n> + for (i = 0; i < smp_cpus; i++) {\n> + s390x_new_cpu(machine->cpu_model, i, &error_fatal);\n> + }\n> +}\n> \n> static const char *const reset_dev_types[] = {\n> TYPE_VIRTUAL_CSS_BRIDGE,\n> @@ -94,7 +135,7 @@ static void virtio_ccw_register_hcalls(void)\n> virtio_ccw_hcall_early_printk);\n> }\n> \n> -void s390_memory_init(ram_addr_t mem_size)\n> +static void s390_memory_init(ram_addr_t mem_size)\n> {\n> MemoryRegion *sysmem = get_system_memory();\n> MemoryRegion *ram = g_new(MemoryRegion, 1);\n> @@ -109,11 +150,103 @@ void s390_memory_init(ram_addr_t mem_size)\n> s390_stattrib_init();\n> }\n> \n> +#define S390_TOD_CLOCK_VALUE_MISSING 0x00\n> +#define S390_TOD_CLOCK_VALUE_PRESENT 0x01\n> +\n> +static void gtod_save(QEMUFile *f, void *opaque)\n> +{\n> + uint64_t tod_low;\n> + uint8_t tod_high;\n> + int r;\n> +\n> + r = s390_get_clock(&tod_high, &tod_low);\n> + if (r) {\n> + fprintf(stderr, \"WARNING: Unable to get guest clock for migration. \"\n> + \"Error code %d. Guest clock will not be migrated \"\n> + \"which could cause the guest to hang.\\n\", r);\n> + qemu_put_byte(f, S390_TOD_CLOCK_VALUE_MISSING);\n> + return;\n> + }\n> +\n> + qemu_put_byte(f, S390_TOD_CLOCK_VALUE_PRESENT);\n> + qemu_put_byte(f, tod_high);\n> + qemu_put_be64(f, tod_low);\n> +}\n> +\n> +static int gtod_load(QEMUFile *f, void *opaque, int version_id)\n> +{\n> + uint64_t tod_low;\n> + uint8_t tod_high;\n> + int r;\n> +\n> + if (qemu_get_byte(f) == S390_TOD_CLOCK_VALUE_MISSING) {\n> + fprintf(stderr, \"WARNING: Guest clock was not migrated. This could \"\n> + \"cause the guest to hang.\\n\");\n> + return 0;\n> + }\n> +\n> + tod_high = qemu_get_byte(f);\n> + tod_low = qemu_get_be64(f);\n> +\n> + r = s390_set_clock(&tod_high, &tod_low);\n> + if (r) {\n> + fprintf(stderr, \"WARNING: Unable to set guest clock value. \"\n> + \"s390_get_clock returned error %d. This could cause \"\n> + \"the guest to hang.\\n\", r);\n> + }\n> +\n> + return 0;\n> +}\n> +\n> static SaveVMHandlers savevm_gtod = {\n> .save_state = gtod_save,\n> .load_state = gtod_load,\n> };\n> \n> +static void s390_init_ipl_dev(const char *kernel_filename,\n> + const char *kernel_cmdline,\n> + const char *initrd_filename, const char *firmware,\n> + const char *netboot_fw, bool enforce_bios)\n> +{\n> + Object *new = object_new(TYPE_S390_IPL);\n> + DeviceState *dev = DEVICE(new);\n> +\n> + if (kernel_filename) {\n> + qdev_prop_set_string(dev, \"kernel\", kernel_filename);\n> + }\n> + if (initrd_filename) {\n> + qdev_prop_set_string(dev, \"initrd\", initrd_filename);\n> + }\n> + qdev_prop_set_string(dev, \"cmdline\", kernel_cmdline);\n> + qdev_prop_set_string(dev, \"firmware\", firmware);\n> + qdev_prop_set_string(dev, \"netboot_fw\", netboot_fw);\n> + qdev_prop_set_bit(dev, \"enforce_bios\", enforce_bios);\n> + object_property_add_child(qdev_get_machine(), TYPE_S390_IPL,\n> + new, NULL);\n> + object_unref(new);\n> + qdev_init_nofail(dev);\n> +}\n> +\n> +static void s390_create_virtio_net(BusState *bus, const char *name)\n> +{\n> + int i;\n> +\n> + for (i = 0; i < nb_nics; i++) {\n> + NICInfo *nd = &nd_table[i];\n> + DeviceState *dev;\n> +\n> + if (!nd->model) {\n> + nd->model = g_strdup(\"virtio\");\n> + }\n> +\n> + qemu_check_nic_model(nd, \"virtio\");\n> +\n> + dev = qdev_create(bus, name);\n> + qdev_set_nic_properties(dev, nd);\n> + qdev_init_nofail(dev);\n> + }\n> +}\n> +\n> static void ccw_init(MachineState *machine)\n> {\n> int ret;\n> @@ -177,6 +310,19 @@ static void s390_cpu_plug(HotplugHandler *hotplug_dev,\n> g_free(name);\n> }\n> \n> +static void s390_machine_reset(void)\n> +{\n> + S390CPU *ipl_cpu = S390_CPU(qemu_get_cpu(0));\n> +\n> + s390_cmma_reset();\n> + qemu_devices_reset();\n> + s390_crypto_reset();\n> +\n> + /* all cpus are stopped - configure and start the ipl cpu only */\n> + s390_ipl_prepare_cpu(ipl_cpu);\n> + s390_cpu_set_state(CPU_STATE_OPERATING, ipl_cpu);\n> +}\n> +\n> static void s390_machine_device_plug(HotplugHandler *hotplug_dev,\n> DeviceState *dev, Error **errp)\n> {\n> @@ -201,6 +347,15 @@ static void s390_hot_add_cpu(const int64_t id, Error **errp)\n> s390x_new_cpu(machine->cpu_model, id, errp);\n> }\n> \n> +static void s390_nmi(NMIState *n, int cpu_index, Error **errp)\n> +{\n> + CPUState *cs = qemu_get_cpu(cpu_index);\n> +\n> + if (s390_cpu_restart(S390_CPU(cs))) {\n> + error_setg(errp, QERR_UNSUPPORTED);\n> + }\n> +}\n> +\n> static void ccw_machine_class_init(ObjectClass *oc, void *data)\n> {\n> MachineClass *mc = MACHINE_CLASS(oc);\n> diff --git a/hw/s390x/s390-virtio.c b/hw/s390x/s390-virtio.c\n> index da3f49e80e..9316be1cfc 100644\n> --- a/hw/s390x/s390-virtio.c\n> +++ b/hw/s390x/s390-virtio.c\n> @@ -48,17 +48,6 @@\n> #define S390_TOD_CLOCK_VALUE_MISSING 0x00\n> #define S390_TOD_CLOCK_VALUE_PRESENT 0x01\n> \n> -static S390CPU **cpu_states;\n> -\n> -S390CPU *s390_cpu_addr2state(uint16_t cpu_addr)\n> -{\n> - if (cpu_addr >= max_cpus) {\n> - return NULL;\n> - }\n> -\n> - /* Fast lookup via CPU ID */\n> - return cpu_states[cpu_addr];\n> -}\n> \n> void s390_init_ipl_dev(const char *kernel_filename,\n> const char *kernel_cmdline,\n> @@ -86,32 +75,6 @@ void s390_init_ipl_dev(const char *kernel_filename,\n> qdev_init_nofail(dev);\n> }\n> \n> -void s390_init_cpus(MachineState *machine)\n> -{\n> - int i;\n> - gchar *name;\n> -\n> - if (machine->cpu_model == NULL) {\n> - machine->cpu_model = s390_default_cpu_model_name();\n> - }\n> -\n> - cpu_states = g_new0(S390CPU *, max_cpus);\n> -\n> - for (i = 0; i < max_cpus; i++) {\n> - name = g_strdup_printf(\"cpu[%i]\", i);\n> - object_property_add_link(OBJECT(machine), name, TYPE_S390_CPU,\n> - (Object **) &cpu_states[i],\n> - object_property_allow_set_link,\n> - OBJ_PROP_LINK_UNREF_ON_RELEASE,\n> - &error_abort);\n> - g_free(name);\n> - }\n> -\n> - for (i = 0; i < smp_cpus; i++) {\n> - s390x_new_cpu(machine->cpu_model, i, &error_fatal);\n> - }\n> -}\n> -\n> \n> void s390_create_virtio_net(BusState *bus, const char *name)\n> {\n> diff --git a/hw/s390x/s390-virtio.h b/hw/s390x/s390-virtio.h\n> index ca97fd6814..d984cd4115 100644\n> --- a/hw/s390x/s390-virtio.h\n> +++ b/hw/s390x/s390-virtio.h\n> @@ -12,24 +12,9 @@\n> #ifndef HW_S390_VIRTIO_H\n> #define HW_S390_VIRTIO_H\n> \n> -#include \"hw/nmi.h\"\n> #include \"standard-headers/asm-s390/kvm_virtio.h\"\n> #include \"standard-headers/asm-s390/virtio-ccw.h\"\n> \n> typedef int (*s390_virtio_fn)(const uint64_t *args);\n> void s390_register_virtio_hypercall(uint64_t code, s390_virtio_fn fn);\n> -\n> -void s390_init_cpus(MachineState *machine);\n> -void s390_init_ipl_dev(const char *kernel_filename,\n> - const char *kernel_cmdline,\n> - const char *initrd_filename,\n> - const char *firmware,\n> - const char *netboot_fw,\n> - bool enforce_bios);\n> -void s390_create_virtio_net(BusState *bus, const char *name);\n> -void s390_nmi(NMIState *n, int cpu_index, Error **errp);\n> -void s390_machine_reset(void);\n> -void s390_memory_init(ram_addr_t mem_size);\n> -void gtod_save(QEMUFile *f, void *opaque);\n> -int gtod_load(QEMUFile *f, void *opaque, int version_id);\n> #endif\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx03.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx03.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=david@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xsnMR1cNLz9s7B\n\tfor ;\n\tThu, 14 Sep 2017 02:35:15 +1000 (AEST)","from localhost ([::1]:43537 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dsAd3-0005zO-It\n\tfor incoming@patchwork.ozlabs.org; Wed, 13 Sep 2017 12:35:09 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:33759)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dsAcX-0005w8-70\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 12:34:38 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dsAcT-0007rE-55\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 12:34:37 -0400","from mx1.redhat.com ([209.132.183.28]:39840)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dsAcS-0007p6-Sn\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 12:34:33 -0400","from smtp.corp.redhat.com\n\t(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id C64687F755;\n\tWed, 13 Sep 2017 16:34:31 +0000 (UTC)","from [10.36.116.230] (ovpn-116-230.ams2.redhat.com [10.36.116.230])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id B7EB05D744;\n\tWed, 13 Sep 2017 16:34:28 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com C64687F755","To":"qemu-devel@nongnu.org","References":"<20170913132417.24384-1-david@redhat.com>\n\t<20170913132417.24384-4-david@redhat.com>","From":"David Hildenbrand ","Organization":"Red Hat GmbH","Message-ID":"<17d817d4-bfce-98aa-7841-2136cb8dcfc6@redhat.com>","Date":"Wed, 13 Sep 2017 18:34:27 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170913132417.24384-4-david@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.14","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.27]);\n\tWed, 13 Sep 2017 16:34:31 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v5 03/22] s390x: get rid of s390-virtio.c","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Matthew Rosato , thuth@redhat.com,\n\tEduardo Habkost , cohuck@redhat.com,\n\tRichard Henderson ,\n\tAlexander Graf ,\n\tMarkus Armbruster , borntraeger@de.ibm.com,\n\tIgor Mammedov , Paolo Bonzini ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1768022,"web_url":"http://patchwork.ozlabs.org/comment/1768022/","msgid":"<20170913185453.675bedac.cohuck@redhat.com>","list_archive_url":null,"date":"2017-09-13T16:54:53","subject":"Re: [Qemu-devel] [PATCH v5 03/22] s390x: get rid of s390-virtio.c","submitter":{"id":71914,"url":"http://patchwork.ozlabs.org/api/people/71914/","name":"Cornelia Huck","email":"cohuck@redhat.com"},"content":"On Wed, 13 Sep 2017 18:34:27 +0200\nDavid Hildenbrand wrote:\n\n> On 13.09.2017 15:23, David Hildenbrand wrote:\n> > It is a leftover from the days where we had still the !ccw virtio\n> > machine. As this one is long gone, let's move everything to> s390-virtio-ccw.c. \n> \n> Whoops, another thing to fix up:\n> \n> hw/s390x/s390-virtio.c is not compiled any more but not completely deleted.\n\nNo worries, fixed up.\n\n> \n> > \n> > Suggested-by: Cornelia Huck \n> > Reviewed-by: Thomas Huth \n> > Acked-by: Christian Borntraeger \n> > Signed-off-by: David Hildenbrand \n> > ---\n> > hw/s390x/Makefile.objs | 1 -\n> > hw/s390x/s390-virtio-ccw.c | 157 ++++++++++++++++++++++++++++++++++++++++++++-\n> > hw/s390x/s390-virtio.c | 37 -----------\n> > hw/s390x/s390-virtio.h | 15 -----\n> > 4 files changed, 156 insertions(+), 54 deletions(-)","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=cohuck@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xsnpt1YLNz9ryQ\n\tfor ;\n\tThu, 14 Sep 2017 02:55:33 +1000 (AEST)","from localhost ([::1]:43657 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dsAwk-00023t-UV\n\tfor incoming@patchwork.ozlabs.org; Wed, 13 Sep 2017 12:55:30 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:49130)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dsAwL-00023D-HV\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 12:55:06 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dsAwI-0006hO-DB\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 12:55:05 -0400","from mx1.redhat.com ([209.132.183.28]:39934)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dsAwI-0006fc-6n\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 12:55:02 -0400","from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id C3F694E4D4;\n\tWed, 13 Sep 2017 16:55:00 +0000 (UTC)","from gondolin (ovpn-117-3.ams2.redhat.com [10.36.117.3])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id C3DCC69FCC;\n\tWed, 13 Sep 2017 16:54:55 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com C3F694E4D4","Date":"Wed, 13 Sep 2017 18:54:53 +0200","From":"Cornelia Huck ","To":"David Hildenbrand ","Message-ID":"<20170913185453.675bedac.cohuck@redhat.com>","In-Reply-To":"<17d817d4-bfce-98aa-7841-2136cb8dcfc6@redhat.com>","References":"<20170913132417.24384-1-david@redhat.com>\n\t<20170913132417.24384-4-david@redhat.com>\n\t<17d817d4-bfce-98aa-7841-2136cb8dcfc6@redhat.com>","Organization":"Red Hat GmbH","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.11","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.38]);\n\tWed, 13 Sep 2017 16:55:01 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v5 03/22] s390x: get rid of s390-virtio.c","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Matthew Rosato , thuth@redhat.com,\n\tEduardo Habkost ,\n\tMarkus Armbruster ,\n\tRichard Henderson ,\n\tqemu-devel@nongnu.org, Alexander Graf ,\n\tborntraeger@de.ibm.com, Igor Mammedov ,\n\tPaolo Bonzini ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]