[{"id":1767926,"web_url":"http://patchwork.ozlabs.org/comment/1767926/","msgid":"<fb0909ad-19bb-3a92-27c6-652bf4d32277@redhat.com>","list_archive_url":null,"date":"2017-09-13T14:29:23","subject":"Re: [Qemu-devel] [PATCH v5 08/22] s390x: move sclp_service_call()\n\tto sclp.h","submitter":{"id":66152,"url":"http://patchwork.ozlabs.org/api/people/66152/","name":"Thomas Huth","email":"thuth@redhat.com"},"content":"On 13.09.2017 15:24, David Hildenbrand wrote:\n> Implemented in sclp.c, so let's move it to the right include file.\n> Fix up one include. Do a forward declaration of struct CPUS390XState to\n> fix the two sclp consoles complaining.\n\nIs that sentence about the forward declaration still valid? I did not\nsee that anymore here...\n\nApart from that:\n\nReviewed-by: Thomas Huth <thuth@redhat.com>\n\n\n> diff --git a/include/hw/s390x/sclp.h b/include/hw/s390x/sclp.h\n> index a72d096081..847ff32f85 100644\n> --- a/include/hw/s390x/sclp.h\n> +++ b/include/hw/s390x/sclp.h\n> @@ -16,6 +16,7 @@\n>  \n>  #include \"hw/sysbus.h\"\n>  #include \"hw/qdev.h\"\n> +#include \"target/s390x/cpu-qom.h\"\n>  \n>  #define SCLP_CMD_CODE_MASK                      0xffff00ff\n>  \n> @@ -242,5 +243,6 @@ sclpMemoryHotplugDev *init_sclp_memory_hotplug_dev(void);\n>  sclpMemoryHotplugDev *get_sclp_memory_hotplug_dev(void);\n>  void sclp_service_interrupt(uint32_t sccb);\n>  void raise_irq_cpu_hotplug(void);\n> +int sclp_service_call(CPUS390XState *env, uint64_t sccb, uint32_t code);\n>  \n>  #endif\n> diff --git a/target/s390x/cpu.h b/target/s390x/cpu.h\n> index 4a0a59dfbc..5295bd3c66 100644\n> --- a/target/s390x/cpu.h\n> +++ b/target/s390x/cpu.h\n> @@ -722,6 +722,5 @@ int s390_cpu_virt_mem_rw(S390CPU *cpu, vaddr laddr, uint8_t ar, void *hostbuf,\n>  \n>  /* outside of target/s390x/ */\n>  S390CPU *s390_cpu_addr2state(uint16_t cpu_addr);\n> -int sclp_service_call(CPUS390XState *env, uint64_t sccb, uint32_t code);\n>  \n>  #endif\n> diff --git a/target/s390x/misc_helper.c b/target/s390x/misc_helper.c\n> index b142db71c6..8b07535b02 100644\n> --- a/target/s390x/misc_helper.c\n> +++ b/target/s390x/misc_helper.c\n> @@ -35,6 +35,7 @@\n>  #include \"sysemu/sysemu.h\"\n>  #include \"hw/s390x/ebcdic.h\"\n>  #include \"hw/s390x/s390-virtio-hcall.h\"\n> +#include \"hw/s390x/sclp.h\"\n>  #endif\n>  \n>  /* #define DEBUG_HELPER */\n>","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)","ext-mx05.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx05.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=thuth@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xskb80Y4dz9sNr\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 14 Sep 2017 00:30:12 +1000 (AEST)","from localhost ([::1]:42825 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1ds8g6-0003qW-66\n\tfor incoming@patchwork.ozlabs.org; Wed, 13 Sep 2017 10:30:10 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:39046)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <thuth@redhat.com>) id 1ds8fZ-0003lj-Dr\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 10:29:43 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <thuth@redhat.com>) id 1ds8fU-00024Q-G3\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 10:29:37 -0400","from mx1.redhat.com ([209.132.183.28]:48816)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <thuth@redhat.com>) id 1ds8fU-00023w-AH\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 10:29:32 -0400","from smtp.corp.redhat.com\n\t(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 4C50F13A4C;\n\tWed, 13 Sep 2017 14:29:31 +0000 (UTC)","from [10.36.116.123] (ovpn-116-123.ams2.redhat.com [10.36.116.123])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 34D8B17D17;\n\tWed, 13 Sep 2017 14:29:25 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 4C50F13A4C","To":"David Hildenbrand <david@redhat.com>, qemu-devel@nongnu.org","References":"<20170913132417.24384-1-david@redhat.com>\n\t<20170913132417.24384-9-david@redhat.com>","From":"Thomas Huth <thuth@redhat.com>","Message-ID":"<fb0909ad-19bb-3a92-27c6-652bf4d32277@redhat.com>","Date":"Wed, 13 Sep 2017 16:29:23 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170913132417.24384-9-david@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.14","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.29]);\n\tWed, 13 Sep 2017 14:29:31 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v5 08/22] s390x: move sclp_service_call()\n\tto sclp.h","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<http://lists.nongnu.org/archive/html/qemu-devel/>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Cc":"Matthew Rosato <mjrosato@linux.vnet.ibm.com>,\n\tEduardo Habkost <ehabkost@redhat.com>, cohuck@redhat.com,\n\tRichard Henderson <richard.henderson@linaro.org>,\n\tAlexander Graf <agraf@suse.de>,\n\tMarkus Armbruster <armbru@redhat.com>, borntraeger@de.ibm.com,\n\tIgor Mammedov <imammedo@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>"}},{"id":1767940,"web_url":"http://patchwork.ozlabs.org/comment/1767940/","msgid":"<d1c205de-5abe-0848-157a-41d25e16de57@redhat.com>","list_archive_url":null,"date":"2017-09-13T14:42:20","subject":"Re: [Qemu-devel] [PATCH v5 08/22] s390x: move sclp_service_call()\n\tto sclp.h","submitter":{"id":70402,"url":"http://patchwork.ozlabs.org/api/people/70402/","name":"David Hildenbrand","email":"david@redhat.com"},"content":"On 13.09.2017 16:29, Thomas Huth wrote:\n> On 13.09.2017 15:24, David Hildenbrand wrote:\n>> Implemented in sclp.c, so let's move it to the right include file.\n>> Fix up one include. Do a forward declaration of struct CPUS390XState to\n>> fix the two sclp consoles complaining.\n> \n> Is that sentence about the forward declaration still valid? I did not\n> see that anymore here...\n\nNope, a leftover. Conny, can you fix this up if I don't have to resend?\n\nThanks!\n\n> \n> Apart from that:\n> \n> Reviewed-by: Thomas Huth <thuth@redhat.com>\n> \n>","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)","ext-mx04.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx04.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=david@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xskt931WFz9sNr\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 14 Sep 2017 00:43:12 +1000 (AEST)","from localhost ([::1]:42914 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1ds8sf-0005BY-TR\n\tfor incoming@patchwork.ozlabs.org; Wed, 13 Sep 2017 10:43:09 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:44071)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <david@redhat.com>) id 1ds8s1-00051l-La\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 10:42:35 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <david@redhat.com>) id 1ds8s0-0002hT-HS\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 10:42:29 -0400","from mx1.redhat.com ([209.132.183.28]:38830)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <david@redhat.com>) id 1ds8s0-0002g9-Ad\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 10:42:28 -0400","from smtp.corp.redhat.com\n\t(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 82CFF69067;\n\tWed, 13 Sep 2017 14:42:26 +0000 (UTC)","from [10.36.116.230] (ovpn-116-230.ams2.redhat.com [10.36.116.230])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 627E3612A7;\n\tWed, 13 Sep 2017 14:42:22 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 82CFF69067","To":"Thomas Huth <thuth@redhat.com>, qemu-devel@nongnu.org","References":"<20170913132417.24384-1-david@redhat.com>\n\t<20170913132417.24384-9-david@redhat.com>\n\t<fb0909ad-19bb-3a92-27c6-652bf4d32277@redhat.com>","From":"David Hildenbrand <david@redhat.com>","Organization":"Red Hat GmbH","Message-ID":"<d1c205de-5abe-0848-157a-41d25e16de57@redhat.com>","Date":"Wed, 13 Sep 2017 16:42:20 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<fb0909ad-19bb-3a92-27c6-652bf4d32277@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.14","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.28]);\n\tWed, 13 Sep 2017 14:42:26 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v5 08/22] s390x: move sclp_service_call()\n\tto sclp.h","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<http://lists.nongnu.org/archive/html/qemu-devel/>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Cc":"Matthew Rosato <mjrosato@linux.vnet.ibm.com>,\n\tEduardo Habkost <ehabkost@redhat.com>, cohuck@redhat.com,\n\tRichard Henderson <richard.henderson@linaro.org>,\n\tAlexander Graf <agraf@suse.de>,\n\tMarkus Armbruster <armbru@redhat.com>, borntraeger@de.ibm.com,\n\tIgor Mammedov <imammedo@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>"}},{"id":1767966,"web_url":"http://patchwork.ozlabs.org/comment/1767966/","msgid":"<20170913172115.1b7fb95d.cohuck@redhat.com>","list_archive_url":null,"date":"2017-09-13T15:21:15","subject":"Re: [Qemu-devel] [PATCH v5 08/22] s390x: move sclp_service_call()\n\tto sclp.h","submitter":{"id":71914,"url":"http://patchwork.ozlabs.org/api/people/71914/","name":"Cornelia Huck","email":"cohuck@redhat.com"},"content":"On Wed, 13 Sep 2017 16:29:23 +0200\nThomas Huth <thuth@redhat.com> wrote:\n\n> On 13.09.2017 15:24, David Hildenbrand wrote:\n> > Implemented in sclp.c, so let's move it to the right include file.\n> > Fix up one include. Do a forward declaration of struct CPUS390XState to\n> > fix the two sclp consoles complaining.  \n> \n> Is that sentence about the forward declaration still valid? I did not\n> see that anymore here...\n\nIndeed. I can fix this up to:\n\n\"Implemented in sclp.c, so let's move it to the right include file.\nAlso adjust some includes.\"\n\n?\n\n> \n> Apart from that:\n> \n> Reviewed-by: Thomas Huth <thuth@redhat.com>","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)","ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=cohuck@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xslkp5fPvz9s7g\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 14 Sep 2017 01:21:53 +1000 (AEST)","from localhost ([::1]:43046 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1ds9U6-0001pf-4C\n\tfor incoming@patchwork.ozlabs.org; Wed, 13 Sep 2017 11:21:50 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:58833)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <cohuck@redhat.com>) id 1ds9Tj-0001pT-6t\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 11:21:31 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <cohuck@redhat.com>) id 1ds9Tg-0006Dp-33\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 11:21:27 -0400","from mx1.redhat.com ([209.132.183.28]:50858)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <cohuck@redhat.com>) id 1ds9Tf-0006Cx-TR\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 11:21:24 -0400","from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 7A139C04B924;\n\tWed, 13 Sep 2017 15:21:22 +0000 (UTC)","from gondolin (ovpn-117-3.ams2.redhat.com [10.36.117.3])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 5A94C5C47C;\n\tWed, 13 Sep 2017 15:21:17 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 7A139C04B924","Date":"Wed, 13 Sep 2017 17:21:15 +0200","From":"Cornelia Huck <cohuck@redhat.com>","To":"Thomas Huth <thuth@redhat.com>","Message-ID":"<20170913172115.1b7fb95d.cohuck@redhat.com>","In-Reply-To":"<fb0909ad-19bb-3a92-27c6-652bf4d32277@redhat.com>","References":"<20170913132417.24384-1-david@redhat.com>\n\t<20170913132417.24384-9-david@redhat.com>\n\t<fb0909ad-19bb-3a92-27c6-652bf4d32277@redhat.com>","Organization":"Red Hat GmbH","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.11","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.31]);\n\tWed, 13 Sep 2017 15:21:22 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v5 08/22] s390x: move sclp_service_call()\n\tto sclp.h","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<http://lists.nongnu.org/archive/html/qemu-devel/>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Cc":"Matthew Rosato <mjrosato@linux.vnet.ibm.com>,\n\tEduardo Habkost <ehabkost@redhat.com>,\n\tDavid Hildenbrand <david@redhat.com>,\n\tMarkus Armbruster <armbru@redhat.com>,\n\tRichard Henderson <richard.henderson@linaro.org>,\n\tAlexander Graf <agraf@suse.de>, qemu-devel@nongnu.org,\n\tborntraeger@de.ibm.com, Igor Mammedov <imammedo@redhat.com>,\n\tPaolo Bonzini <pbonzini@redhat.com>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>"}},{"id":1767968,"web_url":"http://patchwork.ozlabs.org/comment/1767968/","msgid":"<42ef2f55-aced-077e-00d5-35b444fd5653@redhat.com>","list_archive_url":null,"date":"2017-09-13T15:23:33","subject":"Re: [Qemu-devel] [PATCH v5 08/22] s390x: move sclp_service_call()\n\tto sclp.h","submitter":{"id":70402,"url":"http://patchwork.ozlabs.org/api/people/70402/","name":"David Hildenbrand","email":"david@redhat.com"},"content":"On 13.09.2017 17:21, Cornelia Huck wrote:\n> On Wed, 13 Sep 2017 16:29:23 +0200\n> Thomas Huth <thuth@redhat.com> wrote:\n> \n>> On 13.09.2017 15:24, David Hildenbrand wrote:\n>>> Implemented in sclp.c, so let's move it to the right include file.\n>>> Fix up one include. Do a forward declaration of struct CPUS390XState to\n>>> fix the two sclp consoles complaining.  \n>>\n>> Is that sentence about the forward declaration still valid? I did not\n>> see that anymore here...\n> \n> Indeed. I can fix this up to:\n> \n> \"Implemented in sclp.c, so let's move it to the right include file.\n> Also adjust some includes.\"\n> \n> ?\n\nYou know how to use just the right words ;) Thanks!","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=david@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xslnK0LJtz9sPk\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 14 Sep 2017 01:24:05 +1000 (AEST)","from localhost ([::1]:43049 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1ds9WF-0003KR-6q\n\tfor incoming@patchwork.ozlabs.org; Wed, 13 Sep 2017 11:24:03 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:59609)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <david@redhat.com>) id 1ds9Vt-0003K7-7q\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 11:23:42 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <david@redhat.com>) id 1ds9Vq-0007WX-3i\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 11:23:41 -0400","from mx1.redhat.com ([209.132.183.28]:43616)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <david@redhat.com>) id 1ds9Vp-0007Vz-UE\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 11:23:38 -0400","from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 0B5C04A6E4;\n\tWed, 13 Sep 2017 15:23:37 +0000 (UTC)","from [10.36.116.230] (ovpn-116-230.ams2.redhat.com [10.36.116.230])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 6E1DF69FC9;\n\tWed, 13 Sep 2017 15:23:34 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 0B5C04A6E4","To":"Cornelia Huck <cohuck@redhat.com>, Thomas Huth <thuth@redhat.com>","References":"<20170913132417.24384-1-david@redhat.com>\n\t<20170913132417.24384-9-david@redhat.com>\n\t<fb0909ad-19bb-3a92-27c6-652bf4d32277@redhat.com>\n\t<20170913172115.1b7fb95d.cohuck@redhat.com>","From":"David Hildenbrand <david@redhat.com>","Organization":"Red Hat GmbH","Message-ID":"<42ef2f55-aced-077e-00d5-35b444fd5653@redhat.com>","Date":"Wed, 13 Sep 2017 17:23:33 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170913172115.1b7fb95d.cohuck@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.11","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.38]);\n\tWed, 13 Sep 2017 15:23:37 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v5 08/22] s390x: move sclp_service_call()\n\tto sclp.h","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<http://lists.nongnu.org/archive/html/qemu-devel/>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Cc":"Matthew Rosato <mjrosato@linux.vnet.ibm.com>,\n\tEduardo Habkost <ehabkost@redhat.com>,\n\tMarkus Armbruster <armbru@redhat.com>,\n\tRichard Henderson <richard.henderson@linaro.org>,\n\tqemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>,\n\tborntraeger@de.ibm.com, Igor Mammedov <imammedo@redhat.com>,\n\tPaolo Bonzini <pbonzini@redhat.com>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>"}}]