[{"id":1769759,"web_url":"http://patchwork.ozlabs.org/comment/1769759/","msgid":"","list_archive_url":null,"date":"2017-09-17T17:52:52","subject":"Re: [U-Boot] [PATCH 2/6] treewide: replace with error() with\n\tpr_err()","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"On 13 September 2017 at 05:45, Masahiro Yamada\n wrote:\n> U-Boot widely uses error() as a bit noisier variant of printf().\n>\n> This macro causes name conflict with the following line in\n> include/linux/compiler-gcc.h:\n>\n> # define __compiletime_error(message) __attribute__((error(message)))\n>\n> This prevents us from using __compiletime_error(), and makes it\n> difficult to fully sync BUILD_BUG stuff with Linux. (Notice\n> Linux's BUILD_BUG_ON_MSG is defined by using compiletime_assert().)\n>\n> Let's convert error() into now treewide-available pr_err().\n>\n> Done with the help of Coccinelle, excluing tools/ directory.\n>\n> The semantic patch I used is as follows:\n>\n> // \n> @@@@\n> -error\n> +pr_err\n> (...)\n> // \n>\n> Signed-off-by: Masahiro Yamada \n> ---\n>\n> arch/arm/mach-omap2/am33xx/board.c | 2 +-\n> arch/arm/mach-omap2/utils.c | 4 +-\n> arch/arm/mach-rockchip/rk3188-board-spl.c | 2 +-\n> arch/arm/mach-rockchip/rk3188-board.c | 2 +-\n> arch/arm/mach-rockchip/rk3368-board-spl.c | 4 +-\n> arch/arm/mach-rockchip/rk3399/sdram_rk3399.c | 2 +-\n> arch/arm/mach-socfpga/reset_manager_arria10.c | 2 +-\n> arch/arm/mach-tegra/ivc.c | 8 +--\n> arch/arm/mach-tegra/tegra124/xusb-padctl.c | 2 +-\n> arch/arm/mach-tegra/tegra186/nvtboot_mem.c | 4 +-\n> arch/arm/mach-tegra/tegra20/clock.c | 6 +-\n> arch/arm/mach-tegra/tegra210/xusb-padctl.c | 2 +-\n> arch/arm/mach-tegra/tegra30/clock.c | 6 +-\n> arch/arm/mach-tegra/xusb-padctl-common.c | 22 +++----\n> arch/x86/cpu/tangier/sdram.c | 6 +-\n> board/nvidia/jetson-tk1/jetson-tk1.c | 6 +-\n> board/samsung/common/exynos5-dt.c | 2 +-\n> board/samsung/common/misc.c | 2 +-\n> board/samsung/goni/goni.c | 4 +-\n> board/samsung/odroid/odroid.c | 12 ++--\n> cmd/fastboot.c | 2 +-\n> cmd/nvedit.c | 6 +-\n> cmd/regulator.c | 2 +-\n> cmd/thordown.c | 6 +-\n> cmd/tpm_test.c | 6 +-\n> cmd/usb_gadget_sdp.c | 4 +-\n> cmd/usb_mass_storage.c | 6 +-\n> common/dfu.c | 6 +-\n> common/fb_mmc.c | 36 +++++------\n> common/fb_nand.c | 12 ++--\n> common/spl/spl_dfu.c | 4 +-\n> common/spl/spl_sdp.c | 4 +-\n> common/update.c | 2 +-\n> disk/part_efi.c | 10 +--\n> drivers/adc/adc-uclass.c | 6 +-\n> drivers/adc/exynos-adc.c | 6 +-\n> drivers/adc/sandbox.c | 6 +-\n> drivers/ata/dwc_ahci.c | 6 +-\n> drivers/clk/clk_boston.c | 4 +-\n> drivers/clk/clk_stm32f7.c | 2 +-\n> drivers/clk/rockchip/clk_rk3368.c | 8 +--\n> drivers/clk/rockchip/clk_rk3399.c | 6 +-\n> drivers/clk/rockchip/clk_rv1108.c | 2 +-\n> drivers/dfu/dfu.c | 14 ++--\n> drivers/dfu/dfu_mmc.c | 18 +++---\n> drivers/dfu/dfu_ram.c | 8 +--\n> drivers/dfu/dfu_tftp.c | 4 +-\n> drivers/dma/dma-uclass.c | 2 +-\n> drivers/dma/lpc32xx_dma.c | 8 +--\n> drivers/dma/ti-edma3.c | 2 +-\n> drivers/i2c/i2c-gpio.c | 2 +-\n> drivers/i2c/omap24xx_i2c.c | 2 +-\n> drivers/i2c/stm32f7_i2c.c | 16 ++---\n> drivers/i2c/tegra_i2c.c | 4 +-\n> drivers/misc/tegra186_bpmp.c | 28 ++++----\n> drivers/mmc/exynos_dw_mmc.c | 2 +-\n> drivers/mmc/hi6220_dw_mmc.c | 2 +-\n> drivers/mmc/xenon_sdhci.c | 4 +-\n> drivers/mtd/nand/lpc32xx_nand_mlc.c | 6 +-\n> drivers/mtd/nand/pxa3xx_nand.c | 2 +-\n> drivers/net/bcm-sf2-eth-gmac.c | 14 ++--\n> drivers/net/bcm-sf2-eth.c | 18 +++---\n> drivers/net/cpsw-common.c | 8 +--\n> drivers/net/cpsw.c | 8 +--\n> drivers/net/dwc_eth_qos.c | 92 +++++++++++++--------------\n> drivers/net/ep93xx_eth.c | 16 ++---\n> drivers/net/keystone_net.c | 14 ++--\n> drivers/pci/pci_tegra.c | 50 +++++++--------\n> drivers/pci/pcie_xilinx.c | 2 +-\n> drivers/phy/marvell/comphy_cp110.c | 40 ++++++------\n> drivers/phy/ti-pipe3-phy.c | 12 ++--\n> drivers/pinctrl/mvebu/pinctrl-armada-37xx.c | 2 +-\n> drivers/pinctrl/pinctrl-sti.c | 14 ++--\n> drivers/pinctrl/pinctrl_stm32.c | 2 +-\n> drivers/power/pmic/as3722.c | 12 ++--\n> drivers/power/pmic/as3722_gpio.c | 10 +--\n> drivers/power/pmic/i2c_pmic_emul.c | 6 +-\n> drivers/power/pmic/lp873x.c | 4 +-\n> drivers/power/pmic/lp87565.c | 4 +-\n> drivers/power/pmic/max77686.c | 4 +-\n> drivers/power/pmic/max8997.c | 4 +-\n> drivers/power/pmic/max8998.c | 4 +-\n> drivers/power/pmic/palmas.c | 4 +-\n> drivers/power/pmic/pfuze100.c | 4 +-\n> drivers/power/pmic/s2mps11.c | 4 +-\n> drivers/power/pmic/s5m8767.c | 4 +-\n> drivers/power/pmic/sandbox.c | 6 +-\n> drivers/power/pmic/tps65090.c | 4 +-\n> drivers/power/regulator/fixed.c | 2 +-\n> drivers/power/regulator/gpio-regulator.c | 2 +-\n> drivers/power/regulator/max77686.c | 20 +++---\n> drivers/power/regulator/sandbox.c | 18 +++---\n> drivers/ram/rockchip/dmc-rk3368.c | 14 ++--\n> drivers/ram/stm32_sdram.c | 8 +--\n> drivers/reset/sti-reset.c | 10 +--\n> drivers/spi/atmel_spi.c | 2 +-\n> drivers/spi/lpc32xx_ssp.c | 6 +-\n> drivers/sysreset/sysreset_sti.c | 6 +-\n> drivers/sysreset/sysreset_syscon.c | 4 +-\n> drivers/sysreset/sysreset_watchdog.c | 2 +-\n> drivers/tpm/tpm_tis_infineon.c | 2 +-\n> drivers/usb/common/common.c | 2 +-\n> drivers/usb/eth/mcs7830.c | 12 ++--\n> drivers/usb/gadget/at91_udc.c | 4 +-\n> drivers/usb/gadget/atmel_usba_udc.c | 6 +-\n> drivers/usb/gadget/dwc2_udc_otg.c | 2 +-\n> drivers/usb/gadget/ether.c | 42 ++++++------\n> drivers/usb/gadget/f_fastboot.c | 10 +--\n> drivers/usb/gadget/f_sdp.c | 16 ++---\n> drivers/usb/gadget/f_thor.c | 26 ++++----\n> drivers/usb/host/dwc2.c | 2 +-\n> drivers/usb/host/ehci-generic.c | 18 +++---\n> drivers/usb/host/ohci-generic.c | 18 +++---\n> drivers/usb/host/xhci-dwc3.c | 6 +-\n> drivers/usb/host/xhci-rockchip.c | 12 ++--\n> drivers/usb/musb-new/ti-musb.c | 12 ++--\n> drivers/video/am335x-fb.c | 2 +-\n> env/common.c | 8 +--\n> env/sf.c | 2 +-\n> fs/jffs2/jffs2_nand_1pass.c | 2 +-\n> fs/yaffs2/yaffs_uboot_glue.c | 2 +-\n> 121 files changed, 521 insertions(+), 521 deletions(-)\n\nReviewed-by: Simon Glass ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=google.com header.i=@google.com\n\theader.b=\"pN0Kk8pe\"; \n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"apErdT3H\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xwHgk3TK0z9sBZ\n\tfor ;\n\tMon, 18 Sep 2017 04:28:00 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 99C71C21D65; Sun, 17 Sep 2017 18:27:58 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 39D79C21DCE;\n\tSun, 17 Sep 2017 17:54:32 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 01F8DC21D92; Sun, 17 Sep 2017 17:54:30 +0000 (UTC)","from mail-qk0-f178.google.com (mail-qk0-f178.google.com\n\t[209.85.220.178])\n\tby lists.denx.de (Postfix) with ESMTPS id 471DBC21C26\n\tfor ; Sun, 17 Sep 2017 17:53:15 +0000 (UTC)","by mail-qk0-f178.google.com with SMTP id c69so5576754qke.8\n\tfor ; Sun, 17 Sep 2017 10:53:15 -0700 (PDT)","by 10.200.37.200 with HTTP; Sun, 17 Sep 2017 10:52:52 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE,\n\tRCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID autolearn=unavailable\n\tautolearn_force=no version=3.4.0","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=20161025; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=r+PMamR6ZiMmmKDCOzbvEF/I7plSHJBGoFe0DSiLVn4=;\n\tb=pN0Kk8pegfpCnAhVRmxzjPBAyn8+mXOqYwoiniN3dxcN5WAJkiG8Xv25yujUvn3PkC\n\teHagWzg0rH4203/PoMZ2qmiqTk7E1dB0C+64sG73Sj9inbpQ07qstiwyz4/OwIy/wUam\n\tCOfgTSZt6x6+k1Ed3g4269sVuSVcxPH6QCoZQumtY6gGkKdvNQwVHYJWKNGLj0Zv81fX\n\tKcVa9eZE48q3IjbMS+yj/cGce/wdyDzi9VkyMDAyhVwpkztWqskZEDoR2tn9CPFr2UGe\n\tNHmDY9epV9AOFp5LvbcjzOJhxtqbl4Dv7X+D2w5vZ+3xw5hcBL1YANWZzRHrTj/dwG/d\n\tiGXA==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=r+PMamR6ZiMmmKDCOzbvEF/I7plSHJBGoFe0DSiLVn4=;\n\tb=apErdT3HG6ZBcCex7cvnaTNNAR4QjId8aALLjWqX4Q5TsRrnfn0QqhjBFpU5XX5wym\n\tl0YFBTWPwE9TXFQjfyA7vIWLffvcXTtLw6yU68PVNZIB8L87McDnEtcdYfbl+ilOoVBC\n\t5nAEiErkdf6xP8id25yUY7KFEumH6Acs35B3U="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:sender:in-reply-to:references:from\n\t:date:message-id:subject:to:cc;\n\tbh=r+PMamR6ZiMmmKDCOzbvEF/I7plSHJBGoFe0DSiLVn4=;\n\tb=ZMFeuMVJOfa0zKx3YIXqBIlne7BBQNUqC0A0V5swhAbES/BxZWP63PjfncdVFZfO2R\n\tJEZbpwKeHeTJX2XXfyN9CysTrcqdGm0xl8+/zGzx/lUNEsVwh+i7d9/afPf3+H8uoF7J\n\t7ncUgtZBPLPNqW8poVFrgz34GneyBU84Q8e5TQ0AYEJhC+ztAmoauVlwGJpoXXM7//XK\n\tblq2XDa+jZwhA03te4xoho0hdln3s+9H1sgaPyLUHKmguBLVsbDoar/4Tt5GNa4omUKR\n\tNpfIICGk+6r0R74VAPwxMAhiOSHSjR2R1kmt77e/CflzDR/qpMy+yWISBzukyyGB/YMF\n\tyawg==","X-Gm-Message-State":"AHPjjUhJe2Z1Lem8W8wPpq2ucv2LbVqwHVwYIAL1o1NqSBlulZ9g/qCg\n\tAgV0DgIbDCh3EpTXiIs3vBHSYJ5VDZQZaz1InAYQPg==","X-Google-Smtp-Source":"AOwi7QDAEV9HFc3Ac3sy0QoOu5NfmgEEa4o3lBJyE0Ylw4N5HUWXz4s0nxaaEnybJYQpxNJdyppeyM+A+KLAd+qkhBE=","X-Received":"by 10.55.76.205 with SMTP id z196mr7196400qka.252.1505670793819; \n\tSun, 17 Sep 2017 10:53:13 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<1505303106-9780-3-git-send-email-yamada.masahiro@socionext.com>","References":"<1505303106-9780-1-git-send-email-yamada.masahiro@socionext.com>\n\t<1505303106-9780-3-git-send-email-yamada.masahiro@socionext.com>","From":"Simon Glass ","Date":"Sun, 17 Sep 2017 11:52:52 -0600","X-Google-Sender-Auth":"jJqu5fDNQSKz9VNPJq7-K4AkZhw","Message-ID":"","To":"Masahiro Yamada ","Cc":"Marek Vasut , Albert Aribaud , \n\tStephen Warren ,\n\tJoe Hershberger , \n\tRobert Baldyga , Scott Wood ,\n\tU-Boot Mailing List ,\n\tTom Warren , Jagan Teki ","Subject":"Re: [U-Boot] [PATCH 2/6] treewide: replace with error() with\n\tpr_err()","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}}]