[{"id":1767805,"web_url":"http://patchwork.ozlabs.org/comment/1767805/","msgid":"<20170913114231.GD3067@redhat.com>","list_archive_url":null,"date":"2017-09-13T11:42:31","subject":"Re: [Qemu-devel] [PATCH v8 16/20] migration: Create thread\n\tinfrastructure for multifd recv side","submitter":{"id":2694,"url":"http://patchwork.ozlabs.org/api/people/2694/","name":"Daniel P. Berrangé","email":"berrange@redhat.com"},"content":"On Wed, Sep 13, 2017 at 12:59:49PM +0200, Juan Quintela wrote:\n> We make the locking and the transfer of information specific, even if we\n> are still receiving things through the main thread.\n> \n> Signed-off-by: Juan Quintela \n> \n> --\n> \n> We split when we create the main channel and where we start the main\n> migration thread, so we wait for the creation of the other threads.\n> \n> Use multifd_clear_pages().\n> Don't remove object_unref()\n> ---\n> migration/migration.c | 7 ++++---\n> migration/migration.h | 1 +\n> migration/ram.c | 55 +++++++++++++++++++++++++++++++++++++++++++++++----\n> migration/socket.c | 2 +-\n> 4 files changed, 57 insertions(+), 8 deletions(-)\n> \n\n> diff --git a/migration/socket.c b/migration/socket.c\n> index 22fb05edc8..63dedb22e8 100644\n> --- a/migration/socket.c\n> +++ b/migration/socket.c\n> @@ -180,12 +180,12 @@ static gboolean socket_accept_incoming_migration(QIOChannel *ioc,\n> \n> qio_channel_set_name(QIO_CHANNEL(sioc), \"migration-socket-incoming\");\n> migration_channel_process_incoming(QIO_CHANNEL(sioc));\n> - object_unref(OBJECT(sioc));\n\nAs before - this creates a reference leak. migration_channel_process_incoming\nwill acquire its own reference on 'sioc', so we must drop the reference that\nthis function owns.\n\nRegards,\nDaniel","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=berrange@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xsftL61D2z9sNw\n\tfor ;\n\tWed, 13 Sep 2017 21:43:04 +1000 (AEST)","from localhost ([::1]:41724 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1ds64M-00029H-8c\n\tfor incoming@patchwork.ozlabs.org; Wed, 13 Sep 2017 07:43:02 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:38228)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1ds644-00028p-31\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 07:42:45 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1ds640-000729-1a\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 07:42:44 -0400","from mx1.redhat.com ([209.132.183.28]:14904)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1ds63z-00071B-Sf\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 07:42:39 -0400","from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id C036F81E14\n\tfor ; Wed, 13 Sep 2017 11:42:38 +0000 (UTC)","from redhat.com (unknown [10.33.36.24])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 8A2BC60461;\n\tWed, 13 Sep 2017 11:42:34 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com C036F81E14","Date":"Wed, 13 Sep 2017 12:42:31 +0100","From":"\"Daniel P. Berrange\" ","To":"Juan Quintela ","Message-ID":"<20170913114231.GD3067@redhat.com>","References":"<20170913105953.13760-1-quintela@redhat.com>\n\t<20170913105953.13760-17-quintela@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20170913105953.13760-17-quintela@redhat.com>","User-Agent":"Mutt/1.8.3 (2017-05-23)","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.11","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.25]);\n\tWed, 13 Sep 2017 11:42:38 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v8 16/20] migration: Create thread\n\tinfrastructure for multifd recv side","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"\"Daniel P. Berrange\" ","Cc":"lvivier@redhat.com, qemu-devel@nongnu.org, peterx@redhat.com,\n\tdgilbert@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]