[{"id":1768134,"web_url":"http://patchwork.ozlabs.org/comment/1768134/","msgid":"","list_archive_url":null,"date":"2017-09-13T20:19:04","subject":"Re: [PATCH 4/4] Do not wrap expf and exp2f","submitter":{"id":4349,"url":"http://patchwork.ozlabs.org/api/people/4349/","name":"Joseph Myers","email":"joseph@codesourcery.com"},"content":"On Wed, 13 Sep 2017, Szabolcs Nagy wrote:\n\n> \t* sysdeps/x86_64/fpu/w_expf.c: New file.\n\nI don't think having w_expf.c alongside w_expf.S in the same directory \nmakes sense. (An IFUNC w_expf.c in the multiarch subdirectory, used to \nbuild both fma and non-fma versions and replacing the existing \ne_expf-fma.S, may well make sense if benchmarks show improvements on the \nfma and non-fma .S files.)","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-84577-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"rOtXykRg\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xstL267rbz9s78\n\tfor ;\n\tThu, 14 Sep 2017 06:19:22 +1000 (AEST)","(qmail 58701 invoked by alias); 13 Sep 2017 20:19:15 -0000","(qmail 57893 invoked by uid 89); 13 Sep 2017 20:19:14 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:date:from:to:cc:subject:in-reply-to:message-id\n\t:references:mime-version:content-type; q=dns; s=default; b=O3YzT\n\tS5XX6QwnQ9oRoCOY93MeW5L3C2LMRih59gi38jP1KQKFD7WdnWwWK93bNGwyRZ/W\n\te/w6zbOfyVFZm1H5jDHncJ9n0t0UN/LP3ZC1kSlxTM4zsjy0klSOVwjAPrkguRs2\n\tyZV7qghp6U/IF0HLtOdiEL9i8nu8tDF1rpXACQ=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:date:from:to:cc:subject:in-reply-to:message-id\n\t:references:mime-version:content-type; s=default; bh=psSoPW/Dmed\n\t694r4PpWpPm22UaI=; b=rOtXykRgxX1biZUDvPr3jjTtAzNOyS3p4QY/ZJ/fFQW\n\tpf4TQAFrT8b9By5wVx/GZ2B5k1rmy+CgxYy4yyHQdf9JtMETE75pkue6HZDfadb+\n\tcXgvzELGUhXmZd4vonEhtc++NHByKr38sM/1qZJq2NmF13r8KxHKi3cRt+AerPLM\n\t=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Subscribe":"","List-Archive":"","List-Post":"","List-Help":",\n\t","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-2.0 required=5.0 tests=AWL, BAYES_00,\n\tRCVD_IN_DNSWL_NONE, SPF_PASS,\n\tURIBL_RED autolearn=ham version=3.3.2 spammy=alongside","X-HELO":"relay1.mentorg.com","Date":"Wed, 13 Sep 2017 20:19:04 +0000","From":"Joseph Myers ","To":"Szabolcs Nagy ","CC":"GNU C Library , ","Subject":"Re: [PATCH 4/4] Do not wrap expf and exp2f","In-Reply-To":"<59B90D0F.1000207@arm.com>","Message-ID":"","References":"<59B90BDF.7000503@arm.com> <59B90D0F.1000207@arm.com>","User-Agent":"Alpine 2.20 (DEB 67 2015-01-07)","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"US-ASCII\"","X-ClientProxiedBy":"svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) To\n\tsvr-ies-mbx-01.mgc.mentorg.com (139.181.222.1)"}},{"id":1768256,"web_url":"http://patchwork.ozlabs.org/comment/1768256/","msgid":"","list_archive_url":null,"date":"2017-09-14T00:31:18","subject":"Re: Re: [PATCH 4/4] Do not wrap expf and exp2f","submitter":{"id":51,"url":"http://patchwork.ozlabs.org/api/people/51/","name":"Arjan van de Ven","email":"arjan@linux.intel.com"},"content":"On 9/13/2017 1:19 PM, Joseph Myers wrote:\n> On Wed, 13 Sep 2017, Szabolcs Nagy wrote:\n> \n>> \t* sysdeps/x86_64/fpu/w_expf.c: New file.\n> \n> I don't think having w_expf.c alongside w_expf.S in the same directory\n> makes sense. (An IFUNC w_expf.c in the multiarch subdirectory, used to\n> build both fma and non-fma versions and replacing the existing\n> e_expf-fma.S, may well make sense if benchmarks show improvements on the\n> fma and non-fma .S files.)\n\nfwiw I am assuming we'll retire the x86-64 .S files and use the C version\n(for both FMA and non-FMA with some IFUNC selector) once this lands.\nOptimizing the .S file was fun for FMA, but the C version has a smaller\npolynomial and is faster ... data speaks and this wins.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-84583-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"Lq9Ysj69\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xszx33znhz9t38\n\tfor ;\n\tThu, 14 Sep 2017 10:31:35 +1000 (AEST)","(qmail 118307 invoked by alias); 14 Sep 2017 00:31:27 -0000","(qmail 118047 invoked by uid 89); 14 Sep 2017 00:31:27 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:subject:to:cc:references:from:message-id:date\n\t:mime-version:in-reply-to:content-type\n\t:content-transfer-encoding; q=dns; s=default; b=CTRV5AT4Sy/6bS8N\n\t5Gy1f0bpyt7Ynl8QyWgyH+5jZoSflqe6wKlLonCIg2H1rDM1TkCyolMbMEk+MfMk\n\tzqYTjsI2ZeJzIfgIOcFhhI3WVqmAMuVWkIC6UpCtMVLX7/9XBOCMnCJBfIo+kp1X\n\tgyACDulI/2PjAwnwhxJUdglo1DM=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:subject:to:cc:references:from:message-id:date\n\t:mime-version:in-reply-to:content-type\n\t:content-transfer-encoding; s=default; bh=sjzo7xYUHjEchY8H8DcElF\n\tHWPmI=; b=Lq9Ysj69amA/kyKl1aNR0XlmAqKAvriYDP87gUFFw9etQKZ1rhesSt\n\tmuRohXZ+tToAiOfFYTKNoy6Qfa9GPV3gRbTRDV5FEdLJuVG9mkJQClV63kR+3qZS\n\tRq++Bxbjf8Fmz8DIW0gOXB+2ZS4kfxVbFuUUaX+D/jFoqj3BdEC6g=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Subscribe":"","List-Archive":"","List-Post":"","List-Help":",\n\t","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-0.9 required=5.0 tests=BAYES_00,\n\tKAM_LAZY_DOMAIN_SECURITY,\n\tRP_MATCHES_RCVD autolearn=no version=3.3.2 spammy=H*RU:HELO,\n\tHx-spam-relays-external:HELO","X-HELO":"mga14.intel.com","X-ExtLoop1":"1","Subject":"Re: Re: [PATCH 4/4] Do not wrap expf and exp2f","To":"Joseph Myers ,\n\tSzabolcs Nagy ","Cc":"GNU C Library , nd@arm.com","References":"","From":"Arjan van de Ven ","Message-ID":"","Date":"Wed, 13 Sep 2017 17:31:18 -0700","User-Agent":"Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Transfer-Encoding":"7bit"}}]