[{"id":1767760,"web_url":"http://patchwork.ozlabs.org/comment/1767760/","msgid":"<18B5183D-1F9D-4279-A85A-5355B709A1C6@theobroma-systems.com>","list_archive_url":null,"date":"2017-09-13T10:20:26","subject":"Re: [U-Boot] [PATCH 2/8] configs: rockchip: Enable the\n\tROCKCHIP_SARADC config","submitter":{"id":53488,"url":"http://patchwork.ozlabs.org/api/people/53488/","name":"Philipp Tomsich","email":"philipp.tomsich@theobroma-systems.com"},"content":"> On 13 Sep 2017, at 12:09, David Wu wrote:\n> \n> Except for 3036 and 3228 Socs, which don't support Saradc,\n> enable the ROCKCHIP_SARADC config at the other Socs' defconfig.\n\nPlease use an ‘imply’ in the Kconfig for the various SoCs (or possibly\neven the entire sub-architecture) or a \"default y if …”.\n\nGiven that this is a DM-enabled driver, there is no harm in compiling\nit in, even if a given board does not use it. This should make defconfig\nchanges unnecessary (unless someone really needs to override the\nimplied setting).\n\n> Signed-off-by: David Wu \n> ---\n> configs/evb-rk3288_defconfig | 2 ++\n> configs/evb-rk3328_defconfig | 2 ++\n> configs/evb-rk3399_defconfig | 2 ++\n> configs/evb-rv1108_defconfig | 2 ++\n> configs/fennec-rk3288_defconfig | 2 ++\n> configs/firefly-rk3288_defconfig | 2 ++\n> configs/firefly-rk3399_defconfig | 2 ++\n> configs/lion-rk3368_defconfig | 2 ++\n> configs/miqi-rk3288_defconfig | 2 ++\n> configs/phycore-rk3288_defconfig | 2 ++\n> configs/popmetal-rk3288_defconfig | 2 ++\n> configs/puma-rk3399_defconfig | 2 ++\n> configs/sheep-rk3368_defconfig | 2 ++\n> configs/tinker-rk3288_defconfig | 2 ++\n> 14 files changed, 28 insertions(+)\n> \n> diff --git a/configs/evb-rk3288_defconfig b/configs/evb-rk3288_defconfig\n> index 5294ba9..f09b769 100644\n> --- a/configs/evb-rk3288_defconfig\n> +++ b/configs/evb-rk3288_defconfig\n> @@ -37,6 +37,8 @@ CONFIG_REGMAP=y\n> CONFIG_SPL_REGMAP=y\n> CONFIG_SYSCON=y\n> CONFIG_SPL_SYSCON=y\n> +CONFIG_ADC=y\n> +CONFIG_SARADC_ROCKCHIP=y\n> CONFIG_CLK=y\n> CONFIG_SPL_CLK=y\n> CONFIG_ROCKCHIP_GPIO=y\n> diff --git a/configs/evb-rk3328_defconfig b/configs/evb-rk3328_defconfig\n> index 7bec001..b44b029 100644\n> --- a/configs/evb-rk3328_defconfig\n> +++ b/configs/evb-rk3328_defconfig\n> @@ -20,6 +20,8 @@ CONFIG_CMD_TIME=y\n> CONFIG_ENV_IS_IN_MMC=y\n> CONFIG_REGMAP=y\n> CONFIG_SYSCON=y\n> +CONFIG_ADC=y\n> +CONFIG_SARADC_ROCKCHIP=y\n> CONFIG_CLK=y\n> CONFIG_ROCKCHIP_GPIO=y\n> CONFIG_MMC_DW=y\n> diff --git a/configs/evb-rk3399_defconfig b/configs/evb-rk3399_defconfig\n> index 7a0bd4a..6d0d1a0 100644\n> --- a/configs/evb-rk3399_defconfig\n> +++ b/configs/evb-rk3399_defconfig\n> @@ -30,6 +30,8 @@ CONFIG_REGMAP=y\n> CONFIG_SPL_REGMAP=y\n> CONFIG_SYSCON=y\n> CONFIG_SPL_SYSCON=y\n> +CONFIG_ADC=y\n> +CONFIG_SARADC_ROCKCHIP=y\n> CONFIG_CLK=y\n> CONFIG_SPL_CLK=y\n> CONFIG_ROCKCHIP_GPIO=y\n> diff --git a/configs/evb-rv1108_defconfig b/configs/evb-rv1108_defconfig\n> index ab4276a..3278104 100644\n> --- a/configs/evb-rv1108_defconfig\n> +++ b/configs/evb-rv1108_defconfig\n> @@ -13,6 +13,8 @@ CONFIG_CMD_TIME=y\n> CONFIG_NET_RANDOM_ETHADDR=y\n> CONFIG_REGMAP=y\n> CONFIG_SYSCON=y\n> +CONFIG_ADC=y\n> +CONFIG_SARADC_ROCKCHIP=y\n> CONFIG_CLK=y\n> CONFIG_ROCKCHIP_GPIO=y\n> CONFIG_SYS_I2C_ROCKCHIP=y\n> diff --git a/configs/fennec-rk3288_defconfig b/configs/fennec-rk3288_defconfig\n> index 96a07de..913849e 100644\n> --- a/configs/fennec-rk3288_defconfig\n> +++ b/configs/fennec-rk3288_defconfig\n> @@ -40,6 +40,8 @@ CONFIG_SPL_REGMAP=y\n> CONFIG_SYSCON=y\n> CONFIG_SPL_SYSCON=y\n> # CONFIG_SPL_SIMPLE_BUS is not set\n> +CONFIG_ADC=y\n> +CONFIG_SARADC_ROCKCHIP=y\n> CONFIG_CLK=y\n> CONFIG_SPL_CLK=y\n> CONFIG_ROCKCHIP_GPIO=y\n> diff --git a/configs/firefly-rk3288_defconfig b/configs/firefly-rk3288_defconfig\n> index 82da601..75f8cdb 100644\n> --- a/configs/firefly-rk3288_defconfig\n> +++ b/configs/firefly-rk3288_defconfig\n> @@ -40,6 +40,8 @@ CONFIG_SPL_REGMAP=y\n> CONFIG_SYSCON=y\n> CONFIG_SPL_SYSCON=y\n> # CONFIG_SPL_SIMPLE_BUS is not set\n> +CONFIG_ADC=y\n> +CONFIG_SARADC_ROCKCHIP=y\n> CONFIG_CLK=y\n> CONFIG_SPL_CLK=y\n> CONFIG_ROCKCHIP_GPIO=y\n> diff --git a/configs/firefly-rk3399_defconfig b/configs/firefly-rk3399_defconfig\n> index 94b9209..e9e4324 100644\n> --- a/configs/firefly-rk3399_defconfig\n> +++ b/configs/firefly-rk3399_defconfig\n> @@ -30,6 +30,8 @@ CONFIG_REGMAP=y\n> CONFIG_SPL_REGMAP=y\n> CONFIG_SYSCON=y\n> CONFIG_SPL_SYSCON=y\n> +CONFIG_ADC=y\n> +CONFIG_SARADC_ROCKCHIP=y\n> CONFIG_CLK=y\n> CONFIG_SPL_CLK=y\n> CONFIG_ROCKCHIP_GPIO=y\n> diff --git a/configs/lion-rk3368_defconfig b/configs/lion-rk3368_defconfig\n> index 45a12a8..5ef6d4b 100644\n> --- a/configs/lion-rk3368_defconfig\n> +++ b/configs/lion-rk3368_defconfig\n> @@ -52,6 +52,8 @@ CONFIG_TPL_REGMAP=y\n> CONFIG_SYSCON=y\n> CONFIG_SPL_SYSCON=y\n> CONFIG_TPL_SYSCON=y\n> +CONFIG_ADC=y\n> +CONFIG_SARADC_ROCKCHIP=y\n> CONFIG_CLK=y\n> CONFIG_SPL_CLK=y\n> CONFIG_TPL_CLK=y\n> diff --git a/configs/miqi-rk3288_defconfig b/configs/miqi-rk3288_defconfig\n> index b0437e1..7825467 100644\n> --- a/configs/miqi-rk3288_defconfig\n> +++ b/configs/miqi-rk3288_defconfig\n> @@ -40,6 +40,8 @@ CONFIG_SPL_REGMAP=y\n> CONFIG_SYSCON=y\n> CONFIG_SPL_SYSCON=y\n> # CONFIG_SPL_SIMPLE_BUS is not set\n> +CONFIG_ADC=y\n> +CONFIG_SARADC_ROCKCHIP=y\n> CONFIG_CLK=y\n> CONFIG_SPL_CLK=y\n> CONFIG_ROCKCHIP_GPIO=y\n> diff --git a/configs/phycore-rk3288_defconfig b/configs/phycore-rk3288_defconfig\n> index 93ee353..911600d 100644\n> --- a/configs/phycore-rk3288_defconfig\n> +++ b/configs/phycore-rk3288_defconfig\n> @@ -42,6 +42,8 @@ CONFIG_SPL_REGMAP=y\n> CONFIG_SYSCON=y\n> CONFIG_SPL_SYSCON=y\n> # CONFIG_SPL_SIMPLE_BUS is not set\n> +CONFIG_ADC=y\n> +CONFIG_SARADC_ROCKCHIP=y\n> CONFIG_CLK=y\n> CONFIG_SPL_CLK=y\n> CONFIG_ROCKCHIP_GPIO=y\n> diff --git a/configs/popmetal-rk3288_defconfig b/configs/popmetal-rk3288_defconfig\n> index 5e99f9c..9f5d78d 100644\n> --- a/configs/popmetal-rk3288_defconfig\n> +++ b/configs/popmetal-rk3288_defconfig\n> @@ -40,6 +40,8 @@ CONFIG_SPL_REGMAP=y\n> CONFIG_SYSCON=y\n> CONFIG_SPL_SYSCON=y\n> # CONFIG_SPL_SIMPLE_BUS is not set\n> +CONFIG_ADC=y\n> +CONFIG_SARADC_ROCKCHIP=y\n> CONFIG_CLK=y\n> CONFIG_SPL_CLK=y\n> CONFIG_ROCKCHIP_GPIO=y\n> diff --git a/configs/puma-rk3399_defconfig b/configs/puma-rk3399_defconfig\n> index 1badf80..7929a69 100644\n> --- a/configs/puma-rk3399_defconfig\n> +++ b/configs/puma-rk3399_defconfig\n> @@ -41,6 +41,8 @@ CONFIG_REGMAP=y\n> CONFIG_SPL_REGMAP=y\n> CONFIG_SYSCON=y\n> CONFIG_SPL_SYSCON=y\n> +CONFIG_ADC=y\n> +CONFIG_SARADC_ROCKCHIP=y\n> CONFIG_CLK=y\n> CONFIG_SPL_CLK=y\n> CONFIG_ROCKCHIP_GPIO=y\n> diff --git a/configs/sheep-rk3368_defconfig b/configs/sheep-rk3368_defconfig\n> index b862a14..d4877d3 100644\n> --- a/configs/sheep-rk3368_defconfig\n> +++ b/configs/sheep-rk3368_defconfig\n> @@ -10,6 +10,8 @@ CONFIG_ANDROID_BOOT_IMAGE=y\n> CONFIG_CMD_MMC=y\n> CONFIG_REGMAP=y\n> CONFIG_SYSCON=y\n> +CONFIG_ADC=y\n> +CONFIG_SARADC_ROCKCHIP=y\n> CONFIG_CLK=y\n> CONFIG_MMC_DW=y\n> CONFIG_MMC_DW_ROCKCHIP=y\n> diff --git a/configs/tinker-rk3288_defconfig b/configs/tinker-rk3288_defconfig\n> index 00e2d81..e7eba10 100644\n> --- a/configs/tinker-rk3288_defconfig\n> +++ b/configs/tinker-rk3288_defconfig\n> @@ -41,6 +41,8 @@ CONFIG_SPL_REGMAP=y\n> CONFIG_SYSCON=y\n> CONFIG_SPL_SYSCON=y\n> # CONFIG_SPL_SIMPLE_BUS is not set\n> +CONFIG_ADC=y\n> +CONFIG_SARADC_ROCKCHIP=y\n> CONFIG_CLK=y\n> CONFIG_SPL_CLK=y\n> CONFIG_ROCKCHIP_GPIO=y\n> -- \n> 2.7.4\n> \n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xsd3M0x9Fz9ryT\n\tfor ;\n\tWed, 13 Sep 2017 20:20:47 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid C6B4AC22614; Wed, 13 Sep 2017 10:20:42 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 2ADD2C225CB;\n\tWed, 13 Sep 2017 10:20:40 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid A6041C225CB; Wed, 13 Sep 2017 10:20:38 +0000 (UTC)","from mail.theobroma-systems.com (vegas.theobroma-systems.com\n\t[144.76.126.164])\n\tby lists.denx.de (Postfix) with ESMTPS id 6756CC225CA\n\tfor ; Wed, 13 Sep 2017 10:20:38 +0000 (UTC)","from 89-104-28-141.customer.bnet.at ([89.104.28.141]:58214\n\thelo=[192.168.2.129]) by mail.theobroma-systems.com with esmtpsa\n\t(TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80)\n\t(envelope-from )\n\tid 1ds4mR-0002A6-MG; Wed, 13 Sep 2017 12:20:27 +0200"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"*","X-Spam-Status":"No, score=1.0 required=5.0 tests=HK_NAME_DR autolearn=no\n\tautolearn_force=no version=3.4.0","Mime-Version":"1.0 (Mac OS X Mail 10.3 \\(3273\\))","From":"\"Dr. Philipp Tomsich\" ","In-Reply-To":"<1505297379-12638-3-git-send-email-david.wu@rock-chips.com>","Date":"Wed, 13 Sep 2017 12:20:26 +0200","Message-Id":"<18B5183D-1F9D-4279-A85A-5355B709A1C6@theobroma-systems.com>","References":"<1505297379-12638-1-git-send-email-david.wu@rock-chips.com>\n\t<1505297379-12638-3-git-send-email-david.wu@rock-chips.com>","To":"David Wu ","X-Mailer":"Apple Mail (2.3273)","Cc":"huangtao@rock-chips.com, u-boot@lists.denx.de, zhangqing@rock-chips.com, \n\tlinux-rockchip@lists.infradead.org, p.marczak@samsung.com,\n\tandy.yan@rock-chips.com, chenjh@rock-chips.com","Subject":"Re: [U-Boot] [PATCH 2/8] configs: rockchip: Enable the\n\tROCKCHIP_SARADC config","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}}]