[{"id":1768124,"web_url":"http://patchwork.ozlabs.org/comment/1768124/","msgid":"","list_archive_url":null,"date":"2017-09-13T20:07:39","subject":"Re: [U-Boot] [U-Boot,3/5] power: pmic: rk805: support rk805 pmic","submitter":{"id":53488,"url":"http://patchwork.ozlabs.org/api/people/53488/","name":"Philipp Tomsich","email":"philipp.tomsich@theobroma-systems.com"},"content":"> From: Elaine Zhang \n> \n> Add Rockchip pmic rk805 support.\n> \n> Signed-off-by: Elaine Zhang \n> Signed-off-by: Kever Yang \n> ---\n> \n> drivers/power/pmic/rk8xx.c | 1 +\n> drivers/power/regulator/rk8xx.c | 6 ++++++\n> include/power/rk8xx_pmic.h | 1 +\n> 3 files changed, 8 insertions(+)\n> \n\nAcked-by: Philipp Tomsich ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xstCX3bY8z9rxj\n\tfor ;\n\tThu, 14 Sep 2017 06:13:44 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 3DF99C2234B; Wed, 13 Sep 2017 20:08:49 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 2DD15C2218E;\n\tWed, 13 Sep 2017 20:08:00 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid D1729C222AA; Wed, 13 Sep 2017 20:07:46 +0000 (UTC)","from mail.theobroma-systems.com (vegas.theobroma-systems.com\n\t[144.76.126.164])\n\tby lists.denx.de (Postfix) with ESMTPS id C2C8AC22161\n\tfor ; Wed, 13 Sep 2017 20:07:42 +0000 (UTC)","from 89-104-28-141.customer.bnet.at ([89.104.28.141]:62926\n\thelo=vpn-10-11-0-14.lan) by mail.theobroma-systems.com with esmtpsa\n\t(TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80)\n\t(envelope-from )\n\tid 1dsDwh-0004RU-7D; Wed, 13 Sep 2017 22:07:39 +0200"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=0.0 required=5.0 tests=none autolearn=unavailable\n\tautolearn_force=no version=3.4.0","MIME-Version":"1.0","From":"Philipp Tomsich ","To":"Kever Yang ","In-Reply-To":"<1505297094-5273-3-git-send-email-kever.yang@rock-chips.com>","References":"<1505297094-5273-3-git-send-email-kever.yang@rock-chips.com>","Message-Id":"","Date":"Wed, 13 Sep 2017 22:07:39 +0200","Cc":"u-boot@lists.denx.de, Elaine Zhang ,\n\tJacob Chen ","Subject":"Re: [U-Boot] [U-Boot,3/5] power: pmic: rk805: support rk805 pmic","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1768140,"web_url":"http://patchwork.ozlabs.org/comment/1768140/","msgid":"","list_archive_url":null,"date":"2017-09-13T20:23:59","subject":"Re: [U-Boot] [U-Boot,3/5] power: pmic: rk805: support rk805 pmic","submitter":{"id":53488,"url":"http://patchwork.ozlabs.org/api/people/53488/","name":"Philipp Tomsich","email":"philipp.tomsich@theobroma-systems.com"},"content":"On Wed, 13 Sep 2017, Kever Yang wrote:\n\n> From: Elaine Zhang \n>\n> Add Rockchip pmic rk805 support.\n\nAgain: a bit more info would be helpful (see my review of patch 2/5 for a \nfew hints).\n\n>\n> Signed-off-by: Elaine Zhang \n> Signed-off-by: Kever Yang \n> ---\n>\n> drivers/power/pmic/rk8xx.c | 1 +\n> drivers/power/regulator/rk8xx.c | 6 ++++++\n> include/power/rk8xx_pmic.h | 1 +\n> 3 files changed, 8 insertions(+)\n>\n> diff --git a/drivers/power/pmic/rk8xx.c b/drivers/power/pmic/rk8xx.c\n> index 0fdea95..f2a2f07 100644\n> --- a/drivers/power/pmic/rk8xx.c\n> +++ b/drivers/power/pmic/rk8xx.c\n> @@ -99,6 +99,7 @@ static struct dm_pmic_ops rk8xx_ops = {\n> };\n>\n> static const struct udevice_id rk8xx_ids[] = {\n> +\t{ .compatible = \"rockchip,rk805\" },\n> \t{ .compatible = \"rockchip,rk808\" },\n> \t{ .compatible = \"rockchip,rk816\" },\n> \t{ .compatible = \"rockchip,rk818\" },\n> diff --git a/drivers/power/regulator/rk8xx.c b/drivers/power/regulator/rk8xx.c\n> index cf3566e..6d4a243 100644\n> --- a/drivers/power/regulator/rk8xx.c\n> +++ b/drivers/power/regulator/rk8xx.c\n> @@ -117,6 +117,7 @@ static const struct rk8xx_reg_info *get_buck_reg(struct udevice *pmic,\n> \tstruct rk8xx_priv *priv = dev_get_priv(pmic);\n>\n> \tswitch (priv->variant) {\n> +\tcase RK805_ID:\n> \tcase RK816_ID:\n> \t\tswitch (num) {\n> \t\tcase 0:\n\nSo the RK805 is identical to the RK816 for all practical purposes?\n\n> @@ -159,6 +160,7 @@ static int _buck_get_enable(struct udevice *pmic, int buck)\n> \tint ret = 0;\n>\n> \tswitch (priv->variant) {\n> +\tcase RK805_ID:\n> \tcase RK816_ID:\n> \t\tif (buck >= 4) {\n> \t\t\tmask = 1 << (buck - 4);\n> @@ -187,6 +189,7 @@ static int _buck_set_enable(struct udevice *pmic, int buck, bool enable)\n> \tstruct rk8xx_priv *priv = dev_get_priv(pmic);\n>\n> \tswitch (priv->variant) {\n> +\tcase RK805_ID:\n> \tcase RK816_ID:\n> \t\tif (buck >= 4) {\n> \t\t\tbuck -= 4;\n> @@ -231,6 +234,7 @@ static const struct rk8xx_reg_info *get_ldo_reg(struct udevice *pmic,\n> \tstruct rk8xx_priv *priv = dev_get_priv(pmic);\n>\n> \tswitch (priv->variant) {\n> +\tcase RK805_ID:\n> \tcase RK816_ID:\n> \t\treturn &rk816_ldo[num];\n> \tcase RK818_ID:\n> @@ -247,6 +251,7 @@ static int _ldo_get_enable(struct udevice *pmic, int ldo)\n> \tint ret = 0;\n>\n> \tswitch (priv->variant) {\n> +\tcase RK805_ID:\n> \tcase RK816_ID:\n> \t\tif (ldo >= 4) {\n> \t\t\tmask = 1 << (ldo - 4);\n> @@ -275,6 +280,7 @@ static int _ldo_set_enable(struct udevice *pmic, int ldo, bool enable)\n> \tint ret = 0;\n>\n> \tswitch (priv->variant) {\n> +\tcase RK805_ID:\n> \tcase RK816_ID:\n> \t\tif (ldo >= 4) {\n> \t\t\tldo -= 4;\n> diff --git a/include/power/rk8xx_pmic.h b/include/power/rk8xx_pmic.h\n> index 8e821c3..b1482b7 100644\n> --- a/include/power/rk8xx_pmic.h\n> +++ b/include/power/rk8xx_pmic.h\n> @@ -178,6 +178,7 @@ enum {\n> };\n>\n> enum {\n> +\tRK805_ID = 0x8050,\n> \tRK808_ID = 0x0000,\n> \tRK816_ID = 0x8160,\n> \tRK818_ID = 0x8180,\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xstRg0FNkz9s78\n\tfor ;\n\tThu, 14 Sep 2017 06:24:14 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid CE8BBC22389; Wed, 13 Sep 2017 20:24:06 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id CA99AC22168;\n\tWed, 13 Sep 2017 20:24:04 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 5FD88C21F1B; Wed, 13 Sep 2017 20:24:03 +0000 (UTC)","from mail.theobroma-systems.com (vegas.theobroma-systems.com\n\t[144.76.126.164])\n\tby lists.denx.de (Postfix) with ESMTPS id 23411C21C34\n\tfor ; Wed, 13 Sep 2017 20:24:03 +0000 (UTC)","from [86.59.122.178] (port=60363 helo=android.lan)\n\tby mail.theobroma-systems.com with esmtps\n\t(TLS1.2:RSA_AES_128_CBC_SHA1:128)\n\t(Exim 4.80) (envelope-from )\n\tid 1dsECW-0004yF-TZ; Wed, 13 Sep 2017 22:24:01 +0200","from [10.11.0.14] (helo=vpn-10-11-0-14.lan)\n\tby android.lan with esmtp (Exim 4.84_2)\n\t(envelope-from )\n\tid 1dsECW-0007hP-FV; Wed, 13 Sep 2017 22:24:00 +0200"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=0.0 required=5.0 tests=none autolearn=unavailable\n\tautolearn_force=no version=3.4.0","Date":"Wed, 13 Sep 2017 22:23:59 +0200 (CEST)","From":"Philipp Tomsich ","X-X-Sender":"ptomsich@vpn-10-11-0-14.lan","To":"Kever Yang ","In-Reply-To":"<1505297094-5273-3-git-send-email-kever.yang@rock-chips.com>","Message-ID":"","References":"<1505297094-5273-3-git-send-email-kever.yang@rock-chips.com>","User-Agent":"Alpine 2.21 (OSX 202 2017-01-01)","MIME-Version":"1.0","Cc":"u-boot@lists.denx.de, Elaine Zhang ,\n\tJacob Chen ","Subject":"Re: [U-Boot] [U-Boot,3/5] power: pmic: rk805: support rk805 pmic","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Transfer-Encoding":"base64","Content-Type":"text/plain; charset=\"utf-8\"; Format=\"flowed\"","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1776867,"web_url":"http://patchwork.ozlabs.org/comment/1776867/","msgid":"","list_archive_url":null,"date":"2017-09-28T08:36:05","subject":"Re: [U-Boot] [U-Boot,3/5] power: pmic: rk805: support rk805 pmic","submitter":{"id":53488,"url":"http://patchwork.ozlabs.org/api/people/53488/","name":"Philipp Tomsich","email":"philipp.tomsich@theobroma-systems.com"},"content":"> From: Elaine Zhang \n> \n> Add Rockchip pmic rk805 support.\n> \n> Signed-off-by: Elaine Zhang \n> Signed-off-by: Kever Yang \n> Acked-by: Philipp Tomsich \n> ---\n> \n> drivers/power/pmic/rk8xx.c | 1 +\n> drivers/power/regulator/rk8xx.c | 6 ++++++\n> include/power/rk8xx_pmic.h | 1 +\n> 3 files changed, 8 insertions(+)\n> \n\nReviewed-by: Philipp Tomsich ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3y2p1p2Jgrz9rxl\n\tfor ;\n\tThu, 28 Sep 2017 18:36:14 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid F37B2C21DC1; Thu, 28 Sep 2017 08:36:11 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 8E780C21D09;\n\tThu, 28 Sep 2017 08:36:09 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 1925EC21D09; Thu, 28 Sep 2017 08:36:08 +0000 (UTC)","from mail.theobroma-systems.com (vegas.theobroma-systems.com\n\t[144.76.126.164])\n\tby lists.denx.de (Postfix) with ESMTPS id BFBBDC21CB1\n\tfor ; Thu, 28 Sep 2017 08:36:07 +0000 (UTC)","from 89-104-28-141.customer.bnet.at ([89.104.28.141]:55112\n\thelo=vpn-10-11-0-14.lan) by mail.theobroma-systems.com with esmtpsa\n\t(TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80)\n\t(envelope-from )\n\tid 1dxUIf-0007i0-Qd; Thu, 28 Sep 2017 10:36:05 +0200"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=0.0 required=5.0 tests=none autolearn=unavailable\n\tautolearn_force=no version=3.4.0","MIME-Version":"1.0","From":"Philipp Tomsich ","To":"Kever Yang ","In-Reply-To":"<1505297094-5273-3-git-send-email-kever.yang@rock-chips.com>","References":"<1505297094-5273-3-git-send-email-kever.yang@rock-chips.com>","Message-Id":"","Date":"Thu, 28 Sep 2017 10:36:05 +0200","Cc":"u-boot@lists.denx.de, Elaine Zhang ,\n\tJacob Chen ","Subject":"Re: [U-Boot] [U-Boot,3/5] power: pmic: rk805: support rk805 pmic","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}}]