[{"id":1767876,"web_url":"http://patchwork.ozlabs.org/comment/1767876/","msgid":"<20170913131843.GB1981@nanopsycho>","list_archive_url":null,"date":"2017-09-13T13:18:43","subject":"Re: [RFC PATCH v3 2/7] sched: act_mirred: Traffic class option for\n\tmirror/redirect action","submitter":{"id":15321,"url":"http://patchwork.ozlabs.org/api/people/15321/","name":"Jiri Pirko","email":"jiri@resnulli.us"},"content":"Wed, Sep 13, 2017 at 11:59:24AM CEST, amritha.nambiar@intel.com wrote:\n>Adds optional traffic class parameter to the mirror/redirect action.\n>The mirror/redirect action is extended to forward to a traffic\n>class on the device if the traffic class index is provided in\n>addition to the device's ifindex.\n\nDo I understand it correctly that you just abuse mirred to pas tcclass\nindex down to the driver, without actually doing anything with the value\ninside mirred-code ? That is a bit confusing for me.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=resnulli-us.20150623.gappssmtp.com\n\theader.i=@resnulli-us.20150623.gappssmtp.com\n\theader.b=\"2KdvcD1F\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xsj0s1rCnz9s4s\n\tfor ;\n\tWed, 13 Sep 2017 23:18:53 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752325AbdIMNSu (ORCPT );\n\tWed, 13 Sep 2017 09:18:50 -0400","from mail-wm0-f48.google.com ([74.125.82.48]:45419 \"EHLO\n\tmail-wm0-f48.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1752262AbdIMNSq (ORCPT\n\t); Wed, 13 Sep 2017 09:18:46 -0400","by mail-wm0-f48.google.com with SMTP id g206so6642209wme.0\n\tfor ; Wed, 13 Sep 2017 06:18:45 -0700 (PDT)","from localhost (ip-89-177-125-82.net.upcbroadband.cz.\n\t[89.177.125.82]) by smtp.gmail.com with ESMTPSA id\n\tg132sm1147266wmd.5.2017.09.13.06.18.43\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tWed, 13 Sep 2017 06:18:43 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=resnulli-us.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=nk/8nuD+5zryVIaBcJE3eNY9fXnwdq/L8IS4g36il9g=;\n\tb=2KdvcD1F5HaK++MRnTjVjDXHWxpPWciGxM8rEtJno7VW3GAxdpaeH50DY+533JKO/8\n\tg93YPexYb8ivIJaUcvCv04sxgkNej9m4AhlXg9ulOXeBAiCwavwv1440tntKzsvulL0f\n\t5jjPPXoO9ZL0FnJvzzBLK4hih81cdx+QUV2STJymBaW15WZ202pYBRDed9KUmiNsDdoL\n\t//7QErRN+PsubzZzKAKMdp7zjCNKSPJk38QXYo746r7t9gMpGSh0p1CNcKpeVPJ6zigT\n\tcAGCHQib0pSg9OpW0MK7MhlyLylp4xqB4NkFG0rotkrJ7NF0JN4IF/d3dtobxaeQc+qz\n\tttpw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=nk/8nuD+5zryVIaBcJE3eNY9fXnwdq/L8IS4g36il9g=;\n\tb=XtOHlKfn1OPz+DPJKxl2Z5jbeiYXrwmyZQdrhiLJnWJqKZCfZybiLFFdAepCY6LHcZ\n\t52SyzBfvt8Ftoyf+gMLdKuk4O/1TJyHiYIXz6Xs3ZzBf0ok/irwtEGLoLvH7Rgakjezq\n\tCHunw/Fp0a+if/UMgXCPEpDdq3jXAP7tXXTOd4ZP9zdsHTNdouU9vO7dlVKLVEsF3KFb\n\tT/OPN2p5tRxB/uFqIWMEGt0U+Ln8F8sG91bU95cUYCr7UzCQToyn9dsDsBIBOI7LTjOH\n\t4m2WBmUaNF6hgcUQ6QoA5/b9W8dYLROhSqB9Vpn4gen9IGIajUSj3JnO01c6BkaHisT8\n\tccKA==","X-Gm-Message-State":"AHPjjUiKdEc/T+k55BNI3dBY5aOzddSZLHH40+L5ApaSghaZ3L84PKEs\n\t4QJX59gcuyUFzeyr","X-Google-Smtp-Source":"AOwi7QBwe4EuUdznP+/p2FqDqtzA1WSSn7DPtyVlAiPOqfMsnY0mVM6i4Vod6FOxak5IbEc8H6q08Q==","X-Received":"by 10.28.74.89 with SMTP id x86mr2430707wma.57.1505308725155;\n\tWed, 13 Sep 2017 06:18:45 -0700 (PDT)","Date":"Wed, 13 Sep 2017 15:18:43 +0200","From":"Jiri Pirko ","To":"Amritha Nambiar ","Cc":"intel-wired-lan@lists.osuosl.org, jeffrey.t.kirsher@intel.com,\n\talexander.h.duyck@intel.com, netdev@vger.kernel.org, mlxsw@mellanox.com","Subject":"Re: [RFC PATCH v3 2/7] sched: act_mirred: Traffic class option for\n\tmirror/redirect action","Message-ID":"<20170913131843.GB1981@nanopsycho>","References":"<150529632024.57063.15338545678487601430.stgit@anamdev.jf.intel.com>\n\t<150529676456.57063.7605464456122745976.stgit@anamdev.jf.intel.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<150529676456.57063.7605464456122745976.stgit@anamdev.jf.intel.com>","User-Agent":"Mutt/1.8.3 (2017-05-23)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1768392,"web_url":"http://patchwork.ozlabs.org/comment/1768392/","msgid":"<7bb9f703-af45-a873-d964-f9f49c869375@intel.com>","list_archive_url":null,"date":"2017-09-14T07:58:47","subject":"Re: [RFC PATCH v3 2/7] sched: act_mirred: Traffic class option for\n\tmirror/redirect action","submitter":{"id":68504,"url":"http://patchwork.ozlabs.org/api/people/68504/","name":"Nambiar, Amritha","email":"amritha.nambiar@intel.com"},"content":"On 9/13/2017 6:18 AM, Jiri Pirko wrote:\n> Wed, Sep 13, 2017 at 11:59:24AM CEST, amritha.nambiar@intel.com wrote:\n>> Adds optional traffic class parameter to the mirror/redirect action.\n>> The mirror/redirect action is extended to forward to a traffic\n>> class on the device if the traffic class index is provided in\n>> addition to the device's ifindex.\n> \n> Do I understand it correctly that you just abuse mirred to pas tcclass\n> index down to the driver, without actually doing anything with the value\n> inside mirred-code ? That is a bit confusing for me.\n> \n\nI think I get your point, I was looking at it more from a hardware\nangle, and the 'redirect' action looked quite close to how this actually\nworks in the hardware. I agree the tclass value in the mirred-code is\nnot very useful other than offloading it.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xt9sD49ySz9t1t\n\tfor ;\n\tThu, 14 Sep 2017 17:58:56 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751433AbdINH6x (ORCPT );\n\tThu, 14 Sep 2017 03:58:53 -0400","from mga07.intel.com ([134.134.136.100]:12027 \"EHLO\n\tmga07.intel.com\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751168AbdINH6w (ORCPT );\n\tThu, 14 Sep 2017 03:58:52 -0400","from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby orsmga105.jf.intel.com with ESMTP; 14 Sep 2017 00:58:52 -0700","from anambiar-mobl.amr.corp.intel.com (HELO [10.254.52.171])\n\t([10.254.52.171])\n\tby fmsmga002.fm.intel.com with ESMTP; 14 Sep 2017 00:58:47 -0700"],"X-ExtLoop1":"1","X-IronPort-AV":"E=Sophos;i=\"5.42,391,1500966000\"; d=\"scan'208\";a=\"1218649865\"","Subject":"Re: [RFC PATCH v3 2/7] sched: act_mirred: Traffic class option for\n\tmirror/redirect action","To":"Jiri Pirko ","Cc":"intel-wired-lan@lists.osuosl.org, jeffrey.t.kirsher@intel.com,\n\talexander.h.duyck@intel.com, netdev@vger.kernel.org, mlxsw@mellanox.com","References":"<150529632024.57063.15338545678487601430.stgit@anamdev.jf.intel.com>\n\t<150529676456.57063.7605464456122745976.stgit@anamdev.jf.intel.com>\n\t<20170913131843.GB1981@nanopsycho>","From":"\"Nambiar, Amritha\" ","Message-ID":"<7bb9f703-af45-a873-d964-f9f49c869375@intel.com>","Date":"Thu, 14 Sep 2017 00:58:47 -0700","User-Agent":"Mozilla/5.0 (Windows NT 6.3; WOW64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170913131843.GB1981@nanopsycho>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]