[{"id":1768060,"web_url":"http://patchwork.ozlabs.org/comment/1768060/","msgid":"<20170913131843.GB1981@nanopsycho>","list_archive_url":null,"date":"2017-09-13T13:18:43","subject":"Re: [Intel-wired-lan] [RFC PATCH v3 2/7] sched: act_mirred: Traffic\n\tclass option for mirror/redirect action","submitter":{"id":15321,"url":"http://patchwork.ozlabs.org/api/people/15321/","name":"Jiri Pirko","email":"jiri@resnulli.us"},"content":"Wed, Sep 13, 2017 at 11:59:24AM CEST, amritha.nambiar@intel.com wrote:\n>Adds optional traffic class parameter to the mirror/redirect action.\n>The mirror/redirect action is extended to forward to a traffic\n>class on the device if the traffic class index is provided in\n>addition to the device's ifindex.\n\nDo I understand it correctly that you just abuse mirred to pas tcclass\nindex down to the driver, without actually doing anything with the value\ninside mirred-code ? That is a bit confusing for me.","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.133; helo=hemlock.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=resnulli-us.20150623.gappssmtp.com\n\theader.i=@resnulli-us.20150623.gappssmtp.com\n\theader.b=\"2KdvcD1F\"; dkim-atps=neutral"],"Received":["from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xspvN3M3Yz9sNV\n\tfor ;\n\tThu, 14 Sep 2017 03:44:32 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id ECE6A89FC6;\n\tWed, 13 Sep 2017 17:44:30 +0000 (UTC)","from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id Pk3wemHJokPc; Wed, 13 Sep 2017 17:44:28 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 4969F89FBE;\n\tWed, 13 Sep 2017 17:44:28 +0000 (UTC)","from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id CE48D1BFCA2\n\tfor ;\n\tWed, 13 Sep 2017 13:18:48 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id C5D048A122\n\tfor ;\n\tWed, 13 Sep 2017 13:18:48 +0000 (UTC)","from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id yWkReDNkNrsp for ;\n\tWed, 13 Sep 2017 13:18:47 +0000 (UTC)","from mail-wm0-f53.google.com (mail-wm0-f53.google.com\n\t[74.125.82.53])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id 1B6D489F60\n\tfor ;\n\tWed, 13 Sep 2017 13:18:46 +0000 (UTC)","by mail-wm0-f53.google.com with SMTP id i189so6595756wmf.1\n\tfor ;\n\tWed, 13 Sep 2017 06:18:46 -0700 (PDT)","from localhost (ip-89-177-125-82.net.upcbroadband.cz.\n\t[89.177.125.82]) by smtp.gmail.com with ESMTPSA id\n\tg132sm1147266wmd.5.2017.09.13.06.18.43\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tWed, 13 Sep 2017 06:18:43 -0700 (PDT)"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"from auto-whitelisted by SQLgrey-1.7.6","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=resnulli-us.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=nk/8nuD+5zryVIaBcJE3eNY9fXnwdq/L8IS4g36il9g=;\n\tb=2KdvcD1F5HaK++MRnTjVjDXHWxpPWciGxM8rEtJno7VW3GAxdpaeH50DY+533JKO/8\n\tg93YPexYb8ivIJaUcvCv04sxgkNej9m4AhlXg9ulOXeBAiCwavwv1440tntKzsvulL0f\n\t5jjPPXoO9ZL0FnJvzzBLK4hih81cdx+QUV2STJymBaW15WZ202pYBRDed9KUmiNsDdoL\n\t//7QErRN+PsubzZzKAKMdp7zjCNKSPJk38QXYo746r7t9gMpGSh0p1CNcKpeVPJ6zigT\n\tcAGCHQib0pSg9OpW0MK7MhlyLylp4xqB4NkFG0rotkrJ7NF0JN4IF/d3dtobxaeQc+qz\n\tttpw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=nk/8nuD+5zryVIaBcJE3eNY9fXnwdq/L8IS4g36il9g=;\n\tb=bRQiuwQUWCeSJqYmSM/xNB5plsUTLnBksqedCWZP9m1dbLYi7FgLTI42wjQ8hY9cqA\n\t96Duw2HPJyiDfhvr/0M1/XYxk03bj/e20payOLnCTKInorIDnzMXLIvAAxAM9VIla9JM\n\tz7okW99ScFGxuUaD7noS2EGojTiaMnITcGXyh1BjOmdxl7mmgpGmIvRgebSn0C+hM5rs\n\t1TTxGJ/JFspW6/1RTMngurN2F2S28R5RhWxwKEofKU4FaNMiIK4ZSUEJZL/UJJ/KEyr5\n\t5zo2IWEl8KioIR82VKSmutyPPQQD7MFLtrk5LU/ZcYssFsqWSJylZ/LKo2wWDQqc8B8i\n\tn1aA==","X-Gm-Message-State":"AHPjjUgvqexP4NnlxO2t8jIn/RfWxSKVHb/MIALdcEDoMNbj3fWLqYyL\n\tlFY6WW5UdKL1z1rs","X-Google-Smtp-Source":"AOwi7QBwe4EuUdznP+/p2FqDqtzA1WSSn7DPtyVlAiPOqfMsnY0mVM6i4Vod6FOxak5IbEc8H6q08Q==","X-Received":"by 10.28.74.89 with SMTP id x86mr2430707wma.57.1505308725155;\n\tWed, 13 Sep 2017 06:18:45 -0700 (PDT)","Date":"Wed, 13 Sep 2017 15:18:43 +0200","From":"Jiri Pirko ","To":"Amritha Nambiar ","Message-ID":"<20170913131843.GB1981@nanopsycho>","References":"<150529632024.57063.15338545678487601430.stgit@anamdev.jf.intel.com>\n\t<150529676456.57063.7605464456122745976.stgit@anamdev.jf.intel.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<150529676456.57063.7605464456122745976.stgit@anamdev.jf.intel.com>","User-Agent":"Mutt/1.8.3 (2017-05-23)","X-Mailman-Approved-At":"Wed, 13 Sep 2017 17:44:26 +0000","Cc":"netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org,\n\tmlxsw@mellanox.com","Subject":"Re: [Intel-wired-lan] [RFC PATCH v3 2/7] sched: act_mirred: Traffic\n\tclass option for mirror/redirect action","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n\t","List-Unsubscribe":", \n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":", \n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "}},{"id":1768393,"web_url":"http://patchwork.ozlabs.org/comment/1768393/","msgid":"<7bb9f703-af45-a873-d964-f9f49c869375@intel.com>","list_archive_url":null,"date":"2017-09-14T07:58:47","subject":"Re: [Intel-wired-lan] [RFC PATCH v3 2/7] sched: act_mirred: Traffic\n\tclass option for mirror/redirect action","submitter":{"id":68504,"url":"http://patchwork.ozlabs.org/api/people/68504/","name":"Nambiar, Amritha","email":"amritha.nambiar@intel.com"},"content":"On 9/13/2017 6:18 AM, Jiri Pirko wrote:\n> Wed, Sep 13, 2017 at 11:59:24AM CEST, amritha.nambiar@intel.com wrote:\n>> Adds optional traffic class parameter to the mirror/redirect action.\n>> The mirror/redirect action is extended to forward to a traffic\n>> class on the device if the traffic class index is provided in\n>> addition to the device's ifindex.\n> \n> Do I understand it correctly that you just abuse mirred to pas tcclass\n> index down to the driver, without actually doing anything with the value\n> inside mirred-code ? That is a bit confusing for me.\n> \n\nI think I get your point, I was looking at it more from a hardware\nangle, and the 'redirect' action looked quite close to how this actually\nworks in the hardware. I agree the tclass value in the mirred-code is\nnot very useful other than offloading it.","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.136; helo=silver.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=)","Received":["from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xt9sc5Lrpz9sRm\n\tfor ;\n\tThu, 14 Sep 2017 17:59:16 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 920B330F7A;\n\tThu, 14 Sep 2017 07:59:14 +0000 (UTC)","from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id UgUzWeNX4fMb; Thu, 14 Sep 2017 07:59:13 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 5B10F30F76;\n\tThu, 14 Sep 2017 07:59:13 +0000 (UTC)","from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 0CA331C04A5\n\tfor ;\n\tThu, 14 Sep 2017 07:59:12 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 0512A30F76\n\tfor ;\n\tThu, 14 Sep 2017 07:59:12 +0000 (UTC)","from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id YG-4aGuReHlH for ;\n\tThu, 14 Sep 2017 07:59:11 +0000 (UTC)","from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby silver.osuosl.org (Postfix) with ESMTPS id 2E8FA30F75\n\tfor ;\n\tThu, 14 Sep 2017 07:59:11 +0000 (UTC)","from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t14 Sep 2017 00:58:52 -0700","from anambiar-mobl.amr.corp.intel.com (HELO [10.254.52.171])\n\t([10.254.52.171])\n\tby fmsmga002.fm.intel.com with ESMTP; 14 Sep 2017 00:58:47 -0700"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","X-ExtLoop1":"1","X-IronPort-AV":"E=Sophos; i=\"5.42,391,1500966000\"; d=\"scan'208\";\n\ta=\"1218649865\"","To":"Jiri Pirko ","References":"<150529632024.57063.15338545678487601430.stgit@anamdev.jf.intel.com>\n\t<150529676456.57063.7605464456122745976.stgit@anamdev.jf.intel.com>\n\t<20170913131843.GB1981@nanopsycho>","From":"\"Nambiar, Amritha\" ","Message-ID":"<7bb9f703-af45-a873-d964-f9f49c869375@intel.com>","Date":"Thu, 14 Sep 2017 00:58:47 -0700","User-Agent":"Mozilla/5.0 (Windows NT 6.3; WOW64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170913131843.GB1981@nanopsycho>","Content-Language":"en-US","Cc":"netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org,\n\tmlxsw@mellanox.com","Subject":"Re: [Intel-wired-lan] [RFC PATCH v3 2/7] sched: act_mirred: Traffic\n\tclass option for mirror/redirect action","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n\t","List-Unsubscribe":", \n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":", \n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "}}]