[{"id":1767809,"web_url":"http://patchwork.ozlabs.org/comment/1767809/","msgid":"<20170913114530.wrfnw72wdyyf55fz@kamzik.brq.redhat.com>","list_archive_url":null,"date":"2017-09-13T11:45:30","subject":"Re: [Qemu-devel] [PATCH v4 1/3] hw/pci-host/gpex: Set INTx\n\tindex/gsi mapping","submitter":{"id":15871,"url":"http://patchwork.ozlabs.org/api/people/15871/","name":"Andrew Jones","email":"drjones@redhat.com"},"content":"On Wed, Sep 13, 2017 at 11:46:42AM +0200, Eric Auger wrote:\n> From: Pranavkumar Sawargaonkar \n> \n> To implement INTx to gsi routing we need to pass the gpex host\n> bridge the gsi associated to each INTx index. Let's introduce\n> irq_num array and gpex_set_irq_num setter function.\n> \n> Signed-off-by: Pranavkumar Sawargaonkar \n> Signed-off-by: Tushar Jagad \n> Signed-off-by: Eric Auger \n> Tested-by: Feng Kan \n> \n> ---\n> \n> v3 -> v4:\n> - use int for gsi\n> ---\n> hw/pci-host/gpex.c | 10 ++++++++++\n> include/hw/pci-host/gpex.h | 3 +++\n> 2 files changed, 13 insertions(+)\n> \n> diff --git a/hw/pci-host/gpex.c b/hw/pci-host/gpex.c\n> index 83084b9..41a884d 100644\n> --- a/hw/pci-host/gpex.c\n> +++ b/hw/pci-host/gpex.c\n> @@ -43,6 +43,16 @@ static void gpex_set_irq(void *opaque, int irq_num, int level)\n> qemu_set_irq(s->irq[irq_num], level);\n> }\n> \n> +int gpex_set_irq_num(GPEXHost *s, int index, int gsi)\n> +{\n> + if (index >= GPEX_NUM_IRQS) {\n> + return -EINVAL;\n> + }\n> +\n> + s->irq_num[index] = gsi;\n> + return 0;\n> +}\n> +\n> static void gpex_host_realize(DeviceState *dev, Error **errp)\n> {\n> PCIHostState *pci = PCI_HOST_BRIDGE(dev);\n> diff --git a/include/hw/pci-host/gpex.h b/include/hw/pci-host/gpex.h\n> index 68c9348..aef38b8 100644\n> --- a/include/hw/pci-host/gpex.h\n> +++ b/include/hw/pci-host/gpex.h\n> @@ -51,6 +51,9 @@ typedef struct GPEXHost {\n> MemoryRegion io_ioport;\n> MemoryRegion io_mmio;\n> qemu_irq irq[GPEX_NUM_IRQS];\n> + int irq_num[GPEX_NUM_IRQS];\n> } GPEXHost;\n> \n> +int gpex_set_irq_num(GPEXHost *s, int index, int gsi);\n> +\n> #endif /* HW_GPEX_H */\n> -- \n> 2.5.5\n>\n\nReviewed-by: Andrew Jones ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=drjones@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xsfxy6PFbz9sNw\n\tfor ;\n\tWed, 13 Sep 2017 21:46:14 +1000 (AEST)","from localhost ([::1]:41750 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1ds67R-0005E5-2p\n\tfor incoming@patchwork.ozlabs.org; Wed, 13 Sep 2017 07:46:13 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:40313)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1ds674-0005CU-Ky\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 07:45:51 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1ds673-0001a7-NI\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 07:45:50 -0400","from mx1.redhat.com ([209.132.183.28]:35118)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1ds66x-0001VE-Kp; Wed, 13 Sep 2017 07:45:43 -0400","from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id CF1E4C04B924;\n\tWed, 13 Sep 2017 11:45:41 +0000 (UTC)","from kamzik.brq.redhat.com (unknown [10.43.2.160])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 6166B69A7D;\n\tWed, 13 Sep 2017 11:45:33 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com CF1E4C04B924","Date":"Wed, 13 Sep 2017 13:45:30 +0200","From":"Andrew Jones ","To":"Eric Auger ","Message-ID":"<20170913114530.wrfnw72wdyyf55fz@kamzik.brq.redhat.com>","References":"<1505296004-6798-1-git-send-email-eric.auger@redhat.com>\n\t<1505296004-6798-2-git-send-email-eric.auger@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<1505296004-6798-2-git-send-email-eric.auger@redhat.com>","User-Agent":"Mutt/1.6.0.1 (2016-04-01)","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.11","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.31]);\n\tWed, 13 Sep 2017 11:45:42 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v4 1/3] hw/pci-host/gpex: Set INTx\n\tindex/gsi mapping","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"wei@redhat.com, peter.maydell@linaro.org, qemu-devel@nongnu.org,\n\tagraf@suse.de, alex.williamson@redhat.com, qemu-arm@nongnu.org,\n\tpranavkumar@linaro.org, christoffer.dall@linaro.org,\n\teric.auger.pro@gmail.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]