[{"id":1767820,"web_url":"http://patchwork.ozlabs.org/comment/1767820/","msgid":"","list_archive_url":null,"date":"2017-09-13T12:02:10","subject":"Re: [Qemu-devel] [PATCH v2 3/3] iotests: use virtio aliases for 067","submitter":{"id":70402,"url":"http://patchwork.ozlabs.org/api/people/70402/","name":"David Hildenbrand","email":"david@redhat.com"},"content":"On 13.09.2017 11:10, Cornelia Huck wrote:\n> The default cpu model on s390x does not provide zPCI, which is\n> not yet wired up on tcg. Moreover, virtio-ccw is the standard\n> on s390x.\n> \n> Using virtio-scsi will implicitly pick the right device, so just\n> switch to that for simplicity.\n> \n> Signed-off-by: Cornelia Huck \n> ---\n> tests/qemu-iotests/067 | 3 ++-\n> tests/qemu-iotests/067.out | 2 +-\n> 2 files changed, 3 insertions(+), 2 deletions(-)\n> \n> diff --git a/tests/qemu-iotests/067 b/tests/qemu-iotests/067\n> index 5d4ca4bc61..cbb3da286a 100755\n> --- a/tests/qemu-iotests/067\n> +++ b/tests/qemu-iotests/067\n> @@ -141,7 +141,7 @@ echo\n> echo === Empty drive with -device and device_del ===\n> echo\n> \n> -run_qemu -device virtio-scsi-pci -device scsi-cd,id=cd0 < +run_qemu -device virtio-scsi -device scsi-cd,id=cd0 < { \"execute\": \"qmp_capabilities\" }\n> { \"execute\": \"query-block\" }\n> { \"execute\": \"device_del\", \"arguments\": { \"id\": \"cd0\" } }\n> @@ -150,6 +150,7 @@ run_qemu -device virtio-scsi-pci -device scsi-cd,id=cd0 < { \"execute\": \"quit\" }\n> EOF\n> \n> +\n> # success, all done\n> echo \"*** done\"\n> rm -f $seq.full\n> diff --git a/tests/qemu-iotests/067.out b/tests/qemu-iotests/067.out\n> index bd70557ddc..58e83c4505 100644\n> --- a/tests/qemu-iotests/067.out\n> +++ b/tests/qemu-iotests/067.out\n> @@ -419,7 +419,7 @@ Testing:\n> \n> === Empty drive with -device and device_del ===\n> \n> -Testing: -device virtio-scsi-pci -device scsi-cd,id=cd0\n> +Testing: -device virtio-scsi -device scsi-cd,id=cd0\n> {\n> QMP_VERSION\n> }\n> \n\nCertainly not wrong to use the old alias in some tests, as long as we\ntest both variants.\n\nReviewed-by: David Hildenbrand ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=david@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xsgL01yx3z9sNV\n\tfor ;\n\tWed, 13 Sep 2017 22:03:36 +1000 (AEST)","from localhost ([::1]:42064 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1ds6OE-0007aK-EK\n\tfor incoming@patchwork.ozlabs.org; Wed, 13 Sep 2017 08:03:34 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:50947)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1ds6Nq-0007Y9-Mk\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 08:03:14 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1ds6Nk-00038v-SC\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 08:03:10 -0400","from mx1.redhat.com ([209.132.183.28]:56806)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1ds6Nb-0002r3-Qs; Wed, 13 Sep 2017 08:02:55 -0400","from smtp.corp.redhat.com\n\t(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id CB0174A6E9;\n\tWed, 13 Sep 2017 12:02:54 +0000 (UTC)","from [10.36.116.21] (ovpn-116-21.ams2.redhat.com [10.36.116.21])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 50F535D976;\n\tWed, 13 Sep 2017 12:02:51 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com CB0174A6E9","To":"Cornelia Huck , kwolf@redhat.com, mreitz@redhat.com","References":"<20170913091038.2900-1-cohuck@redhat.com>\n\t<20170913091038.2900-4-cohuck@redhat.com>","From":"David Hildenbrand ","Organization":"Red Hat GmbH","Message-ID":"","Date":"Wed, 13 Sep 2017 14:02:10 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170913091038.2900-4-cohuck@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.14","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.38]);\n\tWed, 13 Sep 2017 12:02:54 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v2 3/3] iotests: use virtio aliases for 067","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"thuth@redhat.com, qemu-block@nongnu.org, haoqf@linux.vnet.ibm.com,\n\tqemu-devel@nongnu.org, agraf@suse.de, borntraeger@de.ibm.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]