[{"id":1767704,"web_url":"http://patchwork.ozlabs.org/comment/1767704/","msgid":"<7d703910-cd25-98fd-5382-2b8b62b10840@redhat.com>","list_archive_url":null,"date":"2017-09-13T09:18:53","subject":"Re: [Qemu-devel] [PATCH v2 2/3] iotests: use -ccw on s390x for 051","submitter":{"id":66152,"url":"http://patchwork.ozlabs.org/api/people/66152/","name":"Thomas Huth","email":"thuth@redhat.com"},"content":"On 13.09.2017 11:10, Cornelia Huck wrote:\n> The default cpu model on s390x does not provide zPCI, which is\n> not yet wired up on tcg. Moreover, virtio-ccw is the standard\n> on s390x, so use the -ccw instead of the -pci versions of virtio\n> devices on s390x.\n> \n> Signed-off-by: Cornelia Huck \n> ---\n> tests/qemu-iotests/051 | 12 +++++++++++-\n> tests/qemu-iotests/051.out | 2 +-\n> tests/qemu-iotests/051.pc.out | 2 +-\n> 3 files changed, 13 insertions(+), 3 deletions(-)\n\nReviewed-by: Thomas Huth ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx03.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx03.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=thuth@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xsbj55lP4z9sNr\n\tfor ;\n\tWed, 13 Sep 2017 19:19:53 +1000 (AEST)","from localhost ([::1]:41123 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1ds3pn-0006r0-Qy\n\tfor incoming@patchwork.ozlabs.org; Wed, 13 Sep 2017 05:19:51 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:42622)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1ds3p4-0006oE-WC\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 05:19:07 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1ds3p4-0001Pp-6O\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 05:19:06 -0400","from mx1.redhat.com ([209.132.183.28]:46198)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1ds3ox-0001Kv-NT; Wed, 13 Sep 2017 05:18:59 -0400","from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id A48AD80F95;\n\tWed, 13 Sep 2017 09:18:58 +0000 (UTC)","from [10.36.116.123] (ovpn-116-123.ams2.redhat.com [10.36.116.123])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 856C81717C;\n\tWed, 13 Sep 2017 09:18:54 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com A48AD80F95","To":"Cornelia Huck , kwolf@redhat.com, mreitz@redhat.com","References":"<20170913091038.2900-1-cohuck@redhat.com>\n\t<20170913091038.2900-3-cohuck@redhat.com>","From":"Thomas Huth ","Message-ID":"<7d703910-cd25-98fd-5382-2b8b62b10840@redhat.com>","Date":"Wed, 13 Sep 2017 11:18:53 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170913091038.2900-3-cohuck@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.16","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.27]);\n\tWed, 13 Sep 2017 09:18:58 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v2 2/3] iotests: use -ccw on s390x for 051","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-block@nongnu.org, haoqf@linux.vnet.ibm.com, david@redhat.com,\n\tqemu-devel@nongnu.org, agraf@suse.de, borntraeger@de.ibm.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1767815,"web_url":"http://patchwork.ozlabs.org/comment/1767815/","msgid":"","list_archive_url":null,"date":"2017-09-13T11:57:48","subject":"Re: [Qemu-devel] [PATCH v2 2/3] iotests: use -ccw on s390x for 051","submitter":{"id":70402,"url":"http://patchwork.ozlabs.org/api/people/70402/","name":"David Hildenbrand","email":"david@redhat.com"},"content":"On 13.09.2017 11:10, Cornelia Huck wrote:\n> The default cpu model on s390x does not provide zPCI, which is\n> not yet wired up on tcg. Moreover, virtio-ccw is the standard\n> on s390x, so use the -ccw instead of the -pci versions of virtio\n> devices on s390x.\n> \n> Signed-off-by: Cornelia Huck \n> ---\n> tests/qemu-iotests/051 | 12 +++++++++++-\n> tests/qemu-iotests/051.out | 2 +-\n> tests/qemu-iotests/051.pc.out | 2 +-\n> 3 files changed, 13 insertions(+), 3 deletions(-)\n> \n> diff --git a/tests/qemu-iotests/051 b/tests/qemu-iotests/051\n> index c8cfc764bc..dba8816c9f 100755\n> --- a/tests/qemu-iotests/051\n> +++ b/tests/qemu-iotests/051\n> @@ -103,7 +103,17 @@ echo\n> echo === Device without drive ===\n> echo\n> \n> -run_qemu -device virtio-scsi-pci -device scsi-hd\n> +case \"$QEMU_DEFAULT_MACHINE\" in\n> + s390-ccw-virtio)\n> + virtio_scsi=virtio-scsi-ccw\n> + ;;\n> + *)\n> + virtio_scsi=virtio-scsi-pci\n> + ;;\n> +esac\n> +\n> +run_qemu -device $virtio_scsi -device scsi-hd |\n> + sed -e \"s/$virtio_scsi/VIRTIO_SCSI/\"\n> \n> echo\n> echo === Overriding backing file ===\n> diff --git a/tests/qemu-iotests/051.out b/tests/qemu-iotests/051.out\n> index 4d3b1ff316..e3c6eaba57 100644\n> --- a/tests/qemu-iotests/051.out\n> +++ b/tests/qemu-iotests/051.out\n> @@ -49,7 +49,7 @@ QEMU_PROG: -drive file=TEST_DIR/t.qcow2,driver=qcow2,format=qcow2: Cannot specif\n> \n> === Device without drive ===\n> \n> -Testing: -device virtio-scsi-pci -device scsi-hd\n> +Testing: -device VIRTIO_SCSI -device scsi-hd\n> QEMU X.Y.Z monitor - type 'help' for more information\n> (qemu) QEMU_PROG: -device scsi-hd: drive property not set\n> \n> diff --git a/tests/qemu-iotests/051.pc.out b/tests/qemu-iotests/051.pc.out\n> index 76d7205460..ae7801b44b 100644\n> --- a/tests/qemu-iotests/051.pc.out\n> +++ b/tests/qemu-iotests/051.pc.out\n> @@ -49,7 +49,7 @@ QEMU_PROG: -drive file=TEST_DIR/t.qcow2,driver=qcow2,format=qcow2: Cannot specif\n> \n> === Device without drive ===\n> \n> -Testing: -device virtio-scsi-pci -device scsi-hd\n> +Testing: -device VIRTIO_SCSI -device scsi-hd\n> QEMU X.Y.Z monitor - type 'help' for more information\n> (qemu) QEMU_PROG: -device scsi-hd: drive property not set\n> \n> \n\nReviewed-by: David Hildenbrand ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=david@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xsgCw2jk1z9sNV\n\tfor ;\n\tWed, 13 Sep 2017 21:58:20 +1000 (AEST)","from localhost ([::1]:41799 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1ds6J8-0004oD-Jm\n\tfor incoming@patchwork.ozlabs.org; Wed, 13 Sep 2017 07:58:18 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:47230)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1ds6Ip-0004lf-2o\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 07:58:00 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1ds6Io-0001Ag-32\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 07:57:59 -0400","from mx1.redhat.com ([209.132.183.28]:36462)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1ds6Ii-0000zk-Mm; Wed, 13 Sep 2017 07:57:52 -0400","from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 8CD6AC047B60;\n\tWed, 13 Sep 2017 11:57:51 +0000 (UTC)","from [10.36.116.21] (ovpn-116-21.ams2.redhat.com [10.36.116.21])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 9509217558;\n\tWed, 13 Sep 2017 11:57:49 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 8CD6AC047B60","To":"Cornelia Huck , kwolf@redhat.com, mreitz@redhat.com","References":"<20170913091038.2900-1-cohuck@redhat.com>\n\t<20170913091038.2900-3-cohuck@redhat.com>","From":"David Hildenbrand ","Organization":"Red Hat GmbH","Message-ID":"","Date":"Wed, 13 Sep 2017 13:57:48 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170913091038.2900-3-cohuck@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.16","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.31]);\n\tWed, 13 Sep 2017 11:57:51 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v2 2/3] iotests: use -ccw on s390x for 051","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"thuth@redhat.com, qemu-block@nongnu.org, haoqf@linux.vnet.ibm.com,\n\tqemu-devel@nongnu.org, agraf@suse.de, borntraeger@de.ibm.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]