[{"id":1767736,"web_url":"http://patchwork.ozlabs.org/comment/1767736/","msgid":"","list_archive_url":null,"date":"2017-09-13T09:52:30","subject":"Re: [PATCH v5 7/7] dt-bindings: serial: document rs485 bindings for\n\tvarious devices","submitter":{"id":72355,"url":"http://patchwork.ozlabs.org/api/people/72355/","name":"Ian Arkver","email":"ian.arkver.dev@gmail.com"},"content":"On 13/09/17 09:18, Uwe Kleine-König wrote:\n> Atmel USART, Freescale UARTs and OMAP UART all support the rs485 binding\n> described in rs485.txt, this commit just makes that explicit.\n> \n> Acked-by: Nicolas Ferre \n> Acked-by: Rob Herring \n> Signed-off-by: Uwe Kleine-König \n> ---\n> Documentation/devicetree/bindings/serial/atmel-usart.txt | 1 +\n> Documentation/devicetree/bindings/serial/fsl-imx-uart.txt | 1 +\n> Documentation/devicetree/bindings/serial/fsl-lpuart.txt | 1 +\n> Documentation/devicetree/bindings/serial/omap_serial.txt | 1 +\n> 4 files changed, 4 insertions(+)\n> \n> diff --git a/Documentation/devicetree/bindings/serial/atmel-usart.txt b/Documentation/devicetree/bindings/serial/atmel-usart.txt\n> index e6e6142e33ac..7c0d6b2f53e4 100644\n> --- a/Documentation/devicetree/bindings/serial/atmel-usart.txt\n> +++ b/Documentation/devicetree/bindings/serial/atmel-usart.txt\n> @@ -24,6 +24,7 @@ Optional properties:\n> \t- dma-names: \"rx\" for RX channel, \"tx\" for TX channel.\n> - atmel,fifo-size: maximum number of data the RX and TX FIFOs can store for FIFO\n> capable USARTs.\n> +- rs485-rts-delay, rs485-rx-during-tx, linux,rs485-enabled-at-boot-time: see rs485.txt\n> \n> compatible description:\n> - at91rm9200: legacy USART support\n> diff --git a/Documentation/devicetree/bindings/serial/fsl-imx-uart.txt b/Documentation/devicetree/bindings/serial/fsl-imx-uart.txt\n> index 574c3a2c77d5..860a9559839a 100644\n> --- a/Documentation/devicetree/bindings/serial/fsl-imx-uart.txt\n> +++ b/Documentation/devicetree/bindings/serial/fsl-imx-uart.txt\n> @@ -9,6 +9,7 @@ Optional properties:\n> - fsl,irda-mode : Indicate the uart supports irda mode\n> - fsl,dte-mode : Indicate the uart works in DTE mode. The uart works\n> in DCE mode by default.\n> +- rs485-rts-delay, rs485-rx-during-tx, linux,rs485-enabled-at-boot-time: see rs485.txt\n\nimx.c ignores the values in delay_rts_before_send and \ndelay_rts_after_send, so maybe we shouldn't mention rs485-rts-delay here?\n\n> \n> Please check Documentation/devicetree/bindings/serial/serial.txt\n> for the complete list of generic properties.\n> diff --git a/Documentation/devicetree/bindings/serial/fsl-lpuart.txt b/Documentation/devicetree/bindings/serial/fsl-lpuart.txt\n> index a1252a047f78..59567b51cf09 100644\n> --- a/Documentation/devicetree/bindings/serial/fsl-lpuart.txt\n> +++ b/Documentation/devicetree/bindings/serial/fsl-lpuart.txt\n> @@ -16,6 +16,7 @@ Required properties:\n> Optional properties:\n> - dmas: A list of two dma specifiers, one for each entry in dma-names.\n> - dma-names: should contain \"tx\" and \"rx\".\n> +- rs485-rts-delay, rs485-rx-during-tx, linux,rs485-enabled-at-boot-time: see rs485.txt\n> \n> Note: Optional properties for DMA support. Write them both or both not.\n> \n> diff --git a/Documentation/devicetree/bindings/serial/omap_serial.txt b/Documentation/devicetree/bindings/serial/omap_serial.txt\n> index 7a71b5de77d6..43eac675f21f 100644\n> --- a/Documentation/devicetree/bindings/serial/omap_serial.txt\n> +++ b/Documentation/devicetree/bindings/serial/omap_serial.txt\n> @@ -19,6 +19,7 @@ Optional properties:\n> - dmas : DMA specifier, consisting of a phandle to the DMA controller\n> node and a DMA channel number.\n> - dma-names : \"rx\" for receive channel, \"tx\" for transmit channel.\n> +- rs485-rts-delay, rs485-rx-during-tx, linux,rs485-enabled-at-boot-time: see rs485.txt\n> \n> Example:\n> \n> \n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"Ri9pvDSg\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xscQt01Bzz9s76\n\tfor ;\n\tWed, 13 Sep 2017 19:52:37 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751654AbdIMJwf (ORCPT\n\t);\n\tWed, 13 Sep 2017 05:52:35 -0400","from mail-wr0-f194.google.com ([209.85.128.194]:33673 \"EHLO\n\tmail-wr0-f194.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751614AbdIMJwe (ORCPT\n\t); Wed, 13 Sep 2017 05:52:34 -0400","by mail-wr0-f194.google.com with SMTP id b9so7492912wra.0;\n\tWed, 13 Sep 2017 02:52:34 -0700 (PDT)","from [192.168.19.90] ([95.147.75.148])\n\tby smtp.googlemail.com with ESMTPSA id\n\t138sm768708wmf.23.2017.09.13.02.52.31\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 13 Sep 2017 02:52:32 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=BdKUbIiYq/s7eZfpYihO8lqDWbRdC9CEi32V6jSloeY=;\n\tb=Ri9pvDSg+VYUwlfpTxovEHk8qHsZyFh11gGiVNctTgk5ODZbmyZd2vJwFoCJ9ElJTm\n\tzv2hSimTNLTGWLDjYnDWXLr+Ih7J5dH3YtRq5TCYD5yp9n+I0obrSLnsV0ICGuqQkEng\n\tcyRSkgiNHP1KppnzZla4drbioXurQIatqUWYOngtHpA9RBEOBtvT0GMvx+iSX4mynOpo\n\tkvRgBar0Rkh3qPgRDhlspefaBJPCYv5ngRngtdd06FitEZNsUANDVYbXIO0LsmEUsP9K\n\t7jBD8L9yMLbiF7CllHEpSDSOZREmvlbDxLt7UNqt9bCWtluhpbMmf1cms5dtFPtzKdZa\n\tKw+A==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=BdKUbIiYq/s7eZfpYihO8lqDWbRdC9CEi32V6jSloeY=;\n\tb=PHYNdeouXioA/bLmnSKGyAeqo5qLFBhVWd4yROZLP5Ttvp0zjuQMJMvBvCO/taJBSS\n\t/CjyNGSwYqbXX2/LbF/p08NUwOcotgtGor0wqf6IgUv/N3ZTw+sNKDCt/ZHEbbMEDAjl\n\t49XmXJsQdZOisWfhDpp5qaVJ5tfSE2gFYKmxW7pOEaKJ1cwv03SwhbcJVR4avJ/KrGCp\n\tCgDmQfO/GPlOCui5fEWnBjGL8ShyUZuN8MVung6i/SIK8ERZwyxDSkfIOM06z+plfxg1\n\tmwE+Ku+sR0shTt726b+v+Gn7r6U+z90BQ/EGqO5YgLOYWstAjCcNcIRTrIaM/mN8NlSr\n\tWHJw==","X-Gm-Message-State":"AHPjjUiHEdlWheVnn/fk74pjIjFR8P5kDH3Yg2NRXTQMK+eWDZkbx2N2\n\thZS6u8qaF8ZM4wYU","X-Google-Smtp-Source":"ADKCNb5siS+xLx3edu0jXbiS9OtS1beGwBgvVReZ01PkfTi+MoTVQrb+APpQH7Ll+olapwVLkCe3vQ==","X-Received":"by 10.223.136.119 with SMTP id\n\te52mr13926760wre.225.1505296352963; \n\tWed, 13 Sep 2017 02:52:32 -0700 (PDT)","Subject":"Re: [PATCH v5 7/7] dt-bindings: serial: document rs485 bindings for\n\tvarious devices","To":"=?utf-8?q?Uwe_Kleine-K=C3=B6nig?= ,\n\tGreg Kroah-Hartman ","Cc":"linux-serial@vger.kernel.org, kernel@pengutronix.de,\n\tRob Herring ,\n\tMark Rutland , devicetree@vger.kernel.org","References":"<20170913081833.2740-1-u.kleine-koenig@pengutronix.de>\n\t<20170913081833.2740-8-u.kleine-koenig@pengutronix.de>","From":"Ian Arkver ","Message-ID":"","Date":"Wed, 13 Sep 2017 10:52:30 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170913081833.2740-8-u.kleine-koenig@pengutronix.de>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Language":"en-GB","Content-Transfer-Encoding":"8bit","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1767742,"web_url":"http://patchwork.ozlabs.org/comment/1767742/","msgid":"<20170913095428.xryd526xjyuiecab@pengutronix.de>","list_archive_url":null,"date":"2017-09-13T09:54:28","subject":"Re: [PATCH v5 7/7] dt-bindings: serial: document rs485 bindings for\n\tvarious devices","submitter":{"id":1476,"url":"http://patchwork.ozlabs.org/api/people/1476/","name":"Uwe Kleine-König","email":"u.kleine-koenig@pengutronix.de"},"content":"On Wed, Sep 13, 2017 at 10:52:30AM +0100, Ian Arkver wrote:\n> On 13/09/17 09:18, Uwe Kleine-König wrote:\n> > Atmel USART, Freescale UARTs and OMAP UART all support the rs485 binding\n> > described in rs485.txt, this commit just makes that explicit.\n> > \n> > Acked-by: Nicolas Ferre \n> > Acked-by: Rob Herring \n> > Signed-off-by: Uwe Kleine-König \n> > ---\n> > Documentation/devicetree/bindings/serial/atmel-usart.txt | 1 +\n> > Documentation/devicetree/bindings/serial/fsl-imx-uart.txt | 1 +\n> > Documentation/devicetree/bindings/serial/fsl-lpuart.txt | 1 +\n> > Documentation/devicetree/bindings/serial/omap_serial.txt | 1 +\n> > 4 files changed, 4 insertions(+)\n> > \n> > diff --git a/Documentation/devicetree/bindings/serial/atmel-usart.txt b/Documentation/devicetree/bindings/serial/atmel-usart.txt\n> > index e6e6142e33ac..7c0d6b2f53e4 100644\n> > --- a/Documentation/devicetree/bindings/serial/atmel-usart.txt\n> > +++ b/Documentation/devicetree/bindings/serial/atmel-usart.txt\n> > @@ -24,6 +24,7 @@ Optional properties:\n> > \t- dma-names: \"rx\" for RX channel, \"tx\" for TX channel.\n> > - atmel,fifo-size: maximum number of data the RX and TX FIFOs can store for FIFO\n> > capable USARTs.\n> > +- rs485-rts-delay, rs485-rx-during-tx, linux,rs485-enabled-at-boot-time: see rs485.txt\n> > compatible description:\n> > - at91rm9200: legacy USART support\n> > diff --git a/Documentation/devicetree/bindings/serial/fsl-imx-uart.txt b/Documentation/devicetree/bindings/serial/fsl-imx-uart.txt\n> > index 574c3a2c77d5..860a9559839a 100644\n> > --- a/Documentation/devicetree/bindings/serial/fsl-imx-uart.txt\n> > +++ b/Documentation/devicetree/bindings/serial/fsl-imx-uart.txt\n> > @@ -9,6 +9,7 @@ Optional properties:\n> > - fsl,irda-mode : Indicate the uart supports irda mode\n> > - fsl,dte-mode : Indicate the uart works in DTE mode. The uart works\n> > in DCE mode by default.\n> > +- rs485-rts-delay, rs485-rx-during-tx, linux,rs485-enabled-at-boot-time: see rs485.txt\n> \n> imx.c ignores the values in delay_rts_before_send and delay_rts_after_send,\n> so maybe we shouldn't mention rs485-rts-delay here?\n\nI have a patch here fixing that. Hmm, even without this implemented it\nis IMHO fine to document it here.\n\nBest regards\nUwe","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xscT70nrVz9s76\n\tfor ;\n\tWed, 13 Sep 2017 19:54:35 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751703AbdIMJye (ORCPT\n\t);\n\tWed, 13 Sep 2017 05:54:34 -0400","from metis.ext.4.pengutronix.de ([92.198.50.35]:52761 \"EHLO\n\tmetis.ext.4.pengutronix.de\" rhost-flags-OK-OK-OK-OK)\n\tby vger.kernel.org with ESMTP id S1751543AbdIMJyd (ORCPT\n\t); Wed, 13 Sep 2017 05:54:33 -0400","from [2001:67c:670:100:5054:ff:fe2a:3aa]\n\t(helo=pty.hi.pengutronix.de)\n\tby metis.ext.pengutronix.de with esmtps\n\t(TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2)\n\t(envelope-from )\n\tid 1ds4NJ-0002VI-Kw; Wed, 13 Sep 2017 11:54:29 +0200","from ukl by pty.hi.pengutronix.de with local (Exim 4.89)\n\t(envelope-from )\n\tid 1ds4NI-0007Dj-Ti; Wed, 13 Sep 2017 11:54:28 +0200"],"Date":"Wed, 13 Sep 2017 11:54:28 +0200","From":"Uwe =?iso-8859-1?q?Kleine-K=F6nig?= ","To":"Ian Arkver ","Cc":"Greg Kroah-Hartman ,\n\tlinux-serial@vger.kernel.org, kernel@pengutronix.de,\n\tRob Herring ,\n\tMark Rutland , devicetree@vger.kernel.org","Subject":"Re: [PATCH v5 7/7] dt-bindings: serial: document rs485 bindings for\n\tvarious devices","Message-ID":"<20170913095428.xryd526xjyuiecab@pengutronix.de>","References":"<20170913081833.2740-1-u.kleine-koenig@pengutronix.de>\n\t<20170913081833.2740-8-u.kleine-koenig@pengutronix.de>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"","User-Agent":"NeoMutt/20170113 (1.7.2)","X-SA-Exim-Connect-IP":"2001:67c:670:100:5054:ff:fe2a:3aa","X-SA-Exim-Mail-From":"ukl@pengutronix.de","X-SA-Exim-Scanned":"No (on metis.ext.pengutronix.de);\n\tSAEximRunCond expanded to false","X-PTX-Original-Recipient":"devicetree@vger.kernel.org","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}}]