[{"id":1776792,"web_url":"http://patchwork.ozlabs.org/comment/1776792/","msgid":"<87y3ozuy5t.fsf@linux.vnet.ibm.com>","list_archive_url":null,"date":"2017-09-28T06:37:02","subject":"Re: [Skiboot] [PATCH 2/3] hdata: Add wafer-id property","submitter":{"id":48041,"url":"http://patchwork.ozlabs.org/api/people/48041/","name":"Stewart Smith","email":"stewart@linux.vnet.ibm.com"},"content":"Vasant Hegde writes:\n> +\n> +\t/*\n> +\t * bits 4:63 of ECID data contains wafter ID data (ten 6 bit fields\n> +\t * each containing a code).\n> +\t */\n> +\tfor (i = 0; i < 10; i++) {\n> +\t\ttmp = (u8)((ecid->low >> (i * 6)) & 0x3f);\n\nThis produces the following sparse warning:\n\nhdata/spira.c:433:33: warning: restricted beint64_t degrades to integer\n\nlooks like we're missing some endian conversions?","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","skiboot@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","skiboot@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y2lNc5VwMz9t43\n\tfor ;\n\tThu, 28 Sep 2017 16:37:20 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3y2lNc2xV6zDsPv\n\tfor ;\n\tThu, 28 Sep 2017 16:37:20 +1000 (AEST)","from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com\n\t[148.163.156.1])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3y2lNT4jZKzDsPp\n\tfor ; Thu, 28 Sep 2017 16:37:12 +1000 (AEST)","from pps.filterd (m0098394.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv8S6ZdXn034541\n\tfor ; Thu, 28 Sep 2017 02:37:09 -0400","from e38.co.us.ibm.com (e38.co.us.ibm.com [32.97.110.159])\n\tby mx0a-001b2d01.pphosted.com with ESMTP id 2d8nev9fbd-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor ; Thu, 28 Sep 2017 02:37:09 -0400","from localhost\n\tby e38.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor from ;\n\tThu, 28 Sep 2017 00:37:08 -0600","from b03cxnp07029.gho.boulder.ibm.com (9.17.130.16)\n\tby e38.co.us.ibm.com (192.168.1.138) with IBM ESMTP SMTP Gateway:\n\tAuthorized Use Only! Violators will be prosecuted; \n\tThu, 28 Sep 2017 00:37:08 -0600","from b03ledav006.gho.boulder.ibm.com\n\t(b03ledav006.gho.boulder.ibm.com [9.17.130.237])\n\tby b03cxnp07029.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with\n\tESMTP id v8S6b7678978698; Wed, 27 Sep 2017 23:37:07 -0700","from b03ledav006.gho.boulder.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 7CE8CC603C;\n\tThu, 28 Sep 2017 00:37:07 -0600 (MDT)","from birb.localdomain (unknown [9.81.202.147])\n\tby b03ledav006.gho.boulder.ibm.com (Postfix) with SMTP id 9DAFDC6037; \n\tThu, 28 Sep 2017 00:37:06 -0600 (MDT)","by birb.localdomain (Postfix, from userid 1000)\n\tid D62104E87E5; Thu, 28 Sep 2017 16:37:02 +1000 (AEST)"],"Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=linux.vnet.ibm.com\n\t(client-ip=148.163.156.1; helo=mx0a-001b2d01.pphosted.com;\n\tenvelope-from=stewart@linux.vnet.ibm.com; receiver=)","From":"Stewart Smith ","To":"Vasant Hegde , skiboot@lists.ozlabs.org","In-Reply-To":"<20170913052425.23122-2-hegdevasant@linux.vnet.ibm.com>","References":"<20170913052425.23122-1-hegdevasant@linux.vnet.ibm.com>\n\t<20170913052425.23122-2-hegdevasant@linux.vnet.ibm.com>","Date":"Thu, 28 Sep 2017 16:37:02 +1000","MIME-Version":"1.0","X-TM-AS-GCONF":"00","x-cbid":"17092806-0028-0000-0000-0000086BF183","X-IBM-SpamModules-Scores":"","X-IBM-SpamModules-Versions":"BY=3.00007803; HX=3.00000241; KW=3.00000007;\n\tPH=3.00000004; SC=3.00000232; SDB=6.00923459; UDB=6.00464247;\n\tIPR=6.00703597; \n\tBA=6.00005609; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009;\n\tZB=6.00000000; \n\tZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00017298;\n\tXFM=3.00000015; UTC=2017-09-28 06:37:08","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17092806-0029-0000-0000-000037B9C891","Message-Id":"<87y3ozuy5t.fsf@linux.vnet.ibm.com>","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-09-28_03:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=1\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1709280105","Subject":"Re: [Skiboot] [PATCH 2/3] hdata: Add wafer-id property","X-BeenThere":"skiboot@lists.ozlabs.org","X-Mailman-Version":"2.1.24","Precedence":"list","List-Id":"Mailing list for skiboot development ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org","Sender":"\"Skiboot\"\n\t"}},{"id":1776797,"web_url":"http://patchwork.ozlabs.org/comment/1776797/","msgid":"<86b61dc5-cbd1-ce09-0e83-b31baaba890b@linux.vnet.ibm.com>","list_archive_url":null,"date":"2017-09-28T06:50:18","subject":"Re: [Skiboot] [PATCH 2/3] hdata: Add wafer-id property","submitter":{"id":22361,"url":"http://patchwork.ozlabs.org/api/people/22361/","name":"Vasant Hegde","email":"hegdevasant@linux.vnet.ibm.com"},"content":"On 09/28/2017 12:07 PM, Stewart Smith wrote:\n> Vasant Hegde writes:\n>> +\n>> +\t/*\n>> +\t * bits 4:63 of ECID data contains wafter ID data (ten 6 bit fields\n>> +\t * each containing a code).\n>> +\t */\n>> +\tfor (i = 0; i < 10; i++) {\n>> +\t\ttmp = (u8)((ecid->low >> (i * 6)) & 0x3f);\n>\n> This produces the following sparse warning:\n>\n> hdata/spira.c:433:33: warning: restricted beint64_t degrades to integer\n>\n> looks like we're missing some endian conversions?\n\nMy bad. . I missed be64_to_cpu() ... Will send separate patch for that.\n\n-Vasant","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","skiboot@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","skiboot@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y2lgv4tT8z9t4b\n\tfor ;\n\tThu, 28 Sep 2017 16:50:35 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3y2lgv3xnPzDsPv\n\tfor ;\n\tThu, 28 Sep 2017 16:50:35 +1000 (AEST)","from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com\n\t[148.163.158.5])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3y2lgp0FKZzDsPp\n\tfor ; Thu, 28 Sep 2017 16:50:29 +1000 (AEST)","from pps.filterd (m0098417.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv8S6nMpL013688\n\tfor ; Thu, 28 Sep 2017 02:50:27 -0400","from e23smtp02.au.ibm.com (e23smtp02.au.ibm.com [202.81.31.144])\n\tby mx0a-001b2d01.pphosted.com with ESMTP id 2d8nf2j8rf-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor ; Thu, 28 Sep 2017 02:50:27 -0400","from localhost\n\tby e23smtp02.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor from ; \n\tThu, 28 Sep 2017 16:50:24 +1000","from d23relay10.au.ibm.com (202.81.31.229)\n\tby e23smtp02.au.ibm.com (202.81.31.208) with IBM ESMTP SMTP Gateway:\n\tAuthorized Use Only! Violators will be prosecuted; \n\tThu, 28 Sep 2017 16:50:22 +1000","from d23av01.au.ibm.com (d23av01.au.ibm.com [9.190.234.96])\n\tby d23relay10.au.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n\tv8S6oLXi38273194\n\tfor ; Thu, 28 Sep 2017 16:50:21 +1000","from d23av01.au.ibm.com (localhost [127.0.0.1])\n\tby d23av01.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id\n\tv8S6oMv4000405\n\tfor ; Thu, 28 Sep 2017 16:50:22 +1000","from [9.109.221.121] ([9.109.221.121])\n\tby d23av01.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id\n\tv8S6oJUQ000312; Thu, 28 Sep 2017 16:50:21 +1000"],"Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=linux.vnet.ibm.com\n\t(client-ip=148.163.158.5; helo=mx0a-001b2d01.pphosted.com;\n\tenvelope-from=hegdevasant@linux.vnet.ibm.com; receiver=)","To":"Stewart Smith , skiboot@lists.ozlabs.org","References":"<20170913052425.23122-1-hegdevasant@linux.vnet.ibm.com>\n\t<20170913052425.23122-2-hegdevasant@linux.vnet.ibm.com>\n\t<87y3ozuy5t.fsf@linux.vnet.ibm.com>","From":"Vasant Hegde ","Date":"Thu, 28 Sep 2017 12:20:18 +0530","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101\n\tThunderbird/45.4.0","MIME-Version":"1.0","In-Reply-To":"<87y3ozuy5t.fsf@linux.vnet.ibm.com>","X-TM-AS-MML":"disable","x-cbid":"17092806-0004-0000-0000-0000022FEC16","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17092806-0005-0000-0000-00005E199984","Message-Id":"<86b61dc5-cbd1-ce09-0e83-b31baaba890b@linux.vnet.ibm.com>","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-09-28_03:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=0\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1709280109","Subject":"Re: [Skiboot] [PATCH 2/3] hdata: Add wafer-id property","X-BeenThere":"skiboot@lists.ozlabs.org","X-Mailman-Version":"2.1.24","Precedence":"list","List-Id":"Mailing list for skiboot development ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Transfer-Encoding":"base64","Content-Type":"text/plain; charset=\"utf-8\"; Format=\"flowed\"","Errors-To":"skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org","Sender":"\"Skiboot\"\n\t"}}]