[{"id":1767440,"web_url":"http://patchwork.ozlabs.org/comment/1767440/","msgid":"","list_archive_url":null,"date":"2017-09-13T00:30:18","subject":"Re: [U-Boot] [PATCH v3 1/2] imx: add macro to detect whether USB\n\tPHY is active","submitter":{"id":67231,"url":"http://patchwork.ozlabs.org/api/people/67231/","name":"Eric Nelson","email":"eric@nelint.com"},"content":"Hi Stefan,\n\nI hate to be fussy about this, but I don't think I saw a reply\nto my earlier comment about the term \"USB PHY\".\n\nhttps://lists.denx.de/pipermail/u-boot/2017-September/305123.html\n\nSince i.MX6 SoCs have USB **Host** Phy's as well as the USB OTG Phy,\nthis patch is a bit misleading.\n\nThere's no reference to OTG anywhere in this or patch 2.\n\nOn 09/12/2017 04:54 PM, Stefan Agner wrote:\n> From: Stefan Agner \n> \n> This macro allows to detect whether the USB PHY is active. This\n> is helpful to detect if the boot ROM has previously started the\n> USB serial downloader.\n> \n> The idea is taken from the mfgtool support in the NXP U-Boot:\n> http://git.freescale.com/git/cgit.cgi/imx/uboot-imx.git/commit/?h=imx_v2016.03_4.1.15_2.0.0_ga&id=a352ed3c5184b95c4c9f7468f5fbb5f43de5e412\n> \n> Signed-off-by: Stefan Agner \n> Acked-by: Marcel Ziswiler \n> Tested-by: Fabio Estevam \n> ---\n> \n> Changes in v3: None\n> Changes in v2:\n> - Move macro to sys_proto.h\n> - Renamed from is_boot_from_usb() to is_usbphy_active()\n> - Use defines for register offset and field\n> - Remove tab after define\n> - Remove comment since the actual \"magic\" is happening and\n> documented at usage side\n> \n> arch/arm/include/asm/arch-mx6/sys_proto.h | 7 +++++++\n> 1 file changed, 7 insertions(+)\n> \n> diff --git a/arch/arm/include/asm/arch-mx6/sys_proto.h b/arch/arm/include/asm/arch-mx6/sys_proto.h\n> index 14f5d948c9..9d4b1d6768 100644\n> --- a/arch/arm/include/asm/arch-mx6/sys_proto.h\n> +++ b/arch/arm/include/asm/arch-mx6/sys_proto.h\n> @@ -6,3 +6,10 @@\n> */\n> \n> #include \n> +\n> +#define USBPHY_PWD\t\t0x00000000\n> +\n> +#define USBPHY_PWD_RXPWDRX\t(1 << 20) /* receiver block power down */\n> +\n> +#define is_usbphy_active(void)\t(!(readl(USB_PHY0_BASE_ADDR + USBPHY_PWD) & \\\n> +\t\t\t\t USBPHY_PWD_RXPWDRX))\n> \n\nRegards,\n\n\nEric","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"key not found in DNS\" (0-bit key;\n\tsecure) header.d=nelint.com header.i=@nelint.com header.b=\"AUNEE1j/\";\n\tdkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xsMyV066Wz9t39\n\tfor ;\n\tWed, 13 Sep 2017 10:30:40 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 3A157C22078; Wed, 13 Sep 2017 00:30:28 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id E2080C21EE3;\n\tWed, 13 Sep 2017 00:30:25 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 320F5C21ECA; Wed, 13 Sep 2017 00:30:24 +0000 (UTC)","from mail-pg0-f46.google.com (mail-pg0-f46.google.com\n\t[74.125.83.46])\n\tby lists.denx.de (Postfix) with ESMTPS id 58411C21E4C\n\tfor ; Wed, 13 Sep 2017 00:30:23 +0000 (UTC)","by mail-pg0-f46.google.com with SMTP id v66so24248853pgb.5\n\tfor ; Tue, 12 Sep 2017 17:30:23 -0700 (PDT)","from ?IPv6:2600:8800:1300:1c00:e9cf:8764:f047:89da?\n\t([2600:8800:1300:1c00:e9cf:8764:f047:89da])\n\tby smtp.gmail.com with ESMTPSA id\n\tz30sm22287180pfg.54.2017.09.12.17.30.19\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 12 Sep 2017 17:30:20 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=KHOP_BIG_TO_CC,\n\tRCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID\n\tautolearn=unavailable autolearn_force=no version=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=nelint.com; s=google;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=E5VdLuNjarYP6lkkhMIzEtUkL12RB1Oi/g0bENlQ6kk=;\n\tb=AUNEE1j/ONoc/K8t0XNNVGhX7rX1LolpY6V3MP+3vl6fcqk1GB02XvMQH9Zsth1haj\n\trNr/dQR0DdvrVVPZQOxMv/QRZhZJIai1/Ze95ZffHTlifuFH0plg8Su6IdoOlUzlDG5F\n\tyPgsy+S7PwSKdrnT8X3GqL7L+h0fFO+TmwZAQ=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=E5VdLuNjarYP6lkkhMIzEtUkL12RB1Oi/g0bENlQ6kk=;\n\tb=DjM6Al4LbXRLxmRvF1HW2M89BWKq1gAAHd/inO1sVkK4oq3MjUUleEuvJcXKzpn39H\n\taKf4qtMo1ulI4EF9t69M8T1F6ZIjGzK3hi0FVBQXtlAZd9oG0UyLO44/VWzjXVViRIiU\n\tjz87C9LYfhptXQXrMYzFiefU+WUtjyMQIhzuGfAwQjwRf6eoEAGjE6jvBjgaQvfM/zw1\n\tpoYU8esWhi9aXSfuYNWdicXuU9p0BTxkvPQ4tiQRmWNcn3a8jHIcSV+iz+yvdQRsxjzs\n\tMKX0nWmpsF8TfTtRU770WKTWTXhRg6O0AWu611wCr8KJX5i9HzEIHYrkjRBKKitS/gQR\n\t0Rmg==","X-Gm-Message-State":"AHPjjUjiMn8OWj+RL+LP3unoRdXhEUpsDQxlZ6mtML0M/9T+r+mYG1cP\n\t85vsx0W8FkaNTYFG","X-Google-Smtp-Source":"ADKCNb68PKDmCGIiKvZ/B+RDURMVyIKm79vW3xyHgcnD+TSPuSxoNxHjx2LeQK+833CZ+fy/BtOH3Q==","X-Received":"by 10.84.129.226 with SMTP id b89mr18303605plb.78.1505262621297; \n\tTue, 12 Sep 2017 17:30:21 -0700 (PDT)","To":"Stefan Agner , sbabic@denx.de, fabio.estevam@nxp.com","References":"<20170912235441.19238-1-stefan@agner.ch>","From":"Eric Nelson ","Message-ID":"","Date":"Tue, 12 Sep 2017 17:30:18 -0700","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20170912235441.19238-1-stefan@agner.ch>","Content-Language":"en-US","Cc":"marex@denx.de, albert.u.boot@aribaud.net,\n\tStefan Agner ,\n\tgary.bisson@boundarydevices.com, \n\tMarcel Ziswiler ,\n\tjoel.esponde@honeywell.com, \n\tu-boot@lists.denx.de, Max Krummenacher ,\n\tjagan@openedev.com","Subject":"Re: [U-Boot] [PATCH v3 1/2] imx: add macro to detect whether USB\n\tPHY is active","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Transfer-Encoding":"base64","Content-Type":"text/plain; charset=\"utf-8\"; Format=\"flowed\"","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1767703,"web_url":"http://patchwork.ozlabs.org/comment/1767703/","msgid":"","list_archive_url":null,"date":"2017-09-13T09:19:34","subject":"Re: [U-Boot] [PATCH v3 1/2] imx: add macro to detect whether USB\n\tPHY is active","submitter":{"id":5771,"url":"http://patchwork.ozlabs.org/api/people/5771/","name":"Stefano Babic","email":"sbabic@denx.de"},"content":"Hi Eric, Stefan,\n\nOn 13/09/2017 02:30, Eric Nelson wrote:\n> Hi Stefan,\n> \n> I hate to be fussy about this, but I don't think I saw a reply\n> to my earlier comment about the term \"USB PHY\".\n> \n> https://lists.denx.de/pipermail/u-boot/2017-September/305123.html\n> \n> Since i.MX6 SoCs have USB **Host** Phy's as well as the USB OTG Phy,\n> this patch is a bit misleading.\n> \n> There's no reference to OTG anywhere in this or patch 2.\n> \n\nTo be consistent with the names, Eric is right. We have PHY0 for OTG and\nPHY1 for Host. If you still want to use as name is_usbphy_active, then\nthis should take as parameter the phy number, or you switch to a \"otg\"\nname to ensure that it is only for the OTG interface.\n\nBest regards,\nStefano\n\n> On 09/12/2017 04:54 PM, Stefan Agner wrote:\n>> From: Stefan Agner \n>>\n>> This macro allows to detect whether the USB PHY is active. This\n>> is helpful to detect if the boot ROM has previously started the\n>> USB serial downloader.\n>>\n>> The idea is taken from the mfgtool support in the NXP U-Boot:\n>> http://git.freescale.com/git/cgit.cgi/imx/uboot-imx.git/commit/?h=imx_v2016.03_4.1.15_2.0.0_ga&id=a352ed3c5184b95c4c9f7468f5fbb5f43de5e412\n>>\n>>\n>> Signed-off-by: Stefan Agner \n>> Acked-by: Marcel Ziswiler \n>> Tested-by: Fabio Estevam \n>> ---\n>>\n>> Changes in v3: None\n>> Changes in v2:\n>> - Move macro to sys_proto.h\n>> - Renamed from is_boot_from_usb() to is_usbphy_active()\n>> - Use defines for register offset and field\n>> - Remove tab after define\n>> - Remove comment since the actual \"magic\" is happening and\n>> documented at usage side\n>>\n>> arch/arm/include/asm/arch-mx6/sys_proto.h | 7 +++++++\n>> 1 file changed, 7 insertions(+)\n>>\n>> diff --git a/arch/arm/include/asm/arch-mx6/sys_proto.h\n>> b/arch/arm/include/asm/arch-mx6/sys_proto.h\n>> index 14f5d948c9..9d4b1d6768 100644\n>> --- a/arch/arm/include/asm/arch-mx6/sys_proto.h\n>> +++ b/arch/arm/include/asm/arch-mx6/sys_proto.h\n>> @@ -6,3 +6,10 @@\n>> */\n>> #include \n>> +\n>> +#define USBPHY_PWD 0x00000000\n>> +\n>> +#define USBPHY_PWD_RXPWDRX (1 << 20) /* receiver block power down */\n>> +\n>> +#define is_usbphy_active(void) (!(readl(USB_PHY0_BASE_ADDR +\n>> USBPHY_PWD) & \\\n>> + USBPHY_PWD_RXPWDRX))\n>>\n> \n> Regards,\n> \n> \n> Eric","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xsbj33Jlxz9sNr\n\tfor ;\n\tWed, 13 Sep 2017 19:19:51 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 2B5F1C222F3; Wed, 13 Sep 2017 09:19:46 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id D2A86C21ED8;\n\tWed, 13 Sep 2017 09:19:44 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid E10E3C21ED8; Wed, 13 Sep 2017 09:19:43 +0000 (UTC)","from mail-out.m-online.net (mail-out.m-online.net [212.18.0.10])\n\tby lists.denx.de (Postfix) with ESMTPS id F20FFC21D19\n\tfor ; Wed, 13 Sep 2017 09:19:41 +0000 (UTC)","from frontend03.mail.m-online.net (unknown [192.168.6.182])\n\tby mail-out.m-online.net (Postfix) with ESMTP id 3xsbhr4Qssz1qqkr;\n\tWed, 13 Sep 2017 11:19:40 +0200 (CEST)","from localhost (dynscan3.mnet-online.de [192.168.6.84])\n\tby mail.m-online.net (Postfix) with ESMTP id 3xsbhr2KK7z1qqkS;\n\tWed, 13 Sep 2017 11:19:40 +0200 (CEST)","from mail.mnet-online.de ([192.168.8.182])\n\tby localhost (dynscan3.mail.m-online.net [192.168.6.84]) (amavisd-new,\n\tport 10024)\n\twith ESMTP id axH8ZmjMqE2d; Wed, 13 Sep 2017 11:19:38 +0200 (CEST)","from babic.homelinux.org (host-88-217-136-221.customer.m-online.net\n\t[88.217.136.221])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby mail.mnet-online.de (Postfix) with ESMTPS;\n\tWed, 13 Sep 2017 11:19:38 +0200 (CEST)","from localhost (mail.babic.homelinux.org [127.0.0.1])\n\tby babic.homelinux.org (Postfix) with ESMTP id 2B42D4540491;\n\tWed, 13 Sep 2017 11:19:38 +0200 (CEST)","from babic.homelinux.org ([127.0.0.1])\n\tby localhost (mail.babic.homelinux.org [127.0.0.1]) (amavisd-new,\n\tport 10024)\n\twith ESMTP id bwPr22mVukLO; Wed, 13 Sep 2017 11:19:35 +0200 (CEST)","from [192.168.178.132] (papero.fritz.box [192.168.178.132])\n\tby babic.homelinux.org (Postfix) with ESMTP id 7757745403D9;\n\tWed, 13 Sep 2017 11:19:34 +0200 (CEST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.7 required=5.0 tests=KHOP_BIG_TO_CC,\n\tRCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3,\n\tRCVD_IN_MSPIKE_WL autolearn=unavailable\n\tautolearn_force=no version=3.4.0","X-Virus-Scanned":["amavisd-new at mnet-online.de","Debian amavisd-new at babic.homelinux.org"],"To":"Eric Nelson , Stefan Agner ,\n\tsbabic@denx.de, fabio.estevam@nxp.com","References":"<20170912235441.19238-1-stefan@agner.ch>\n\t","From":"Stefano Babic ","Message-ID":"","Date":"Wed, 13 Sep 2017 11:19:34 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"","Content-Language":"de-DE","Cc":"marex@denx.de, albert.u.boot@aribaud.net,\n\tStefan Agner ,\n\tgary.bisson@boundarydevices.com, \n\tMarcel Ziswiler ,\n\tjoel.esponde@honeywell.com, \n\tu-boot@lists.denx.de, Max Krummenacher ,\n\tjagan@openedev.com","Subject":"Re: [U-Boot] [PATCH v3 1/2] imx: add macro to detect whether USB\n\tPHY is active","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1768105,"web_url":"http://patchwork.ozlabs.org/comment/1768105/","msgid":"<4699c19c13b2df477aff064ab516d31d@agner.ch>","list_archive_url":null,"date":"2017-09-13T19:47:49","subject":"Re: [U-Boot] [PATCH v3 1/2] imx: add macro to detect whether USB\n\tPHY is active","submitter":{"id":4137,"url":"http://patchwork.ozlabs.org/api/people/4137/","name":"Stefan Agner","email":"stefan@agner.ch"},"content":"On 2017-09-13 02:19, Stefano Babic wrote:\n> Hi Eric, Stefan,\n> \n> On 13/09/2017 02:30, Eric Nelson wrote:\n>> Hi Stefan,\n>>\n>> I hate to be fussy about this, but I don't think I saw a reply\n>> to my earlier comment about the term \"USB PHY\".\n>>\n>> https://lists.denx.de/pipermail/u-boot/2017-September/305123.html\n>>\n>> Since i.MX6 SoCs have USB **Host** Phy's as well as the USB OTG Phy,\n>> this patch is a bit misleading.\n>>\n>> There's no reference to OTG anywhere in this or patch 2.\n>>\n\nHm, sorry I missed that.\n\n> \n> To be consistent with the names, Eric is right. We have PHY0 for OTG and\n> PHY1 for Host. If you still want to use as name is_usbphy_active, then\n> this should take as parameter the phy number, or you switch to a \"otg\"\n> name to ensure that it is only for the OTG interface.\n\nFor the registers itself I followed the notation used in chapter 66 and\narch/arm/include/asm/arch-mx6/imx-regs.h.\n\nRenaming the function macro makes sense I agree.\n\nThe USB serial downloader only works with the OTG USB PHY anyway, so I\nwill rename it. I like to have USB still in there, how about:\n\nis_usbotg_phy_active()\n\n--\nStefan\n\n> \n> Best regards,\n> Stefano\n> \n>> On 09/12/2017 04:54 PM, Stefan Agner wrote:\n>>> From: Stefan Agner \n>>>\n>>> This macro allows to detect whether the USB PHY is active. This\n>>> is helpful to detect if the boot ROM has previously started the\n>>> USB serial downloader.\n>>>\n>>> The idea is taken from the mfgtool support in the NXP U-Boot:\n>>> http://git.freescale.com/git/cgit.cgi/imx/uboot-imx.git/commit/?h=imx_v2016.03_4.1.15_2.0.0_ga&id=a352ed3c5184b95c4c9f7468f5fbb5f43de5e412\n>>>\n>>>\n>>> Signed-off-by: Stefan Agner \n>>> Acked-by: Marcel Ziswiler \n>>> Tested-by: Fabio Estevam \n>>> ---\n>>>\n>>> Changes in v3: None\n>>> Changes in v2:\n>>> - Move macro to sys_proto.h\n>>> - Renamed from is_boot_from_usb() to is_usbphy_active()\n>>> - Use defines for register offset and field\n>>> - Remove tab after define\n>>> - Remove comment since the actual \"magic\" is happening and\n>>> documented at usage side\n>>>\n>>> arch/arm/include/asm/arch-mx6/sys_proto.h | 7 +++++++\n>>> 1 file changed, 7 insertions(+)\n>>>\n>>> diff --git a/arch/arm/include/asm/arch-mx6/sys_proto.h\n>>> b/arch/arm/include/asm/arch-mx6/sys_proto.h\n>>> index 14f5d948c9..9d4b1d6768 100644\n>>> --- a/arch/arm/include/asm/arch-mx6/sys_proto.h\n>>> +++ b/arch/arm/include/asm/arch-mx6/sys_proto.h\n>>> @@ -6,3 +6,10 @@\n>>> */\n>>> #include \n>>> +\n>>> +#define USBPHY_PWD 0x00000000\n>>> +\n>>> +#define USBPHY_PWD_RXPWDRX (1 << 20) /* receiver block power down */\n>>> +\n>>> +#define is_usbphy_active(void) (!(readl(USB_PHY0_BASE_ADDR +\n>>> USBPHY_PWD) & \\\n>>> + USBPHY_PWD_RXPWDRX))\n>>>\n>>\n>> Regards,\n>>\n>>\n>> Eric","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tsecure) header.d=agner.ch header.i=@agner.ch header.b=\"Ay3q52IR\";\n\tdkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xssjV4rwQz9s72\n\tfor ;\n\tThu, 14 Sep 2017 05:51:10 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 64830C21F2B; Wed, 13 Sep 2017 19:51:00 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id EE674C21E9B;\n\tWed, 13 Sep 2017 19:50:57 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 98783C21E9B; Wed, 13 Sep 2017 19:50:56 +0000 (UTC)","from mail.kmu-office.ch (mail.kmu-office.ch [178.209.48.109])\n\tby lists.denx.de (Postfix) with ESMTPS id 231A8C21C73\n\tfor ; Wed, 13 Sep 2017 19:50:56 +0000 (UTC)","from webmail.kmu-office.ch (unknown [178.209.48.103])\n\tby mail.kmu-office.ch (Postfix) with ESMTPSA id 66EE65C079B;\n\tWed, 13 Sep 2017 21:47:08 +0200 (CEST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=0.0 required=5.0 tests=KHOP_BIG_TO_CC,\n\tRCVD_IN_DNSWL_NONE, SPF_HELO_PASS,\n\tT_DKIM_INVALID autolearn=unavailable\n\tautolearn_force=no version=3.4.0","MIME-Version":"1.0","Date":"Wed, 13 Sep 2017 12:47:49 -0700","From":"Stefan Agner ","To":"Stefano Babic ","In-Reply-To":"","References":"<20170912235441.19238-1-stefan@agner.ch>\n\t\n\t","Message-ID":"<4699c19c13b2df477aff064ab516d31d@agner.ch>","X-Sender":"stefan@agner.ch","User-Agent":"Roundcube Webmail/1.2.5","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=agner.ch; s=dkim;\n\tt=1505332028; bh=4QLk0sk1+nPkTDZXVxEfaisb/2nGHMxTr9R/qxPqNOM=;\n\th=MIME-Version:Content-Type:Content-Transfer-Encoding:Date:From:To:Cc:Subject:In-Reply-To:References:Message-ID;\n\tb=Ay3q52IRO3MO2QwdFXMZU+nouJ9c0J46rWoa+STvJ48ClGAbP63khhi/2JnxdpVhBlQrgDdF/0qU5THXAqVxp/tvhoiK75ZzLJDQGAHCAsGQpVv1j/6Xu5fNcSYpJfmIBHpxLIu7WoGGeqFlAPZUVgJpSHm1Fmh2GHpzDYVY7Rw=","Cc":"marex@denx.de, albert.u.boot@aribaud.net,\n\tStefan Agner ,\n\tgary.bisson@boundarydevices.com, \n\tMarcel Ziswiler ,\n\tjoel.esponde@honeywell.com, \n\tu-boot@lists.denx.de, Max Krummenacher ,\n\tfabio.estevam@nxp.com, jagan@openedev.com","Subject":"Re: [U-Boot] [PATCH v3 1/2] imx: add macro to detect whether USB\n\tPHY is active","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1768182,"web_url":"http://patchwork.ozlabs.org/comment/1768182/","msgid":"","list_archive_url":null,"date":"2017-09-13T21:07:18","subject":"Re: [U-Boot] [PATCH v3 1/2] imx: add macro to detect whether USB\n\tPHY is active","submitter":{"id":6978,"url":"http://patchwork.ozlabs.org/api/people/6978/","name":"Fabio Estevam","email":"festevam@gmail.com"},"content":"On Wed, Sep 13, 2017 at 4:47 PM, Stefan Agner wrote:\n\n> The USB serial downloader only works with the OTG USB PHY anyway, so I\n> will rename it. I like to have USB still in there, how about:\n>\n> is_usbotg_phy_active()\n\nLooks fine. Please send a v4 with it and we should be good :-)","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"Xk6hZgb4\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xsvPZ4WFhz9s7M\n\tfor ;\n\tThu, 14 Sep 2017 07:07:30 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 5EA6EC224BB; Wed, 13 Sep 2017 21:07:25 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id E7F76C220D0;\n\tWed, 13 Sep 2017 21:07:22 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 0B31EC220D0; Wed, 13 Sep 2017 21:07:21 +0000 (UTC)","from mail-io0-f196.google.com (mail-io0-f196.google.com\n\t[209.85.223.196])\n\tby lists.denx.de (Postfix) with ESMTPS id AE4BDC21F49\n\tfor ; Wed, 13 Sep 2017 21:07:20 +0000 (UTC)","by mail-io0-f196.google.com with SMTP id j141so1538188ioj.5\n\tfor ; Wed, 13 Sep 2017 14:07:20 -0700 (PDT)","by 10.157.14.246 with HTTP; Wed, 13 Sep 2017 14:07:18 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=0.0 required=5.0 tests=FREEMAIL_FROM,\n\tRCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,\n\tT_DKIM_INVALID autolearn=unavailable\n\tautolearn_force=no version=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=3HODO5QQNj7gXuHChdfvqRN40GFTZK6jYIeD2zDm5+k=;\n\tb=Xk6hZgb4JBWirU+6L2/9qAr3xRhyk81e+riueHCtTs4RY8pwcSfW+pffSDM7TwgWtM\n\tWT/zwzNCFG8shEZW8tJAtcC2CSnZy97Iipo81e7i0xhyax2f6nlIy16oxj7xrINES/t2\n\taxGc/9YOnwHprI7GI6drjHnxOcZbMwkzGk/ZIOunsUKa1QDOemGJi2D1UGcjqDlBQLhW\n\tJ1KQi0ozJ9VKl/PYeewYklBdIjnBwbjm6u5nvJyWrcMCXsa3kMi7asWTg7IzpTrOIoJW\n\tnDkSzDYHn3C0yht894jzFkKSxS931zByjRIGVvJvl6+9Tap9OKTmwW3Ob3Cwv6nFstik\n\t9SJw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=3HODO5QQNj7gXuHChdfvqRN40GFTZK6jYIeD2zDm5+k=;\n\tb=PGzYboD7O7nYvG6Q8mWAkPjcCoeKAS1nd3kAi/kp86RXNZfSI1CuKEvx7N1reZqFYu\n\t96cdY6kye3C5nW97OV3fmM7t9rGo8eA4nAUPZwHZMH0gsJjiukaJTmlpnybd4ciLVsCm\n\toQ9TuNAupG2/cuYb+oBRAcadrBVBhaPQfnDTPo6yUmIO/JHDLVOgXvMX7z9cGevhP8vp\n\t8LqSUGeGWD7ZEFqIO6oVIQbN/cQyuZEgUpaul93G/wHxQL1GvTBxULT2rPH4Ljj4g3/v\n\tz/RhXblqcsqRsa9b6drbeSICi5prGpcNBROoTrIMPW4cPE9MXkK0kYeWi8UOrgK6rCrH\n\tTMWw==","X-Gm-Message-State":"AHPjjUgLWhrydx0nVlO65x9OKCHXSkvzrhNNoBSfRRkOlYMGxYTPVuvX\n\thOOBkDWtulOyop2NMFvxiuIAXCoEnxYI/KUJrnQ=","X-Google-Smtp-Source":"AOwi7QBredpgJTPetE1IWbJ0GRvdUjDpqeXMbayxQu/LS+lg1OK2KrfQ/8/1rKhrWoRfwBHU9GjSw5SnOwe8t2hOeQo=","X-Received":"by 10.202.207.72 with SMTP id f69mr20917309oig.87.1505336839074; \n\tWed, 13 Sep 2017 14:07:19 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<4699c19c13b2df477aff064ab516d31d@agner.ch>","References":"<20170912235441.19238-1-stefan@agner.ch>\n\t\n\t\n\t<4699c19c13b2df477aff064ab516d31d@agner.ch>","From":"Fabio Estevam ","Date":"Wed, 13 Sep 2017 18:07:18 -0300","Message-ID":"","To":"Stefan Agner ","Cc":"Marek Vasut , Albert ARIBAUD , \n\t\"Esponde, Joel\" ,\n\tStefan Agner ,\n\tMarcel Ziswiler ,\n\tGary Bisson ,\n\tU-Boot-Denx ,\n\tMax Krummenacher ,\n\tFabio Estevam , Jagan Teki ","Subject":"Re: [U-Boot] [PATCH v3 1/2] imx: add macro to detect whether USB\n\tPHY is active","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1768186,"web_url":"http://patchwork.ozlabs.org/comment/1768186/","msgid":"","list_archive_url":null,"date":"2017-09-13T21:14:17","subject":"Re: [U-Boot] [PATCH v3 1/2] imx: add macro to detect whether USB\n\tPHY is active","submitter":{"id":67231,"url":"http://patchwork.ozlabs.org/api/people/67231/","name":"Eric Nelson","email":"eric@nelint.com"},"content":"Hi Stefan,\n\nOn 09/13/2017 12:47 PM, Stefan Agner wrote:\n> On 2017-09-13 02:19, Stefano Babic wrote:\n>> Hi Eric, Stefan,\n>>\n>> On 13/09/2017 02:30, Eric Nelson wrote:\n>>> Hi Stefan,\n>>>\n>>> I hate to be fussy about this, but I don't think I saw a reply\n>>> to my earlier comment about the term \"USB PHY\".\n>>>\n>>> https://lists.denx.de/pipermail/u-boot/2017-September/305123.html\n>>>\n>>> Since i.MX6 SoCs have USB **Host** Phy's as well as the USB OTG Phy,\n>>> this patch is a bit misleading.\n>>>\n>>> There's no reference to OTG anywhere in this or patch 2.\n>>>\n> \n> Hm, sorry I missed that.\n> \nNo worries. We're here to nag...\n\n>>\n>> To be consistent with the names, Eric is right. We have PHY0 for OTG and\n>> PHY1 for Host. If you still want to use as name is_usbphy_active, then\n>> this should take as parameter the phy number, or you switch to a \"otg\"\n>> name to ensure that it is only for the OTG interface.\n> \n> For the registers itself I followed the notation used in chapter 66 and\n> arch/arm/include/asm/arch-mx6/imx-regs.h.\n> \n> Renaming the function macro makes sense I agree.\n> \n> The USB serial downloader only works with the OTG USB PHY anyway, so I\n> will rename it. I like to have USB still in there, how about:\n> \n> is_usbotg_phy_active()\n> \n\nPerfect.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"key not found in DNS\" (0-bit key;\n\tsecure) header.d=nelint.com header.i=@nelint.com header.b=\"Un4cfAKQ\";\n\tdkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xsvYf059Tz9ryv\n\tfor ;\n\tThu, 14 Sep 2017 07:14:29 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 93EAAC224A1; Wed, 13 Sep 2017 21:14:25 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 26950C220FE;\n\tWed, 13 Sep 2017 21:14:23 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid F04F1C220FE; Wed, 13 Sep 2017 21:14:21 +0000 (UTC)","from mail-pg0-f46.google.com (mail-pg0-f46.google.com\n\t[74.125.83.46])\n\tby lists.denx.de (Postfix) with ESMTPS id 616F9C21F49\n\tfor ; Wed, 13 Sep 2017 21:14:21 +0000 (UTC)","by mail-pg0-f46.google.com with SMTP id u18so2665094pgo.0\n\tfor ; Wed, 13 Sep 2017 14:14:21 -0700 (PDT)","from ?IPv6:2600:8800:1300:1c00:e9cf:8764:f047:89da?\n\t([2600:8800:1300:1c00:e9cf:8764:f047:89da])\n\tby smtp.gmail.com with ESMTPSA id\n\tb63sm27465660pga.27.2017.09.13.14.14.18\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 13 Sep 2017 14:14:19 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=KHOP_BIG_TO_CC,\n\tRCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID\n\tautolearn=unavailable autolearn_force=no version=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=nelint.com; s=google;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=DxA8nzfOnql86tM6Fk3LjLkYFTmAs5VBTTQ+YTtP1wY=;\n\tb=Un4cfAKQ+siFzx76RgPjUq1M4fzyncAyrSEdguv+gK8g99jkQTHhkoQPKf0uhwK8Vr\n\tNOaA5uRXxg2SlBHNpBSmJbn/NdejlS7V5nKRRPZ5SPYDa80pM7WSKflEfM5w91LMzK+/\n\tWroDlHLuUpxm9ytVZdcxcXeDVtBdxIK/iH43Q=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=DxA8nzfOnql86tM6Fk3LjLkYFTmAs5VBTTQ+YTtP1wY=;\n\tb=IXXVG4mmjsMvGxQ/r9agZo4X/6CHjZBFhfruVrk9W15ak2XYOnp2z4q7TgMFTLKE9/\n\tGtAZREf1Pjceh7Jie9nQ8vQU/RtWe5OK8pN6R63OT7tDQFYf9ipxb3cvwoSPoN9uf6ty\n\tC5B+KdRStu87eenzfXnvW9qEv7lH4JCnbcW+hjPnkyxiRJ0+dS/g/17Ke8qAzBz3jx9P\n\tCmXgBeCKkvui9lKDhq5qsn4mkdyiawvJH/qJgqKzY5BQ00YL0uqeZLc7yUdG2spMi941\n\tD4drYWGFrvO7hAM8lcyKS3u4IMkONN+rK3Bg6g8X3GbK5Scq7Zr9hKzUU3cPPOWtbcIj\n\tXoqA==","X-Gm-Message-State":"AHPjjUh3mGrjbz/TmaHWUqOhzNlp2b3o843qSdVVncojmeffg3g529JS\n\thF1aqw8wCi69Mkqf","X-Google-Smtp-Source":"AOwi7QCB7nuL5eEtNYwODtzgPwOsPJxuCXGKVxptDhdRABC1PVkOx1Ql7hq2d76CF1c84NSCou6eQg==","X-Received":"by 10.159.194.137 with SMTP id y9mr2133756pln.77.1505337259792; \n\tWed, 13 Sep 2017 14:14:19 -0700 (PDT)","To":"Stefan Agner , Stefano Babic ","References":"<20170912235441.19238-1-stefan@agner.ch>\n\t\n\t\n\t<4699c19c13b2df477aff064ab516d31d@agner.ch>","From":"Eric Nelson ","Message-ID":"","Date":"Wed, 13 Sep 2017 14:14:17 -0700","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<4699c19c13b2df477aff064ab516d31d@agner.ch>","Content-Language":"en-US","Cc":"marex@denx.de, albert.u.boot@aribaud.net,\n\tStefan Agner ,\n\tgary.bisson@boundarydevices.com, \n\tMarcel Ziswiler ,\n\tjoel.esponde@honeywell.com, \n\tu-boot@lists.denx.de, Max Krummenacher ,\n\tfabio.estevam@nxp.com, jagan@openedev.com","Subject":"Re: [U-Boot] [PATCH v3 1/2] imx: add macro to detect whether USB\n\tPHY is active","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Transfer-Encoding":"base64","Content-Type":"text/plain; charset=\"utf-8\"; Format=\"flowed\"","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}}]