[{"id":1767679,"web_url":"http://patchwork.ozlabs.org/comment/1767679/","msgid":"","list_archive_url":null,"date":"2017-09-13T08:36:23","subject":"Re: [PATCH 04/11] soc: renesas: rcar-sysc: add R8A77970 support","submitter":{"id":703,"url":"http://patchwork.ozlabs.org/api/people/703/","name":"Geert Uytterhoeven","email":"geert@linux-m68k.org"},"content":"Hi Sergei,\n\nOn Tue, Sep 12, 2017 at 10:37 PM, Sergei Shtylyov\n wrote:\n> Add support for R-Car V3M (R8A77970) SoC power areas to the R-Car SYSC\n> driver.\n>\n> Based on the original (and large) patch by Daisuke Matsushita\n> .\n>\n> Signed-off-by: Vladimir Barinov \n> Signed-off-by: Sergei Shtylyov \n\n> --- /dev/null\n> +++ renesas/drivers/soc/renesas/r8a77970-sysc.c\n> @@ -0,0 +1,39 @@\n\n> +#include \n\nI think this include is no longer needed since commit c7acec713d14c6ce\n(\"kernel.h: handle pointers to arrays better in container_of()\").\n\n> +static const struct rcar_sysc_area r8a77970_areas[] __initconst = {\n\n> + { \"a3ir\", 0x180, 0, R8A77970_PD_A3IR, R8A77970_PD_ALWAYS_ON },\n> + { \"a2ir0\", 0x400, 0, R8A77970_PD_A2IR0, R8A77970_PD_ALWAYS_ON },\n> + { \"a2ir1\", 0x400, 1, R8A77970_PD_A2IR1, R8A77970_PD_A2IR0 },\n> + { \"a2ir2\", 0x400, 2, R8A77970_PD_A2IR2, R8A77970_PD_A2IR0 },\n> + { \"a2ir3\", 0x400, 3, R8A77970_PD_A2IR3, R8A77970_PD_A2IR0 },\n> + { \"a2sc0\", 0x400, 4, R8A77970_PD_A2SC0, R8A77970_PD_ALWAYS_ON },\n> + { \"a2sc1\", 0x400, 5, R8A77970_PD_A2SC1, R8A77970_PD_A2SC0 },\n\nAccording to Figure 9.2(b) \"Power domain structure (R-Car V3M)\" and Table 9.4\n\"Power domains\", all of A2IR[0-3] and A2SC[01] are direct children of A3IR.\n\nBTW, the bit indices \"4\" resp. \"5\" for A2SC[01] don't match Section 9.2.5\n\"Power Control Registers for A2IR\" (which uses \"0\" resp. \"1\"), but I assume\nthat's just a typo in the datasheet, as those would conflict with A2IR[01], and\nthe would conflict with the documentation for other R-Car Gen3 SoCs.\n\nWith the above fixed:\nReviewed-by: Geert Uytterhoeven \n\nGr{oetje,eeting}s,\n\n Geert\n\n--\nGeert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org\n\nIn personal conversations with technical people, I call myself a hacker. But\nwhen I'm talking to journalists I just say \"programmer\" or something like that.\n -- Linus Torvalds\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"S9JagYSK\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xsZl04Qzlz9sPs\n\tfor ;\n\tWed, 13 Sep 2017 18:36:28 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751128AbdIMIg1 (ORCPT\n\t);\n\tWed, 13 Sep 2017 04:36:27 -0400","from mail-pg0-f67.google.com ([74.125.83.67]:38252 \"EHLO\n\tmail-pg0-f67.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751120AbdIMIgZ (ORCPT\n\t); Wed, 13 Sep 2017 04:36:25 -0400","by mail-pg0-f67.google.com with SMTP id m30so2382311pgn.5;\n\tWed, 13 Sep 2017 01:36:24 -0700 (PDT)","by 10.100.160.13 with HTTP; Wed, 13 Sep 2017 01:36:23 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=ilytYXqv+Ho2XyC4HeuWyJdGVi4QfmzZUfwhm5/UiEU=;\n\tb=S9JagYSKp5doUyAvH85y9sI2CDQcvwmBDSWQHpml2dmvVTqZPQpKp3If/gVjBKOsS3\n\tqzN+vXj5q9GLMf1UtZwLqsj3tRQcU+jVQ6y+ZLdc/OcnCggCgShG0BelYEEs8d8iioYB\n\tA2V4ltdcrV2kdWoNl+25UTR2N9Jmfrq1ekvjLuXrnWcAsDcb9ituXgwzvX92Gd8FxJVD\n\tWCc1mVlEHjqQrAX25aNONh35TdosmwflRDx4e7PkppkH6DUsVBZ/hMZfdLeSFJ7y6LVK\n\tv+X3AFS2muvpETY9xdNV/lHuhGmpsOTY3VYhh/Oyhy7RSPQipLFvny+HwLhOtLq/hgOb\n\trpvw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:sender:in-reply-to:references:from\n\t:date:message-id:subject:to:cc;\n\tbh=ilytYXqv+Ho2XyC4HeuWyJdGVi4QfmzZUfwhm5/UiEU=;\n\tb=GZw4zBAtTU9fVB3TwHdzGCSL+8AwQEWOqXmHWbbvpcY2dPlMln13clKY2dKTOQDVMF\n\t8zUQLj8LMFd3smCZjbQgGXxhalE9UefYnxgdAA5YpDwFd3UArURoxPYOuNGXyn+fN6dm\n\tEJuaf9ctcWi6Nj57qMpm+3PXjH3JpX2+8gRJekgfqzXRtWzVOqRmHjRYVk2+jnA/dAzR\n\twNIHepKvWg3HKj5uPfFs7OATcT6hXqm7OCjH9Ca5Q3+Pgjhjq6RQ3OHLo+4qeoM0wVu3\n\tZYB0tqrVVgGnB82PKLvbeslk37tH3cPetgAx/szOrUqMQZdRNHHrUviS8n/tuOxJK779\n\tDK7A==","X-Gm-Message-State":"AHPjjUjmv/lhOrFtvyLOgFvy1tG6Txe2F+0cqU4NJxsK9/xa3RFJtrtK\n\tuqKL0q3U24uWrnqCdSIOd1Gize0gU4yxj5w3o0I=","X-Google-Smtp-Source":"ADKCNb7SSaiqlw5M6q+/evR8iCl/rdZFOuV952GXMje77VdtxAovR/wFo6TEjo7wRztmXw0Hv3MOW73wmdx1B5ILeFg=","X-Received":"by 10.98.166.136 with SMTP id r8mr17679371pfl.228.1505291784412; \n\tWed, 13 Sep 2017 01:36:24 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170912210518.203740259@cogentembedded.com>","References":"<20170912210518.203740259@cogentembedded.com>","From":"Geert Uytterhoeven ","Date":"Wed, 13 Sep 2017 10:36:23 +0200","X-Google-Sender-Auth":"3bduyr-_Y0DXGLC1__80G_aBUO4","Message-ID":"","Subject":"Re: [PATCH 04/11] soc: renesas: rcar-sysc: add R8A77970 support","To":"Sergei Shtylyov ","Cc":"Rob Herring , Mark Rutland ,\n\tSimon Horman ,\n\t\"devicetree@vger.kernel.org\" ,\n\tLinux-Renesas ,\n\tCatalin Marinas ,\n\tWill Deacon , Magnus Damm ,\n\tVladimir Barinov ,\n\t\"linux-arm-kernel@lists.infradead.org\" \n\t","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1768986,"web_url":"http://patchwork.ozlabs.org/comment/1768986/","msgid":"<20170915072504.GA3924@verge.net.au>","list_archive_url":null,"date":"2017-09-15T07:25:05","subject":"Re: [PATCH 04/11] soc: renesas: rcar-sysc: add R8A77970 support","submitter":{"id":106,"url":"http://patchwork.ozlabs.org/api/people/106/","name":"Simon Horman","email":"horms@verge.net.au"},"content":"On Wed, Sep 13, 2017 at 10:36:23AM +0200, Geert Uytterhoeven wrote:\n> Hi Sergei,\n> \n> On Tue, Sep 12, 2017 at 10:37 PM, Sergei Shtylyov\n> wrote:\n> > Add support for R-Car V3M (R8A77970) SoC power areas to the R-Car SYSC\n> > driver.\n> >\n> > Based on the original (and large) patch by Daisuke Matsushita\n> > .\n> >\n> > Signed-off-by: Vladimir Barinov \n> > Signed-off-by: Sergei Shtylyov \n> \n> > --- /dev/null\n> > +++ renesas/drivers/soc/renesas/r8a77970-sysc.c\n> > @@ -0,0 +1,39 @@\n> \n> > +#include \n> \n> I think this include is no longer needed since commit c7acec713d14c6ce\n> (\"kernel.h: handle pointers to arrays better in container_of()\").\n> \n> > +static const struct rcar_sysc_area r8a77970_areas[] __initconst = {\n> \n> > + { \"a3ir\", 0x180, 0, R8A77970_PD_A3IR, R8A77970_PD_ALWAYS_ON },\n> > + { \"a2ir0\", 0x400, 0, R8A77970_PD_A2IR0, R8A77970_PD_ALWAYS_ON },\n> > + { \"a2ir1\", 0x400, 1, R8A77970_PD_A2IR1, R8A77970_PD_A2IR0 },\n> > + { \"a2ir2\", 0x400, 2, R8A77970_PD_A2IR2, R8A77970_PD_A2IR0 },\n> > + { \"a2ir3\", 0x400, 3, R8A77970_PD_A2IR3, R8A77970_PD_A2IR0 },\n> > + { \"a2sc0\", 0x400, 4, R8A77970_PD_A2SC0, R8A77970_PD_ALWAYS_ON },\n> > + { \"a2sc1\", 0x400, 5, R8A77970_PD_A2SC1, R8A77970_PD_A2SC0 },\n> \n> According to Figure 9.2(b) \"Power domain structure (R-Car V3M)\" and Table 9.4\n> \"Power domains\", all of A2IR[0-3] and A2SC[01] are direct children of A3IR.\n> \n> BTW, the bit indices \"4\" resp. \"5\" for A2SC[01] don't match Section 9.2.5\n> \"Power Control Registers for A2IR\" (which uses \"0\" resp. \"1\"), but I assume\n> that's just a typo in the datasheet, as those would conflict with A2IR[01], and\n> the would conflict with the documentation for other R-Car Gen3 SoCs.\n> \n> With the above fixed:\n> Reviewed-by: Geert Uytterhoeven \n\nSergei,\n\nplease address Geert's review and repost when you are ready.\nI believe patches 1-3 of this series have been applied.\nI have marked patches 4 (this one) onwards as \"Changes Requested\"\nindicating that I expect all those patches to be reposted when you are ready.\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=verge.net.au header.i=@verge.net.au\n\theader.b=\"NuSusY4w\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xtn485d0dz9t2f\n\tfor ;\n\tFri, 15 Sep 2017 17:25:28 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1750865AbdIOHZ1 (ORCPT\n\t);\n\tFri, 15 Sep 2017 03:25:27 -0400","from kirsty.vergenet.net ([202.4.237.240]:52684 \"EHLO\n\tkirsty.vergenet.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750838AbdIOHZ0 (ORCPT\n\t); Fri, 15 Sep 2017 03:25:26 -0400","from penelope.horms.nl (unknown [217.111.208.18])\n\tby kirsty.vergenet.net (Postfix) with ESMTPA id 4EBDC25B73F;\n\tFri, 15 Sep 2017 17:25:24 +1000 (AEST)","by penelope.horms.nl (Postfix, from userid 7100)\n\tid 4389EE23462; Fri, 15 Sep 2017 03:25:05 -0400 (EDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=simple/simple; d=verge.net.au; s=mail; \n\tt=1505460324; bh=ztyk4ahMJI9sOrNTSsBv6spxjaxjgBVkVk9PB0jmaWw=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=NuSusY4w68Ziy0OBNuy9Gb5nVbEzvwZbEwW+JRIbsx66iUMtbPrCvlfeS3E8n/rZe\n\tPmIqXbAjQh2e3P5mfQobGPpLjmcG8418QKoYI9cDI+ynuBxYvjmIJXFhYcZV9uZ9u2\n\tnp4UrvdvEZ2JzJ94ZM70oFXViuQUnPSYRWiLDEzg=","Date":"Fri, 15 Sep 2017 09:25:05 +0200","From":"Simon Horman ","To":"Geert Uytterhoeven ","Cc":"Sergei Shtylyov ,\n\tRob Herring , Mark Rutland ,\n\t\"devicetree@vger.kernel.org\" ,\n\tLinux-Renesas ,\n\tCatalin Marinas ,\n\tWill Deacon , Magnus Damm ,\n\tVladimir Barinov ,\n\t\"linux-arm-kernel@lists.infradead.org\" \n\t","Subject":"Re: [PATCH 04/11] soc: renesas: rcar-sysc: add R8A77970 support","Message-ID":"<20170915072504.GA3924@verge.net.au>","References":"<20170912210518.203740259@cogentembedded.com>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"","Organisation":"Horms Solutions BV","User-Agent":"Mutt/1.5.23 (2014-03-12)","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}}]