[{"id":1771212,"web_url":"http://patchwork.ozlabs.org/comment/1771212/","msgid":"<397365fd-c1b6-1d85-e7f6-2a1d91d33e58@gmail.com>","list_archive_url":null,"date":"2017-09-19T16:55:18","subject":"Re: [ovs-dev] [merge native tunneling and patch port 1/7]\n\tofproto-dpif: Unfreeze within clone","submitter":{"id":69140,"url":"http://patchwork.ozlabs.org/api/people/69140/","name":"Gregory Rose","email":"gvrose8192@gmail.com"},"content":"On 09/12/2017 12:49 PM, Andy Zhou wrote:\n> When translating actions within open flow clone, actions generated\n> by finish_freezeing() should also be enclosed within the datapath\n> clone netlink encoding.\n> \n> Signed-off-by: Andy Zhou \n\nAndy,\n\nI am reviewing and testing your patches. I have applied them to my private github repository\non a branch named test-813027-35.\n\nhttps://github.com/gvrose8192/ovs-experimental/tree/test-813027-35\n\nHowever, the Travis 'TESTSUITE=1 KERNEL=3.16.46 build fails:\n\nhttps://travis-ci.org/gvrose8192/ovs-experimental/jobs/277364409\n\nHave you noticed this as well?\n\nThe current master branch does not have the same error.\n\nThanks,\n\n- Greg\n\n\n> ---\n> ofproto/ofproto-dpif-xlate.c | 9 +++++++++\n> 1 file changed, 9 insertions(+)\n> \n> diff --git a/ofproto/ofproto-dpif-xlate.c b/ofproto/ofproto-dpif-xlate.c\n> index 9e1f837cb23e..e5ad832d7c47 100644\n> --- a/ofproto/ofproto-dpif-xlate.c\n> +++ b/ofproto/ofproto-dpif-xlate.c\n> @@ -5353,6 +5353,9 @@ compose_clone(struct xlate_ctx *ctx, const struct ofpact_nest *oc)\n> if (reversible_actions(oc->actions, oc_actions_len)) {\n> old_flow = ctx->xin->flow;\n> do_xlate_actions(oc->actions, oc_actions_len, ctx);\n> + if (ctx->freezing) {\n> + finish_freezing(ctx);\n> + }\n> goto xlate_done;\n> }\n> \n> @@ -5372,6 +5375,9 @@ compose_clone(struct xlate_ctx *ctx, const struct ofpact_nest *oc)\n> offset = nl_msg_start_nested(ctx->odp_actions, OVS_ACTION_ATTR_CLONE);\n> ac_offset = ctx->odp_actions->size;\n> do_xlate_actions(oc->actions, oc_actions_len, ctx);\n> + if (ctx->freezing) {\n> + finish_freezing(ctx);\n> + }\n> nl_msg_end_non_empty_nested(ctx->odp_actions, offset);\n> goto dp_clone_done;\n> }\n> @@ -5382,6 +5388,9 @@ compose_clone(struct xlate_ctx *ctx, const struct ofpact_nest *oc)\n> ac_offset = nl_msg_start_nested(ctx->odp_actions,\n> OVS_SAMPLE_ATTR_ACTIONS);\n> do_xlate_actions(oc->actions, oc_actions_len, ctx);\n> + if (ctx->freezing) {\n> + finish_freezing(ctx);\n> + }\n> if (nl_msg_end_non_empty_nested(ctx->odp_actions, ac_offset)) {\n> nl_msg_cancel_nested(ctx->odp_actions, offset);\n> } else {\n>","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"ogmbr0jK\"; dkim-atps=neutral"],"Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xxTWx6Z6pz9sPs\n\tfor ;\n\tWed, 20 Sep 2017 02:55:25 +1000 (AEST)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id 49F6B9F0;\n\tTue, 19 Sep 2017 16:55:23 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id 3873D5A7\n\tfor ; Tue, 19 Sep 2017 16:55:22 +0000 (UTC)","from mail-pg0-f65.google.com (mail-pg0-f65.google.com\n\t[74.125.83.65])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id BDF8F174\n\tfor ; Tue, 19 Sep 2017 16:55:21 +0000 (UTC)","by mail-pg0-f65.google.com with SMTP id v5so110216pgn.4\n\tfor ; Tue, 19 Sep 2017 09:55:21 -0700 (PDT)","from gizo.bigblue.kilchis.com (67-5-132-83.ptld.qwest.net.\n\t[67.5.132.83]) by smtp.gmail.com with ESMTPSA id\n\tt19sm3705139pfa.73.2017.09.19.09.55.19\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 19 Sep 2017 09:55:19 -0700 (PDT)"],"X-Greylist":"whitelisted by SQLgrey-1.7.6","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=subject:to:references:from:message-id:date:user-agent:mime-version\n\t:in-reply-to:content-language:content-transfer-encoding;\n\tbh=4hYibLDLZ0/1Oe+suUGusrSQv+YHjInhD8H4JNz4Pfg=;\n\tb=ogmbr0jK2OYgmN+x6+aFO9FX4SmzKl0gp1YGW8nturWFagCM7985fxGaZnRcAUbPSW\n\t9ZfzNBJQjett68IQ6o7RlegIqxQ4brD+wtj5gA7ldfafSLnGkgdERjOCewPcafkB2TP0\n\twa4Cu4JjjY/W34hH9oVWoCfWLT3N/j7RHQnAQ9fA/FeVgsGpIzppxQ1LnDJnxV4crhJe\n\tC7/HoHyq/oD5qgEgScuwkJViF1nVDIBhgXv+fG4bsej8QLjy6HWQ/Ti1CsnYDx6PHhs3\n\tc/xYxXVrTppTxiKwQ8muK1uIY/LJ3zUNc0nidWwyqDUQkmw8C0yuWV2eIwFq9+CwDHLq\n\t4wBw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=4hYibLDLZ0/1Oe+suUGusrSQv+YHjInhD8H4JNz4Pfg=;\n\tb=bOheK3R3M4sblnhFsYrtDyi8aUMPXcCGw1zLqlUY27qLPkfDrom9NVxTalz+rx0VI+\n\tDiHJrGDf2WKPTxRtFaCfL56EA+1SrpSxxA/XfsshU2oqHreKw4nRiyJKpSV1egLYX0eH\n\t3j3hqf+lJnMd33QsCjYZUaLTAJKO/wiWk33yuTLTUD+z8KIqfwUnbRFVD/wo+zkTSDjI\n\tH03CF6yP52nw+26AcKMYQobYyLbctI9VCgQ4XkW8Ir1V/ick4C2XbqCDDzDkVJ67YhAU\n\tGyBwe4CC221lKMsHtwmotcHOD6qW5jNd/TSpowBlBcgzyf+/Jt44/NH5vtD1h4WehpH8\n\tqUfg==","X-Gm-Message-State":"AHPjjUh/siqt7OMZh8YXbmd6kxqYsWvr5RxmQopjeNYfnhWFjRUGqtoW\n\tV0dgxFBXNVCLp75BpfHgHaGJ5DsD","X-Google-Smtp-Source":"AOwi7QDVapXvI6md9JtT0/N+ctY79SmGsH+/a7hkzr3mm860yRXgp8P8kh1N9/GPStQC4HHFNb6sfA==","X-Received":"by 10.99.117.30 with SMTP id q30mr1881124pgc.75.1505840120818;\n\tTue, 19 Sep 2017 09:55:20 -0700 (PDT)","To":"Andy Zhou , dev@openvswitch.org","References":"<1505245749-3402-1-git-send-email-azhou@ovn.org>","From":"Greg Rose ","Message-ID":"<397365fd-c1b6-1d85-e7f6-2a1d91d33e58@gmail.com>","Date":"Tue, 19 Sep 2017 09:55:18 -0700","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.1.0","MIME-Version":"1.0","In-Reply-To":"<1505245749-3402-1-git-send-email-azhou@ovn.org>","Content-Language":"en-US","X-Spam-Status":"No, score=0.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tDKIM_VALID_AU, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM,\n\tRCVD_IN_DNSWL_NONE, \n\tRCVD_IN_SORBS_SPAM autolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Subject":"Re: [ovs-dev] [merge native tunneling and patch port 1/7]\n\tofproto-dpif: Unfreeze within clone","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Transfer-Encoding":"7bit","Content-Type":"text/plain; charset=\"us-ascii\"; Format=\"flowed\"","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"}},{"id":1771365,"web_url":"http://patchwork.ozlabs.org/comment/1771365/","msgid":"","list_archive_url":null,"date":"2017-09-19T20:26:03","subject":"Re: [ovs-dev] [merge native tunneling and patch port 1/7]\n\tofproto-dpif: Unfreeze within clone","submitter":{"id":67699,"url":"http://patchwork.ozlabs.org/api/people/67699/","name":"Andy Zhou","email":"azhou@ovn.org"},"content":"On Tue, Sep 19, 2017 at 9:55 AM, Greg Rose wrote:\n> On 09/12/2017 12:49 PM, Andy Zhou wrote:\n>>\n>> When translating actions within open flow clone, actions generated\n>> by finish_freezeing() should also be enclosed within the datapath\n>> clone netlink encoding.\n>>\n>> Signed-off-by: Andy Zhou \n>\n>\n> Andy,\n>\n> I am reviewing and testing your patches. I have applied them to my private\n> github repository\n> on a branch named test-813027-35.\n>\n> https://github.com/gvrose8192/ovs-experimental/tree/test-813027-35\n>\n> However, the Travis 'TESTSUITE=1 KERNEL=3.16.46 build fails:\n>\n> https://travis-ci.org/gvrose8192/ovs-experimental/jobs/277364409\n>\n> Have you noticed this as well?\n\nNo. It passed my local test, and passed travis test from my private\nbranch (just rebased this morning)\n\nhttps://github.com/azhou-nicira/ovs-review/tree/patch_port\n\nhttps://travis-ci.org/azhou-nicira/ovs-review/builds/277412765\n\n(The --disable-ssl build is slow for some reason, same as master).\n\nMay be this is caused by travis running slow for some reason?\n\nDid your local test pass?","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xxZCx1Pz2z9s81\n\tfor ;\n\tWed, 20 Sep 2017 06:26:52 +1000 (AEST)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id E3D9897A;\n\tTue, 19 Sep 2017 20:26:49 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id 3D7C994F\n\tfor ; Tue, 19 Sep 2017 20:26:48 +0000 (UTC)","from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net\n\t[217.70.183.194])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id BF741442\n\tfor ; Tue, 19 Sep 2017 20:26:47 +0000 (UTC)","from mail-pf0-f174.google.com (mail-pf0-f174.google.com\n\t[209.85.192.174]) (Authenticated sender: azhou@ovn.org)\n\tby relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 3DC70C5A4E\n\tfor ; Tue, 19 Sep 2017 22:26:46 +0200 (CEST)","by mail-pf0-f174.google.com with SMTP id m63so389492pfk.7\n\tfor ; Tue, 19 Sep 2017 13:26:45 -0700 (PDT)","by 10.100.189.15 with HTTP; Tue, 19 Sep 2017 13:26:03 -0700 (PDT)"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","X-Originating-IP":"209.85.192.174","X-Gm-Message-State":"AHPjjUiW0nxTygXH9VLn9kj6fChB6adiYoovq4hOTzFuR4avQyrs/Ii0\n\tFwpQqtcLR7tUdsVPsiLrRIgXsD3Tlb/8hifiAlo=","X-Google-Smtp-Source":"AOwi7QB4Kz51p+M2NUA1cVWsorQiRhi4QX4AIytvtLhO3kdyYMuUk4MfcjBXFtnQbiXz7F3ogDMeyDx3li7HaN4a4jA=","X-Received":"by 10.99.95.131 with SMTP id t125mr2430958pgb.172.1505852804484; \n\tTue, 19 Sep 2017 13:26:44 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<397365fd-c1b6-1d85-e7f6-2a1d91d33e58@gmail.com>","References":"<1505245749-3402-1-git-send-email-azhou@ovn.org>\n\t<397365fd-c1b6-1d85-e7f6-2a1d91d33e58@gmail.com>","From":"Andy Zhou ","Date":"Tue, 19 Sep 2017 13:26:03 -0700","X-Gmail-Original-Message-ID":"","Message-ID":"","To":"Greg Rose ","X-Spam-Status":"No, score=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW\n\tautolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Cc":"\"\" ","Subject":"Re: [ovs-dev] [merge native tunneling and patch port 1/7]\n\tofproto-dpif: Unfreeze within clone","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"}},{"id":1771386,"web_url":"http://patchwork.ozlabs.org/comment/1771386/","msgid":"<00017b7f-fbdb-ab9e-33b7-aea55cf9ef14@gmail.com>","list_archive_url":null,"date":"2017-09-19T20:56:28","subject":"Re: [ovs-dev] [merge native tunneling and patch port 1/7]\n\tofproto-dpif: Unfreeze within clone","submitter":{"id":69140,"url":"http://patchwork.ozlabs.org/api/people/69140/","name":"Gregory Rose","email":"gvrose8192@gmail.com"},"content":"On 09/19/2017 01:26 PM, Andy Zhou wrote:\n> On Tue, Sep 19, 2017 at 9:55 AM, Greg Rose wrote:\n>> On 09/12/2017 12:49 PM, Andy Zhou wrote:\n>>>\n>>> When translating actions within open flow clone, actions generated\n>>> by finish_freezeing() should also be enclosed within the datapath\n>>> clone netlink encoding.\n>>>\n>>> Signed-off-by: Andy Zhou \n>>\n>>\n>> Andy,\n>>\n>> I am reviewing and testing your patches. I have applied them to my private\n>> github repository\n>> on a branch named test-813027-35.\n>>\n>> https://github.com/gvrose8192/ovs-experimental/tree/test-813027-35\n>>\n>> However, the Travis 'TESTSUITE=1 KERNEL=3.16.46 build fails:\n>>\n>> https://travis-ci.org/gvrose8192/ovs-experimental/jobs/277364409\n>>\n>> Have you noticed this as well?\n> \n> No. It passed my local test, and passed travis test from my private\n> branch (just rebased this morning)\n> \n> https://github.com/azhou-nicira/ovs-review/tree/patch_port\n> \n> https://travis-ci.org/azhou-nicira/ovs-review/builds/277412765\n> \n> (The --disable-ssl build is slow for some reason, same as master).\n> \n> May be this is caused by travis running slow for some reason?\n> \n> Did your local test pass?\n> \n\nYes, I just tried on a VM running Centos 7.3 with the 4.9 kernel and it passed there.\n\n/shrug?\n\nOK, I'll continue with review then.\n\nThanks!\n\n- Greg","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"l+eU1TRk\"; dkim-atps=neutral"],"Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xxZtF4yynz9ryv\n\tfor ;\n\tWed, 20 Sep 2017 06:56:36 +1000 (AEST)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id 2B2EFB7D;\n\tTue, 19 Sep 2017 20:56:33 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id 82EC8B47\n\tfor ; Tue, 19 Sep 2017 20:56:32 +0000 (UTC)","from mail-pg0-f65.google.com (mail-pg0-f65.google.com\n\t[74.125.83.65])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id 04B2C20D\n\tfor ; Tue, 19 Sep 2017 20:56:31 +0000 (UTC)","by mail-pg0-f65.google.com with SMTP id j16so437068pga.2\n\tfor ; Tue, 19 Sep 2017 13:56:31 -0700 (PDT)","from gizo.bigblue.kilchis.com (67-5-132-83.ptld.qwest.net.\n\t[67.5.132.83]) by smtp.gmail.com with ESMTPSA id\n\ts62sm4541266pfe.91.2017.09.19.13.56.29\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 19 Sep 2017 13:56:29 -0700 (PDT)"],"X-Greylist":"whitelisted by SQLgrey-1.7.6","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=cC9x8LBRzhfO4HmO+1bG7gNLTMlhOyMXeP7jDu86fD4=;\n\tb=l+eU1TRk5wUi4N2ngCRS0TSj/67tJnmVR5gfjMq0/XfmR/rXlC5uNTAs1H3xs2So11\n\t1edeXVqA6Tv6SAOUkvSpG3mMbL0Jl619P3xe/MZ0wX+Zw+poeIJgUm1N6mSBlwV0wp1h\n\tXTW4swXx/jcmjkLxpVUYMtOG49xp4008E7ZDwo2D3VrKZdTxeXppwAVhdKimVbQ4DlGS\n\tGcaKsVf2GVunTeaVuFQ0NzYF/99T1oA2EcIb9OW+IySXsPjtaQTz3aPdDUCyhDkP3wVp\n\tz4VeagdEQUajVZ6wvLSj1Z0jcmfHSeq6andmx/CwtayW3KAXE8XH3wmuX+OYX2HTrOSI\n\tBkqw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=cC9x8LBRzhfO4HmO+1bG7gNLTMlhOyMXeP7jDu86fD4=;\n\tb=awmPH96MF0CWfxdsCjUF3T6zPkSVaHW7zPTmeTydRjNkV1tuJW5+IY8LNesByV+xnl\n\tPf3bYTRh/v5fWy9zdol9lox2cisj9+GylkbjvcnjOOH0RaVMxCse3c55qOeMvjhDJjV0\n\tG9G9yKdWZniwjeqBTfpqFdXgmkLR4C8LNlMH6JDKXou9EJO4DR3ZSLftX161btoWrLgo\n\tFYCGSGHTJxwruQgYPGZg19KmKZJAC3CyLCsj/0EBc2Mgo5LVXNF4OvuzOYH6qn0qundz\n\tsyvUKoCl+PwJrQCIbJ7BsyxBhOsWCf1X+rh60FFXXb07FYmbt1jm57m+fa5Tw3uIBX3u\n\tLZSw==","X-Gm-Message-State":"AHPjjUgu3PiWs40uncQbx4i2dKWf4Izx7K35Otp0ungs78TMgcYCp5EI\n\tTgkmmBb4QH4xMl4a9b0LzCnfzgZ0","X-Google-Smtp-Source":"AOwi7QBXNwCc8WhgD6oHgqdyMQ/EtjLUf3rUlmfZ7f8p7FuLj5da3z6PRH6EIPpzs1zfG0XhNad++A==","X-Received":"by 10.99.123.16 with SMTP id w16mr2482449pgc.396.1505854590955; \n\tTue, 19 Sep 2017 13:56:30 -0700 (PDT)","To":"Andy Zhou ","References":"<1505245749-3402-1-git-send-email-azhou@ovn.org>\n\t<397365fd-c1b6-1d85-e7f6-2a1d91d33e58@gmail.com>\n\t","From":"Greg Rose ","Message-ID":"<00017b7f-fbdb-ab9e-33b7-aea55cf9ef14@gmail.com>","Date":"Tue, 19 Sep 2017 13:56:28 -0700","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.1.0","MIME-Version":"1.0","In-Reply-To":"","Content-Language":"en-US","X-Spam-Status":"No, score=0.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tDKIM_VALID_AU, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM,\n\tRCVD_IN_DNSWL_NONE, \n\tRCVD_IN_SORBS_SPAM autolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Cc":"\"\" ","Subject":"Re: [ovs-dev] [merge native tunneling and patch port 1/7]\n\tofproto-dpif: Unfreeze within clone","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Transfer-Encoding":"7bit","Content-Type":"text/plain; charset=\"us-ascii\"; Format=\"flowed\"","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"}},{"id":1771452,"web_url":"http://patchwork.ozlabs.org/comment/1771452/","msgid":"","list_archive_url":null,"date":"2017-09-19T23:11:45","subject":"Re: [ovs-dev] [merge native tunneling and patch port 1/7]\n\tofproto-dpif: Unfreeze within clone","submitter":{"id":67699,"url":"http://patchwork.ozlabs.org/api/people/67699/","name":"Andy Zhou","email":"azhou@ovn.org"},"content":"On Tue, Sep 19, 2017 at 1:56 PM, Greg Rose wrote:\n> On 09/19/2017 01:26 PM, Andy Zhou wrote:\n>>\n>> On Tue, Sep 19, 2017 at 9:55 AM, Greg Rose wrote:\n>>>\n>>> On 09/12/2017 12:49 PM, Andy Zhou wrote:\n>>>>\n>>>>\n>>>> When translating actions within open flow clone, actions generated\n>>>> by finish_freezeing() should also be enclosed within the datapath\n>>>> clone netlink encoding.\n>>>>\n>>>> Signed-off-by: Andy Zhou \n>>>\n>>>\n>>>\n>>> Andy,\n>>>\n>>> I am reviewing and testing your patches. I have applied them to my\n>>> private\n>>> github repository\n>>> on a branch named test-813027-35.\n>>>\n>>> https://github.com/gvrose8192/ovs-experimental/tree/test-813027-35\n>>>\n>>> However, the Travis 'TESTSUITE=1 KERNEL=3.16.46 build fails:\n>>>\n>>> https://travis-ci.org/gvrose8192/ovs-experimental/jobs/277364409\n>>>\n>>> Have you noticed this as well?\n>>\n>>\n>> No. It passed my local test, and passed travis test from my private\n>> branch (just rebased this morning)\n>>\n>> https://github.com/azhou-nicira/ovs-review/tree/patch_port\n>>\n>> https://travis-ci.org/azhou-nicira/ovs-review/builds/277412765\n>>\n>> (The --disable-ssl build is slow for some reason, same as master).\n>>\n>> May be this is caused by travis running slow for some reason?\n>>\n>> Did your local test pass?\n>>\n>\n> Yes, I just tried on a VM running Centos 7.3 with the 4.9 kernel and it\n> passed there.\n>\n> /shrug?\n>\n> OK, I'll continue with review then.\n>\n> Thanks!\n>\n> - Greg\n\nFWIW. the --disable-ssl build finally passed. The total build/test\ntime is 4hr 42min.\nTravis CI is definitely slow today.","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xxdv65mZNz9s8J\n\tfor ;\n\tWed, 20 Sep 2017 09:12:32 +1000 (AEST)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id F1BCD9E8;\n\tTue, 19 Sep 2017 23:12:30 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id 0D67292F\n\tfor ; Tue, 19 Sep 2017 23:12:30 +0000 (UTC)","from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net\n\t[217.70.183.195])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id 80AC3159\n\tfor ; Tue, 19 Sep 2017 23:12:29 +0000 (UTC)","from mail-pf0-f178.google.com (mail-pf0-f178.google.com\n\t[209.85.192.178]) (Authenticated sender: azhou@ovn.org)\n\tby relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 30B32A80CF\n\tfor ; Wed, 20 Sep 2017 01:12:26 +0200 (CEST)","by mail-pf0-f178.google.com with SMTP id l188so584126pfc.6\n\tfor ; Tue, 19 Sep 2017 16:12:26 -0700 (PDT)","by 10.100.189.15 with HTTP; Tue, 19 Sep 2017 16:11:45 -0700 (PDT)"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","X-Originating-IP":"209.85.192.178","X-Gm-Message-State":"AHPjjUiK3owGyZeznudUIUCinWxB2dL1rxAsGB+JTONYHfAdJ74CwmZF\n\tTmUmT2cZnajnFTs8257aSm0pLab+Tm/9MdCSdF8=","X-Google-Smtp-Source":"AOwi7QABefQEN6fj5lq6iVaEjePHVR9ZUfssbCemZS1tF3ntJfZML+a43dkaXl9Hb6GGv9x6rrsUytYseLk8nNs0ocw=","X-Received":"by 10.99.49.205 with SMTP id x196mr202164pgx.121.1505862745427; \n\tTue, 19 Sep 2017 16:12:25 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<00017b7f-fbdb-ab9e-33b7-aea55cf9ef14@gmail.com>","References":"<1505245749-3402-1-git-send-email-azhou@ovn.org>\n\t<397365fd-c1b6-1d85-e7f6-2a1d91d33e58@gmail.com>\n\t\n\t<00017b7f-fbdb-ab9e-33b7-aea55cf9ef14@gmail.com>","From":"Andy Zhou ","Date":"Tue, 19 Sep 2017 16:11:45 -0700","X-Gmail-Original-Message-ID":"","Message-ID":"","To":"Greg Rose ","X-Spam-Status":"No, score=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW\n\tautolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Cc":"\"\" ","Subject":"Re: [ovs-dev] [merge native tunneling and patch port 1/7]\n\tofproto-dpif: Unfreeze within clone","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"}},{"id":1771462,"web_url":"http://patchwork.ozlabs.org/comment/1771462/","msgid":"<6b5ddf41-b872-d6d0-6b0c-6a4f4aff00c0@gmail.com>","list_archive_url":null,"date":"2017-09-19T23:31:33","subject":"Re: [ovs-dev] [merge native tunneling and patch port 1/7]\n\tofproto-dpif: Unfreeze within clone","submitter":{"id":69140,"url":"http://patchwork.ozlabs.org/api/people/69140/","name":"Gregory Rose","email":"gvrose8192@gmail.com"},"content":"On 09/19/2017 04:11 PM, Andy Zhou wrote:\n> On Tue, Sep 19, 2017 at 1:56 PM, Greg Rose wrote:\n>> On 09/19/2017 01:26 PM, Andy Zhou wrote:\n>>>\n>>\n>> Yes, I just tried on a VM running Centos 7.3 with the 4.9 kernel and it\n>> passed there.\n>>\n>> /shrug?\n>>\n>> OK, I'll continue with review then.\n>>\n>> Thanks!\n>>\n>> - Greg\n> \n> FWIW. the --disable-ssl build finally passed. The total build/test\n> time is 4hr 42min.\n> Travis CI is definitely slow today.\n> \n\nWell, it is free. :^)\n\nThanks,\n\n- Greg","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"f/H+WcYo\"; dkim-atps=neutral"],"Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xxfK96ngKz9sPr\n\tfor ;\n\tWed, 20 Sep 2017 09:31:41 +1000 (AEST)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id 0BA99D3D;\n\tTue, 19 Sep 2017 23:31:39 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id F0CD7C14\n\tfor ; Tue, 19 Sep 2017 23:31:37 +0000 (UTC)","from mail-pg0-f66.google.com (mail-pg0-f66.google.com\n\t[74.125.83.66])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id B584B157\n\tfor ; Tue, 19 Sep 2017 23:31:37 +0000 (UTC)","by mail-pg0-f66.google.com with SMTP id m30so622091pgn.5\n\tfor ; Tue, 19 Sep 2017 16:31:37 -0700 (PDT)","from gizo.bigblue.kilchis.com (67-5-132-83.ptld.qwest.net.\n\t[67.5.132.83]) by smtp.gmail.com with ESMTPSA id\n\tv8sm3873555pgs.9.2017.09.19.16.31.34\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 19 Sep 2017 16:31:35 -0700 (PDT)"],"X-Greylist":"whitelisted by SQLgrey-1.7.6","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=b3r+g1JjnAL2P+nvOV3Q3zRqaFuRHfQEjmhhjR7z30Y=;\n\tb=f/H+WcYo4ZBkOTXy+7oypoVMVfKunPa+Ze4HeJsZKDJjkT7F0/Kgs+e15WPmGYbvLx\n\tzfn8bNDU3cyZffNoB958JQOJceFM2ZDjUDsIUfAZCZ/lfj0vbqPcMKK565eHlJjdOKxN\n\tc3A+0kipanFV2dl6uhF7G6YC62uYxYrbfgNveYCTWdjgId4q7C9Ae/QpGppc/9YHiJBe\n\t12vWb0/X+EIo+/uCwHr9gfPaIFYidJL4TcksN1FZQKCMIh7XI9CMVyAXe4AmEHy1WG/N\n\tL5mUoCLlpgSoogzPVl6i/8wpvw8m+3o2ywfxW8EtSkiunRSvmzXibbp8f4ynD/yLFYCF\n\t7RVQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=b3r+g1JjnAL2P+nvOV3Q3zRqaFuRHfQEjmhhjR7z30Y=;\n\tb=X9VW7Q1p3XrORJRez9kEdxzgS3bt3LuXaW7yVQN2qZa2x+257irkHCLPqGRYz8SZwo\n\tlARwolxzjqZ2WekmQ3N6ENR4Z5fPvcIVOw5qjTwOS4nNxn2qAtIcIvLGsw7HPF1tYjwp\n\tupfp0EZTJ5HIo4UWTqWFR7u0oP1JOK3eR/oBzf3AW9lHeiruFkT/do3OLgfvOd+YRRoD\n\tw7ZnsVPAOR637qsxDRWw6hZTngj/Uy16b2WXQunWupdcdld/PzhmrV36uqHV8lN2U84f\n\tgC0xki680GUz7bGUH7alC/rPSflZny/IQU1Vv8pBjt2lH71xBbGrF0jX8FR89e/ENK3B\n\ta4lg==","X-Gm-Message-State":"AHPjjUgNPmO6nkJCM0y5f9y7myJCKvoag0e8SSO4r20gZgLFHcdVp+Vy\n\tqDEDdQGCNUPKRsUIEMMcUYqTheAh","X-Google-Smtp-Source":"AOwi7QC8KA7KWi/0ItNYwHapKae3ZgfR7OEcX6J+xFQoKXuIc1OT4lWBj07LGhGokgsUV8oFuwAJ3Q==","X-Received":"by 10.99.42.11 with SMTP id q11mr237554pgq.7.1505863896861;\n\tTue, 19 Sep 2017 16:31:36 -0700 (PDT)","To":"Andy Zhou ","References":"<1505245749-3402-1-git-send-email-azhou@ovn.org>\n\t<397365fd-c1b6-1d85-e7f6-2a1d91d33e58@gmail.com>\n\t\n\t<00017b7f-fbdb-ab9e-33b7-aea55cf9ef14@gmail.com>\n\t","From":"Greg Rose ","Message-ID":"<6b5ddf41-b872-d6d0-6b0c-6a4f4aff00c0@gmail.com>","Date":"Tue, 19 Sep 2017 16:31:33 -0700","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.1.0","MIME-Version":"1.0","In-Reply-To":"","Content-Language":"en-US","X-Spam-Status":"No, score=0.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tDKIM_VALID_AU, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM,\n\tRCVD_IN_DNSWL_NONE, \n\tRCVD_IN_SORBS_SPAM autolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Cc":"\"\" ","Subject":"Re: [ovs-dev] [merge native tunneling and patch port 1/7]\n\tofproto-dpif: Unfreeze within clone","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Transfer-Encoding":"7bit","Content-Type":"text/plain; charset=\"us-ascii\"; Format=\"flowed\"","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"}},{"id":1772986,"web_url":"http://patchwork.ozlabs.org/comment/1772986/","msgid":"<06e00a78-b648-e216-178f-23cf567b3ef6@gmail.com>","list_archive_url":null,"date":"2017-09-21T16:44:30","subject":"Re: [ovs-dev] [merge native tunneling and patch port 1/7]\n\tofproto-dpif: Unfreeze within clone","submitter":{"id":69140,"url":"http://patchwork.ozlabs.org/api/people/69140/","name":"Gregory Rose","email":"gvrose8192@gmail.com"},"content":"On 09/12/2017 12:49 PM, Andy Zhou wrote:\n> When translating actions within open flow clone, actions generated\n> by finish_freezeing() should also be enclosed within the datapath\n> clone netlink encoding.\n> \n> Signed-off-by: Andy Zhou \n> ---\n> ofproto/ofproto-dpif-xlate.c | 9 +++++++++\n> 1 file changed, 9 insertions(+)\n> \n> diff --git a/ofproto/ofproto-dpif-xlate.c b/ofproto/ofproto-dpif-xlate.c\n> index 9e1f837cb23e..e5ad832d7c47 100644\n> --- a/ofproto/ofproto-dpif-xlate.c\n> +++ b/ofproto/ofproto-dpif-xlate.c\n> @@ -5353,6 +5353,9 @@ compose_clone(struct xlate_ctx *ctx, const struct ofpact_nest *oc)\n> if (reversible_actions(oc->actions, oc_actions_len)) {\n> old_flow = ctx->xin->flow;\n> do_xlate_actions(oc->actions, oc_actions_len, ctx);\n> + if (ctx->freezing) {\n> + finish_freezing(ctx);\n> + }\n> goto xlate_done;\n> }\n> \n> @@ -5372,6 +5375,9 @@ compose_clone(struct xlate_ctx *ctx, const struct ofpact_nest *oc)\n> offset = nl_msg_start_nested(ctx->odp_actions, OVS_ACTION_ATTR_CLONE);\n> ac_offset = ctx->odp_actions->size;\n> do_xlate_actions(oc->actions, oc_actions_len, ctx);\n> + if (ctx->freezing) {\n> + finish_freezing(ctx);\n> + }\n> nl_msg_end_non_empty_nested(ctx->odp_actions, offset);\n> goto dp_clone_done;\n> }\n> @@ -5382,6 +5388,9 @@ compose_clone(struct xlate_ctx *ctx, const struct ofpact_nest *oc)\n> ac_offset = nl_msg_start_nested(ctx->odp_actions,\n> OVS_SAMPLE_ATTR_ACTIONS);\n> do_xlate_actions(oc->actions, oc_actions_len, ctx);\n> + if (ctx->freezing) {\n> + finish_freezing(ctx);\n> + }\n> if (nl_msg_end_non_empty_nested(ctx->odp_actions, ac_offset)) {\n> nl_msg_cancel_nested(ctx->odp_actions, offset);\n> } else {\n> \n\nTested-by: Greg Rose \nReviewed-by: Greg Rose ","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"fIRISKUh\"; dkim-atps=neutral"],"Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xyjBd1yHxz9t4B\n\tfor ;\n\tFri, 22 Sep 2017 02:44:38 +1000 (AEST)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id 0E531AB7;\n\tThu, 21 Sep 2017 16:44:36 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id 779B89E8\n\tfor ; Thu, 21 Sep 2017 16:44:34 +0000 (UTC)","from mail-pg0-f66.google.com (mail-pg0-f66.google.com\n\t[74.125.83.66])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id 83AB4204\n\tfor ; Thu, 21 Sep 2017 16:44:33 +0000 (UTC)","by mail-pg0-f66.google.com with SMTP id v5so3706167pgn.4\n\tfor ; Thu, 21 Sep 2017 09:44:33 -0700 (PDT)","from gizo.bigblue.kilchis.com (67-5-132-83.ptld.qwest.net.\n\t[67.5.132.83]) by smtp.gmail.com with ESMTPSA id\n\tr11sm4339488pfg.180.2017.09.21.09.44.30\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tThu, 21 Sep 2017 09:44:31 -0700 (PDT)"],"X-Greylist":"whitelisted by SQLgrey-1.7.6","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=subject:to:references:from:message-id:date:user-agent:mime-version\n\t:in-reply-to:content-language:content-transfer-encoding;\n\tbh=bPQ/SXMT7K2X6aMwCPkCqqa6dHNLDNmsY3+4lW6QDcM=;\n\tb=fIRISKUh47iqCyWtebZOWRb+S1QMx9ErPptkX/SGqPbV5DwH/MoXIW8tWdfzVDh5Dv\n\ty5eE7Erb4pzmU2HZ09IeBCqJVvszeUF25E//GCEdQ4sVhigsb6byncN/xRPCx9LT9/Hq\n\t2aMiFuvcDxZapuAhF6WpoHqsGdxXVJ1fBEYeSnNYO676LkW/1xXs0QzqYEcFN8KEmt9b\n\tRZ8q7XVr+2NB10KapCI4c8zmncPi2ndz1llCF3RRryRE2Tl2HW9HN1/Wn/2B1KnUfTV1\n\tJ3/UqVBcImUZnIB3cMLYGi7nbvZBFMR/MOFBSJ/A4C7XqCuiN6ywCCc66M/Xch1xQCY+\n\tguxw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=bPQ/SXMT7K2X6aMwCPkCqqa6dHNLDNmsY3+4lW6QDcM=;\n\tb=Qu9EUc+vYr1R43jxzat3vWMJfTVEpUjupGeQJN0T7TGu91hZlokJkuogltnG7/PnIT\n\tBQbhG3yeLRVFttcN/YFbmbh/8uIY/jwMIi7jNT55aMcymeNlKM3QWHyWCKpdEjISwXHm\n\tbfPwtvek9wDHNZSyuC1s5JgGk33N8PKBK2whn1G9+IZDt6R4c4sVzOcAZ9wCjOypYQ8K\n\tZs71JgPL+QNld/Ly2qnsDPFidKI/yDnUFaKSaXUqUhsf+/leR/BAqp1SXIGIifeN8H2g\n\t1MIrP1kO+Fhviwlef8c23SCJfbnTxRKlvLgoUlR9GTfLrszl4cquRsqxygNux7sJmgVU\n\t6oIw==","X-Gm-Message-State":"AHPjjUj8g0b+1wNCqd5dTRGLrGtjXZTN5fWpNIsZoVEV3r3JzNlryr9G\n\tc6QPSUVquaimFInXhew9ZGtWQ/7t","X-Google-Smtp-Source":"AOwi7QCi8GUgF6cffDLGxOfK6DJ1OrQKhnxXsfOIks3PJddZZKC91ojHHFIr4eatk+BNpoKToJe+7A==","X-Received":"by 10.98.204.157 with SMTP id j29mr6346453pfk.100.1506012272699; \n\tThu, 21 Sep 2017 09:44:32 -0700 (PDT)","To":"Andy Zhou , dev@openvswitch.org","References":"<1505245749-3402-1-git-send-email-azhou@ovn.org>","From":"Greg Rose ","Message-ID":"<06e00a78-b648-e216-178f-23cf567b3ef6@gmail.com>","Date":"Thu, 21 Sep 2017 09:44:30 -0700","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.1.0","MIME-Version":"1.0","In-Reply-To":"<1505245749-3402-1-git-send-email-azhou@ovn.org>","Content-Language":"en-US","X-Spam-Status":"No, score=0.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tDKIM_VALID_AU, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM,\n\tRCVD_IN_DNSWL_NONE, \n\tRCVD_IN_SORBS_SPAM autolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Subject":"Re: [ovs-dev] [merge native tunneling and patch port 1/7]\n\tofproto-dpif: Unfreeze within clone","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Transfer-Encoding":"7bit","Content-Type":"text/plain; charset=\"us-ascii\"; Format=\"flowed\"","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"}},{"id":1776484,"web_url":"http://patchwork.ozlabs.org/comment/1776484/","msgid":"","list_archive_url":null,"date":"2017-09-27T17:10:04","subject":"Re: [ovs-dev] [merge native tunneling and patch port 1/7]\n\tofproto-dpif: Unfreeze within clone","submitter":{"id":67699,"url":"http://patchwork.ozlabs.org/api/people/67699/","name":"Andy Zhou","email":"azhou@ovn.org"},"content":"On Thu, Sep 21, 2017 at 9:44 AM, Greg Rose wrote:\n> On 09/12/2017 12:49 PM, Andy Zhou wrote:\n>>\n>> When translating actions within open flow clone, actions generated\n>> by finish_freezeing() should also be enclosed within the datapath\n>> clone netlink encoding.\n>>\n>> Signed-off-by: Andy Zhou \n>> ---\n>> ofproto/ofproto-dpif-xlate.c | 9 +++++++++\n>> 1 file changed, 9 insertions(+)\n>>\n>> diff --git a/ofproto/ofproto-dpif-xlate.c b/ofproto/ofproto-dpif-xlate.c\n>> index 9e1f837cb23e..e5ad832d7c47 100644\n>> --- a/ofproto/ofproto-dpif-xlate.c\n>> +++ b/ofproto/ofproto-dpif-xlate.c\n>> @@ -5353,6 +5353,9 @@ compose_clone(struct xlate_ctx *ctx, const struct\n>> ofpact_nest *oc)\n>> if (reversible_actions(oc->actions, oc_actions_len)) {\n>> old_flow = ctx->xin->flow;\n>> do_xlate_actions(oc->actions, oc_actions_len, ctx);\n>> + if (ctx->freezing) {\n>> + finish_freezing(ctx);\n>> + }\n>> goto xlate_done;\n>> }\n>> @@ -5372,6 +5375,9 @@ compose_clone(struct xlate_ctx *ctx, const struct\n>> ofpact_nest *oc)\n>> offset = nl_msg_start_nested(ctx->odp_actions,\n>> OVS_ACTION_ATTR_CLONE);\n>> ac_offset = ctx->odp_actions->size;\n>> do_xlate_actions(oc->actions, oc_actions_len, ctx);\n>> + if (ctx->freezing) {\n>> + finish_freezing(ctx);\n>> + }\n>> nl_msg_end_non_empty_nested(ctx->odp_actions, offset);\n>> goto dp_clone_done;\n>> }\n>> @@ -5382,6 +5388,9 @@ compose_clone(struct xlate_ctx *ctx, const struct\n>> ofpact_nest *oc)\n>> ac_offset = nl_msg_start_nested(ctx->odp_actions,\n>> OVS_SAMPLE_ATTR_ACTIONS);\n>> do_xlate_actions(oc->actions, oc_actions_len, ctx);\n>> + if (ctx->freezing) {\n>> + finish_freezing(ctx);\n>> + }\n>> if (nl_msg_end_non_empty_nested(ctx->odp_actions, ac_offset)) {\n>> nl_msg_cancel_nested(ctx->odp_actions, offset);\n>> } else {\n>>\n>\n> Tested-by: Greg Rose \n> Reviewed-by: Greg Rose \n\nThanks for the review Greg! I applied your suggestion on patch 6 and pushed\nthe series to master.","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y2PV731v9z9tXb\n\tfor ;\n\tThu, 28 Sep 2017 03:10:54 +1000 (AEST)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id 7777F9AF;\n\tWed, 27 Sep 2017 17:10:50 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id 012CE93E\n\tfor ; Wed, 27 Sep 2017 17:10:49 +0000 (UTC)","from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net\n\t[217.70.183.198])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id 788BA41D\n\tfor ; Wed, 27 Sep 2017 17:10:48 +0000 (UTC)","from mail-pg0-f46.google.com (mail-pg0-f46.google.com\n\t[74.125.83.46]) (Authenticated sender: azhou@ovn.org)\n\tby relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 090A6FB887\n\tfor ; Wed, 27 Sep 2017 19:10:46 +0200 (CEST)","by mail-pg0-f46.google.com with SMTP id d8so8120645pgt.4\n\tfor ; Wed, 27 Sep 2017 10:10:46 -0700 (PDT)","by 10.100.189.15 with HTTP; Wed, 27 Sep 2017 10:10:04 -0700 (PDT)"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","X-Originating-IP":"74.125.83.46","X-Gm-Message-State":"AHPjjUjxF8tfX3492wKl+Oq5CmaUzfiw5qw0/PkGy1k0ObZci5msJn81\n\teNy6uMuX4Aogb0a6+ciOMC2KudpbWPrhV2S35gM=","X-Google-Smtp-Source":"AOwi7QCuaaqmlZYONSK4xrnbC0nKAb+IAuzALLCnmgtCh4G3fu00sONVBWyDv+/DEu2nB0vCwKEiMv3omJGfd7uItEo=","X-Received":"by 10.99.121.135 with SMTP id u129mr1889483pgc.250.1506532245223;\n\tWed, 27 Sep 2017 10:10:45 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<06e00a78-b648-e216-178f-23cf567b3ef6@gmail.com>","References":"<1505245749-3402-1-git-send-email-azhou@ovn.org>\n\t<06e00a78-b648-e216-178f-23cf567b3ef6@gmail.com>","From":"Andy Zhou ","Date":"Wed, 27 Sep 2017 10:10:04 -0700","X-Gmail-Original-Message-ID":"","Message-ID":"","To":"Greg Rose ","X-Spam-Status":"No, score=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW\n\tautolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Cc":"\"\" ","Subject":"Re: [ovs-dev] [merge native tunneling and patch port 1/7]\n\tofproto-dpif: Unfreeze within clone","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"}}]