[{"id":1767779,"web_url":"http://patchwork.ozlabs.org/comment/1767779/","msgid":"","list_archive_url":null,"date":"2017-09-13T10:42:01","subject":"Re: [U-Boot] [PATCH v2 08/14] sunxi: provide default USB gadget\n\tsetup","submitter":{"id":70701,"url":"http://patchwork.ozlabs.org/api/people/70701/","name":"Lukasz Majewski","email":"lukma@denx.de"},"content":"On 09/12/2017 09:01 PM, Maxime Ripard wrote:\n> All the Allwinner boards use the same manufacturer, VID and PID for the\n> gadgets. Make them the defaults to remove some boilerplate from our\n> defconfigs.\n\nReviewed-by: Łukasz Majewski \n> \n> Reviewed-by: Simon Glass \n> Signed-off-by: Maxime Ripard \n> ---\n> configs/A13-OLinuXino_defconfig | 3 ---\n> configs/A20-OLinuXino-Lime2-eMMC_defconfig | 3 ---\n> configs/A20-OLinuXino-Lime2_defconfig | 3 ---\n> configs/CHIP_defconfig | 3 ---\n> configs/CHIP_pro_defconfig | 3 ---\n> configs/Cubietruck_defconfig | 3 ---\n> configs/Nintendo_NES_Classic_Edition_defconfig | 3 ---\n> configs/Sinlinx_SinA33_defconfig | 3 ---\n> configs/parrot_r16_defconfig | 3 ---\n> drivers/usb/gadget/Kconfig | 3 +++\n> 10 files changed, 3 insertions(+), 27 deletions(-)\n> \n> diff --git a/configs/A13-OLinuXino_defconfig b/configs/A13-OLinuXino_defconfig\n> index 2574018d8213..ae790164dff7 100644\n> --- a/configs/A13-OLinuXino_defconfig\n> +++ b/configs/A13-OLinuXino_defconfig\n> @@ -32,7 +32,4 @@ CONFIG_USB_EHCI_HCD=y\n> CONFIG_USB_MUSB_GADGET=y\n> CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y\n> CONFIG_USB_GADGET=y\n> -CONFIG_USB_GADGET_MANUFACTURER=\"Allwinner Technology\"\n> -CONFIG_USB_GADGET_VENDOR_NUM=0x1f3a\n> -CONFIG_USB_GADGET_PRODUCT_NUM=0x1010\n> CONFIG_USB_GADGET_DOWNLOAD=y\n> diff --git a/configs/A20-OLinuXino-Lime2-eMMC_defconfig b/configs/A20-OLinuXino-Lime2-eMMC_defconfig\n> index 5663a824e71b..b136af66b71f 100644\n> --- a/configs/A20-OLinuXino-Lime2-eMMC_defconfig\n> +++ b/configs/A20-OLinuXino-Lime2-eMMC_defconfig\n> @@ -34,7 +34,4 @@ CONFIG_USB_EHCI_HCD=y\n> CONFIG_USB_MUSB_GADGET=y\n> CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y\n> CONFIG_USB_GADGET=y\n> -CONFIG_USB_GADGET_MANUFACTURER=\"Allwinner Technology\"\n> -CONFIG_USB_GADGET_VENDOR_NUM=0x1f3a\n> -CONFIG_USB_GADGET_PRODUCT_NUM=0x1010\n> CONFIG_USB_GADGET_DOWNLOAD=y\n> diff --git a/configs/A20-OLinuXino-Lime2_defconfig b/configs/A20-OLinuXino-Lime2_defconfig\n> index 63d013293690..ebb435f30956 100644\n> --- a/configs/A20-OLinuXino-Lime2_defconfig\n> +++ b/configs/A20-OLinuXino-Lime2_defconfig\n> @@ -33,7 +33,4 @@ CONFIG_USB_EHCI_HCD=y\n> CONFIG_USB_MUSB_GADGET=y\n> CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y\n> CONFIG_USB_GADGET=y\n> -CONFIG_USB_GADGET_MANUFACTURER=\"Allwinner Technology\"\n> -CONFIG_USB_GADGET_VENDOR_NUM=0x1f3a\n> -CONFIG_USB_GADGET_PRODUCT_NUM=0x1010\n> CONFIG_USB_GADGET_DOWNLOAD=y\n> diff --git a/configs/CHIP_defconfig b/configs/CHIP_defconfig\n> index 278039c05573..7d50d0533dcd 100644\n> --- a/configs/CHIP_defconfig\n> +++ b/configs/CHIP_defconfig\n> @@ -23,8 +23,5 @@ CONFIG_USB_EHCI_HCD=y\n> CONFIG_USB_MUSB_GADGET=y\n> CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y\n> CONFIG_USB_GADGET=y\n> -CONFIG_USB_GADGET_MANUFACTURER=\"Allwinner Technology\"\n> -CONFIG_USB_GADGET_VENDOR_NUM=0x1f3a\n> -CONFIG_USB_GADGET_PRODUCT_NUM=0x1010\n> CONFIG_USB_GADGET_DOWNLOAD=y\n> CONFIG_OF_LIBFDT_OVERLAY=y\n> diff --git a/configs/CHIP_pro_defconfig b/configs/CHIP_pro_defconfig\n> index edbdefc69ddf..76daf477ec87 100644\n> --- a/configs/CHIP_pro_defconfig\n> +++ b/configs/CHIP_pro_defconfig\n> @@ -28,8 +28,5 @@ CONFIG_USB_EHCI_HCD=y\n> CONFIG_USB_MUSB_GADGET=y\n> CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y\n> CONFIG_USB_GADGET=y\n> -CONFIG_USB_GADGET_MANUFACTURER=\"Allwinner Technology\"\n> -CONFIG_USB_GADGET_VENDOR_NUM=0x1f3a\n> -CONFIG_USB_GADGET_PRODUCT_NUM=0x1010\n> CONFIG_USB_GADGET_DOWNLOAD=y\n> CONFIG_OF_LIBFDT_OVERLAY=y\n> diff --git a/configs/Cubietruck_defconfig b/configs/Cubietruck_defconfig\n> index 2d1753645b0f..1b2989d364f6 100644\n> --- a/configs/Cubietruck_defconfig\n> +++ b/configs/Cubietruck_defconfig\n> @@ -33,7 +33,4 @@ CONFIG_USB_EHCI_HCD=y\n> CONFIG_USB_MUSB_GADGET=y\n> CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y\n> CONFIG_USB_GADGET=y\n> -CONFIG_USB_GADGET_MANUFACTURER=\"Allwinner Technology\"\n> -CONFIG_USB_GADGET_VENDOR_NUM=0x1f3a\n> -CONFIG_USB_GADGET_PRODUCT_NUM=0x1010\n> CONFIG_USB_GADGET_DOWNLOAD=y\n> diff --git a/configs/Nintendo_NES_Classic_Edition_defconfig b/configs/Nintendo_NES_Classic_Edition_defconfig\n> index 99f7d30f150d..5986764a14b9 100644\n> --- a/configs/Nintendo_NES_Classic_Edition_defconfig\n> +++ b/configs/Nintendo_NES_Classic_Edition_defconfig\n> @@ -23,7 +23,4 @@ CONFIG_AXP_ELDO2_VOLT=1800\n> CONFIG_USB_MUSB_GADGET=y\n> CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y\n> CONFIG_USB_GADGET=y\n> -CONFIG_USB_GADGET_MANUFACTURER=\"Allwinner Technology\"\n> -CONFIG_USB_GADGET_VENDOR_NUM=0x1f3a\n> -CONFIG_USB_GADGET_PRODUCT_NUM=0x1010\n> CONFIG_USB_GADGET_DOWNLOAD=y\n> diff --git a/configs/Sinlinx_SinA33_defconfig b/configs/Sinlinx_SinA33_defconfig\n> index 8c5fc7587909..9299aedd6019 100644\n> --- a/configs/Sinlinx_SinA33_defconfig\n> +++ b/configs/Sinlinx_SinA33_defconfig\n> @@ -28,7 +28,4 @@ CONFIG_USB_EHCI_HCD=y\n> CONFIG_USB_MUSB_GADGET=y\n> CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y\n> CONFIG_USB_GADGET=y\n> -CONFIG_USB_GADGET_MANUFACTURER=\"Allwinner Technology\"\n> -CONFIG_USB_GADGET_VENDOR_NUM=0x1f3a\n> -CONFIG_USB_GADGET_PRODUCT_NUM=0x1010\n> CONFIG_USB_GADGET_DOWNLOAD=y\n> diff --git a/configs/parrot_r16_defconfig b/configs/parrot_r16_defconfig\n> index 4b70fc5687eb..57db9587fe77 100644\n> --- a/configs/parrot_r16_defconfig\n> +++ b/configs/parrot_r16_defconfig\n> @@ -24,7 +24,4 @@ CONFIG_USB_EHCI_HCD=y\n> CONFIG_USB_MUSB_GADGET=y\n> CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y\n> CONFIG_USB_GADGET=y\n> -CONFIG_USB_GADGET_MANUFACTURER=\"Allwinner Technology\"\n> -CONFIG_USB_GADGET_VENDOR_NUM=0x1f3a\n> -CONFIG_USB_GADGET_PRODUCT_NUM=0x1010\n> CONFIG_USB_GADGET_DOWNLOAD=y\n> diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig\n> index ef13bd2edb66..32b9a7e9fe49 100644\n> --- a/drivers/usb/gadget/Kconfig\n> +++ b/drivers/usb/gadget/Kconfig\n> @@ -38,12 +38,14 @@ if USB_GADGET\n> \n> config USB_GADGET_MANUFACTURER\n> \tstring \"Vendor name of the USB device\"\n> +\tdefault \"Allwinner Technology\" if ARCH_SUNXI\n> \thelp\n> \t Vendor name of the USB device emulated, reported to the host device.\n> \t This is usually either the manufacturer of the device or the SoC.\n> \n> config USB_GADGET_VENDOR_NUM\n> \thex \"Vendor ID of the USB device\"\n> +\tdefault 0x1f3a if ARCH_SUNXI\n> \thelp\n> \t Vendor ID of the USB device emulated, reported to the host device.\n> \t This is usually the board or SoC vendor's, unless you've registered\n> @@ -51,6 +53,7 @@ config USB_GADGET_VENDOR_NUM\n> \n> config USB_GADGET_PRODUCT_NUM\n> \thex \"Product ID of the USB device\"\n> +\tdefault 0x1010 if ARCH_SUNXI\n> \thelp\n> \t Product ID of the USB device emulated, reported to the host device.\n> \n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xsdXm2skQz9sPk\n\tfor ;\n\tWed, 13 Sep 2017 20:42:48 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 1ACE2C226EC; Wed, 13 Sep 2017 10:42:31 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 5950DC226FC;\n\tWed, 13 Sep 2017 10:42:28 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 9ACFAC226E5; Wed, 13 Sep 2017 10:42:06 +0000 (UTC)","from mail-out.m-online.net (mail-out.m-online.net [212.18.0.9])\n\tby lists.denx.de (Postfix) with ESMTPS id 4D48FC226F7\n\tfor ; Wed, 13 Sep 2017 10:42:05 +0000 (UTC)","from frontend03.mail.m-online.net (unknown [192.168.6.182])\n\tby mail-out.m-online.net (Postfix) with ESMTP id 3xsdWw5BCHz1qsDg;\n\tWed, 13 Sep 2017 12:42:04 +0200 (CEST)","from localhost (dynscan3.mnet-online.de [192.168.6.84])\n\tby mail.m-online.net (Postfix) with ESMTP id 3xsdWw443hz1qqkm;\n\tWed, 13 Sep 2017 12:42:04 +0200 (CEST)","from mail.mnet-online.de ([192.168.8.182])\n\tby localhost (dynscan3.mail.m-online.net [192.168.6.84]) (amavisd-new,\n\tport 10024)\n\twith ESMTP id PbIuTSRtnEri; Wed, 13 Sep 2017 12:42:02 +0200 (CEST)","from [192.168.2.222] (89-64-27-66.dynamic.chello.pl [89.64.27.66])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby mail.mnet-online.de (Postfix) with ESMTPSA;\n\tWed, 13 Sep 2017 12:42:02 +0200 (CEST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW,\n\tRCVD_IN_MSPIKE_H3,\n\tRCVD_IN_MSPIKE_WL autolearn=unavailable autolearn_force=no\n\tversion=3.4.0","X-Virus-Scanned":"amavisd-new at mnet-online.de","X-Auth-Info":"Tf5trrw43rEMECS+aA/Y4Mx6WWQVOc9FY/mhg/Je7PU=","To":"Maxime Ripard ,\n\tTom Rini , Jagan Teki ","References":"\n\t","From":"=?utf-8?q?=C5=81ukasz_Majewski?= ","Organization":"DENX","Message-ID":"","Date":"Wed, 13 Sep 2017 12:42:01 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"","Content-Language":"en-US","Cc":"Thomas Petazzoni , marex@denx.de,\n\tu-boot@lists.denx.de","Subject":"Re: [U-Boot] [PATCH v2 08/14] sunxi: provide default USB gadget\n\tsetup","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Transfer-Encoding":"base64","Content-Type":"text/plain; charset=\"utf-8\"; Format=\"flowed\"","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}}]