[{"id":1767780,"web_url":"http://patchwork.ozlabs.org/comment/1767780/","msgid":"<846e50b8-c7d0-4563-31df-e8dbb183db53@denx.de>","list_archive_url":null,"date":"2017-09-13T10:42:43","subject":"Re: [U-Boot] [PATCH v2 09/14] sunxi: imply USB_GADGET","submitter":{"id":70701,"url":"http://patchwork.ozlabs.org/api/people/70701/","name":"Lukasz Majewski","email":"lukma@denx.de"},"content":"On 09/12/2017 09:01 PM, Maxime Ripard wrote:\n> A good number of our boards have USB_GADGET enabled. Imply it so that all\n> the boards can benefit from it, and remove some boilerplate from our\n> defconfigs.\n> \n> Reviewed-by: Simon Glass \n> Signed-off-by: Maxime Ripard \n> ---\n> arch/arm/Kconfig | 1 +\n> configs/A13-OLinuXino_defconfig | 1 -\n> configs/A20-OLinuXino-Lime2-eMMC_defconfig | 1 -\n> configs/A20-OLinuXino-Lime2_defconfig | 1 -\n> configs/CHIP_defconfig | 1 -\n> configs/CHIP_pro_defconfig | 1 -\n> configs/Cubietruck_defconfig | 1 -\n> configs/Nintendo_NES_Classic_Edition_defconfig | 1 -\n> configs/Sinlinx_SinA33_defconfig | 1 -\n> configs/parrot_r16_defconfig | 1 -\n> 10 files changed, 1 insertion(+), 9 deletions(-)\n> \n> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig\n> index 53eae8953e0b..1eb59c591a54 100644\n> --- a/arch/arm/Kconfig\n> +++ b/arch/arm/Kconfig\n> @@ -705,6 +705,7 @@ config ARCH_SUNXI\n> \timply SPL_POWER_SUPPORT\n> \timply SPL_SERIAL_SUPPORT\n> \timply USB_FUNCTION_FASTBOOT\n> +\timply USB_GADGET\n> \n> config TARGET_TS4600\n> \tbool \"Support TS4600\"\n> diff --git a/configs/A13-OLinuXino_defconfig b/configs/A13-OLinuXino_defconfig\n> index ae790164dff7..e55dbff44d36 100644\n> --- a/configs/A13-OLinuXino_defconfig\n> +++ b/configs/A13-OLinuXino_defconfig\n> @@ -31,5 +31,4 @@ CONFIG_AXP_ALDO3_VOLT=3300\n> CONFIG_USB_EHCI_HCD=y\n> CONFIG_USB_MUSB_GADGET=y\n> CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y\n> -CONFIG_USB_GADGET=y\n> CONFIG_USB_GADGET_DOWNLOAD=y\n> diff --git a/configs/A20-OLinuXino-Lime2-eMMC_defconfig b/configs/A20-OLinuXino-Lime2-eMMC_defconfig\n> index b136af66b71f..9491708d80c6 100644\n> --- a/configs/A20-OLinuXino-Lime2-eMMC_defconfig\n> +++ b/configs/A20-OLinuXino-Lime2-eMMC_defconfig\n> @@ -33,5 +33,4 @@ CONFIG_SCSI=y\n> CONFIG_USB_EHCI_HCD=y\n> CONFIG_USB_MUSB_GADGET=y\n> CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y\n> -CONFIG_USB_GADGET=y\n> CONFIG_USB_GADGET_DOWNLOAD=y\n> diff --git a/configs/A20-OLinuXino-Lime2_defconfig b/configs/A20-OLinuXino-Lime2_defconfig\n> index ebb435f30956..2bb8ee8c9ebd 100644\n> --- a/configs/A20-OLinuXino-Lime2_defconfig\n> +++ b/configs/A20-OLinuXino-Lime2_defconfig\n> @@ -32,5 +32,4 @@ CONFIG_SCSI=y\n> CONFIG_USB_EHCI_HCD=y\n> CONFIG_USB_MUSB_GADGET=y\n> CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y\n> -CONFIG_USB_GADGET=y\n> CONFIG_USB_GADGET_DOWNLOAD=y\n> diff --git a/configs/CHIP_defconfig b/configs/CHIP_defconfig\n> index 7d50d0533dcd..b9f70d240c3c 100644\n> --- a/configs/CHIP_defconfig\n> +++ b/configs/CHIP_defconfig\n> @@ -22,6 +22,5 @@ CONFIG_AXP_ALDO4_VOLT=3300\n> CONFIG_USB_EHCI_HCD=y\n> CONFIG_USB_MUSB_GADGET=y\n> CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y\n> -CONFIG_USB_GADGET=y\n> CONFIG_USB_GADGET_DOWNLOAD=y\n> CONFIG_OF_LIBFDT_OVERLAY=y\n> diff --git a/configs/CHIP_pro_defconfig b/configs/CHIP_pro_defconfig\n> index 76daf477ec87..74f6eb10fc01 100644\n> --- a/configs/CHIP_pro_defconfig\n> +++ b/configs/CHIP_pro_defconfig\n> @@ -27,6 +27,5 @@ CONFIG_AXP_ALDO4_VOLT=3300\n> CONFIG_USB_EHCI_HCD=y\n> CONFIG_USB_MUSB_GADGET=y\n> CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y\n> -CONFIG_USB_GADGET=y\n> CONFIG_USB_GADGET_DOWNLOAD=y\n> CONFIG_OF_LIBFDT_OVERLAY=y\n> diff --git a/configs/Cubietruck_defconfig b/configs/Cubietruck_defconfig\n> index 1b2989d364f6..458e2a9d8b04 100644\n> --- a/configs/Cubietruck_defconfig\n> +++ b/configs/Cubietruck_defconfig\n> @@ -32,5 +32,4 @@ CONFIG_SCSI=y\n> CONFIG_USB_EHCI_HCD=y\n> CONFIG_USB_MUSB_GADGET=y\n> CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y\n> -CONFIG_USB_GADGET=y\n> CONFIG_USB_GADGET_DOWNLOAD=y\n> diff --git a/configs/Nintendo_NES_Classic_Edition_defconfig b/configs/Nintendo_NES_Classic_Edition_defconfig\n> index 5986764a14b9..e031dd8f5d5f 100644\n> --- a/configs/Nintendo_NES_Classic_Edition_defconfig\n> +++ b/configs/Nintendo_NES_Classic_Edition_defconfig\n> @@ -22,5 +22,4 @@ CONFIG_AXP_DLDO1_VOLT=3300\n> CONFIG_AXP_ELDO2_VOLT=1800\n> CONFIG_USB_MUSB_GADGET=y\n> CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y\n> -CONFIG_USB_GADGET=y\n> CONFIG_USB_GADGET_DOWNLOAD=y\n> diff --git a/configs/Sinlinx_SinA33_defconfig b/configs/Sinlinx_SinA33_defconfig\n> index 9299aedd6019..143a9b4b6c10 100644\n> --- a/configs/Sinlinx_SinA33_defconfig\n> +++ b/configs/Sinlinx_SinA33_defconfig\n> @@ -27,5 +27,4 @@ CONFIG_DFU_RAM=y\n> CONFIG_USB_EHCI_HCD=y\n> CONFIG_USB_MUSB_GADGET=y\n> CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y\n> -CONFIG_USB_GADGET=y\n> CONFIG_USB_GADGET_DOWNLOAD=y\n> diff --git a/configs/parrot_r16_defconfig b/configs/parrot_r16_defconfig\n> index 57db9587fe77..b36b9efec650 100644\n> --- a/configs/parrot_r16_defconfig\n> +++ b/configs/parrot_r16_defconfig\n> @@ -23,5 +23,4 @@ CONFIG_FASTBOOT_FLASH_MMC_DEV=0\n> CONFIG_USB_EHCI_HCD=y\n> CONFIG_USB_MUSB_GADGET=y\n> CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y\n> -CONFIG_USB_GADGET=y\n> CONFIG_USB_GADGET_DOWNLOAD=y\n> \nReviewed-by: Łukasz Majewski ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xsdYg13Gqz9s5L\n\tfor ;\n\tWed, 13 Sep 2017 20:43:35 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid E608BC226FF; Wed, 13 Sep 2017 10:43:07 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 04AE0C226F2;\n\tWed, 13 Sep 2017 10:43:06 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 435F4C226C0; Wed, 13 Sep 2017 10:42:51 +0000 (UTC)","from mail-out.m-online.net (mail-out.m-online.net [212.18.0.10])\n\tby lists.denx.de (Postfix) with ESMTPS id 06A42C226E9\n\tfor ; Wed, 13 Sep 2017 10:42:47 +0000 (UTC)","from frontend03.mail.m-online.net (unknown [192.168.6.182])\n\tby mail-out.m-online.net (Postfix) with ESMTP id 3xsdXk2kHsz1qtFY;\n\tWed, 13 Sep 2017 12:42:46 +0200 (CEST)","from localhost (dynscan3.mnet-online.de [192.168.6.84])\n\tby mail.m-online.net (Postfix) with ESMTP id 3xsdXk1NjCz1qqkS;\n\tWed, 13 Sep 2017 12:42:46 +0200 (CEST)","from mail.mnet-online.de ([192.168.8.182])\n\tby localhost (dynscan3.mail.m-online.net [192.168.6.84]) (amavisd-new,\n\tport 10024)\n\twith ESMTP id 20B0KZxx9--5; Wed, 13 Sep 2017 12:42:44 +0200 (CEST)","from [192.168.2.222] (89-64-27-66.dynamic.chello.pl [89.64.27.66])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby mail.mnet-online.de (Postfix) with ESMTPSA;\n\tWed, 13 Sep 2017 12:42:44 +0200 (CEST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW,\n\tRCVD_IN_MSPIKE_H3,\n\tRCVD_IN_MSPIKE_WL autolearn=unavailable autolearn_force=no\n\tversion=3.4.0","X-Virus-Scanned":"amavisd-new at mnet-online.de","X-Auth-Info":"m/FbPKhBRRdzwBYZWxP1KbY0UAOuj7/KxkKJMtv0eSY=","To":"Maxime Ripard ,\n\tTom Rini , Jagan Teki ","References":"\n\t<87f4f66f2cc60d14667fafe84b3c9f3ddd252779.1505242834.git-series.maxime.ripard@free-electrons.com>","From":"=?utf-8?q?=C5=81ukasz_Majewski?= ","Organization":"DENX","Message-ID":"<846e50b8-c7d0-4563-31df-e8dbb183db53@denx.de>","Date":"Wed, 13 Sep 2017 12:42:43 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<87f4f66f2cc60d14667fafe84b3c9f3ddd252779.1505242834.git-series.maxime.ripard@free-electrons.com>","Content-Language":"en-US","Cc":"Thomas Petazzoni , marex@denx.de,\n\tu-boot@lists.denx.de","Subject":"Re: [U-Boot] [PATCH v2 09/14] sunxi: imply USB_GADGET","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Transfer-Encoding":"base64","Content-Type":"text/plain; charset=\"utf-8\"; Format=\"flowed\"","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1773237,"web_url":"http://patchwork.ozlabs.org/comment/1773237/","msgid":"","list_archive_url":null,"date":"2017-09-22T03:20:33","subject":"Re: [U-Boot] [PATCH v2 09/14] sunxi: imply USB_GADGET","submitter":{"id":47154,"url":"http://patchwork.ozlabs.org/api/people/47154/","name":"Chen-Yu Tsai","email":"wens@csie.org"},"content":"On Wed, Sep 13, 2017 at 3:01 AM, Maxime Ripard\n wrote:\n> A good number of our boards have USB_GADGET enabled. Imply it so that all\n> the boards can benefit from it, and remove some boilerplate from our\n> defconfigs.\n>\n> Reviewed-by: Simon Glass \n> Signed-off-by: Maxime Ripard \n\nThis breaks builds using defconfigs where USB_MUSB_GADGET is not set.\nPerhaps a better solution would be to imply USB_GADGET from USB_MUSB_GADGET?\nKconfig complains about recursive dependencies if I do\n\n imply USB_GADGET if USB_MUSB_GADGET\n\nunder ARCH_SUNXI though.\n\nChenYu","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xyzKB6TKMz9t30\n\tfor ;\n\tFri, 22 Sep 2017 13:21:17 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 3A0E8C21E4C; Fri, 22 Sep 2017 03:21:07 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 468CEC21C29;\n\tFri, 22 Sep 2017 03:21:05 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 8ECBEC21C29; Fri, 22 Sep 2017 03:21:04 +0000 (UTC)","from smtp.csie.ntu.edu.tw (smtp.csie.ntu.edu.tw [140.112.30.61])\n\tby lists.denx.de (Postfix) with ESMTPS id 97C44C21C26\n\tfor ; Fri, 22 Sep 2017 03:21:03 +0000 (UTC)","from mail-wm0-f46.google.com (mail-wm0-f46.google.com\n\t[74.125.82.46])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits))\n\t(No client certificate requested) (Authenticated sender: b93043)\n\tby smtp.csie.ntu.edu.tw (Postfix) with ESMTPSA id CE5D427C56\n\tfor ; Fri, 22 Sep 2017 11:20:57 +0800 (CST)","by mail-wm0-f46.google.com with SMTP id m127so261053wmm.3\n\tfor ; Thu, 21 Sep 2017 20:20:57 -0700 (PDT)","by 10.223.196.226 with HTTP; Thu, 21 Sep 2017 20:20:33 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.7 required=5.0 tests=RCVD_IN_BRBL_LASTEXT,\n\tRCVD_IN_DNSWL_MED autolearn=unavailable autolearn_force=no\n\tversion=3.4.0","X-Gm-Message-State":"AHPjjUgyhh6MeozcJBQoA1SJoO+kT09mfRbHEaiu1EFzMNl0f+lViJ/T\n\t2wMCrnHhDxXphrydyr9wB2pJ/5Dn7geNymPCBjU=","X-Google-Smtp-Source":"AOwi7QCF4Vh+H6IMv9enBu39bWlIcvUy/Pz2hdhXv3QsOsBpeleFmaE+DKx90SnOu30/jMUkH3P9ogTF/Qu3bb+I0vQ=","X-Received":"by 10.28.59.215 with SMTP id i206mr2553644wma.116.1506050454485; \n\tThu, 21 Sep 2017 20:20:54 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<87f4f66f2cc60d14667fafe84b3c9f3ddd252779.1505242834.git-series.maxime.ripard@free-electrons.com>","References":"\n\t<87f4f66f2cc60d14667fafe84b3c9f3ddd252779.1505242834.git-series.maxime.ripard@free-electrons.com>","From":"Chen-Yu Tsai ","Date":"Fri, 22 Sep 2017 11:20:33 +0800","X-Gmail-Original-Message-ID":"","Message-ID":"","To":"Maxime Ripard ","Cc":"Thomas Petazzoni ,\n\tTom Rini , Marek Vasut ,\n\tU-Boot Mailing List ,\n\tJagan Teki ","Subject":"Re: [U-Boot] [PATCH v2 09/14] sunxi: imply USB_GADGET","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1773333,"web_url":"http://patchwork.ozlabs.org/comment/1773333/","msgid":"<20170922075337.wkwqmdbvwrosgv36@flea.lan>","list_archive_url":null,"date":"2017-09-22T07:53:37","subject":"Re: [U-Boot] [PATCH v2 09/14] sunxi: imply USB_GADGET","submitter":{"id":12916,"url":"http://patchwork.ozlabs.org/api/people/12916/","name":"Maxime Ripard","email":"maxime.ripard@free-electrons.com"},"content":"Hi,\n\nOn Fri, Sep 22, 2017 at 03:20:33AM +0000, Chen-Yu Tsai wrote:\n> On Wed, Sep 13, 2017 at 3:01 AM, Maxime Ripard\n> wrote:\n> > A good number of our boards have USB_GADGET enabled. Imply it so that all\n> > the boards can benefit from it, and remove some boilerplate from our\n> > defconfigs.\n> >\n> > Reviewed-by: Simon Glass \n> > Signed-off-by: Maxime Ripard \n> \n> This breaks builds using defconfigs where USB_MUSB_GADGET is not set.\n> Perhaps a better solution would be to imply USB_GADGET from USB_MUSB_GADGET?\n> Kconfig complains about recursive dependencies if I do\n> \n> imply USB_GADGET if USB_MUSB_GADGET\n> \n> under ARCH_SUNXI though.\n\nThanks, I just pushed a fix for it.\n\nMaxime","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xz5MY4NHtz9s83\n\tfor ;\n\tFri, 22 Sep 2017 17:53:45 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 5D4A4C21FCF; Fri, 22 Sep 2017 07:53:43 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 9E907C21E0E;\n\tFri, 22 Sep 2017 07:53:39 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid D8AE0C21E0E; Fri, 22 Sep 2017 07:53:38 +0000 (UTC)","from mail.free-electrons.com (mail.free-electrons.com [62.4.15.54])\n\tby lists.denx.de (Postfix) with ESMTP id B80E7C21C8F\n\tfor ; Fri, 22 Sep 2017 07:53:37 +0000 (UTC)","by mail.free-electrons.com (Postfix, from userid 110)\n\tid D1E9D209C3; Fri, 22 Sep 2017 09:53:36 +0200 (CEST)","from localhost (LStLambert-657-1-97-87.w90-63.abo.wanadoo.fr\n\t[90.63.216.87])\n\tby mail.free-electrons.com (Postfix) with ESMTPSA id A4DD920866;\n\tFri, 22 Sep 2017 09:53:36 +0200 (CEST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=0.0 required=5.0 tests=none autolearn=unavailable\n\tautolearn_force=no version=3.4.0","Date":"Fri, 22 Sep 2017 09:53:37 +0200","From":"Maxime Ripard ","To":"Chen-Yu Tsai ","Message-ID":"<20170922075337.wkwqmdbvwrosgv36@flea.lan>","References":"\n\t<87f4f66f2cc60d14667fafe84b3c9f3ddd252779.1505242834.git-series.maxime.ripard@free-electrons.com>\n\t","MIME-Version":"1.0","In-Reply-To":"","User-Agent":"NeoMutt/20170914 (1.9.0)","Cc":"Thomas Petazzoni ,\n\tTom Rini , Marek Vasut ,\n\tU-Boot Mailing List ,\n\tJagan Teki ","Subject":"Re: [U-Boot] [PATCH v2 09/14] sunxi: imply USB_GADGET","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"multipart/mixed;\n\tboundary=\"===============8504940394802439243==\"","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}}]