[{"id":1767561,"web_url":"http://patchwork.ozlabs.org/comment/1767561/","msgid":"","list_archive_url":null,"date":"2017-09-13T04:27:20","subject":"Re: [U-Boot] [PATCH v2 05/14] usb: gadget: usb_ether: Move the\n\tinterfaces to Kconfig","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"On 12 September 2017 at 13:01, Maxime Ripard\n wrote:\n> We need to select an interface for the usb_ether gadget, and they haven't\n> been converted to Kconfig yet. Add a choice to make sure we have an option\n> selected, and convert all the users.\n>\n> Signed-off-by: Maxime Ripard \n> ---\n> configs/gwventana_emmc_defconfig | 1 +-\n> configs/gwventana_gw5904_defconfig | 1 +-\n> configs/gwventana_nand_defconfig | 1 +-\n> configs/mx6qsabrelite_defconfig | 1 +-\n> configs/nitrogen6dl2g_defconfig | 1 +-\n> configs/nitrogen6dl_defconfig | 1 +-\n> configs/nitrogen6q2g_defconfig | 1 +-\n> configs/nitrogen6q_defconfig | 1 +-\n> configs/nitrogen6s1g_defconfig | 1 +-\n> configs/nitrogen6s_defconfig | 1 +-\n> configs/novena_defconfig | 1 +-\n> configs/sansa_fuze_plus_defconfig | 1 +-\n> configs/warp7_defconfig | 1 +-\n> configs/warp7_secure_defconfig | 1 +-\n> configs/xfi3_defconfig | 1 +-\n> drivers/usb/gadget/Kconfig | 28 +++++++++++++++++++++++++++-\n> include/configs/am335x_evm.h | 4 +----\n> include/configs/am3517_evm.h | 4 +----\n> include/configs/baltos.h | 4 +----\n> include/configs/gw_ventana.h | 1 +-\n> include/configs/ma5d4evk.h | 1 +-\n> include/configs/nitrogen6x.h | 1 +-\n> include/configs/novena.h | 1 +-\n> include/configs/pcm051.h | 4 +----\n> include/configs/sama5d2_ptc.h | 1 +-\n> include/configs/sansa_fuze_plus.h | 1 +-\n> include/configs/siemens-am33x-common.h | 4 +----\n> include/configs/vinco.h | 1 +-\n> include/configs/warp7.h | 2 +--\n> include/configs/xfi3.h | 1 +-\n> scripts/config_whitelist.txt | 2 +--\n> 31 files changed, 43 insertions(+), 32 deletions(-)\n>\n\nReviewed-by: Simon Glass ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=google.com header.i=@google.com\n\theader.b=\"h4rvZf9g\"; \n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"g15QcMeU\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xsTYd1BLxz9sNV\n\tfor ;\n\tWed, 13 Sep 2017 14:43:01 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid C9D2AC2255D; Wed, 13 Sep 2017 04:30:32 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 28533C22437;\n\tWed, 13 Sep 2017 04:28:32 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 0EB87C22447; Wed, 13 Sep 2017 04:27:47 +0000 (UTC)","from mail-qk0-f178.google.com (mail-qk0-f178.google.com\n\t[209.85.220.178])\n\tby lists.denx.de (Postfix) with ESMTPS id 07682C22453\n\tfor ; Wed, 13 Sep 2017 04:27:43 +0000 (UTC)","by mail-qk0-f178.google.com with SMTP id j5so74230qkd.0\n\tfor ; Tue, 12 Sep 2017 21:27:42 -0700 (PDT)","by 10.200.37.200 with HTTP; Tue, 12 Sep 2017 21:27:20 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE,\n\tRCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID autolearn=unavailable\n\tautolearn_force=no version=3.4.0","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=20161025; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=UjQUgYljRClDK1um2t52EBbmmxUtNRkBRbUP3Q2Qw3s=;\n\tb=h4rvZf9g6LB4m3ZroF4JF92z34Vx4zhLgagx63X/pTEvL8p6XggKhM4jAxDW8NpM+t\n\tp9i16BXP7R8Hf5Qzx8+OO5+OdGYOU9qbxsR3XGJVrzWNEfYGeAbVQhqrsL62i81CFXTN\n\tInV3g7UHCuS4YdV50w2qFYszp4dKSnJlfrJqGWtt2C4aYLaIF7SWnxspwjTOFXZcGJYT\n\tDT0jZ2JJp8hxXClfw5r7K+7j9k2fM339s3Z4hq2EQFi6WaD9mJqBbL4lnYnOxHLdjek9\n\tYa+6SniK7r5YWeecRDlgvh2G3Mrx46hN9ef0IdNS95+kcrEnjkPGUZHvdPN2SCbHEPER\n\tSI+A==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=UjQUgYljRClDK1um2t52EBbmmxUtNRkBRbUP3Q2Qw3s=;\n\tb=g15QcMeUHOVC6yQF9Pyqvz12/98BdexFfJmdsFpZ6NKp/hMedNm3+Ek2WTnnLhxxtO\n\tWyobVY4VLSg0Rq1aADHRrWbMn09l7CkzJetpxRiB/OnaC6FcU/IJWCTT4kmTSew7QEp5\n\t4u2zwS05aFQYL6Pc6ehl4YRj3asX+oexkrSwo="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:sender:in-reply-to:references:from\n\t:date:message-id:subject:to:cc;\n\tbh=UjQUgYljRClDK1um2t52EBbmmxUtNRkBRbUP3Q2Qw3s=;\n\tb=tV6Bev1F+VRaMbjt77/lXAePprqcW/vRw7KBlUsY+pb2LS4eBMjqNSf1uunH6SK4jo\n\tRJTFvYl8XYYswcUIbLVMbbF/Az2X1mE6bV9j6thKDEn4k2PeKzvS2CHfQDyCrYjj38gv\n\tS7IUhjQQiGNhzEy4dDASULurLMPOZe161ItjaBXsHQQ2KaS5Q6hknn1txIRM+QSvuc43\n\tjJO8jZ6S0YGZM9sNisw6WfJruFW62E3fp85VGiGWR0hj5m624Sn3bDNnev90ugyVbp2U\n\tKZnklJBz3j1QVMDBJpzWgqS6jCV7ei+XuQgCtwssOyOXx4mA7XZqkTPqYj4XFnW8Nyam\n\tzrfw==","X-Gm-Message-State":"AHPjjUhg6TI1d3aN8sHeFda1BQ1gXMXQA1lTlBCVrnsNsXTPQM8+Pwzv\n\tNZ9VdPxsDsAnsEam5rTb3sci5Z4f6rrUJo1IFgDuOg==","X-Google-Smtp-Source":"AOwi7QBh5Xf2CWZFvhciYPZX30YDdKqqFeKjl0pOyFEUu/1tsKUVsSIf6/5q30oFX2wY7aM/20GvQbPowB3dV0lcmV8=","X-Received":"by 10.55.81.215 with SMTP id f206mr21178091qkb.188.1505276861639;\n\tTue, 12 Sep 2017 21:27:41 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"","References":"\n\t","From":"Simon Glass ","Date":"Tue, 12 Sep 2017 22:27:20 -0600","X-Google-Sender-Auth":"QT4gbkI5JlkQxYMhAYJGP63pXh8","Message-ID":"","To":"Maxime Ripard ","Cc":"Thomas Petazzoni ,\n\tTom Rini , Marek Vasut ,\n\tU-Boot Mailing List ,\n\tJagan Teki ","Subject":"Re: [U-Boot] [PATCH v2 05/14] usb: gadget: usb_ether: Move the\n\tinterfaces to Kconfig","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1767777,"web_url":"http://patchwork.ozlabs.org/comment/1767777/","msgid":"","list_archive_url":null,"date":"2017-09-13T10:39:50","subject":"Re: [U-Boot] [PATCH v2 05/14] usb: gadget: usb_ether: Move the\n\tinterfaces to Kconfig","submitter":{"id":70701,"url":"http://patchwork.ozlabs.org/api/people/70701/","name":"Lukasz Majewski","email":"lukma@denx.de"},"content":"On 09/12/2017 09:01 PM, Maxime Ripard wrote:\n> We need to select an interface for the usb_ether gadget, and they haven't\n> been converted to Kconfig yet. Add a choice to make sure we have an option\n> selected, and convert all the users.\n\nReviewed-by: Łukasz Majewski \n\n> \n> Signed-off-by: Maxime Ripard \n> ---\n> configs/gwventana_emmc_defconfig | 1 +-\n> configs/gwventana_gw5904_defconfig | 1 +-\n> configs/gwventana_nand_defconfig | 1 +-\n> configs/mx6qsabrelite_defconfig | 1 +-\n> configs/nitrogen6dl2g_defconfig | 1 +-\n> configs/nitrogen6dl_defconfig | 1 +-\n> configs/nitrogen6q2g_defconfig | 1 +-\n> configs/nitrogen6q_defconfig | 1 +-\n> configs/nitrogen6s1g_defconfig | 1 +-\n> configs/nitrogen6s_defconfig | 1 +-\n> configs/novena_defconfig | 1 +-\n> configs/sansa_fuze_plus_defconfig | 1 +-\n> configs/warp7_defconfig | 1 +-\n> configs/warp7_secure_defconfig | 1 +-\n> configs/xfi3_defconfig | 1 +-\n> drivers/usb/gadget/Kconfig | 28 +++++++++++++++++++++++++++-\n> include/configs/am335x_evm.h | 4 +----\n> include/configs/am3517_evm.h | 4 +----\n> include/configs/baltos.h | 4 +----\n> include/configs/gw_ventana.h | 1 +-\n> include/configs/ma5d4evk.h | 1 +-\n> include/configs/nitrogen6x.h | 1 +-\n> include/configs/novena.h | 1 +-\n> include/configs/pcm051.h | 4 +----\n> include/configs/sama5d2_ptc.h | 1 +-\n> include/configs/sansa_fuze_plus.h | 1 +-\n> include/configs/siemens-am33x-common.h | 4 +----\n> include/configs/vinco.h | 1 +-\n> include/configs/warp7.h | 2 +--\n> include/configs/xfi3.h | 1 +-\n> scripts/config_whitelist.txt | 2 +--\n> 31 files changed, 43 insertions(+), 32 deletions(-)\n> \n> diff --git a/configs/gwventana_emmc_defconfig b/configs/gwventana_emmc_defconfig\n> index 35d9e1ac27dc..03d732d8f11e 100644\n> --- a/configs/gwventana_emmc_defconfig\n> +++ b/configs/gwventana_emmc_defconfig\n> @@ -69,6 +69,7 @@ CONFIG_G_DNL_MANUFACTURER=\"Gateworks\"\n> CONFIG_G_DNL_VENDOR_NUM=0x0525\n> CONFIG_G_DNL_PRODUCT_NUM=0xa4a5\n> CONFIG_USB_ETHER=y\n> +CONFIG_USB_ETH_CDC=y\n> CONFIG_USB_HOST_ETHER=y\n> CONFIG_USB_ETHER_ASIX=y\n> CONFIG_USB_ETHER_SMSC95XX=y\n> diff --git a/configs/gwventana_gw5904_defconfig b/configs/gwventana_gw5904_defconfig\n> index ca7eb5ac573e..51aa13dbaca3 100644\n> --- a/configs/gwventana_gw5904_defconfig\n> +++ b/configs/gwventana_gw5904_defconfig\n> @@ -73,6 +73,7 @@ CONFIG_G_DNL_MANUFACTURER=\"Gateworks\"\n> CONFIG_G_DNL_VENDOR_NUM=0x0525\n> CONFIG_G_DNL_PRODUCT_NUM=0xa4a5\n> CONFIG_USB_ETHER=y\n> +CONFIG_USB_ETH_CDC=y\n> CONFIG_USB_HOST_ETHER=y\n> CONFIG_USB_ETHER_ASIX=y\n> CONFIG_USB_ETHER_SMSC95XX=y\n> diff --git a/configs/gwventana_nand_defconfig b/configs/gwventana_nand_defconfig\n> index cb9655574888..4b2e1a752935 100644\n> --- a/configs/gwventana_nand_defconfig\n> +++ b/configs/gwventana_nand_defconfig\n> @@ -72,6 +72,7 @@ CONFIG_G_DNL_MANUFACTURER=\"Gateworks\"\n> CONFIG_G_DNL_VENDOR_NUM=0x0525\n> CONFIG_G_DNL_PRODUCT_NUM=0xa4a5\n> CONFIG_USB_ETHER=y\n> +CONFIG_USB_ETH_CDC=y\n> CONFIG_USB_HOST_ETHER=y\n> CONFIG_USB_ETHER_ASIX=y\n> CONFIG_USB_ETHER_SMSC95XX=y\n> diff --git a/configs/mx6qsabrelite_defconfig b/configs/mx6qsabrelite_defconfig\n> index bab0d0c79f0d..f716c8fd7f77 100644\n> --- a/configs/mx6qsabrelite_defconfig\n> +++ b/configs/mx6qsabrelite_defconfig\n> @@ -55,5 +55,6 @@ CONFIG_G_DNL_MANUFACTURER=\"Boundary\"\n> CONFIG_G_DNL_VENDOR_NUM=0x0525\n> CONFIG_G_DNL_PRODUCT_NUM=0xa4a5\n> CONFIG_USB_ETHER=y\n> +CONFIG_USB_ETH_CDC=y\n> # CONFIG_VIDEO_SW_CURSOR is not set\n> CONFIG_OF_LIBFDT=y\n> diff --git a/configs/nitrogen6dl2g_defconfig b/configs/nitrogen6dl2g_defconfig\n> index 0d19b85a30f3..fd4a46558129 100644\n> --- a/configs/nitrogen6dl2g_defconfig\n> +++ b/configs/nitrogen6dl2g_defconfig\n> @@ -52,5 +52,6 @@ CONFIG_G_DNL_MANUFACTURER=\"Boundary\"\n> CONFIG_G_DNL_VENDOR_NUM=0x0525\n> CONFIG_G_DNL_PRODUCT_NUM=0xa4a5\n> CONFIG_USB_ETHER=y\n> +CONFIG_USB_ETH_CDC=y\n> # CONFIG_VIDEO_SW_CURSOR is not set\n> CONFIG_OF_LIBFDT=y\n> diff --git a/configs/nitrogen6dl_defconfig b/configs/nitrogen6dl_defconfig\n> index a20580eb77bb..30046e3f3a07 100644\n> --- a/configs/nitrogen6dl_defconfig\n> +++ b/configs/nitrogen6dl_defconfig\n> @@ -52,5 +52,6 @@ CONFIG_G_DNL_MANUFACTURER=\"Boundary\"\n> CONFIG_G_DNL_VENDOR_NUM=0x0525\n> CONFIG_G_DNL_PRODUCT_NUM=0xa4a5\n> CONFIG_USB_ETHER=y\n> +CONFIG_USB_ETH_CDC=y\n> # CONFIG_VIDEO_SW_CURSOR is not set\n> CONFIG_OF_LIBFDT=y\n> diff --git a/configs/nitrogen6q2g_defconfig b/configs/nitrogen6q2g_defconfig\n> index 940c74a5ece2..f9160c208fe7 100644\n> --- a/configs/nitrogen6q2g_defconfig\n> +++ b/configs/nitrogen6q2g_defconfig\n> @@ -53,5 +53,6 @@ CONFIG_G_DNL_MANUFACTURER=\"Boundary\"\n> CONFIG_G_DNL_VENDOR_NUM=0x0525\n> CONFIG_G_DNL_PRODUCT_NUM=0xa4a5\n> CONFIG_USB_ETHER=y\n> +CONFIG_USB_ETH_CDC=y\n> # CONFIG_VIDEO_SW_CURSOR is not set\n> CONFIG_OF_LIBFDT=y\n> diff --git a/configs/nitrogen6q_defconfig b/configs/nitrogen6q_defconfig\n> index 83772cb2efcf..8bca0e04439e 100644\n> --- a/configs/nitrogen6q_defconfig\n> +++ b/configs/nitrogen6q_defconfig\n> @@ -53,5 +53,6 @@ CONFIG_G_DNL_MANUFACTURER=\"Boundary\"\n> CONFIG_G_DNL_VENDOR_NUM=0x0525\n> CONFIG_G_DNL_PRODUCT_NUM=0xa4a5\n> CONFIG_USB_ETHER=y\n> +CONFIG_USB_ETH_CDC=y\n> # CONFIG_VIDEO_SW_CURSOR is not set\n> CONFIG_OF_LIBFDT=y\n> diff --git a/configs/nitrogen6s1g_defconfig b/configs/nitrogen6s1g_defconfig\n> index 862b41a3f8c9..668fbaa37010 100644\n> --- a/configs/nitrogen6s1g_defconfig\n> +++ b/configs/nitrogen6s1g_defconfig\n> @@ -52,5 +52,6 @@ CONFIG_G_DNL_MANUFACTURER=\"Boundary\"\n> CONFIG_G_DNL_VENDOR_NUM=0x0525\n> CONFIG_G_DNL_PRODUCT_NUM=0xa4a5\n> CONFIG_USB_ETHER=y\n> +CONFIG_USB_ETH_CDC=y\n> # CONFIG_VIDEO_SW_CURSOR is not set\n> CONFIG_OF_LIBFDT=y\n> diff --git a/configs/nitrogen6s_defconfig b/configs/nitrogen6s_defconfig\n> index e5376313b9bd..99106c9a1f5a 100644\n> --- a/configs/nitrogen6s_defconfig\n> +++ b/configs/nitrogen6s_defconfig\n> @@ -52,5 +52,6 @@ CONFIG_G_DNL_MANUFACTURER=\"Boundary\"\n> CONFIG_G_DNL_VENDOR_NUM=0x0525\n> CONFIG_G_DNL_PRODUCT_NUM=0xa4a5\n> CONFIG_USB_ETHER=y\n> +CONFIG_USB_ETH_CDC=y\n> # CONFIG_VIDEO_SW_CURSOR is not set\n> CONFIG_OF_LIBFDT=y\n> diff --git a/configs/novena_defconfig b/configs/novena_defconfig\n> index 786ab2854f70..a7056ff13771 100644\n> --- a/configs/novena_defconfig\n> +++ b/configs/novena_defconfig\n> @@ -49,6 +49,7 @@ CONFIG_SYS_USB_EVENT_POLL_VIA_CONTROL_EP=y\n> CONFIG_USB_GADGET=y\n> CONFIG_CI_UDC=y\n> CONFIG_USB_ETHER=y\n> +CONFIG_USB_ETH_CDC=y\n> CONFIG_USB_HOST_ETHER=y\n> CONFIG_USB_ETHER_ASIX=y\n> CONFIG_USB_ETHER_SMSC95XX=y\n> diff --git a/configs/sansa_fuze_plus_defconfig b/configs/sansa_fuze_plus_defconfig\n> index c6d50ccb8e15..b5443dda98a9 100644\n> --- a/configs/sansa_fuze_plus_defconfig\n> +++ b/configs/sansa_fuze_plus_defconfig\n> @@ -33,4 +33,5 @@ CONFIG_USB_EHCI_HCD=y\n> CONFIG_USB_GADGET=y\n> CONFIG_CI_UDC=y\n> CONFIG_USB_ETHER=y\n> +CONFIG_USB_ETH_CDC=y\n> CONFIG_OF_LIBFDT=y\n> diff --git a/configs/warp7_defconfig b/configs/warp7_defconfig\n> index 8a3717facdbd..32cf7a4da4b4 100644\n> --- a/configs/warp7_defconfig\n> +++ b/configs/warp7_defconfig\n> @@ -39,5 +39,6 @@ CONFIG_G_DNL_MANUFACTURER=\"FSL\"\n> CONFIG_G_DNL_VENDOR_NUM=0x0525\n> CONFIG_G_DNL_PRODUCT_NUM=0xa4a5\n> CONFIG_USB_ETHER=y\n> +CONFIG_USB_ETH_CDC=y\n> CONFIG_USBNET_HOST_ADDR=\"de:ad:be:af:00:00\"\n> CONFIG_OF_LIBFDT=y\n> diff --git a/configs/warp7_secure_defconfig b/configs/warp7_secure_defconfig\n> index 83a06079fdc5..99764dbd0bb1 100644\n> --- a/configs/warp7_secure_defconfig\n> +++ b/configs/warp7_secure_defconfig\n> @@ -37,5 +37,6 @@ CONFIG_G_DNL_MANUFACTURER=\"FSL\"\n> CONFIG_G_DNL_VENDOR_NUM=0x0525\n> CONFIG_G_DNL_PRODUCT_NUM=0xa4a5\n> CONFIG_USB_ETHER=y\n> +CONFIG_USB_ETH_CDC=y\n> CONFIG_USBNET_HOST_ADDR=\"de:ad:be:af:00:00\"\n> CONFIG_OF_LIBFDT=y\n> diff --git a/configs/xfi3_defconfig b/configs/xfi3_defconfig\n> index 6cc78452829c..91768a4a7106 100644\n> --- a/configs/xfi3_defconfig\n> +++ b/configs/xfi3_defconfig\n> @@ -32,4 +32,5 @@ CONFIG_USB_EHCI_HCD=y\n> CONFIG_USB_GADGET=y\n> CONFIG_CI_UDC=y\n> CONFIG_USB_ETHER=y\n> +CONFIG_USB_ETH_CDC=y\n> CONFIG_OF_LIBFDT=y\n> diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig\n> index ae3a37b3a935..1201276be837 100644\n> --- a/drivers/usb/gadget/Kconfig\n> +++ b/drivers/usb/gadget/Kconfig\n> @@ -133,6 +133,34 @@ config USB_ETHER\n> \n> if USB_ETHER\n> \n> +choice\n> +\tprompt \"USB Ethernet Gadget Model\"\n> +\tdefault USB_ETH_RNDIS\n> +\thelp\n> +\t There is several models (protocols) to implement Ethernet over USB\n> +\t devices. The main ones are Microsoft's RNDIS and USB's CDC-Ethernet\n> +\t (also called CDC-ECM). RNDIS is obviously compatible with Windows,\n> +\t while CDC-ECM is not. Most other operating systems support both, so\n> +\t if inter-operability is a concern, RNDIS is to be preferred.\n> +\n> +config USB_ETH_CDC\n> +\tbool \"CDC-ECM Protocol\"\n> +\thelp\n> +\t CDC (Communications Device Class) is the standard for Ethernet over\n> +\t USB devices. While there's several alternatives, the most widely used\n> +\t protocol is ECM (Ethernet Control Model). However, compatibility with\n> +\t Windows is not that great.\n> +\n> +config USB_ETH_RNDIS\n> +\tbool \"RNDIS Protocol\"\n> +\thelp\n> +\t The RNDIS (Remote Network Driver Interface Specification) is a\n> +\t Microsoft proprietary protocol to create an Ethernet device over USB.\n> +\t Windows obviously supports it, as well as all the major operating\n> +\t systems, so it's the best option for compatibility.\n> +\n> +endchoice\n> +\n> config USBNET_DEVADDR\n> \tstring \"USB Gadget Ethernet device mac address\"\n> \tdefault \"de:ad:be:ef:00:01\"\n> diff --git a/include/configs/am335x_evm.h b/include/configs/am335x_evm.h\n> index 9238c4bb769c..96294679bf9b 100644\n> --- a/include/configs/am335x_evm.h\n> +++ b/include/configs/am335x_evm.h\n> @@ -263,10 +263,6 @@\n> #define CONFIG_AM335X_USB1\n> #define CONFIG_AM335X_USB1_MODE MUSB_HOST\n> \n> -#ifdef CONFIG_USB_MUSB_GADGET\n> -#define CONFIG_USB_ETH_RNDIS\n> -#endif /* CONFIG_USB_MUSB_GADGET */\n> -\n> /*\n> * Disable MMC DM for SPL build and can be re-enabled after adding\n> * DM support in SPL\n> diff --git a/include/configs/am3517_evm.h b/include/configs/am3517_evm.h\n> index d09672770134..38bd6e35e8cd 100644\n> --- a/include/configs/am3517_evm.h\n> +++ b/include/configs/am3517_evm.h\n> @@ -79,10 +79,6 @@\n> \n> #endif /* CONFIG_USB_MUSB_HOST */\n> \n> -#ifdef CONFIG_USB_MUSB_GADGET\n> -#define CONFIG_USB_ETH_RNDIS\n> -#endif /* CONFIG_USB_MUSB_GADGET */\n> -\n> #endif /* CONFIG_USB_MUSB_AM35X */\n> \n> /* I2C */\n> diff --git a/include/configs/baltos.h b/include/configs/baltos.h\n> index 380a78918f29..44af4d3deec8 100644\n> --- a/include/configs/baltos.h\n> +++ b/include/configs/baltos.h\n> @@ -283,10 +283,6 @@\n> #define CONFIG_AM335X_USB1\n> #define CONFIG_AM335X_USB1_MODE MUSB_OTG\n> \n> -#ifdef CONFIG_USB_MUSB_GADGET\n> -#define CONFIG_USB_ETH_RNDIS\n> -#endif /* CONFIG_USB_MUSB_GADGET */\n> -\n> #if defined(CONFIG_SPL_BUILD) && defined(CONFIG_SPL_USBETH_SUPPORT)\n> /* disable host part of MUSB in SPL */\n> /* disable EFI partitions and partition UUID support */\n> diff --git a/include/configs/gw_ventana.h b/include/configs/gw_ventana.h\n> index f4b7a061ba12..2795568e8c89 100644\n> --- a/include/configs/gw_ventana.h\n> +++ b/include/configs/gw_ventana.h\n> @@ -146,7 +146,6 @@\n> #define CONFIG_MXC_USB_PORTSC (PORT_PTS_UTMI | PORT_PTS_PTW)\n> #define CONFIG_MXC_USB_FLAGS 0\n> #define CONFIG_USBD_HS\n> -#define CONFIG_USB_ETH_CDC\n> #define CONFIG_NETCONSOLE\n> \n> /* USB Mass Storage Gadget */\n> diff --git a/include/configs/ma5d4evk.h b/include/configs/ma5d4evk.h\n> index 2ad4952f5eeb..6d25d84c6eb6 100644\n> --- a/include/configs/ma5d4evk.h\n> +++ b/include/configs/ma5d4evk.h\n> @@ -97,7 +97,6 @@\n> #ifdef CONFIG_CMD_USB\n> \n> /* USB device */\n> -#define CONFIG_USB_ETH_RNDIS\n> #define CONFIG_USBNET_MANUFACTURER \"AriesEmbedded\"\n> #define CONFIG_USB_FUNCTION_MASS_STORAGE\n> #define CONFIG_SYS_DFU_DATA_BUF_SIZE\t(1 * 1024 * 1024)\n> diff --git a/include/configs/nitrogen6x.h b/include/configs/nitrogen6x.h\n> index ca37f584f042..6068b70d2d69 100644\n> --- a/include/configs/nitrogen6x.h\n> +++ b/include/configs/nitrogen6x.h\n> @@ -19,7 +19,6 @@\n> \n> #define CONFIG_MISC_INIT_R\n> #define CONFIG_USBD_HS\n> -#define CONFIG_USB_ETH_CDC\n> #define CONFIG_NETCONSOLE\n> \n> #define CONFIG_MXC_UART\n> diff --git a/include/configs/novena.h b/include/configs/novena.h\n> index 9068ee2182e3..4825d5bac19a 100644\n> --- a/include/configs/novena.h\n> +++ b/include/configs/novena.h\n> @@ -129,7 +129,6 @@\n> #define CONFIG_MXC_USB_FLAGS\t\t0\n> /* Gadget part */\n> #define CONFIG_USBD_HS\n> -#define CONFIG_USB_ETH_CDC\n> #define CONFIG_NETCONSOLE\n> #endif\n> \n> diff --git a/include/configs/pcm051.h b/include/configs/pcm051.h\n> index 309bbd6bd36f..79f3f48df87e 100644\n> --- a/include/configs/pcm051.h\n> +++ b/include/configs/pcm051.h\n> @@ -133,10 +133,6 @@\n> #define CONFIG_AM335X_USB1\n> #define CONFIG_AM335X_USB1_MODE MUSB_HOST\n> \n> -#ifdef CONFIG_USB_MUSB_GADGET\n> -#define CONFIG_USB_ETH_RNDIS\n> -#endif /* CONFIG_USB_MUSB_GADGET */\n> -\n> #define CONFIG_PHY_SMSC\n> \n> #endif\t/* ! __CONFIG_PCM051_H */\n> diff --git a/include/configs/sama5d2_ptc.h b/include/configs/sama5d2_ptc.h\n> index a1a0602cdd0c..543592e3a574 100644\n> --- a/include/configs/sama5d2_ptc.h\n> +++ b/include/configs/sama5d2_ptc.h\n> @@ -60,7 +60,6 @@\n> #endif\n> \n> /* USB device */\n> -#define CONFIG_USB_ETH_RNDIS\n> #define CONFIG_USBNET_MANUFACTURER \"Atmel SAMA5D2_PTC\"\n> \n> /* Ethernet Hardware */\n> diff --git a/include/configs/sansa_fuze_plus.h b/include/configs/sansa_fuze_plus.h\n> index 9e33ca42270c..99200140fe5e 100644\n> --- a/include/configs/sansa_fuze_plus.h\n> +++ b/include/configs/sansa_fuze_plus.h\n> @@ -39,7 +39,6 @@\n> #define CONFIG_EHCI_MXS_PORT0\n> #define CONFIG_USB_MAX_CONTROLLER_COUNT 1\n> \n> -#define CONFIG_USB_ETH_CDC\n> #define CONFIG_NETCONSOLE\n> #endif\n> \n> diff --git a/include/configs/siemens-am33x-common.h b/include/configs/siemens-am33x-common.h\n> index 0600984f95aa..1997c2dd5ae4 100644\n> --- a/include/configs/siemens-am33x-common.h\n> +++ b/include/configs/siemens-am33x-common.h\n> @@ -178,10 +178,6 @@\n> #define CONFIG_AM335X_USB1\n> #define CONFIG_AM335X_USB1_MODE MUSB_HOST\n> \n> -#ifdef CONFIG_USB_MUSB_GADGET\n> -#define CONFIG_USB_ETH_RNDIS\n> -#endif /* CONFIG_USB_MUSB_GADGET */\n> -\n> /* USB DRACO ID as default */\n> #define CONFIG_USBD_HS\n> \n> diff --git a/include/configs/vinco.h b/include/configs/vinco.h\n> index 3b3ec6c8f2ad..f5aaaa2ffe91 100644\n> --- a/include/configs/vinco.h\n> +++ b/include/configs/vinco.h\n> @@ -64,7 +64,6 @@\n> #endif\n> \n> /* USB device */\n> -#define CONFIG_USB_ETH_RNDIS\n> #define CONFIG_USBNET_MANUFACTURER \"L+G VInCo\"\n> \n> /* Ethernet Hardware */\n> diff --git a/include/configs/warp7.h b/include/configs/warp7.h\n> index 05ae3542a9ad..11f1bc3eab75 100644\n> --- a/include/configs/warp7.h\n> +++ b/include/configs/warp7.h\n> @@ -136,8 +136,6 @@\n> #define CONFIG_SYS_DFU_DATA_BUF_SIZE\tSZ_16M\n> #define DFU_DEFAULT_POLL_TIMEOUT\t300\n> \n> -#define CONFIG_USB_ETH_CDC\n> -#define CONFIG_USB_ETH_RNDIS\n> #define CONFIG_USBNET_DEV_ADDR\t\t\"de:ad:be:af:00:01\"\n> \n> #endif\n> diff --git a/include/configs/xfi3.h b/include/configs/xfi3.h\n> index 7bbfd75c0cb8..1e70a762e0d9 100644\n> --- a/include/configs/xfi3.h\n> +++ b/include/configs/xfi3.h\n> @@ -39,7 +39,6 @@\n> #define CONFIG_EHCI_MXS_PORT0\n> #define CONFIG_USB_MAX_CONTROLLER_COUNT 1\n> \n> -#define CONFIG_USB_ETH_CDC\n> #define CONFIG_NETCONSOLE\n> #endif\n> \n> diff --git a/scripts/config_whitelist.txt b/scripts/config_whitelist.txt\n> index e9e716e7c80e..bbc3d4351bbd 100644\n> --- a/scripts/config_whitelist.txt\n> +++ b/scripts/config_whitelist.txt\n> @@ -5013,9 +5013,7 @@ CONFIG_USB_EHCI_TEGRA\n> CONFIG_USB_EHCI_TXFIFO_THRESH\n> CONFIG_USB_EHCI_VCT\n> CONFIG_USB_EHCI_VF\n> -CONFIG_USB_ETH_CDC\n> CONFIG_USB_ETH_QMULT\n> -CONFIG_USB_ETH_RNDIS\n> CONFIG_USB_ETH_SUBSET\n> CONFIG_USB_EXT2_BOOT\n> CONFIG_USB_FAT_BOOT\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xsdWq1Wpzz9s5L\n\tfor ;\n\tWed, 13 Sep 2017 20:41:59 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid CC68CC226ED; Wed, 13 Sep 2017 10:41:27 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id E7E0BC226E0;\n\tWed, 13 Sep 2017 10:40:32 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid B40F1C226F3; Wed, 13 Sep 2017 10:39:56 +0000 (UTC)","from mail-out.m-online.net (mail-out.m-online.net [212.18.0.10])\n\tby lists.denx.de (Postfix) with ESMTPS id 9C69FC2265A\n\tfor ; Wed, 13 Sep 2017 10:39:54 +0000 (UTC)","from frontend03.mail.m-online.net (unknown [192.168.6.182])\n\tby mail-out.m-online.net (Postfix) with ESMTP id 3xsdTQ078jz1qtFQ;\n\tWed, 13 Sep 2017 12:39:53 +0200 (CEST)","from localhost (dynscan3.mnet-online.de [192.168.6.84])\n\tby mail.m-online.net (Postfix) with ESMTP id 3xsdTP645Hz1qqkS;\n\tWed, 13 Sep 2017 12:39:53 +0200 (CEST)","from mail.mnet-online.de ([192.168.8.182])\n\tby localhost (dynscan3.mail.m-online.net [192.168.6.84]) (amavisd-new,\n\tport 10024)\n\twith ESMTP id bA4n2MvTCt2g; Wed, 13 Sep 2017 12:39:51 +0200 (CEST)","from [192.168.2.222] (89-64-27-66.dynamic.chello.pl [89.64.27.66])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby mail.mnet-online.de (Postfix) with ESMTPSA;\n\tWed, 13 Sep 2017 12:39:51 +0200 (CEST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW,\n\tRCVD_IN_MSPIKE_H3,\n\tRCVD_IN_MSPIKE_WL autolearn=unavailable autolearn_force=no\n\tversion=3.4.0","X-Virus-Scanned":"amavisd-new at mnet-online.de","X-Auth-Info":"E4MmmgsZR3SJuXOJCPFPD9Ex09Jf/AE45szDG3o5iZw=","To":"Maxime Ripard ,\n\tTom Rini , Jagan Teki ","References":"\n\t","From":"=?utf-8?q?=C5=81ukasz_Majewski?= ","Organization":"DENX","Message-ID":"","Date":"Wed, 13 Sep 2017 12:39:50 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"","Content-Language":"en-US","Cc":"Thomas Petazzoni , marex@denx.de,\n\tu-boot@lists.denx.de","Subject":"Re: [U-Boot] [PATCH v2 05/14] usb: gadget: usb_ether: Move the\n\tinterfaces to Kconfig","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Transfer-Encoding":"base64","Content-Type":"text/plain; charset=\"utf-8\"; Format=\"flowed\"","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}}]