[{"id":1767773,"web_url":"http://patchwork.ozlabs.org/comment/1767773/","msgid":"<78ba37a8-0020-d08b-1063-7f45e0383ea1@denx.de>","list_archive_url":null,"date":"2017-09-13T10:37:19","subject":"Re: [U-Boot] [PATCH v2 01/14] usb: gadget: Move USBNET_DEVADDR\n\toption out of g_dnl","submitter":{"id":70701,"url":"http://patchwork.ozlabs.org/api/people/70701/","name":"Lukasz Majewski","email":"lukma@denx.de"},"content":"On 09/12/2017 09:01 PM, Maxime Ripard wrote:\n> The USBNET_DEVADDR has nothing to do with the USB download gadget, but\n> rather with the USB Ethernet gadget. Move it out of the if statement.\n> \n> Reviewed-by: Simon Glass <sjg@chromium.org>\n> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>\n> ---\n>   drivers/usb/gadget/Kconfig | 4 ++--\n>   1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig\n> index 225b66bc95ff..d52626908846 100644\n> --- a/drivers/usb/gadget/Kconfig\n> +++ b/drivers/usb/gadget/Kconfig\n> @@ -119,10 +119,10 @@ config G_DNL_VENDOR_NUM\n>   config G_DNL_PRODUCT_NUM\n>   \thex \"Product ID of USB device\"\n>   \n> +endif # USB_GADGET_DOWNLOAD\n> +\n>   config USBNET_DEVADDR\n>   \tstring \"USB Gadget Ethernet device mac address\"\n>   \tdefault \"de:ad:be:ef:00:01\"\n>   \n> -endif # USB_GADGET_DOWNLOAD\n> -\n>   endif # USB_GADGET\n> \n\nAcked-by: Łukasz Majewski <lukma@denx.de>","headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=<UNKNOWN>)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xsdSh2gFQz9sPk\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 13 Sep 2017 20:39:16 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid DE886C2269E; Wed, 13 Sep 2017 10:38:41 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id E21C9C2262A;\n\tWed, 13 Sep 2017 10:38:18 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 5400FC220FB; Wed, 13 Sep 2017 10:38:04 +0000 (UTC)","from mail-out.m-online.net (mail-out.m-online.net [212.18.0.9])\n\tby lists.denx.de (Postfix) with ESMTPS id 80E06C2204C\n\tfor <u-boot@lists.denx.de>; Wed, 13 Sep 2017 10:37:23 +0000 (UTC)","from frontend03.mail.m-online.net (unknown [192.168.6.182])\n\tby mail-out.m-online.net (Postfix) with ESMTP id 3xsdQV1Qr0z1qsD4;\n\tWed, 13 Sep 2017 12:37:22 +0200 (CEST)","from localhost (dynscan3.mnet-online.de [192.168.6.84])\n\tby mail.m-online.net (Postfix) with ESMTP id 3xsdQV0CdTz1qqks;\n\tWed, 13 Sep 2017 12:37:22 +0200 (CEST)","from mail.mnet-online.de ([192.168.8.182])\n\tby localhost (dynscan3.mail.m-online.net [192.168.6.84]) (amavisd-new,\n\tport 10024)\n\twith ESMTP id EJ0I64eYhHBQ; Wed, 13 Sep 2017 12:37:20 +0200 (CEST)","from [192.168.2.222] (89-64-27-66.dynamic.chello.pl [89.64.27.66])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby mail.mnet-online.de (Postfix) with ESMTPSA;\n\tWed, 13 Sep 2017 12:37:20 +0200 (CEST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW,\n\tRCVD_IN_MSPIKE_H3,\n\tRCVD_IN_MSPIKE_WL autolearn=unavailable autolearn_force=no\n\tversion=3.4.0","X-Virus-Scanned":"amavisd-new at mnet-online.de","X-Auth-Info":"niIAAxMDQfN6zCiDmEDbRndXAeAPmnlZ76OSuoFc5t4=","To":"Maxime Ripard <maxime.ripard@free-electrons.com>,\n\tTom Rini <trini@konsulko.com>, Jagan Teki <jagan@openedev.com>","References":"<cover.afe89ac52a0b82d1c12952c3cb82bb3762c85fa8.1505242834.git-series.maxime.ripard@free-electrons.com>\n\t<ba86e9aa151de6a619ab1ecb247647e49e15ae1e.1505242834.git-series.maxime.ripard@free-electrons.com>","From":"=?utf-8?q?=C5=81ukasz_Majewski?= <lukma@denx.de>","Organization":"DENX","Message-ID":"<78ba37a8-0020-d08b-1063-7f45e0383ea1@denx.de>","Date":"Wed, 13 Sep 2017 12:37:19 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<ba86e9aa151de6a619ab1ecb247647e49e15ae1e.1505242834.git-series.maxime.ripard@free-electrons.com>","Content-Language":"en-US","Cc":"Thomas Petazzoni <thomas.petazzoni@free-electrons.com>, marex@denx.de,\n\tu-boot@lists.denx.de","Subject":"Re: [U-Boot] [PATCH v2 01/14] usb: gadget: Move USBNET_DEVADDR\n\toption out of g_dnl","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<http://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=subscribe>","Content-Transfer-Encoding":"base64","Content-Type":"text/plain; charset=\"utf-8\"; Format=\"flowed\"","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>"}}]