[{"id":1772096,"web_url":"http://patchwork.ozlabs.org/comment/1772096/","msgid":"<32822ee7-ab8d-7455-e6ad-ac705fc54c4d@linaro.org>","list_archive_url":null,"date":"2017-09-20T17:21:55","subject":"Re: [Qemu-devel] [PATCH 15/19] nvic: Handle v8M changes in\n\tnvic_exec_prio()","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/people/72104/","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"content":"On 09/12/2017 01:14 PM, Peter Maydell wrote:\n> Update nvic_exec_prio() to support the v8M changes:\n> * BASEPRI, FAULTMASK and PRIMASK are all banked\n> * AIRCR.PRIS can affect NS priorities\n> * AIRCR.BFHFNMINS affects FAULTMASK behaviour\n> \n> These changes mean that it's no longer possible to\n> definitely say that if FAULTMASK is set it overrides\n> PRIMASK, and if PRIMASK is set it overrides BASEPRI\n> (since if PRIMASK_NS is set and AIRCR.PRIS is set then\n> whether that 0x80 priority should take effect or the\n> priority in BASEPRI_S depends on the value of BASEPRI_S,\n> for instance). So we switch to the same approach used\n> by the pseudocode of working through BASEPRI, PRIMASK\n> and FAULTMASK and overriding the previous values if\n> needed.\n> \n> Signed-off-by: Peter Maydell \n> ---\n> hw/intc/armv7m_nvic.c | 51 ++++++++++++++++++++++++++++++++++++++++++---------\n> 1 file changed, 42 insertions(+), 9 deletions(-)\n\nReviewed-by: Richard Henderson \n\nr~","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"g4DoVNZL\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xy64l6yt1z9s0Z\n\tfor ;\n\tThu, 21 Sep 2017 03:22:31 +1000 (AEST)","from localhost ([::1]:49897 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1duihh-00041z-Px\n\tfor incoming@patchwork.ozlabs.org; Wed, 20 Sep 2017 13:22:29 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:50630)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1duihH-00041i-3T\n\tfor qemu-devel@nongnu.org; Wed, 20 Sep 2017 13:22:04 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1duihD-0004po-PY\n\tfor qemu-devel@nongnu.org; Wed, 20 Sep 2017 13:22:03 -0400","from mail-io0-x233.google.com ([2607:f8b0:4001:c06::233]:56090)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1duihD-0004pE-I1\n\tfor qemu-devel@nongnu.org; Wed, 20 Sep 2017 13:21:59 -0400","by mail-io0-x233.google.com with SMTP id z187so5119046ioz.12\n\tfor ; Wed, 20 Sep 2017 10:21:59 -0700 (PDT)","from bigtime.twiddle.net (162.189-204-159.bestel.com.mx.\n\t[189.204.159.162]) by smtp.gmail.com with ESMTPSA id\n\tt205sm1666337oig.53.2017.09.20.10.21.57\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 20 Sep 2017 10:21:57 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=OrJ5uMlRKMMl++TWoSOvmuGCPCwv04nPYssFLzFHwO8=;\n\tb=g4DoVNZLonDiaH4AdLF5f708ZsyZth0a1xHxH94R/lMdiX8HC7ZKVb0P/3gTjZD91i\n\tFApe+4iglfFcclrlDP3cPfA9UeFpBsY18F89PfHBpMEt7UNOTo3lAX/Q8eVsleMArp2J\n\t7uojkhA6RPa5cGnz+w+TZA+/94mqajGnwoOtM=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=OrJ5uMlRKMMl++TWoSOvmuGCPCwv04nPYssFLzFHwO8=;\n\tb=anYDUPPnseq/lFzzqgtvCsCBkXjxMxiAWwtctPnQOGAN1ztVEoCspmtuWbi9pwGqYF\n\tQc2aDdVZKOuIHK5MX7eR0xNKHgO5K7fQmieIbJbRZKLkFnAHMzcZFYuWeHGeWoL4qoz2\n\tCjcf9fHjq7ZXg4O14dX2OZYjTiId7nuG9Z7YVLE8LeIW7ebdubyF5LOaPOLxzEFeABN8\n\t6oDT0RyAQdcC0uvBfwMbksJk/YTAtiDLJRsQt+LwlLNxWmKql5IvjobTJBerugMBHvun\n\tOcLJ3hV1fClnHiB1YlqwiSLfAa9CCWUs3wtIQ34kNUJjYtYs1uzMgJOW9fKa0zklymR3\n\ti+gg==","X-Gm-Message-State":"AHPjjUgJwEG/NhC9QLoKZWIQCROc/gJBYVLL07FXsqGSxrWnYmgcOR+1\n\t9lqhutAWuAMuWHBP3NBzZAnZlA==","X-Google-Smtp-Source":"AOwi7QD8n9rS3eDA36G3XLrQFfSwFYdMrw+aZ0wfN1dIWHfjGcg0AtBt+D8f2sBDwJUapUulAv1Wbw==","X-Received":"by 10.202.188.2 with SMTP id m2mr7095877oif.126.1505928118772;\n\tWed, 20 Sep 2017 10:21:58 -0700 (PDT)","To":"Peter Maydell , qemu-arm@nongnu.org,\n\tqemu-devel@nongnu.org","References":"<1505240046-11454-1-git-send-email-peter.maydell@linaro.org>\n\t<1505240046-11454-16-git-send-email-peter.maydell@linaro.org>","From":"Richard Henderson ","Message-ID":"<32822ee7-ab8d-7455-e6ad-ac705fc54c4d@linaro.org>","Date":"Wed, 20 Sep 2017 12:21:55 -0500","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<1505240046-11454-16-git-send-email-peter.maydell@linaro.org>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2607:f8b0:4001:c06::233","Subject":"Re: [Qemu-devel] [PATCH 15/19] nvic: Handle v8M changes in\n\tnvic_exec_prio()","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"patches@linaro.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]