[{"id":1771290,"web_url":"http://patchwork.ozlabs.org/comment/1771290/","msgid":"<1e3a6dd4-9b8b-b2c6-723a-5867167b1272@linaro.org>","list_archive_url":null,"date":"2017-09-19T18:48:30","subject":"Re: [Qemu-devel] [PATCH 11/19] nvic: Compare group priority for\n\tescalation to HF","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/people/72104/","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"content":"On 09/12/2017 01:13 PM, Peter Maydell wrote:\n> In armv7m_nvic_set_pending() we have to compare the\n> priority of an exception against the execution priority\n> to decide whether it needs to be escalated to HardFault.\n> In the specification this is a comparison against the\n> exception's group priority; for v7M we implemented it\n> as a comparison against the raw exception priority\n> because the two comparisons will always give the\n> same answer. For v8M the existence of AIRCR.PRIS and\n> the possibility of different PRIGROUP values for secure\n> and nonsecure exceptions means we need to explicitly\n> calculate the vector's group priority for this check.\n> \n> Signed-off-by: Peter Maydell \n> ---\n> hw/intc/armv7m_nvic.c | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n\nReviewed-by: Richard Henderson \n\nr~","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"a5iFy7us\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xxX3J5nQjz9s7g\n\tfor ;\n\tWed, 20 Sep 2017 04:49:16 +1000 (AEST)","from localhost ([::1]:44851 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1duNa7-0007Sb-05\n\tfor incoming@patchwork.ozlabs.org; Tue, 19 Sep 2017 14:49:15 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:37215)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1duNZW-0007RB-1P\n\tfor qemu-devel@nongnu.org; Tue, 19 Sep 2017 14:48:39 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1duNZS-0005X1-54\n\tfor qemu-devel@nongnu.org; Tue, 19 Sep 2017 14:48:38 -0400","from mail-io0-x22b.google.com ([2607:f8b0:4001:c06::22b]:53588)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1duNZR-0005Vm-WA\n\tfor qemu-devel@nongnu.org; Tue, 19 Sep 2017 14:48:34 -0400","by mail-io0-x22b.google.com with SMTP id q11so1298418ioe.10\n\tfor ; Tue, 19 Sep 2017 11:48:33 -0700 (PDT)","from bigtime.twiddle.net (162.189-204-159.bestel.com.mx.\n\t[189.204.159.162]) by smtp.gmail.com with ESMTPSA id\n\te17sm642606otj.15.2017.09.19.11.48.31\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 19 Sep 2017 11:48:32 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=O1j90dNY3tJbC2K2spNvPiospWeVguR32mP9i5A9vvM=;\n\tb=a5iFy7usOWCVoy3yuudzy7F/sFDAbRzxFdYTEqqsWpob6aNId+0AABSaECJ4XFzODc\n\tjvh8q9ElrgD1rdKuhXWqzh+Bt7YDfIROzltaIV2qEjH4wLab5TUshZ3EToCumDuGuEYD\n\tVfbQArzGRz/ZqW7OUMDzKkgEFZvm8qpWVNKz8=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=O1j90dNY3tJbC2K2spNvPiospWeVguR32mP9i5A9vvM=;\n\tb=rNB6Tgt1s4wpHhnwur6IUf7VJ8TaLtHC8jzKdwdC+c/JO0qFbhF0KPEQVd0l12U4wb\n\t1j99FZinEOUUcPS5B1b1oUMCphwZJD6os0Gsn0h/oMFo7KAs8/yP2rkHpYNWIPQLwSUK\n\tQswF6zQ/raCnppoVxeXhVMSWzHwl2frdjzJ5XGWN7Bxk+Opc+vNKI6XjIEE18xbto+3P\n\tSYS9iwtixERlPX+xV7DRqZ1BLGyT07bvc33Jc0VeryWkQdr92JoLTWi3ubb1sdlFZlWV\n\tr2fMb77RNRFskQ4ROb8MPwnikzdl1Nh4qugs2jCwDoVuDiRZ07cTJeORbckPJMNmBenZ\n\tcg/w==","X-Gm-Message-State":"AHPjjUj3MLzRnbJoKmyw6y9bIcwcls5iBZCxnzy9X4NUEjJtM2wNCZrX\n\ts9YDS4aCqH0XiTCcROLRc6iomA==","X-Google-Smtp-Source":"AOwi7QDYEQntxIJEn1FgcCCMMGRIzG6pf0o3LF9cFVsytedVdL6T2HkLJTMBAH+IIHyDRg44FcXddw==","X-Received":"by 10.202.77.4 with SMTP id a4mr2448748oib.70.1505846913256;\n\tTue, 19 Sep 2017 11:48:33 -0700 (PDT)","To":"Peter Maydell , qemu-arm@nongnu.org,\n\tqemu-devel@nongnu.org","References":"<1505240046-11454-1-git-send-email-peter.maydell@linaro.org>\n\t<1505240046-11454-12-git-send-email-peter.maydell@linaro.org>","From":"Richard Henderson ","Message-ID":"<1e3a6dd4-9b8b-b2c6-723a-5867167b1272@linaro.org>","Date":"Tue, 19 Sep 2017 13:48:30 -0500","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<1505240046-11454-12-git-send-email-peter.maydell@linaro.org>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2607:f8b0:4001:c06::22b","Subject":"Re: [Qemu-devel] [PATCH 11/19] nvic: Compare group priority for\n\tescalation to HF","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"patches@linaro.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]