[{"id":1771286,"web_url":"http://patchwork.ozlabs.org/comment/1771286/","msgid":"","list_archive_url":null,"date":"2017-09-19T18:41:32","subject":"Re: [Qemu-devel] [PATCH 09/19] nvic: Make set_pending and\n\tclear_pending take a secure parameter","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/people/72104/","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"content":"On 09/12/2017 01:13 PM, Peter Maydell wrote:\n> Make the armv7m_nvic_set_pending() and armv7m_nvic_clear_pending()\n> functions take a bool indicating whether to pend the secure\n> or non-secure version of a banked interrupt, and update the\n> callsites accordingly.\n> \n> In most callsites we can simply pass the correct security\n> state in; in a couple of cases we use TODO comments to indicate\n> that we will return the code in a subsequent commit.\n> \n> Signed-off-by: Peter Maydell \n> ---\n> target/arm/cpu.h | 14 ++++++++++-\n> hw/intc/armv7m_nvic.c | 64 ++++++++++++++++++++++++++++++++++++++-------------\n> target/arm/helper.c | 24 +++++++++++--------\n> hw/intc/trace-events | 4 ++--\n> 4 files changed, 77 insertions(+), 29 deletions(-)\n\nReviewed-by: Richard Henderson \n\nr~","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"arlyYK1Q\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xxWvD0WJ0z9s7m\n\tfor ;\n\tWed, 20 Sep 2017 04:42:13 +1000 (AEST)","from localhost ([::1]:44835 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1duNTF-00058m-J0\n\tfor incoming@patchwork.ozlabs.org; Tue, 19 Sep 2017 14:42:09 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:33228)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1duNSr-0004x0-Tu\n\tfor qemu-devel@nongnu.org; Tue, 19 Sep 2017 14:41:47 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1duNSl-0007Pf-Rb\n\tfor qemu-devel@nongnu.org; Tue, 19 Sep 2017 14:41:43 -0400","from mail-io0-x235.google.com ([2607:f8b0:4001:c06::235]:49295)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1duNSl-0007LP-MD\n\tfor qemu-devel@nongnu.org; Tue, 19 Sep 2017 14:41:39 -0400","by mail-io0-x235.google.com with SMTP id 21so1291994iof.6\n\tfor ; Tue, 19 Sep 2017 11:41:37 -0700 (PDT)","from bigtime.twiddle.net (162.189-204-159.bestel.com.mx.\n\t[189.204.159.162]) by smtp.gmail.com with ESMTPSA id\n\te17sm634779otj.15.2017.09.19.11.41.34\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 19 Sep 2017 11:41:35 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=tMyhnpcSaKr0Gv+lJYw707LF378sWq2+SFcsgpXjOpE=;\n\tb=arlyYK1Q68HSlCN1sQ/AorRPZfPu+7M2DLzcWtI0or7oa4WuWF3/wbQrfveryieOUi\n\txmW0qKv+9APSnR7mVmSu/N695tb61IHoI1qRLjH8XuYEioT3BHMh9ulLQf2crB/Yr0Sa\n\t2DFYVQY5GcJOMNKWiI3CLFpVgc5kv463AgdTg=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=tMyhnpcSaKr0Gv+lJYw707LF378sWq2+SFcsgpXjOpE=;\n\tb=ElnnmvaudYQv6D3xLb4+vjQk05Jhi6YdyFG0NbFfztFCgzZJ5AtPg4LNtRLbX2Y54T\n\tetcRYjcIp98MW6HGJmUnB2fjPzHQMbwoff83WCOLxgaE111glVuaa3IJeWOaFrjrjxNF\n\tWFSVioZghpK7rEyT4Tqkhe1/KLiQfTwgroX5RDeglL2zImSvXf26kmwR7+J29a1Vybsx\n\t+7Og5cVxhgOtR6sJq6MsBMyVrnXka6mMsEicGwpKwXeHukzpurFFk3KfTFCEg4Y5nNmO\n\tlBWKe//h4yX/9B5wzcZ+uqsq2V9tWp63JO7SgmZrrl+RcSt8vISL4MGgEBsGclpCAGME\n\tM5gQ==","X-Gm-Message-State":"AHPjjUhhl7atDyr7hys+PUWcYuvsfXqSI55y5pE14zeayzPCTTUAjDZ5\n\tDTIHDny7izDuMGsbSKf5uYAb3g==","X-Google-Smtp-Source":"AOwi7QAd/fCqXw7WVLM2NiEjaHXr7hzP4054FawmPipR6FZBFXnIB2URdHChH6317oi2k0fr1C+OfA==","X-Received":"by 10.202.102.36 with SMTP id a36mr1848158oic.83.1505846496514; \n\tTue, 19 Sep 2017 11:41:36 -0700 (PDT)","To":"Peter Maydell , qemu-arm@nongnu.org,\n\tqemu-devel@nongnu.org","References":"<1505240046-11454-1-git-send-email-peter.maydell@linaro.org>\n\t<1505240046-11454-10-git-send-email-peter.maydell@linaro.org>","From":"Richard Henderson ","Message-ID":"","Date":"Tue, 19 Sep 2017 13:41:32 -0500","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<1505240046-11454-10-git-send-email-peter.maydell@linaro.org>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2607:f8b0:4001:c06::235","Subject":"Re: [Qemu-devel] [PATCH 09/19] nvic: Make set_pending and\n\tclear_pending take a secure parameter","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"patches@linaro.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]