[{"id":1772155,"web_url":"http://patchwork.ozlabs.org/comment/1772155/","msgid":"","list_archive_url":null,"date":"2017-09-20T18:39:15","subject":"Re: [Qemu-devel] [PATCH 19/19] nvic: Support banked exceptions in\n\tacknowledge and complete","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/people/72104/","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"content":"On 09/12/2017 01:14 PM, Peter Maydell wrote:\n> Update armv7m_nvic_acknowledge_irq() and armv7m_nvic_complete_irq()\n> to handle banked exceptions:\n> * acknowledge needs to use the correct vector, which may be\n> in sec_vectors[]\n> * acknowledge needs to return to its caller whether the\n> exception should be taken to secure or non-secure state\n> * complete needs its caller to tell it whether the exception\n> being completed is a secure one or not\n> \n> Signed-off-by: Peter Maydell \n> ---\n> target/arm/cpu.h | 15 +++++++++++++--\n> hw/intc/armv7m_nvic.c | 26 ++++++++++++++++++++------\n> target/arm/helper.c | 8 +++++---\n> hw/intc/trace-events | 4 ++--\n> 4 files changed, 40 insertions(+), 13 deletions(-)\n\nReviewed-by: Richard Henderson \n\nr~","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"B534JIZP\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xy7p04vkwz9ryk\n\tfor ;\n\tThu, 21 Sep 2017 04:39:52 +1000 (AEST)","from localhost ([::1]:50151 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dujuY-0000ZH-SD\n\tfor incoming@patchwork.ozlabs.org; Wed, 20 Sep 2017 14:39:50 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:57008)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1duju6-0000Z5-KU\n\tfor qemu-devel@nongnu.org; Wed, 20 Sep 2017 14:39:23 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1duju3-0005vS-I6\n\tfor qemu-devel@nongnu.org; Wed, 20 Sep 2017 14:39:22 -0400","from mail-io0-x22a.google.com ([2607:f8b0:4001:c06::22a]:54572)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1duju3-0005u8-Cc\n\tfor qemu-devel@nongnu.org; Wed, 20 Sep 2017 14:39:19 -0400","by mail-io0-x22a.google.com with SMTP id h66so5634556ioh.11\n\tfor ; Wed, 20 Sep 2017 11:39:19 -0700 (PDT)","from bigtime.twiddle.net (162.189-204-159.bestel.com.mx.\n\t[189.204.159.162]) by smtp.gmail.com with ESMTPSA id\n\ta194sm2002573oii.36.2017.09.20.11.39.17\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 20 Sep 2017 11:39:17 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=ftqO8t4Gl5V5VFnYZeGeeAStooWIYtNmQvOmi4mVhag=;\n\tb=B534JIZPfmLk6c2EHwTjYBemdhrq+jQPQH/OUIgRa7jGEuNZZUn+HMxEX7hDV52OR9\n\tf0OpYgYehfujthUqp5ihz7+RxdXiBcRHDbxrh0DOyzKMTK+voK1cfNf84wpVl2QfwTYi\n\tjUMEFq4e9/rY5ccH6owOIejMQqJiPborsvCrQ=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=ftqO8t4Gl5V5VFnYZeGeeAStooWIYtNmQvOmi4mVhag=;\n\tb=ap2fyv/sycgrREUcW1/l5fWTux5HrTN9IfYjPLLlhWgCOGSlYOpomdXaVELWCROytt\n\ti6YJlypZ3HiujhqUhPhe8F5ezb3a6llCD8fh7ung5wEjSpJ5NGgEyKQqnFuBODM5+0kV\n\trT4FquD59uXd5lQgprXMPS1AizQrPxYA1QtTIkKg+i0suzcJPnR9gqPvx+gCW5lvLxOg\n\tC04yXBM44MqE6bnUHLOCN6Nk5+N+xok7+QKJrR7nB1v6sStcv3rgT43asBMUMtTRBPGP\n\tlW4tf3jhU0scYiRG/R8OaTh0+/l186X+l9DnKcYv4UZ4b4GU+z4wBInVbuB7U1MHhkdG\n\t8TtQ==","X-Gm-Message-State":"AHPjjUjh51gW1KAppn820KkuK++oyx0HDeJovdbZwooe2ws8zMm4cNbE\n\tIqP53VUZVIMTHnr6iAtQLqar3g==","X-Google-Smtp-Source":"AOwi7QBhWkQQMP4bLHgPOy+vi6qh95m8Vw+4R6H5zFJR4UUl/3y+F/Yk0rmClsZMlK8w4HtbPjEJKQ==","X-Received":"by 10.202.44.134 with SMTP id s128mr6460076ois.99.1505932758739; \n\tWed, 20 Sep 2017 11:39:18 -0700 (PDT)","To":"Peter Maydell , qemu-arm@nongnu.org,\n\tqemu-devel@nongnu.org","References":"<1505240046-11454-1-git-send-email-peter.maydell@linaro.org>\n\t<1505240046-11454-20-git-send-email-peter.maydell@linaro.org>","From":"Richard Henderson ","Message-ID":"","Date":"Wed, 20 Sep 2017 13:39:15 -0500","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<1505240046-11454-20-git-send-email-peter.maydell@linaro.org>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2607:f8b0:4001:c06::22a","Subject":"Re: [Qemu-devel] [PATCH 19/19] nvic: Support banked exceptions in\n\tacknowledge and complete","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"patches@linaro.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]