[{"id":1768237,"web_url":"http://patchwork.ozlabs.org/comment/1768237/","msgid":"<41634883-f5ad-a43a-d4d1-378176c95b67@linaro.org>","list_archive_url":null,"date":"2017-09-13T23:08:30","subject":"Re: [Qemu-devel] [PATCH 02/19] nvic: Add banked exception states","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/people/72104/","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"content":"On 09/12/2017 11:13 AM, Peter Maydell wrote:\n> For the v8M security extension, some exceptions must be banked\n> between security states. Add the new vecinfo array which holds\n> the state for the banked exceptions and migrate it if the\n> CPU the NVIC is attached to implements the security extension.\n> \n> Signed-off-by: Peter Maydell \n> ---\n> include/hw/intc/armv7m_nvic.h | 14 +++++++++++++\n> hw/intc/armv7m_nvic.c | 49 ++++++++++++++++++++++++++++++++++++++++++-\n> 2 files changed, 62 insertions(+), 1 deletion(-)\n\nReviewed-by: Richard Henderson \n\n\nr~","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"BYB+J479\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xsy5r2mFXz9t0F\n\tfor ;\n\tThu, 14 Sep 2017 09:09:03 +1000 (AEST)","from localhost ([::1]:44961 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dsGmC-0004cv-25\n\tfor incoming@patchwork.ozlabs.org; Wed, 13 Sep 2017 19:09:00 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:53859)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dsGlr-0004cH-LP\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 19:08:40 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dsGlm-0008LE-Mr\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 19:08:39 -0400","from mail-pg0-x231.google.com ([2607:f8b0:400e:c05::231]:47867)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1dsGlm-0008Kg-Gn\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 19:08:34 -0400","by mail-pg0-x231.google.com with SMTP id d8so3071350pgt.4\n\tfor ; Wed, 13 Sep 2017 16:08:34 -0700 (PDT)","from bigtime.twiddle.net (97-126-103-167.tukw.qwest.net.\n\t[97.126.103.167]) by smtp.gmail.com with ESMTPSA id\n\tr138sm26152204pgr.12.2017.09.13.16.08.32\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 13 Sep 2017 16:08:32 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=aJ7VOuXov0xK9rkpdiPW+/MSGdn/CoRdZwW8lbSodyU=;\n\tb=BYB+J479T4ZAJlJjjDnDj8YJVuhbGTg6Y+xIMJTlJulM2LVpxOs9WTadEvOYB6BQW4\n\tvj+2aMK+GuR7cDuHe3PplMB22uUJlXisEefwrYXZlEtpCooojb3oJNkyqiaXCH/mPUxh\n\tBwAF5yEgn+SGEJb3twPoleceBokEX6tgnYRbg=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=aJ7VOuXov0xK9rkpdiPW+/MSGdn/CoRdZwW8lbSodyU=;\n\tb=ozynYh+isWqgIQFAS/VXB1NXHwIlhze3dyOHP3w+LeLDN5H7hUpCKLi4KsFOxXnAGx\n\tEJGHgUsf/9SlKoDLxw1MijZAjC06AaqyDSwibQgNQ7rhDpZ1KXVNizNVYPr2dQ3V9p6k\n\td/IEvW99AsbJpwHdikwJRgeQxGZ7vHLt0uZrf17TnSaRlrgQzDp88VIS5Dm7TXCwHmzX\n\tM4bnocr67tfFUh047U6P011EmCrc+xSNw5LaFOd/XAyUHVPvfC4fB1AkxeHmzcr748cF\n\t+gCBgVtXgil4OH664aKp7qAv8hutSxQn5c9H+/UvsxdG5jViGurzIvclQSRGU5CErNtH\n\tXQPg==","X-Gm-Message-State":"AHPjjUhrCIuwU8/v95B1oeIHStIaeGE9ClqAGWNi8pP01fWXQykkduwF\n\tqADO3cRGnNwUQ440","X-Google-Smtp-Source":"ADKCNb6rpBijX5Rm5JPgPs1NKVB+lmRlOlx4YMqgz4mx/ZVyJcSk5qhiETN2Lq3pn3227op06763eA==","X-Received":"by 10.98.214.23 with SMTP id r23mr19890771pfg.195.1505344113543; \n\tWed, 13 Sep 2017 16:08:33 -0700 (PDT)","To":"Peter Maydell , qemu-arm@nongnu.org,\n\tqemu-devel@nongnu.org","References":"<1505240046-11454-1-git-send-email-peter.maydell@linaro.org>\n\t<1505240046-11454-3-git-send-email-peter.maydell@linaro.org>","From":"Richard Henderson ","Message-ID":"<41634883-f5ad-a43a-d4d1-378176c95b67@linaro.org>","Date":"Wed, 13 Sep 2017 16:08:30 -0700","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<1505240046-11454-3-git-send-email-peter.maydell@linaro.org>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2607:f8b0:400e:c05::231","Subject":"Re: [Qemu-devel] [PATCH 02/19] nvic: Add banked exception states","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"patches@linaro.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1771282,"web_url":"http://patchwork.ozlabs.org/comment/1771282/","msgid":"","list_archive_url":null,"date":"2017-09-19T18:31:44","subject":"Re: [Qemu-devel] [Qemu-arm] [PATCH 02/19] nvic: Add banked\n\texception states","submitter":{"id":5111,"url":"http://patchwork.ozlabs.org/api/people/5111/","name":"Peter Maydell","email":"peter.maydell@linaro.org"},"content":"On 12 September 2017 at 19:13, Peter Maydell wrote:\n> For the v8M security extension, some exceptions must be banked\n> between security states. Add the new vecinfo array which holds\n> the state for the banked exceptions and migrate it if the\n> CPU the NVIC is attached to implements the security extension.\n>\n> Signed-off-by: Peter Maydell \n\n> +static const VMStateDescription vmstate_nvic_security = {\n> + .name = \"nvic/m-security\",\n> + .version_id = 1,\n> + .minimum_version_id = 1,\n> + .needed = nvic_security_needed,\n> + .post_load = &nvic_security_post_load,\n> + .fields = (VMStateField[]) {\n> + VMSTATE_STRUCT_ARRAY(sec_vectors, NVICState, NVIC_INTERNAL_VECTORS, 1,\n> + vmstate_VecInfo, VecInfo),\n> + VMSTATE_END_OF_LIST()\n> + }\n> +};\n> +\n> static const VMStateDescription vmstate_nvic = {\n> .name = \"armv7m_nvic\",\n> .version_id = 4,\n\nThis patch needs the following folded in, so that we actually\ninclude the new vmstate subsection in the top level's subsection\nlist...\n\ndiff --git a/hw/intc/armv7m_nvic.c b/hw/intc/armv7m_nvic.c\nindex 694b9e0..8793f75 100644\n--- a/hw/intc/armv7m_nvic.c\n+++ b/hw/intc/armv7m_nvic.c\n@@ -1205,6 +1205,10 @@ static const VMStateDescription vmstate_nvic = {\n vmstate_VecInfo, VecInfo),\n VMSTATE_UINT32(prigroup, NVICState),\n VMSTATE_END_OF_LIST()\n+ },\n+ .subsections = (const VMStateDescription*[]) {\n+ &vmstate_nvic_security,\n+ NULL\n }\n };\n\nthanks\n-- PMM","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"Sf6IkNOV\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xxWlq0Cbxz9sBZ\n\tfor ;\n\tWed, 20 Sep 2017 04:35:50 +1000 (AEST)","from localhost ([::1]:44808 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1duNN6-00018j-Fj\n\tfor incoming@patchwork.ozlabs.org; Tue, 19 Sep 2017 14:35:48 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:55618)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1duNJX-0007BP-7r\n\tfor qemu-devel@nongnu.org; Tue, 19 Sep 2017 14:32:13 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1duNJW-0002rl-CY\n\tfor qemu-devel@nongnu.org; Tue, 19 Sep 2017 14:32:07 -0400","from mail-wm0-x231.google.com ([2a00:1450:400c:c09::231]:43623)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1duNJW-0002pv-6U\n\tfor qemu-devel@nongnu.org; Tue, 19 Sep 2017 14:32:06 -0400","by mail-wm0-x231.google.com with SMTP id a137so1155922wma.0\n\tfor ; Tue, 19 Sep 2017 11:32:06 -0700 (PDT)","by 10.223.139.215 with HTTP; Tue, 19 Sep 2017 11:31:44 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=NlyGwrGBShUp0VZmPB3XJvAWyqtCTRlPHjp1c1Jg84k=;\n\tb=Sf6IkNOVgx6BwVcddSz6ujQ5u81OZ1EGyksLZwwbZnH7Fmx30MdbOhATGrx/UdrNcs\n\tMBIT1J6KtaDNYc7BZjFlIi2aWuGoTs5zOfKpY8g+rtB03lOjxMb2ZlkRjSY0F4m/4OJm\n\tmtou/fIi2BaujKIzclyYmkkcIFJyGCe2ZcSCc=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=NlyGwrGBShUp0VZmPB3XJvAWyqtCTRlPHjp1c1Jg84k=;\n\tb=QQlkk6UFgiondsswAA0oJRMElwVR2NKtyCnsPrMstudCAh+sUALU9Qdg+OzgTvHUWl\n\t5QgUHpEUrkRoyqMSMUIA02+kR2puDFU1d/ZyIOESt4KnSX5W4iPMnSN6kPe3mDZyw16v\n\tz8NJqmH5++NckpHcDEfpWeym/SY7M1EtmP5vrYsfM+Eni2AFDgbvEMP5Rx2SBUOlpQr4\n\trciTSRbOOUYwiOnttSkHHRWg+VwVOlJf57Xo0oF6qwdYyfZYnk6u4m/ZJq91YekgJZwB\n\ttzNRfNI/YtqUAnLIfGV7ZnDNxBKwl5rlsJrdNDBQ5dRFgdEnJ+5+JbM2TTkw1ookuh1M\n\tcg2A==","X-Gm-Message-State":"AHPjjUhl2/Cng9ol7gFte77uZUHmjHqdQKFQhN6K1wZlQm8h+dsEn/mj\n\tjJltYuO6KzdGdCQTk2hhoYfGlkXBqm+UmcUlpQ/sTS5K","X-Google-Smtp-Source":"AOwi7QAD8LORL87FXZBAileNNuo7DEeOknCq2yxy+MCllK4g1ukD2YcJRiJPGcf7ZLSHdBVoMobTEqQm+VEGtqjrMVU=","X-Received":"by 10.28.166.135 with SMTP id p129mr1929285wme.147.1505845925138;\n\tTue, 19 Sep 2017 11:32:05 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<1505240046-11454-3-git-send-email-peter.maydell@linaro.org>","References":"<1505240046-11454-1-git-send-email-peter.maydell@linaro.org>\n\t<1505240046-11454-3-git-send-email-peter.maydell@linaro.org>","From":"Peter Maydell ","Date":"Tue, 19 Sep 2017 19:31:44 +0100","Message-ID":"","To":"qemu-arm , QEMU Developers ","Content-Type":"text/plain; charset=\"UTF-8\"","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2a00:1450:400c:c09::231","Subject":"Re: [Qemu-devel] [Qemu-arm] [PATCH 02/19] nvic: Add banked\n\texception states","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"\"patches@linaro.org\" ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]