[{"id":1773912,"web_url":"http://patchwork.ozlabs.org/comment/1773912/","msgid":"","list_archive_url":null,"date":"2017-09-22T22:14:43","subject":"Re: [U-Boot] [PATCH 2/6] ARM: rmobile: Move HSUSB configuration to\n\tboard on Salvator-X","submitter":{"id":1028,"url":"http://patchwork.ozlabs.org/api/people/1028/","name":"Nobuhiro Iwamatsu","email":"iwamatsu@nigauri.org"},"content":"Hi,\n\n2017-09-13 2:07 GMT+09:00 Marek Vasut :\n> In order to use ehci-generic driver, move the configuration of HSUSB\n> block into the board file. This configuration should not have been in\n> the Gen3 EHCI USB driver in the first place, so move it to the board\n> file until there is a proper infrastructure and driver for the HSUSB\n> block.\n>\n> Signed-off-by: Marek Vasut \n> Cc: Nobuhiro Iwamatsu \n\nApplied to rmobile branch.\n\nThanks,\n Nobuhiro\n\n> ---\n> board/renesas/salvator-x/salvator-x.c | 16 ++++++++++++++++\n> 1 file changed, 16 insertions(+)\n>\n> diff --git a/board/renesas/salvator-x/salvator-x.c b/board/renesas/salvator-x/salvator-x.c\n> index e260117802..37fcbbd448 100644\n> --- a/board/renesas/salvator-x/salvator-x.c\n> +++ b/board/renesas/salvator-x/salvator-x.c\n> @@ -55,6 +55,7 @@ void s_init(void)\n> #define SD1_MSTP313 BIT(13)\n> #define SD2_MSTP312 BIT(12) /* either MMC0 */\n> #define SD3_MSTP311 BIT(11) /* either MMC1 */\n> +#define HSUSB_MSTP704 BIT(4) /* HSUSB */\n>\n> #define SD0CKCR 0xE6150074\n> #define SD1CKCR 0xE6150078\n> @@ -92,6 +93,13 @@ int board_early_init_f(void)\n> /* -/W 32 Power resume control register 2 (3DG) */\n> #define SYSC_PWRONCR2 0xE618010C\n>\n> +/* HSUSB block registers */\n> +#define HSUSB_REG_LPSTS 0xE6590102\n> +#define HSUSB_REG_LPSTS_SUSPM_NORMAL BIT(14)\n> +#define HSUSB_REG_UGCTRL2 0xE6590184\n> +#define HSUSB_REG_UGCTRL2_USB0SEL 0x30\n> +#define HSUSB_REG_UGCTRL2_USB0SEL_EHCI 0x10\n> +\n> int board_init(void)\n> {\n> /* adress of boot parameters */\n> @@ -116,6 +124,14 @@ int board_init(void)\n> /* USB1 pull-up */\n> setbits_le32(PFC_PUEN6, PUEN_USB1_OVC | PUEN_USB1_PWEN);\n>\n> + /* Configure the HSUSB block */\n> + mstp_clrbits_le32(MSTPSR7, SMSTPCR7, HSUSB_MSTP704);\n> + /* Choice USB0SEL */\n> + clrsetbits_le32(HSUSB_REG_UGCTRL2, HSUSB_REG_UGCTRL2_USB0SEL,\n> + HSUSB_REG_UGCTRL2_USB0SEL_EHCI);\n> + /* low power status */\n> + setbits_le16(HSUSB_REG_LPSTS, HSUSB_REG_LPSTS_SUSPM_NORMAL);\n> +\n> #ifdef CONFIG_RENESAS_RAVB\n> /* EtherAVB Enable */\n> /* GPSR2 */\n> --\n> 2.11.0\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=nigauri-org.20150623.gappssmtp.com\n\theader.i=@nigauri-org.20150623.gappssmtp.com\n\theader.b=\"r2KZPxWx\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xzSTv0JWlz9sPk\n\tfor ;\n\tSat, 23 Sep 2017 08:15:30 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid BAFD9C21E48; Fri, 22 Sep 2017 22:15:20 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 807AAC21C39;\n\tFri, 22 Sep 2017 22:15:18 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 6B364C21C39; Fri, 22 Sep 2017 22:15:16 +0000 (UTC)","from mail-io0-f195.google.com (mail-io0-f195.google.com\n\t[209.85.223.195])\n\tby lists.denx.de (Postfix) with ESMTPS id B1896C21C26\n\tfor ; Fri, 22 Sep 2017 22:15:15 +0000 (UTC)","by mail-io0-f195.google.com with SMTP id e9so374753iod.5\n\tfor ; Fri, 22 Sep 2017 15:15:15 -0700 (PDT)","by 10.107.29.5 with HTTP; Fri, 22 Sep 2017 15:14:43 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE,\n\tRCVD_IN_MSPIKE_H2,\n\tT_DKIM_INVALID autolearn=unavailable autolearn_force=no\n\tversion=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=nigauri-org.20150623.gappssmtp.com; s=20150623;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=AGZ7FLGnChYrEIL+Ny9NWXeyxUIw6r/uR2mujRqv5GA=;\n\tb=r2KZPxWxYEHZmYhGqoCu60i+/sYQL1ubTnN4/BWsaXn1OMSGkIZdsoti+rwgJm7UeL\n\tCuZL7GXK6OzoNFl5Bb0TKEhsWAvZpfiGrQzcwR46FrOJLSAP/Lom2Ib8aDkXjBWeq6aG\n\tpLPP0K31T5Htd3XyNPHvFcxH0Gg00VAlAhSM84SkqWTprCfgBpLHpcmVRMMjw9NlIAno\n\tUqICgBO4mk/fqHC5cnp1AZ5+9woIRPL6yFVaVu7pyg2YXjbjyF0SZpbiNlhCUNgacWpa\n\tiRG2B9bIjYVv2+OSgmrDA9yLAVzNO0uqDjuZ3iwcMBcnPetB43yPpk975PVbxHKpgOx+\n\tuuEg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=AGZ7FLGnChYrEIL+Ny9NWXeyxUIw6r/uR2mujRqv5GA=;\n\tb=lGLNWpYWJIvGlVcuOZgznFXMsctxovls2FkBHpzZjk30AznfrhnQ5dlnDR8ARDfeHN\n\t5fFCtxMSA0CKe1CKWCpidjAjFnGGD53pGLKnJXz83v6EMyid15evUwyjlwI1kkFfY+w/\n\tt8lUYKLWezCQN4nJVTP29Wic4qjwTFZEJ4q/VnOeNczo5f1YtwE+/L9d9ihlDnZOwPjL\n\tp0YBXtJfkUpx+B7dCtmxRh2B0zfKh2EiY+mYVViNNANS2+V27hrFa3ZfxKXMKmJtbFgj\n\tfP2zOolVCgmhUJr5/Swsbdq8vNJwYNlLC/ATbvu2aARqAJVJFiLloikKVgUoPAHrtxCM\n\taJ7g==","X-Gm-Message-State":"AHPjjUgfwqB7DGyreOG5BrTYXlBItddrSyz6G1N23ssHn6bo86mqt7ME\n\tRENSh9IQ3SheZ+sp9/4B3f0NgtgKith7TUMSI4Lx","X-Google-Smtp-Source":"AOwi7QC+PXR3njMW1vrgj3Ukr3pAu1I6Rpa0PMB9Sg8XIHf4UQYACaMbbyIdqxDiY7Nyl20scKS71CKdTUW63e/gkMM=","X-Received":"by 10.107.152.75 with SMTP id a72mr982851ioe.242.1506118514212; \n\tFri, 22 Sep 2017 15:15:14 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170912170725.29733-2-marek.vasut+renesas@gmail.com>","References":"<20170912170725.29733-1-marek.vasut+renesas@gmail.com>\n\t<20170912170725.29733-2-marek.vasut+renesas@gmail.com>","From":"Nobuhiro Iwamatsu ","Date":"Sat, 23 Sep 2017 07:14:43 +0900","Message-ID":"","To":"Marek Vasut ","Cc":"U-Boot ,\n\tMarek Vasut ","Subject":"Re: [U-Boot] [PATCH 2/6] ARM: rmobile: Move HSUSB configuration to\n\tboard on Salvator-X","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}}]