[{"id":1767289,"web_url":"http://patchwork.ozlabs.org/comment/1767289/","msgid":"<6f1f0e95-ca3e-d988-d5b9-05f29fd55053@amsat.org>","list_archive_url":null,"date":"2017-09-12T18:52:38","subject":"Re: [Qemu-devel] [PATCH v2 12/16] tcg: Remove tcg_regset_set","submitter":{"id":70924,"url":"http://patchwork.ozlabs.org/api/people/70924/","name":"Philippe Mathieu-Daudé","email":"f4bug@amsat.org"},"content":"On 09/12/2017 01:25 PM, Richard Henderson wrote:\n> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>\n\nReviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>\n\n> ---\n>   tcg/tcg.h | 1 -\n>   tcg/tcg.c | 8 ++++----\n>   2 files changed, 4 insertions(+), 5 deletions(-)\n> \n> diff --git a/tcg/tcg.h b/tcg/tcg.h\n> index 7226727ee4..e168bd2c44 100644\n> --- a/tcg/tcg.h\n> +++ b/tcg/tcg.h\n> @@ -210,7 +210,6 @@ typedef enum TCGOpcode {\n>       NB_OPS,\n>   } TCGOpcode;\n>   \n> -#define tcg_regset_set(d, s) (d) = (s)\n>   #define tcg_regset_set32(d, reg, val32) (d) |= (val32) << (reg)\n>   #define tcg_regset_set_reg(d, r) (d) |= 1L << (r)\n>   #define tcg_regset_reset_reg(d, r) (d) &= ~(1L << (r))\n> diff --git a/tcg/tcg.c b/tcg/tcg.c\n> index f40cce3364..873915925f 100644\n> --- a/tcg/tcg.c\n> +++ b/tcg/tcg.c\n> @@ -2452,7 +2452,7 @@ static void tcg_reg_alloc_mov(TCGContext *s, const TCGOpDef *def,\n>       TCGTemp *ts, *ots;\n>       TCGType otype, itype;\n>   \n> -    tcg_regset_set(allocated_regs, s->reserved_regs);\n> +    allocated_regs = s->reserved_regs;\n>       ots = &s->temps[args[0]];\n>       ts = &s->temps[args[1]];\n>   \n> @@ -2540,8 +2540,8 @@ static void tcg_reg_alloc_op(TCGContext *s,\n>              args + nb_oargs + nb_iargs,\n>              sizeof(TCGArg) * def->nb_cargs);\n>   \n> -    tcg_regset_set(i_allocated_regs, s->reserved_regs);\n> -    tcg_regset_set(o_allocated_regs, s->reserved_regs);\n> +    i_allocated_regs = s->reserved_regs;\n> +    o_allocated_regs = s->reserved_regs;\n>   \n>       /* satisfy input constraints */\n>       for(k = 0; k < nb_iargs; k++) {\n> @@ -2741,7 +2741,7 @@ static void tcg_reg_alloc_call(TCGContext *s, int nb_oargs, int nb_iargs,\n>       }\n>       \n>       /* assign input registers */\n> -    tcg_regset_set(allocated_regs, s->reserved_regs);\n> +    allocated_regs = s->reserved_regs;\n>       for(i = 0; i < nb_regs; i++) {\n>           arg = args[nb_oargs + i];\n>           if (arg != TCG_CALL_DUMMY_ARG) {\n>","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"LpUiOhIa\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xsDTJ1f10z9s9Y\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 13 Sep 2017 04:53:23 +1000 (AEST)","from localhost ([::1]:38150 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1drqJG-0007GW-46\n\tfor incoming@patchwork.ozlabs.org; Tue, 12 Sep 2017 14:53:22 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:60763)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <philippe.mathieu.daude@gmail.com>)\n\tid 1drqIf-0007El-Eu\n\tfor qemu-devel@nongnu.org; Tue, 12 Sep 2017 14:52:46 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <philippe.mathieu.daude@gmail.com>)\n\tid 1drqIb-0008T9-SR\n\tfor qemu-devel@nongnu.org; Tue, 12 Sep 2017 14:52:45 -0400","from mail-qk0-x244.google.com ([2607:f8b0:400d:c09::244]:35617)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from <philippe.mathieu.daude@gmail.com>)\n\tid 1drqIb-0008Sw-Nq\n\tfor qemu-devel@nongnu.org; Tue, 12 Sep 2017 14:52:41 -0400","by mail-qk0-x244.google.com with SMTP id o77so7705781qke.2\n\tfor <qemu-devel@nongnu.org>; Tue, 12 Sep 2017 11:52:41 -0700 (PDT)","from [192.168.1.10] ([181.93.89.178])\n\tby smtp.gmail.com with ESMTPSA id\n\tg33sm7106025qtc.52.2017.09.12.11.52.39\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 12 Sep 2017 11:52:40 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=EGIN9a5aoeCzjYulAxHDBVF+kQ5OzJnrfYyq1oD4S4Q=;\n\tb=LpUiOhIaUAAlljwfFeeSmGfkkRUra7duCdXLlohUk6EBnENT91GBasRfSUOve1J4Nb\n\tXgqgkjpJgaTh3wqmgW5p+NYTBMDfxuTH17KM4mW8HcMOK2FZ7Jgeb4AcgeiKNkCiHHcG\n\tFMy9RoED7uC+wFrL/Lk6TzD6QsTLUTK+5M/Q0UokzzCWEdb8TpHphJVjUEQ3foViNxct\n\tFG2YIQAy/tu0hJ/yD4DqO3fB6hWFxAWjf4gRSRqE+M1ra2nwB/iWHFqH8rzpUn16cyUF\n\t4QHmmZwIzP1RKHKJUw+MirwmIW4HpOF6198IqVVFteH3cYy0nfNBYvUDR56aJU8sMopR\n\trNrg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:subject:to:cc:references:from:message-id\n\t:date:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=EGIN9a5aoeCzjYulAxHDBVF+kQ5OzJnrfYyq1oD4S4Q=;\n\tb=cDYY01rcBuKtOaayBZm/TYKKUzbALsVU/H3zrGpLgaaSnr/OhRtRvAzrj4+deAu6ZI\n\t0Z99PJXhPOfGOmAcc2j5Gh5IE6OjQMJvilg5Y9wtm7hA8NhYQ/aUoy1CVCUsTldvwNNZ\n\tg3Rv3TlAApNsaXEsGSvB/xk/aXdcRgzsD3ecrtx0+jWYgR88NU896RNKveFsHh4pnLw/\n\tG2LzUhOdMqqzHygSuRf+R2I6WDit66nsi3S1orxhxFTVZ66uy8aayx+9HUPHgBitFK1J\n\tSHgun11Tg2bzbbwAZzfIbWP346+kw2jj80FwNnwkDCnpbbTWHDKivlvdUN+uUFmJwnBm\n\tZaZw==","X-Gm-Message-State":"AHPjjUgMiUHzIHM1jEgyh9cgylqf6CSN1IAnQvTTvz3zja07cFnJXiqD\n\tpNfuDzPB8tXgWQ==","X-Google-Smtp-Source":"AOwi7QC0sCzBPQdGNo8vjPTu141SgbEHJWv6SrdVpCUTYHTSOArTm0a6VSTRSTabuXnSyyf6FtWWVA==","X-Received":"by 10.55.43.22 with SMTP id r22mr20109376qkh.53.1505242361136;\n\tTue, 12 Sep 2017 11:52:41 -0700 (PDT)","To":"Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org","References":"<20170912162513.21694-1-richard.henderson@linaro.org>\n\t<20170912162513.21694-13-richard.henderson@linaro.org>","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <f4bug@amsat.org>","Message-ID":"<6f1f0e95-ca3e-d988-d5b9-05f29fd55053@amsat.org>","Date":"Tue, 12 Sep 2017 15:52:38 -0300","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170912162513.21694-13-richard.henderson@linaro.org>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Language":"en-US","Content-Transfer-Encoding":"8bit","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2607:f8b0:400d:c09::244","Subject":"Re: [Qemu-devel] [PATCH v2 12/16] tcg: Remove tcg_regset_set","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<http://lists.nongnu.org/archive/html/qemu-devel/>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Cc":"alex.bennee@linaro.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>"}},{"id":1769100,"web_url":"http://patchwork.ozlabs.org/comment/1769100/","msgid":"<87zi9w8dpu.fsf@linaro.org>","list_archive_url":null,"date":"2017-09-15T10:21:01","subject":"Re: [Qemu-devel] [PATCH v2 12/16] tcg: Remove tcg_regset_set","submitter":{"id":39532,"url":"http://patchwork.ozlabs.org/api/people/39532/","name":"Alex Bennée","email":"alex.bennee@linaro.org"},"content":"Richard Henderson <richard.henderson@linaro.org> writes:\n\n> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>\n\nThis breaks the mips cross build:\n\nIn file included from /tmp/qemu-test/src/tcg/tcg.c:254:0:\n/tmp/qemu-test/src/tcg/mips/tcg-target.inc.c: In function 'target_parse_constraint':\n/tmp/qemu-test/src/tcg/mips/tcg-target.inc.c:198:9: error: implicit\ndeclaration of function 'tcg_regset_set' [-Werror=implicit-function-declaration]\n\n         tcg_regset_set(ct->u.regs, 0xffffffff);                                                                                                                                      ^~~~~~~~~~~~~~                                                                                                                                                      /tmp/qemu-test/src/tcg/mips/tcg-target.inc.c:198:9: error: nested extern declaration of 'tcg_regset_set' [-Werror=nested-externs]\n\nVia:\n\n  make docker-test-build@debian-mips-cross V=1 J=9 TARGET_LIST=mips-softmmu,mipsel-linux-user\n\n> ---\n>  tcg/tcg.h | 1 -\n>  tcg/tcg.c | 8 ++++----\n>  2 files changed, 4 insertions(+), 5 deletions(-)\n>\n> diff --git a/tcg/tcg.h b/tcg/tcg.h\n> index 7226727ee4..e168bd2c44 100644\n> --- a/tcg/tcg.h\n> +++ b/tcg/tcg.h\n> @@ -210,7 +210,6 @@ typedef enum TCGOpcode {\n>      NB_OPS,\n>  } TCGOpcode;\n>\n> -#define tcg_regset_set(d, s) (d) = (s)\n>  #define tcg_regset_set32(d, reg, val32) (d) |= (val32) << (reg)\n>  #define tcg_regset_set_reg(d, r) (d) |= 1L << (r)\n>  #define tcg_regset_reset_reg(d, r) (d) &= ~(1L << (r))\n> diff --git a/tcg/tcg.c b/tcg/tcg.c\n> index f40cce3364..873915925f 100644\n> --- a/tcg/tcg.c\n> +++ b/tcg/tcg.c\n> @@ -2452,7 +2452,7 @@ static void tcg_reg_alloc_mov(TCGContext *s, const TCGOpDef *def,\n>      TCGTemp *ts, *ots;\n>      TCGType otype, itype;\n>\n> -    tcg_regset_set(allocated_regs, s->reserved_regs);\n> +    allocated_regs = s->reserved_regs;\n>      ots = &s->temps[args[0]];\n>      ts = &s->temps[args[1]];\n>\n> @@ -2540,8 +2540,8 @@ static void tcg_reg_alloc_op(TCGContext *s,\n>             args + nb_oargs + nb_iargs,\n>             sizeof(TCGArg) * def->nb_cargs);\n>\n> -    tcg_regset_set(i_allocated_regs, s->reserved_regs);\n> -    tcg_regset_set(o_allocated_regs, s->reserved_regs);\n> +    i_allocated_regs = s->reserved_regs;\n> +    o_allocated_regs = s->reserved_regs;\n>\n>      /* satisfy input constraints */\n>      for(k = 0; k < nb_iargs; k++) {\n> @@ -2741,7 +2741,7 @@ static void tcg_reg_alloc_call(TCGContext *s, int nb_oargs, int nb_iargs,\n>      }\n>\n>      /* assign input registers */\n> -    tcg_regset_set(allocated_regs, s->reserved_regs);\n> +    allocated_regs = s->reserved_regs;\n>      for(i = 0; i < nb_regs; i++) {\n>          arg = args[nb_oargs + i];\n>          if (arg != TCG_CALL_DUMMY_ARG) {\n\n\n--\nAlex Bennée","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"kcPX3Why\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xts000w4Hz9sxR\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 15 Sep 2017 20:22:08 +1000 (AEST)","from localhost ([::1]:52392 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dsnl8-0004sA-6K\n\tfor incoming@patchwork.ozlabs.org; Fri, 15 Sep 2017 06:22:06 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:40427)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <alex.bennee@linaro.org>) id 1dsnkB-0004Ar-TD\n\tfor qemu-devel@nongnu.org; Fri, 15 Sep 2017 06:21:09 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <alex.bennee@linaro.org>) id 1dsnk7-00024M-UG\n\tfor qemu-devel@nongnu.org; Fri, 15 Sep 2017 06:21:07 -0400","from mail-wr0-x233.google.com ([2a00:1450:400c:c0c::233]:57175)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from <alex.bennee@linaro.org>)\n\tid 1dsnk7-00023T-Nl\n\tfor qemu-devel@nongnu.org; Fri, 15 Sep 2017 06:21:03 -0400","by mail-wr0-x233.google.com with SMTP id r74so1421111wrb.13\n\tfor <qemu-devel@nongnu.org>; Fri, 15 Sep 2017 03:21:03 -0700 (PDT)","from zen.linaro.local ([81.128.185.34])\n\tby smtp.gmail.com with ESMTPSA id\n\t77sm831833wmx.10.2017.09.15.03.21.01\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tFri, 15 Sep 2017 03:21:01 -0700 (PDT)","from zen (localhost [127.0.0.1])\n\tby zen.linaro.local (Postfix) with ESMTPS id 194053E02DF;\n\tFri, 15 Sep 2017 11:21:01 +0100 (BST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=references:user-agent:from:to:cc:subject:in-reply-to:date\n\t:message-id:mime-version:content-transfer-encoding;\n\tbh=Ul7Izt4v+9WMjU6+JZidT0RcTstj/ahz0SxPsRSAZBM=;\n\tb=kcPX3WhyyV64zdJjT3RYyveDNUiTg8xfMCeEEhkR3uJ5VgRp99kW44PHuW6gCVxUI5\n\tbMNHndTslJD16JHL9kONPlynnCPyFrcFm9Il+q0mdaRAUKnNUv4EEY1cBr6irGonMEJ5\n\tCGyTJmpOhvH1hszTqCKJhL6f2zMk9+LMbb7mg=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:references:user-agent:from:to:cc:subject\n\t:in-reply-to:date:message-id:mime-version:content-transfer-encoding; \n\tbh=Ul7Izt4v+9WMjU6+JZidT0RcTstj/ahz0SxPsRSAZBM=;\n\tb=JvB+2ecy8/hz6gTyIRMGb4k1i/OYqDpbaCpgcRluyOQ/l+UZNHvYauuUkswDGPHi0Z\n\tNgrwhQppM2n5OQZ4P8AiBfOUPLYWievQfinhgbAQzazqk4gvTk0y+3i2E/52nFe74+db\n\tX+sA0vHw2RbLw51zAnIMUcARb20t3UpGTB9aEIhQy6+9iuBDx3LhRY+0t8A5ivSYINQU\n\tMhXhPEjOymGEGGd+VHPXSdPZA3JrQPiEI3rsTmUoQlmOxkQsrwWqRB/X3dq+P2+ULZXd\n\tPFIpDuERoU/YrUwm/bUP3pFvZIvsDUUTj0GWQEEeSvUDAysQvyCuqQFYCYpZbcmZKHYc\n\tr/gA==","X-Gm-Message-State":"AHPjjUhdD13rtzcMh0dVr6t8SgdEdfUqfiGRx2yPZO/E8Abw8MNmN544\n\tdz0j6PbSjLNyuqGS","X-Google-Smtp-Source":"ADKCNb4P7hLh03Ftr4SQBvIvtK9BMXTYGr6Qtxr1sICeaAApFeTI3rBGm2Y8vzOUuyYXPqW/ayTUsg==","X-Received":"by 10.223.135.58 with SMTP id a55mr21069878wra.109.1505470862392;\n\tFri, 15 Sep 2017 03:21:02 -0700 (PDT)","References":"<20170912162513.21694-1-richard.henderson@linaro.org>\n\t<20170912162513.21694-13-richard.henderson@linaro.org>","User-agent":"mu4e 0.9.19; emacs 25.2.50.3","From":"Alex =?utf-8?q?Benn=C3=A9e?= <alex.bennee@linaro.org>","To":"Richard Henderson <richard.henderson@linaro.org>","In-reply-to":"<20170912162513.21694-13-richard.henderson@linaro.org>","Date":"Fri, 15 Sep 2017 11:21:01 +0100","Message-ID":"<87zi9w8dpu.fsf@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"8bit","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2a00:1450:400c:c0c::233","Subject":"Re: [Qemu-devel] [PATCH v2 12/16] tcg: Remove tcg_regset_set","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<http://lists.nongnu.org/archive/html/qemu-devel/>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Cc":"qemu-devel@nongnu.org, f4bug@amsat.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>"}},{"id":1769311,"web_url":"http://patchwork.ozlabs.org/comment/1769311/","msgid":"<93cffc82-7621-7d7d-addd-859a8813cc2e@linaro.org>","list_archive_url":null,"date":"2017-09-15T17:03:43","subject":"Re: [Qemu-devel] [PATCH v2 12/16] tcg: Remove tcg_regset_set","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/people/72104/","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"content":"On 09/15/2017 03:21 AM, Alex Bennée wrote:\n> \n> Richard Henderson <richard.henderson@linaro.org> writes:\n> \n>> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>\n> \n> This breaks the mips cross build:\n> \n> In file included from /tmp/qemu-test/src/tcg/tcg.c:254:0:\n> /tmp/qemu-test/src/tcg/mips/tcg-target.inc.c: In function 'target_parse_constraint':\n> /tmp/qemu-test/src/tcg/mips/tcg-target.inc.c:198:9: error: implicit\n> declaration of function 'tcg_regset_set' [-Werror=implicit-function-declaration]\n> \n>          tcg_regset_set(ct->u.regs, 0xffffffff);     \n\nYes, I found this myself yesterday.\nFixed in tcg-next.\n\nThanks,\n\n\nr~","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"PrxZAE/y\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xv1yR1HbZz9sNc\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 16 Sep 2017 03:06:23 +1000 (AEST)","from localhost ([::1]:54315 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dsu4L-0002ot-Aq\n\tfor incoming@patchwork.ozlabs.org; Fri, 15 Sep 2017 13:06:21 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:51505)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <richard.henderson@linaro.org>) id 1dsu1v-0001Sh-LG\n\tfor qemu-devel@nongnu.org; Fri, 15 Sep 2017 13:03:52 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <richard.henderson@linaro.org>) id 1dsu1s-0006X3-IU\n\tfor qemu-devel@nongnu.org; Fri, 15 Sep 2017 13:03:51 -0400","from mail-pg0-x22f.google.com ([2607:f8b0:400e:c05::22f]:52017)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from <richard.henderson@linaro.org>)\n\tid 1dsu1s-0006Wr-8p\n\tfor qemu-devel@nongnu.org; Fri, 15 Sep 2017 13:03:48 -0400","by mail-pg0-x22f.google.com with SMTP id k193so1846399pgc.8\n\tfor <qemu-devel@nongnu.org>; Fri, 15 Sep 2017 10:03:48 -0700 (PDT)","from bigtime.twiddle.net (97-126-103-167.tukw.qwest.net.\n\t[97.126.103.167]) by smtp.gmail.com with ESMTPSA id\n\tk73sm3366971pfg.81.2017.09.15.10.03.45\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tFri, 15 Sep 2017 10:03:46 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=rDQse5TblkgbUGmgS9vfAfQv33klh1obZyP4mRmmd0s=;\n\tb=PrxZAE/ydf+zpkOg3EkkWz55ojiwtXITQloKkTqchCsOYMUXABY2NtOtpW7x6F8sMB\n\tZpP2Ickh0nVNgsQOu+6loD+LWGgT2j4cepC9gKngr96X+cRHuBxQYPT2SoYbEWn8ULN+\n\tlES/9T30HyFjxChxNcXggqT4eJ8qDAJ0uYd4M=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=rDQse5TblkgbUGmgS9vfAfQv33klh1obZyP4mRmmd0s=;\n\tb=h15tQHNvYtbDaHKIHKsrIQGdnrTkwq/D14JJqZmXCncsGjm3kOGvZkux0j5fBaTBJF\n\tpszZmnFOtwuUWOO7lATh8TlcJelicJFhdWHXN4Xr2+Xt6CN6jDBMlg4cVV0Y9TQsBjch\n\tyaulVutUTscRzhVqgL+kRemRIIYYgL5aHEnXLrJx+Z+XUHbE8seEuVLrOBFfmvvD4PlG\n\tnyOaaosWJ9rugfXV7O0snF3whg6zpeXwxOFc5hoWc7rjV+n8hRs6rQSQY8bJksNtUCcH\n\tetnjlK4z8LY8lWZdmIaQJsD5/Ops30FoQmf6uOwFKjogMtNFmxvCh+dLS08qOnlm78Ny\n\t1USQ==","X-Gm-Message-State":"AHPjjUj08FZ6lDRHyLRG8AY9Amh2KLjZ5fg0XZotCm6onJWTTsEla5JR\n\tcE6KE7PwlUxF5GZW","X-Google-Smtp-Source":"ADKCNb5bdzi4Y0+0jmn7R+hbNtFMAmqlWjIkpfW6d0RqTGyaHjivNLzjoNLNL3P1yjbdYzl2poZYyA==","X-Received":"by 10.98.87.11 with SMTP id l11mr25542912pfb.134.1505495027037; \n\tFri, 15 Sep 2017 10:03:47 -0700 (PDT)","To":"=?utf-8?q?Alex_Benn=C3=A9e?= <alex.bennee@linaro.org>","References":"<20170912162513.21694-1-richard.henderson@linaro.org>\n\t<20170912162513.21694-13-richard.henderson@linaro.org>\n\t<87zi9w8dpu.fsf@linaro.org>","From":"Richard Henderson <richard.henderson@linaro.org>","Message-ID":"<93cffc82-7621-7d7d-addd-859a8813cc2e@linaro.org>","Date":"Fri, 15 Sep 2017 10:03:43 -0700","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<87zi9w8dpu.fsf@linaro.org>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"8bit","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2607:f8b0:400e:c05::22f","Subject":"Re: [Qemu-devel] [PATCH v2 12/16] tcg: Remove tcg_regset_set","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<http://lists.nongnu.org/archive/html/qemu-devel/>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Cc":"qemu-devel@nongnu.org, f4bug@amsat.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>"}}]