[{"id":1767291,"web_url":"http://patchwork.ozlabs.org/comment/1767291/","msgid":"","list_archive_url":null,"date":"2017-09-12T18:52:53","subject":"Re: [Qemu-devel] [PATCH v2 13/16] tcg: Remove tcg_regset_{or, and, \n\tandnot, not}","submitter":{"id":70924,"url":"http://patchwork.ozlabs.org/api/people/70924/","name":"Philippe Mathieu-Daudé","email":"f4bug@amsat.org"},"content":"On 09/12/2017 01:25 PM, Richard Henderson wrote:\n> Signed-off-by: Richard Henderson \n\nReviewed-by: Philippe Mathieu-Daudé \n\n> ---\n> tcg/tcg.h | 4 ----\n> tcg/tcg.c | 2 +-\n> 2 files changed, 1 insertion(+), 5 deletions(-)\n> \n> diff --git a/tcg/tcg.h b/tcg/tcg.h\n> index e168bd2c44..8b4208ea03 100644\n> --- a/tcg/tcg.h\n> +++ b/tcg/tcg.h\n> @@ -214,10 +214,6 @@ typedef enum TCGOpcode {\n> #define tcg_regset_set_reg(d, r) (d) |= 1L << (r)\n> #define tcg_regset_reset_reg(d, r) (d) &= ~(1L << (r))\n> #define tcg_regset_test_reg(d, r) (((d) >> (r)) & 1)\n> -#define tcg_regset_or(d, a, b) (d) = (a) | (b)\n> -#define tcg_regset_and(d, a, b) (d) = (a) & (b)\n> -#define tcg_regset_andnot(d, a, b) (d) = (a) & ~(b)\n> -#define tcg_regset_not(d, a) (d) = ~(a)\n> \n> #ifndef TCG_TARGET_INSN_UNIT_SIZE\n> # error \"Missing TCG_TARGET_INSN_UNIT_SIZE\"\n> diff --git a/tcg/tcg.c b/tcg/tcg.c\n> index 873915925f..a19767b5ef 100644\n> --- a/tcg/tcg.c\n> +++ b/tcg/tcg.c\n> @@ -2306,7 +2306,7 @@ static TCGReg tcg_reg_alloc(TCGContext *s, TCGRegSet desired_regs,\n> TCGReg reg;\n> TCGRegSet reg_ct;\n> \n> - tcg_regset_andnot(reg_ct, desired_regs, allocated_regs);\n> + reg_ct = desired_regs & ~allocated_regs;\n> order = rev ? indirect_reg_alloc_order : tcg_target_reg_alloc_order;\n> \n> /* first try free registers */\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"CNVLnX/e\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xsDVD16SZz9s8J\n\tfor ;\n\tWed, 13 Sep 2017 04:54:12 +1000 (AEST)","from localhost ([::1]:38152 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1drqK2-0007wv-7c\n\tfor incoming@patchwork.ozlabs.org; Tue, 12 Sep 2017 14:54:10 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:60871)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from )\n\tid 1drqIu-0007SN-IZ\n\tfor qemu-devel@nongnu.org; Tue, 12 Sep 2017 14:53:01 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from )\n\tid 1drqIr-0000DV-Fe\n\tfor qemu-devel@nongnu.org; Tue, 12 Sep 2017 14:53:00 -0400","from mail-qk0-x241.google.com ([2607:f8b0:400d:c09::241]:33774)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1drqIr-0000D9-BM\n\tfor qemu-devel@nongnu.org; Tue, 12 Sep 2017 14:52:57 -0400","by mail-qk0-x241.google.com with SMTP id g128so7724960qke.0\n\tfor ; Tue, 12 Sep 2017 11:52:57 -0700 (PDT)","from [192.168.1.10] ([181.93.89.178])\n\tby smtp.gmail.com with ESMTPSA id\n\tn1sm7836142qkf.50.2017.09.12.11.52.54\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 12 Sep 2017 11:52:56 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=4ZHkBuZlgomVKIASq7BQW2jHSTrhABz/uZGklQcQJp4=;\n\tb=CNVLnX/eeekMH7J66rlRktLPQjaKHh2stGh1aieA3r2mrTtJdjJJINP3lkZxDkRC9Q\n\tlzcNpAUBdQmE/qqnxvkvcaHJG+6FraU4HrJ1YOEbQr+QItlrYkPCNuuaNLEhI55hNYC/\n\too6hrfLLc/9FFhxHVXkPxe4oKsQbcyPH0ZVMx+O8n3a+xVCOB4NQgKT/mEbMofsXbP9m\n\tqgmGM3m2gk4bvG/5AnKmNE887lg9aynNbeoYiWgQg3b0l3L7wH1BUTOHRoPwTnzhmm5U\n\t1i40XzEr2gZZXJzl3dBsRu77pCoNrHfDFD0yVl/PJa62tQJP6lkBxQn8brYR1Al5Uzx4\n\tyRXA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:subject:to:cc:references:from:message-id\n\t:date:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=4ZHkBuZlgomVKIASq7BQW2jHSTrhABz/uZGklQcQJp4=;\n\tb=LI2UBu8bXK7DL70qofrmR+O/yWVjTl/pt0V5JgvZwb/h/L+9FwfCSPEjxq/F6FbD2B\n\tynSO8ifKc/f+VzcKPwU98DBuAbOWzgkfzGeeBckFgk9jdqjj4eIr7KT67hU23dd0YBjD\n\tga0BVMZFIet3cV3gnbkUaqxVBdC3PPnjPJ1A2u74hp9k2sgt4PpfzYAW5nuXTodN6ZgZ\n\tlSIh7+bGHMYsES0vu6RkEgED8Sxjqie3SW7/4MDkBe0ibem3wLnimZxMtOjCyBaXLLPP\n\twC9QDWNgGPMLUzsK4pBP62Dd1OD3vuhKTta8x6C5URfYfxtfXEeLnWk4GC6qkqx263MK\n\tHnoQ==","X-Gm-Message-State":"AHPjjUj67tO3S2zPXomf6l5TMd5/GRh4SEX7y07JRlb5a2hYGGqcxab9\n\tgAV1bVm0IlFeIMIjPlYgfg==","X-Google-Smtp-Source":"AOwi7QDaA8L40EuwXT/SZj4NzFZRATejGKUYwcnWtciu8BSM1xDgNjItf1w/K9uUGGBf65RvQRMEGQ==","X-Received":"by 10.55.123.1 with SMTP id w1mr11252228qkc.114.1505242376782;\n\tTue, 12 Sep 2017 11:52:56 -0700 (PDT)","To":"Richard Henderson , qemu-devel@nongnu.org","References":"<20170912162513.21694-1-richard.henderson@linaro.org>\n\t<20170912162513.21694-14-richard.henderson@linaro.org>","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","Message-ID":"","Date":"Tue, 12 Sep 2017 15:52:53 -0300","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170912162513.21694-14-richard.henderson@linaro.org>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Language":"en-US","Content-Transfer-Encoding":"8bit","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2607:f8b0:400d:c09::241","Subject":"Re: [Qemu-devel] [PATCH v2 13/16] tcg: Remove tcg_regset_{or, and, \n\tandnot, not}","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"alex.bennee@linaro.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]