[{"id":1767556,"web_url":"http://patchwork.ozlabs.org/comment/1767556/","msgid":"<CAPnjgZ0OTHayJ4fVPADt_mbEYWTX_LwN6DANJCHKWn-KkCkfVg@mail.gmail.com>","list_archive_url":null,"date":"2017-09-13T04:26:42","subject":"Re: [U-Boot] [PATCH v5 08/10] fdtdec: sort include files","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"Hi Jean-Jacques,\n\nOn 12 September 2017 at 08:45, Jean-Jacques Hiblot <jjhiblot@ti.com> wrote:\n> Sort include files in accordance to U-Boot coding style.\n>\n> Signed-off-by: Jean-Jacques Hiblot <jjhiblot@ti.com>\n> ---\n>  lib/fdtdec.c | 10 +++++-----\n>  1 file changed, 5 insertions(+), 5 deletions(-)\n>\n> diff --git a/lib/fdtdec.c b/lib/fdtdec.c\n> index 630e040..ee398d1 100644\n> --- a/lib/fdtdec.c\n> +++ b/lib/fdtdec.c\n> @@ -4,17 +4,17 @@\n>   */\n>\n>  #ifndef USE_HOSTCC\n> +#include <asm/sections.h>\n>  #include <boot_fit.h>\n>  #include <common.h>\n>  #include <dm.h>\n> +#include <dm/of_extra.h>\n>  #include <errno.h>\n> -#include <serial.h>\n> -#include <libfdt.h>\n> -#include <fdt_support.h>\n>  #include <fdtdec.h>\n> -#include <asm/sections.h>\n> -#include <dm/of_extra.h>\n> +#include <fdt_support.h>\n> +#include <libfdt.h>\n>  #include <linux/ctype.h>\n> +#include <serial.h>\n\nThe asm and linux things come at the end. Please see:\n\nhttps://www.denx.de/wiki/U-Boot/CodingStyle\n\n>\n>  DECLARE_GLOBAL_DATA_PTR;\n>\n> --\n> 1.9.1\n>\n\nRegards,\nSimon","headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=<UNKNOWN>)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=google.com header.i=@google.com\n\theader.b=\"JwkjdDQg\"; \n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"l8HGAh8H\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xsTTl58t6z9rvt\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 13 Sep 2017 14:39:39 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 6F488C22547; Wed, 13 Sep 2017 04:36:02 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id C700FC224F5;\n\tWed, 13 Sep 2017 04:35:59 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid A4336C2250A; Wed, 13 Sep 2017 04:27:08 +0000 (UTC)","from mail-qt0-f174.google.com (mail-qt0-f174.google.com\n\t[209.85.216.174])\n\tby lists.denx.de (Postfix) with ESMTPS id 4D0D5C223E0\n\tfor <u-boot@lists.denx.de>; Wed, 13 Sep 2017 04:27:04 +0000 (UTC)","by mail-qt0-f174.google.com with SMTP id s18so28110549qta.3\n\tfor <u-boot@lists.denx.de>; Tue, 12 Sep 2017 21:27:04 -0700 (PDT)","by 10.200.37.200 with HTTP; Tue, 12 Sep 2017 21:26:42 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE,\n\tRCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID autolearn=unavailable\n\tautolearn_force=no version=3.4.0","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=20161025; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=H6/fzRTaib45BtZF7KGUoqnvTjQZRN+ACGyrbFJV45o=;\n\tb=JwkjdDQg4MqL4eRrMKQnZVfi3wyC4jctJjuNJQPOQHXtR1Owy9dhnZoHIlFGZcsT1i\n\tKasVVGmpGHDbNx8xfGDkdjE/VJxLL0T738HHh7eFXtguMsLAq7NGHyByzFvE6c+JkXNk\n\tBaBnQVQPkdUfX/f2F3X5lh7vCKqel1RKWzlyLinvIXzm3eBHiN9IW1foflmec1cq7M7u\n\t1odfg/JLPtExv4aG0jhtMqWXqy7G9sAol36nMqMjoqkkh6HkiK9odCC0pHEVBcqGfM/M\n\tq+N2SUeg0CjRVRMaEwpWAkGBCpfEp7fS+mhCB2khqHN7YLKQR3bd/QYhJh4dOKiyzudK\n\t53Cw==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=H6/fzRTaib45BtZF7KGUoqnvTjQZRN+ACGyrbFJV45o=;\n\tb=l8HGAh8Hqm69KmEXsMxbJNB+RbacsLCnb6026wdyvYAFJMWFDOfzI2yP/Ek8RQcumR\n\t2Kg1ktqE9m8ni7ILYKyaVRx7c4TR6/RYMY7xYbKJKSJSg42c/7V9XZVrpvJ+FTTFoVgt\n\tHcmI9wsVM4w42d1UwEHunUgPEb19DnpwRahwc="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:sender:in-reply-to:references:from\n\t:date:message-id:subject:to:cc;\n\tbh=H6/fzRTaib45BtZF7KGUoqnvTjQZRN+ACGyrbFJV45o=;\n\tb=fFN70BkMfq3LZcPzT8K8/Jli5/vlEODmutt5+utkzzKmj5RgZPhIS0H5fKLq7eRRE+\n\tU+iOHvREQxL8IiLHiK3+AjxX7+0r7jqEYYomdIhRzCK+1A+FrUPjs8nK7oe0tbSmMStA\n\tmMseO5QyOgPr05tplLkOCK3LdJ+Y+Xuqo2m/H13P13ussVQPWH+0Il8BbXE/PjiRQS0U\n\tPWlwHtVxflA5ISl4AKzvTG+DlttEIS3NtyA6AHkzSINijZ9miCn3u+dgGRIQvyEvMSlZ\n\tfO2di6N5tJeEHIpgN8D3CdFS3unxYUt8H402+Gz/Nk1oz3p1lhwlzgewqxdXdKm5n1nt\n\tYJYg==","X-Gm-Message-State":"AHPjjUjnPJ/GkMz7SBFZZ3yt2PbVFmmadkwYeTj2gHHDzlobpr535c3p\n\tw4b6uXwZaDGFmRyu0RQa17vh0MbnxAh5szU+Y62MJQ==","X-Google-Smtp-Source":"AOwi7QC/KVIiXVIt9xWC+YVtscwhc3ww1phWh0jqBSoSFPngOLTlBdftoYkOmU/TWXtZMpb391mFir8xtaTJg85Yimk=","X-Received":"by 10.200.41.239 with SMTP id 44mr23169648qtt.138.1505276823085; \n\tTue, 12 Sep 2017 21:27:03 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<1505227539-17560-9-git-send-email-jjhiblot@ti.com>","References":"<1505227539-17560-1-git-send-email-jjhiblot@ti.com>\n\t<1505227539-17560-9-git-send-email-jjhiblot@ti.com>","From":"Simon Glass <sjg@chromium.org>","Date":"Tue, 12 Sep 2017 22:26:42 -0600","X-Google-Sender-Auth":"wWZHpwCQiVBJ9vPSqwzipRTWVSc","Message-ID":"<CAPnjgZ0OTHayJ4fVPADt_mbEYWTX_LwN6DANJCHKWn-KkCkfVg@mail.gmail.com>","To":"Jean-Jacques Hiblot <jjhiblot@ti.com>","Cc":"Tom Rini <trini@konsulko.com>, Franklin <fcooper@ti.com>,\n\tU-Boot Mailing List <u-boot@lists.denx.de>","Subject":"Re: [U-Boot] [PATCH v5 08/10] fdtdec: sort include files","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<http://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=subscribe>","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>"}}]