[{"id":1767344,"web_url":"http://patchwork.ozlabs.org/comment/1767344/","msgid":"<dcb2f6b9-e30c-34f2-5cfd-088dd90fcc84@redhat.com>","list_archive_url":null,"date":"2017-09-12T21:15:39","subject":"Re: [Qemu-devel] [PATCH 05/10] qemu-iotests: limit\n\tnon-_PROG-suffixed variables to common.rc","submitter":{"id":6591,"url":"http://patchwork.ozlabs.org/api/people/6591/","name":"Eric Blake","email":"eblake@redhat.com"},"content":"On 09/12/2017 09:44 AM, Paolo Bonzini wrote:\n> These are never used by \"check\", with one exception that does not need\n> $QEMU_OPTIONS.  Keep them in common.rc, which will be soon included only\n> by the tests.\n> \n> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>\n> ---\n>  tests/qemu-iotests/039.out       | 10 +++---\n>  tests/qemu-iotests/061.out       |  4 +--\n>  tests/qemu-iotests/137.out       |  2 +-\n>  tests/qemu-iotests/common.config | 69 ++--------------------------------------\n>  tests/qemu-iotests/common.rc     | 65 +++++++++++++++++++++++++++++++++++++\n>  5 files changed, 75 insertions(+), 75 deletions(-)\n\nIt may be worth tweaking scripts/git.orderfile to prioritize\ntests/qemu-iotests/common* above the rest of tests/qemu-iotests (I have\nthat tweak locally, at any rate).  But that's a separate issue.\n\nReviewed-by: Eric Blake <eblake@redhat.com>","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)","ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=eblake@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xsHfD5YGzz9t2W\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 13 Sep 2017 07:16:20 +1000 (AEST)","from localhost ([::1]:38650 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1drsXa-0002qI-Tg\n\tfor incoming@patchwork.ozlabs.org; Tue, 12 Sep 2017 17:16:18 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:58977)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <eblake@redhat.com>) id 1drsX6-0002mA-Tr\n\tfor qemu-devel@nongnu.org; Tue, 12 Sep 2017 17:15:49 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <eblake@redhat.com>) id 1drsX5-0006dg-Ph\n\tfor qemu-devel@nongnu.org; Tue, 12 Sep 2017 17:15:48 -0400","from mx1.redhat.com ([209.132.183.28]:38236)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <eblake@redhat.com>)\n\tid 1drsX0-0006Yj-B7; Tue, 12 Sep 2017 17:15:42 -0400","from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 5B53DC047B64;\n\tTue, 12 Sep 2017 21:15:41 +0000 (UTC)","from [10.10.120.44] (ovpn-120-44.rdu2.redhat.com [10.10.120.44])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id AFC0A60F87;\n\tTue, 12 Sep 2017 21:15:40 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 5B53DC047B64","To":"Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org","References":"<20170912144459.11359-1-pbonzini@redhat.com>\n\t<20170912144459.11359-6-pbonzini@redhat.com>","From":"Eric Blake <eblake@redhat.com>","Openpgp":"url=http://people.redhat.com/eblake/eblake.gpg","Organization":"Red Hat, Inc.","Message-ID":"<dcb2f6b9-e30c-34f2-5cfd-088dd90fcc84@redhat.com>","Date":"Tue, 12 Sep 2017 16:15:39 -0500","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170912144459.11359-6-pbonzini@redhat.com>","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\";\n\tboundary=\"NX434OEEWfrgSLD06TLbXwP9Ex0kaUM4M\"","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.12","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.31]);\n\tTue, 12 Sep 2017 21:15:41 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","X-Content-Filtered-By":"Mailman/MimeDel 2.1.21","Subject":"Re: [Qemu-devel] [PATCH 05/10] qemu-iotests: limit\n\tnon-_PROG-suffixed variables to common.rc","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<http://lists.nongnu.org/archive/html/qemu-devel/>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Cc":"kwolf@redhat.com, qemu-block@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>"}}]