[{"id":1767357,"web_url":"http://patchwork.ozlabs.org/comment/1767357/","msgid":"<0df82bae-77a8-816c-b157-32655005d368@redhat.com>","list_archive_url":null,"date":"2017-09-12T21:30:21","subject":"Re: [Qemu-devel] [PATCH 08/10] qemu-iotests: fix uninitialized\n\tvariable","submitter":{"id":6591,"url":"http://patchwork.ozlabs.org/api/people/6591/","name":"Eric Blake","email":"eblake@redhat.com"},"content":"On 09/12/2017 09:44 AM, Paolo Bonzini wrote:\n> The variable is used in \"common\" but defined only after the file\n> is sourced.\n> \n> Signed-off-by: Paolo Bonzini \n> ---\n> tests/qemu-iotests/check | 2 --\n> tests/qemu-iotests/common | 2 ++\n> 2 files changed, 2 insertions(+), 2 deletions(-)\n> \n\nReviewed-by: Eric Blake \n\n> +tmp=\"${TEST_DIR}\"/$$\n\nPre-existing to your code motion, but would we be any safer if $tmp also\nincluded a use of $RANDOM? (The $$ already protects us from collisions\nwith a parallel run, but it is easy to guess, so if $tmp is used to\ncreate any file that an attacker can access, running the testsuite may\nexpose a machine to a symlink or other attack - but we probably have\nlots of those things to audit for before we can recommend running the\ntestsuite in an untrusted environment).","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=eblake@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xsHzH46pDz9sBd\n\tfor ;\n\tWed, 13 Sep 2017 07:31:07 +1000 (AEST)","from localhost ([::1]:38698 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1drslt-00018h-Jh\n\tfor incoming@patchwork.ozlabs.org; Tue, 12 Sep 2017 17:31:05 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:38396)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1drslM-00016o-MW\n\tfor qemu-devel@nongnu.org; Tue, 12 Sep 2017 17:30:33 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1drslL-0002oI-QN\n\tfor qemu-devel@nongnu.org; Tue, 12 Sep 2017 17:30:32 -0400","from mx1.redhat.com ([209.132.183.28]:44104)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1drslG-0002k0-4W; Tue, 12 Sep 2017 17:30:26 -0400","from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 297B7883AC;\n\tTue, 12 Sep 2017 21:30:25 +0000 (UTC)","from [10.10.120.44] (ovpn-120-44.rdu2.redhat.com [10.10.120.44])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 2995461981;\n\tTue, 12 Sep 2017 21:30:22 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 297B7883AC","To":"Paolo Bonzini , qemu-devel@nongnu.org","References":"<20170912144459.11359-1-pbonzini@redhat.com>\n\t<20170912144459.11359-9-pbonzini@redhat.com>","From":"Eric Blake ","Openpgp":"url=http://people.redhat.com/eblake/eblake.gpg","Organization":"Red Hat, Inc.","Message-ID":"<0df82bae-77a8-816c-b157-32655005d368@redhat.com>","Date":"Tue, 12 Sep 2017 16:30:21 -0500","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170912144459.11359-9-pbonzini@redhat.com>","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\";\n\tboundary=\"JbtRPQU6doq9nOSD9u6vBmPCglcn6SOp0\"","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.12","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.26]);\n\tTue, 12 Sep 2017 21:30:25 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","X-Content-Filtered-By":"Mailman/MimeDel 2.1.21","Subject":"Re: [Qemu-devel] [PATCH 08/10] qemu-iotests: fix uninitialized\n\tvariable","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"kwolf@redhat.com, qemu-block@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]