[{"id":1767347,"web_url":"http://patchwork.ozlabs.org/comment/1767347/","msgid":"","list_archive_url":null,"date":"2017-09-12T21:25:57","subject":"Re: [Qemu-devel] [PATCH 07/10] qemu-iotests: disintegrate more\n\tparts of common.config","submitter":{"id":6591,"url":"http://patchwork.ozlabs.org/api/people/6591/","name":"Eric Blake","email":"eblake@redhat.com"},"content":"On 09/12/2017 09:44 AM, Paolo Bonzini wrote:\n> Split \"check\" parts from tests part.\n> \n> For the directory setup, the actual computation of directories goes\n> in \"check\", while the sanity checks go in the tests.\n> \n> Signed-off-by: Paolo Bonzini \n> ---\n> tests/qemu-iotests/common | 24 ++++++++++++++++++++\n> tests/qemu-iotests/common.config | 49 ----------------------------------------\n> tests/qemu-iotests/common.qemu | 1 +\n> tests/qemu-iotests/common.rc | 25 ++++++++++++++++++++\n> 4 files changed, 50 insertions(+), 49 deletions(-)\n> \n> diff --git a/tests/qemu-iotests/common b/tests/qemu-iotests/common\n> index abacc24114..ee313af92f 100644\n> --- a/tests/qemu-iotests/common\n> +++ b/tests/qemu-iotests/common\n> @@ -48,6 +48,14 @@ set_prog_path()\n> fi\n> }\n> \n> +if [ -z \"$TEST_DIR\" ]; then\n> + TEST_DIR=`pwd`/scratch\n\n8-space indent looks odd compared to the rest of the file.\n\n> @@ -153,6 +158,26 @@ else\n> fi\n> ORIG_TEST_IMG=\"$TEST_IMG\"\n> \n> +if [ -z \"$TEST_DIR\" ]; then\n> + TEST_DIR=`pwd`/scratch\n\nWe probably ought to clean things up to use $PWD instead of `pwd`\neverywhere as a minor optimization (why fork, when bash already has the\nright information for you?) - but that can be separate.\n\nSplit looks okay to me,\nReviewed-by: Eric Blake ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx03.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx03.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=eblake@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xsHtB0cdzz9sBd\n\tfor ;\n\tWed, 13 Sep 2017 07:26:40 +1000 (AEST)","from localhost ([::1]:38680 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1drsha-00071u-IG\n\tfor incoming@patchwork.ozlabs.org; Tue, 12 Sep 2017 17:26:38 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:36164)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1drsh5-0006z1-Mq\n\tfor qemu-devel@nongnu.org; Tue, 12 Sep 2017 17:26:08 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1drsh4-0007DK-K8\n\tfor qemu-devel@nongnu.org; Tue, 12 Sep 2017 17:26:07 -0400","from mx1.redhat.com ([209.132.183.28]:35702)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1drsgy-00077a-R9; Tue, 12 Sep 2017 17:26:01 -0400","from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id B406083F3D;\n\tTue, 12 Sep 2017 21:25:59 +0000 (UTC)","from [10.10.120.44] (ovpn-120-44.rdu2.redhat.com [10.10.120.44])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id DA2306A31C;\n\tTue, 12 Sep 2017 21:25:58 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com B406083F3D","To":"Paolo Bonzini , qemu-devel@nongnu.org","References":"<20170912144459.11359-1-pbonzini@redhat.com>\n\t<20170912144459.11359-8-pbonzini@redhat.com>","From":"Eric Blake ","Openpgp":"url=http://people.redhat.com/eblake/eblake.gpg","Organization":"Red Hat, Inc.","Message-ID":"","Date":"Tue, 12 Sep 2017 16:25:57 -0500","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170912144459.11359-8-pbonzini@redhat.com>","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\";\n\tboundary=\"o3sOgARMeNEICbEGe3CFPOrqqc2Dh0cWb\"","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.16","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.27]);\n\tTue, 12 Sep 2017 21:25:59 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","X-Content-Filtered-By":"Mailman/MimeDel 2.1.21","Subject":"Re: [Qemu-devel] [PATCH 07/10] qemu-iotests: disintegrate more\n\tparts of common.config","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"kwolf@redhat.com, qemu-block@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]