[{"id":1767665,"web_url":"http://patchwork.ozlabs.org/comment/1767665/","msgid":"<1505290435.22749.3.camel@redhat.com>","list_archive_url":null,"date":"2017-09-13T08:13:55","subject":"Re: [Qemu-devel] [PATCH v1 1/2] virtio_gpu: Handle endian conversion","submitter":{"id":589,"url":"http://patchwork.ozlabs.org/api/people/589/","name":"Gerd Hoffmann","email":"kraxel@redhat.com"},"content":"Hi,\n\n> @@ -287,6 +287,12 @@ static void\n> virtio_gpu_resource_create_2d(VirtIOGPU *g,\n>      struct virtio_gpu_resource_create_2d c2d;\n>  \n>      VIRTIO_GPU_FILL_CMD(c2d);\n> +\n> +    c2d.resource_id = le32_to_cpu(c2d.resource_id);\n> +    c2d.format = le32_to_cpu(c2d.format);\n> +    c2d.width = le32_to_cpu(c2d.width);\n> +    c2d.height = le32_to_cpu(c2d.height);\n> +\n\nPlease move this to a helper function, maybe by updating the\nVIRTIO_GPU_FILL_CMD macro.\n\nThe header fields should be byteswapped too. As most structs have\n32bit fields only (with the exception of hdr.fence_id) you should be\nable to create a generic byteswap function which only needs the struct\nsize as argument and handles all structs without addresses/offsets\n(which are 64bit fields).\n\nThe conversion looks incomplete, at least virtio_gpu_ctrl_response will\nneed adaptions too. It probably works by luck because the guest driver\nuses fences only in virgl (3d) mode.\n\ncheers,\n Gerd","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx04.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx04.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=kraxel@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xsZFg3QYdz9sPs\n\tfor ;\n\tWed, 13 Sep 2017 18:14:30 +1000 (AEST)","from localhost ([::1]:40793 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1ds2oT-0001JP-NI\n\tfor incoming@patchwork.ozlabs.org; Wed, 13 Sep 2017 04:14:25 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:58961)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1ds2o7-0001J4-Dh\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 04:14:04 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1ds2o2-0005LQ-Dh\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 04:14:03 -0400","from mx1.redhat.com ([209.132.183.28]:52160)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1ds2o2-0005K9-7D\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 04:13:58 -0400","from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id D71E3A0489;\n\tWed, 13 Sep 2017 08:13:56 +0000 (UTC)","from sirius.home.kraxel.org (ovpn-117-51.ams2.redhat.com\n\t[10.36.117.51])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 6E4521754E;\n\tWed, 13 Sep 2017 08:13:56 +0000 (UTC)","from localhost (localhost [IPv6:::1])\n\tby sirius.home.kraxel.org (Postfix) with ESMTP id 9306B3F105;\n\tWed, 13 Sep 2017 10:13:55 +0200 (CEST)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com D71E3A0489","Message-ID":"<1505290435.22749.3.camel@redhat.com>","From":"Gerd Hoffmann ","To":"Farhan Ali , qemu-devel@nongnu.org","Date":"Wed, 13 Sep 2017 10:13:55 +0200","In-Reply-To":"<0a156f413f67b1bf55c5516d8263a15db3ec42c3.1505225353.git.alifm@linux.vnet.ibm.com>","References":"\n\t<0a156f413f67b1bf55c5516d8263a15db3ec42c3.1505225353.git.alifm@linux.vnet.ibm.com>","Content-Type":"text/plain; charset=\"UTF-8\"","Mime-Version":"1.0","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.16","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.28]);\n\tWed, 13 Sep 2017 08:13:57 +0000 (UTC)","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v1 1/2] virtio_gpu: Handle endian conversion","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"borntraeger@de.ibm.com, thuth@redhat.com, cohuck@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1767983,"web_url":"http://patchwork.ozlabs.org/comment/1767983/","msgid":"<5678da9e-ddea-1d31-77ff-8ea52ee30ca9@linux.vnet.ibm.com>","list_archive_url":null,"date":"2017-09-13T15:53:15","subject":"Re: [Qemu-devel] [PATCH v1 1/2] virtio_gpu: Handle endian conversion","submitter":{"id":71051,"url":"http://patchwork.ozlabs.org/api/people/71051/","name":"Farhan Ali","email":"alifm@linux.vnet.ibm.com"},"content":"On 09/13/2017 04:13 AM, Gerd Hoffmann wrote:\n> Please move this to a helper function, maybe by updating the\n> VIRTIO_GPU_FILL_CMD macro.\n>\n> The header fields should be byteswapped too. As most structs have\n> 32bit fields only (with the exception of hdr.fence_id) you should be\n> able to create a generic byteswap function which only needs the struct\n> size as argument and handles all structs without addresses/offsets\n> (which are 64bit fields).\n\nI am not sure if I understand what you mean here. Since struct \nvirtio_gpu_ctrl_hdr is part of every struct, so any such function\nwould also need to handle the case of hdr.fence_id, right?\n\n>\n> The conversion looks incomplete, at least virtio_gpu_ctrl_response will\n> need adaptions too. It probably works by luck because the guest driver\n> uses fences only in virgl (3d) mode.\n>\n\nOh right, I need to handle the conversion there as well. Thanks for \ncatching that.\n\nAlso I believe this conversion patch isn't comprehensive, it's mostly \nthe changes I made to get a display working on S390. So I appreciate\nyou reviewing the changes.\n\n> cheers,\n> Gerd\n\nThanks\nFarhan","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xsmRb57YPz9sPk\n\tfor ;\n\tThu, 14 Sep 2017 01:53:47 +1000 (AEST)","from localhost ([::1]:43167 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1ds9yz-0001xg-Tr\n\tfor incoming@patchwork.ozlabs.org; Wed, 13 Sep 2017 11:53:45 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:41833)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1ds9yg-0001xH-0u\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 11:53:27 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1ds9yc-0006eH-0c\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 11:53:26 -0400","from mx0b-001b2d01.pphosted.com ([148.163.158.5]:44180\n\thelo=mx0a-001b2d01.pphosted.com)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1ds9yb-0006dg-RC\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 11:53:21 -0400","from pps.filterd (m0098417.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv8DFo0Cu111860\n\tfor ; Wed, 13 Sep 2017 11:53:20 -0400","from e36.co.us.ibm.com (e36.co.us.ibm.com [32.97.110.154])\n\tby mx0a-001b2d01.pphosted.com with ESMTP id 2cy5y3wmy4-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor ; Wed, 13 Sep 2017 11:53:20 -0400","from localhost\n\tby e36.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor from ;\n\tWed, 13 Sep 2017 09:53:19 -0600","from b03cxnp08028.gho.boulder.ibm.com (9.17.130.20)\n\tby e36.co.us.ibm.com (192.168.1.136) with IBM ESMTP SMTP Gateway:\n\tAuthorized Use Only! Violators will be prosecuted; \n\tWed, 13 Sep 2017 09:53:16 -0600","from b03ledav003.gho.boulder.ibm.com\n\t(b03ledav003.gho.boulder.ibm.com [9.17.130.234])\n\tby b03cxnp08028.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with\n\tESMTP id v8DFrGZ231916140; Wed, 13 Sep 2017 08:53:16 -0700","from b03ledav003.gho.boulder.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 0A43C6A03B;\n\tWed, 13 Sep 2017 09:53:16 -0600 (MDT)","from [9.56.58.100] (unknown [9.56.58.100])\n\tby b03ledav003.gho.boulder.ibm.com (Postfix) with ESMTP id 7FC7A6A03D;\n\tWed, 13 Sep 2017 09:53:15 -0600 (MDT)"],"To":"Gerd Hoffmann , qemu-devel@nongnu.org","References":"\n\t<0a156f413f67b1bf55c5516d8263a15db3ec42c3.1505225353.git.alifm@linux.vnet.ibm.com>\n\t<1505290435.22749.3.camel@redhat.com>","From":"Farhan Ali ","Date":"Wed, 13 Sep 2017 11:53:15 -0400","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101\n\tThunderbird/45.7.0","MIME-Version":"1.0","In-Reply-To":"<1505290435.22749.3.camel@redhat.com>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Transfer-Encoding":"7bit","X-TM-AS-GCONF":"00","x-cbid":"17091315-0020-0000-0000-00000CB4404B","X-IBM-SpamModules-Scores":"","X-IBM-SpamModules-Versions":"BY=3.00007721; HX=3.00000241; KW=3.00000007;\n\tPH=3.00000004; SC=3.00000227; SDB=6.00916481; UDB=6.00460226;\n\tIPR=6.00696712; \n\tBA=6.00005588; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009;\n\tZB=6.00000000; \n\tZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00017139;\n\tXFM=3.00000015; UTC=2017-09-13 15:53:18","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17091315-0021-0000-0000-00005E1D922D","Message-Id":"<5678da9e-ddea-1d31-77ff-8ea52ee30ca9@linux.vnet.ibm.com>","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-09-13_04:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=0\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1709130247","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy]","X-Received-From":"148.163.158.5","Subject":"Re: [Qemu-devel] [PATCH v1 1/2] virtio_gpu: Handle endian conversion","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"borntraeger@de.ibm.com, thuth@redhat.com, cohuck@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1768421,"web_url":"http://patchwork.ozlabs.org/comment/1768421/","msgid":"<1505378653.31557.5.camel@redhat.com>","list_archive_url":null,"date":"2017-09-14T08:44:13","subject":"Re: [Qemu-devel] [PATCH v1 1/2] virtio_gpu: Handle endian conversion","submitter":{"id":589,"url":"http://patchwork.ozlabs.org/api/people/589/","name":"Gerd Hoffmann","email":"kraxel@redhat.com"},"content":"On Wed, 2017-09-13 at 11:53 -0400, Farhan Ali wrote:\n> \n> On 09/13/2017 04:13 AM, Gerd Hoffmann wrote:\n> > Please move this to a helper function, maybe by updating the\n> > VIRTIO_GPU_FILL_CMD macro.\n> > \n> > The header fields should be byteswapped too.  As most structs have\n> > 32bit fields only (with the exception of hdr.fence_id) you should\n> > be\n> > able to create a generic byteswap function which only needs the\n> > struct\n> > size as argument and handles all structs without addresses/offsets\n> > (which are 64bit fields).\n> \n> I am not sure if I understand what you mean here. Since struct \n> virtio_gpu_ctrl_hdr is part of every struct, so any such function\n> would also need to handle the case of hdr.fence_id, right?\n\nYes, but that is common in all structs. You can have one function to\nhandle the header, one generic function (calls the header function for\nthe header and just does 32bit byteswaps for everything else), one\nspecific function for each operation which has a 64bit address\nsomewhere in the struct (which again can use the header function for\nthe header).\n\ncheers,\n Gerd","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=kraxel@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xtBt744LRz9sP1\n\tfor ;\n\tThu, 14 Sep 2017 18:44:46 +1000 (AEST)","from localhost ([::1]:46389 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dsPlL-0008Tt-Ro\n\tfor incoming@patchwork.ozlabs.org; Thu, 14 Sep 2017 04:44:43 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:50961)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dsPkv-0008TS-QA\n\tfor qemu-devel@nongnu.org; Thu, 14 Sep 2017 04:44:18 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dsPkt-0001EG-Rx\n\tfor qemu-devel@nongnu.org; Thu, 14 Sep 2017 04:44:17 -0400","from mx1.redhat.com ([209.132.183.28]:35314)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dsPkt-0001Dj-M1\n\tfor qemu-devel@nongnu.org; Thu, 14 Sep 2017 04:44:15 -0400","from smtp.corp.redhat.com\n\t(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 9EE344A6E0;\n\tThu, 14 Sep 2017 08:44:14 +0000 (UTC)","from sirius.home.kraxel.org (ovpn-117-51.ams2.redhat.com\n\t[10.36.117.51])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 5BE295D963;\n\tThu, 14 Sep 2017 08:44:14 +0000 (UTC)","from localhost (localhost [IPv6:::1])\n\tby sirius.home.kraxel.org (Postfix) with ESMTP id 82C0720488;\n\tThu, 14 Sep 2017 10:44:13 +0200 (CEST)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 9EE344A6E0","Message-ID":"<1505378653.31557.5.camel@redhat.com>","From":"Gerd Hoffmann ","To":"Farhan Ali , qemu-devel@nongnu.org","Date":"Thu, 14 Sep 2017 10:44:13 +0200","In-Reply-To":"<5678da9e-ddea-1d31-77ff-8ea52ee30ca9@linux.vnet.ibm.com>","References":"\n\t<0a156f413f67b1bf55c5516d8263a15db3ec42c3.1505225353.git.alifm@linux.vnet.ibm.com>\n\t<1505290435.22749.3.camel@redhat.com>\n\t<5678da9e-ddea-1d31-77ff-8ea52ee30ca9@linux.vnet.ibm.com>","Content-Type":"text/plain; charset=\"UTF-8\"","Mime-Version":"1.0","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.14","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.38]);\n\tThu, 14 Sep 2017 08:44:14 +0000 (UTC)","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v1 1/2] virtio_gpu: Handle endian conversion","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"borntraeger@de.ibm.com, thuth@redhat.com, cohuck@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]