[{"id":1767102,"web_url":"http://patchwork.ozlabs.org/comment/1767102/","msgid":"","list_archive_url":null,"date":"2017-09-12T14:13:45","subject":"Re: [Qemu-devel] [PATCH v3 3/3] tests/hmp: test \"none\" machine with\n\tmemory","submitter":{"id":66152,"url":"http://patchwork.ozlabs.org/api/people/66152/","name":"Thomas Huth","email":"thuth@redhat.com"},"content":"On 12.09.2017 16:01, Laurent Vivier wrote:\n> and add a test case of dump-guest-memory without\n> \"[begin length]\" parameters.\n> \n> Signed-off-by: Laurent Vivier \n> Reviewed-by: Thomas Huth \n> ---\n> tests/test-hmp.c | 4 ++++\n> 1 file changed, 4 insertions(+)\n> \n> diff --git a/tests/test-hmp.c b/tests/test-hmp.c\n> index 729c0339f7..6b2dd5f8b8 100644\n> --- a/tests/test-hmp.c\n> +++ b/tests/test-hmp.c\n> @@ -35,6 +35,7 @@ static const char *hmp_cmds[] = {\n> \"mouse_button 0\",\n> \"device_del mouse1\",\n> \"dump-guest-memory /dev/null 0 4096\",\n> + \"dump-guest-memory /dev/null\",\n> \"gdbserver\",\n> \"host_net_add user id=net0\",\n> \"hostfwd_add tcp::43210-:43210\",\n> @@ -159,5 +160,8 @@ int main(int argc, char **argv)\n> \n> qtest_cb_for_every_machine(add_machine_test_case);\n> \n> + /* as none machine has no memory, add a test case with memory */\n> + qtest_add_data_func(\"hmp/none+2MB\", g_strdup(\"none -m 2\"), test_machine);\n> +\n> return g_test_run();\n> }\n> \n\nReviewed-by: Thomas Huth ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx05.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx05.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=thuth@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xs6Hp1Ch9z9s0Z\n\tfor ;\n\tWed, 13 Sep 2017 00:14:45 +1000 (AEST)","from localhost ([::1]:36132 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1drlxb-0000G5-VA\n\tfor incoming@patchwork.ozlabs.org; Tue, 12 Sep 2017 10:14:44 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:36783)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1drlws-0008Ub-Jn\n\tfor qemu-devel@nongnu.org; Tue, 12 Sep 2017 10:13:59 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1drlwr-0004GV-Mg\n\tfor qemu-devel@nongnu.org; Tue, 12 Sep 2017 10:13:58 -0400","from mx1.redhat.com ([209.132.183.28]:44300)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1drlwm-0004C8-0j; Tue, 12 Sep 2017 10:13:52 -0400","from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id F08902F9447;\n\tTue, 12 Sep 2017 14:13:50 +0000 (UTC)","from [10.40.204.137] (ovpn-204-137.brq.redhat.com [10.40.204.137])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 4FB4C66851;\n\tTue, 12 Sep 2017 14:13:47 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com F08902F9447","To":"Laurent Vivier , qemu-devel@nongnu.org","References":"<20170912140149.7692-1-lvivier@redhat.com>\n\t<20170912140149.7692-4-lvivier@redhat.com>","From":"Thomas Huth ","Message-ID":"","Date":"Tue, 12 Sep 2017 16:13:45 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170912140149.7692-4-lvivier@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.16","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.29]);\n\tTue, 12 Sep 2017 14:13:51 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v3 3/3] tests/hmp: test \"none\" machine with\n\tmemory","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Peter Maydell ,\n\tCornelia Huck , \n\t\"Dr . David Alan Gilbert\" ,\n\tGreg Kurz , qemu-arm@nongnu.org,\n\tqemu-ppc@nongnu.org, David Gibson ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1767645,"web_url":"http://patchwork.ozlabs.org/comment/1767645/","msgid":"<20170913095341.6505861c.cohuck@redhat.com>","list_archive_url":null,"date":"2017-09-13T07:53:41","subject":"Re: [Qemu-devel] [PATCH v3 3/3] tests/hmp: test \"none\" machine with\n\tmemory","submitter":{"id":71914,"url":"http://patchwork.ozlabs.org/api/people/71914/","name":"Cornelia Huck","email":"cohuck@redhat.com"},"content":"On Tue, 12 Sep 2017 16:01:49 +0200\nLaurent Vivier wrote:\n\n> and add a test case of dump-guest-memory without\n> \"[begin length]\" parameters.\n> \n> Signed-off-by: Laurent Vivier \n> Reviewed-by: Thomas Huth \n> ---\n> tests/test-hmp.c | 4 ++++\n> 1 file changed, 4 insertions(+)\n> \n> diff --git a/tests/test-hmp.c b/tests/test-hmp.c\n> index 729c0339f7..6b2dd5f8b8 100644\n> --- a/tests/test-hmp.c\n> +++ b/tests/test-hmp.c\n> @@ -35,6 +35,7 @@ static const char *hmp_cmds[] = {\n> \"mouse_button 0\",\n> \"device_del mouse1\",\n> \"dump-guest-memory /dev/null 0 4096\",\n> + \"dump-guest-memory /dev/null\",\n> \"gdbserver\",\n> \"host_net_add user id=net0\",\n> \"hostfwd_add tcp::43210-:43210\",\n> @@ -159,5 +160,8 @@ int main(int argc, char **argv)\n> \n> qtest_cb_for_every_machine(add_machine_test_case);\n> \n> + /* as none machine has no memory, add a test case with memory */\n\ns/no memory/no memory by default/\n\n?\n\n> + qtest_add_data_func(\"hmp/none+2MB\", g_strdup(\"none -m 2\"), test_machine);\n> +\n> return g_test_run();\n> }\n\nRegardless,\n\nReviewed-by: Cornelia Huck ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=cohuck@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xsYpd1c65z9sNV\n\tfor ;\n\tWed, 13 Sep 2017 17:54:33 +1000 (AEST)","from localhost ([::1]:40695 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1ds2VD-0006lk-Au\n\tfor incoming@patchwork.ozlabs.org; Wed, 13 Sep 2017 03:54:31 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:44968)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1ds2Ud-0006kN-L4\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 03:53:56 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1ds2Uc-0002g8-Rc\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 03:53:55 -0400","from mx1.redhat.com ([209.132.183.28]:34420)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1ds2UX-0002Wv-3b; Wed, 13 Sep 2017 03:53:49 -0400","from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id CBAF0478A;\n\tWed, 13 Sep 2017 07:53:47 +0000 (UTC)","from gondolin (dhcp-192-215.str.redhat.com [10.33.192.215])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 1A2555C6D7;\n\tWed, 13 Sep 2017 07:53:43 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com CBAF0478A","Date":"Wed, 13 Sep 2017 09:53:41 +0200","From":"Cornelia Huck ","To":"Laurent Vivier ","Message-ID":"<20170913095341.6505861c.cohuck@redhat.com>","In-Reply-To":"<20170912140149.7692-4-lvivier@redhat.com>","References":"<20170912140149.7692-1-lvivier@redhat.com>\n\t<20170912140149.7692-4-lvivier@redhat.com>","Organization":"Red Hat GmbH","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.11","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.30]);\n\tWed, 13 Sep 2017 07:53:48 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v3 3/3] tests/hmp: test \"none\" machine with\n\tmemory","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Peter Maydell , Thomas Huth ,\n\tqemu-devel@nongnu.org, \"Dr . David Alan Gilbert\" ,\n\tGreg Kurz , qemu-arm@nongnu.org,\n\tqemu-ppc@nongnu.org, David Gibson ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]