[{"id":1767103,"web_url":"http://patchwork.ozlabs.org/comment/1767103/","msgid":"<13c0f923-dbaa-e458-0544-59cd8e05a7e6@redhat.com>","list_archive_url":null,"date":"2017-09-12T14:11:17","subject":"Re: [Qemu-devel] [PATCH v3 2/3] hmp: fix \"dump-quest-memory\"\n\tsegfault (arm)","submitter":{"id":66152,"url":"http://patchwork.ozlabs.org/api/people/66152/","name":"Thomas Huth","email":"thuth@redhat.com"},"content":"On 12.09.2017 16:01, Laurent Vivier wrote:\n> Running QEMU with\n> qemu-system-aarch64 -M none -nographic -m 256\n> and executing\n> dump-guest-memory /dev/null 0 8192\n> results in segfault\n> \n> Fix by checking if we have CPU, and exit with\n> error if there is no CPU:\n> \n> (qemu) dump-guest-memory /dev/null\n> this feature or command is not currently supported\n> \n> Signed-off-by: Laurent Vivier \n> ---\n> target/arm/arch_dump.c | 11 +++++++++--\n> 1 file changed, 9 insertions(+), 2 deletions(-)\n> \n> diff --git a/target/arm/arch_dump.c b/target/arm/arch_dump.c\n> index 1a9861f69b..9e5b2fb31c 100644\n> --- a/target/arm/arch_dump.c\n> +++ b/target/arm/arch_dump.c\n> @@ -273,11 +273,18 @@ int arm_cpu_write_elf32_note(WriteCoreDumpFunction f, CPUState *cs,\n> int cpu_get_dump_info(ArchDumpInfo *info,\n> const GuestPhysBlockList *guest_phys_blocks)\n> {\n> - ARMCPU *cpu = ARM_CPU(first_cpu);\n> - CPUARMState *env = &cpu->env;\n> + ARMCPU *cpu;\n> + CPUARMState *env;\n> GuestPhysBlock *block;\n> hwaddr lowest_addr = ULLONG_MAX;\n> \n> + if (first_cpu == NULL) {\n> + return -1;\n> + }\n> +\n> + cpu = ARM_CPU(first_cpu);\n> + env = &cpu->env;\n> +\n> /* Take a best guess at the phys_base. If we get it wrong then crash\n> * will need '--machdep phys_offset=' added to its command\n> * line, which isn't any worse than assuming we can use zero, but being\n> \n\nReviewed-by: Thomas Huth ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=thuth@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xs6Hx32nmz9s0Z\n\tfor ;\n\tWed, 13 Sep 2017 00:14:53 +1000 (AEST)","from localhost ([::1]:36133 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1drlxj-0000Nc-GZ\n\tfor incoming@patchwork.ozlabs.org; Tue, 12 Sep 2017 10:14:51 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:35206)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1drlub-0006Cm-Nl\n\tfor qemu-devel@nongnu.org; Tue, 12 Sep 2017 10:11:39 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1drluV-0002Dm-Oo\n\tfor qemu-devel@nongnu.org; Tue, 12 Sep 2017 10:11:37 -0400","from mx1.redhat.com ([209.132.183.28]:46971)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1drluO-00027y-Cq; Tue, 12 Sep 2017 10:11:24 -0400","from smtp.corp.redhat.com\n\t(int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 786B25F7AD;\n\tTue, 12 Sep 2017 14:11:23 +0000 (UTC)","from [10.40.204.137] (ovpn-204-137.brq.redhat.com [10.40.204.137])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 3DE1A6FB8E;\n\tTue, 12 Sep 2017 14:11:18 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 786B25F7AD","To":"Laurent Vivier , qemu-devel@nongnu.org","References":"<20170912140149.7692-1-lvivier@redhat.com>\n\t<20170912140149.7692-3-lvivier@redhat.com>","From":"Thomas Huth ","Message-ID":"<13c0f923-dbaa-e458-0544-59cd8e05a7e6@redhat.com>","Date":"Tue, 12 Sep 2017 16:11:17 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170912140149.7692-3-lvivier@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.15","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.39]);\n\tTue, 12 Sep 2017 14:11:23 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v3 2/3] hmp: fix \"dump-quest-memory\"\n\tsegfault (arm)","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Peter Maydell ,\n\tCornelia Huck , \n\t\"Dr . David Alan Gilbert\" ,\n\tGreg Kurz , qemu-arm@nongnu.org,\n\tqemu-ppc@nongnu.org, David Gibson ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1767149,"web_url":"http://patchwork.ozlabs.org/comment/1767149/","msgid":"<20170912165028.11ab5489@bahia.lan>","list_archive_url":null,"date":"2017-09-12T14:50:28","subject":"Re: [Qemu-devel] [PATCH v3 2/3] hmp: fix \"dump-quest-memory\"\n\tsegfault (arm)","submitter":{"id":69178,"url":"http://patchwork.ozlabs.org/api/people/69178/","name":"Greg Kurz","email":"groug@kaod.org"},"content":"On Tue, 12 Sep 2017 16:01:48 +0200\nLaurent Vivier wrote:\n\n> Running QEMU with\n> qemu-system-aarch64 -M none -nographic -m 256\n> and executing\n> dump-guest-memory /dev/null 0 8192\n> results in segfault\n> \n> Fix by checking if we have CPU, and exit with\n> error if there is no CPU:\n> \n> (qemu) dump-guest-memory /dev/null\n> this feature or command is not currently supported\n> \n> Signed-off-by: Laurent Vivier \n> ---\n\nReviewed-by: Greg Kurz \n\n> target/arm/arch_dump.c | 11 +++++++++--\n> 1 file changed, 9 insertions(+), 2 deletions(-)\n> \n> diff --git a/target/arm/arch_dump.c b/target/arm/arch_dump.c\n> index 1a9861f69b..9e5b2fb31c 100644\n> --- a/target/arm/arch_dump.c\n> +++ b/target/arm/arch_dump.c\n> @@ -273,11 +273,18 @@ int arm_cpu_write_elf32_note(WriteCoreDumpFunction f, CPUState *cs,\n> int cpu_get_dump_info(ArchDumpInfo *info,\n> const GuestPhysBlockList *guest_phys_blocks)\n> {\n> - ARMCPU *cpu = ARM_CPU(first_cpu);\n> - CPUARMState *env = &cpu->env;\n> + ARMCPU *cpu;\n> + CPUARMState *env;\n> GuestPhysBlock *block;\n> hwaddr lowest_addr = ULLONG_MAX;\n> \n> + if (first_cpu == NULL) {\n> + return -1;\n> + }\n> +\n> + cpu = ARM_CPU(first_cpu);\n> + env = &cpu->env;\n> +\n> /* Take a best guess at the phys_base. If we get it wrong then crash\n> * will need '--machdep phys_offset=' added to its command\n> * line, which isn't any worse than assuming we can use zero, but being","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xs7JR61SSz9sNV\n\tfor ;\n\tWed, 13 Sep 2017 01:00:23 +1000 (AEST)","from localhost ([::1]:36392 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1drmfl-0007mr-RV\n\tfor incoming@patchwork.ozlabs.org; Tue, 12 Sep 2017 11:00:21 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:54184)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1drmWW-0000UR-Nn\n\tfor qemu-devel@nongnu.org; Tue, 12 Sep 2017 10:50:55 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1drmWR-0004Zh-PB\n\tfor qemu-devel@nongnu.org; Tue, 12 Sep 2017 10:50:48 -0400","from 10.mo1.mail-out.ovh.net ([178.32.96.102]:50969)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1drmWR-0004Xw-08\n\tfor qemu-devel@nongnu.org; Tue, 12 Sep 2017 10:50:43 -0400","from player691.ha.ovh.net (b9.ovh.net [213.186.33.59])\n\tby mo1.mail-out.ovh.net (Postfix) with ESMTP id 8925093A4F\n\tfor ; Tue, 12 Sep 2017 16:50:41 +0200 (CEST)","from bahia.lan (deibp9eh1--blueice1n3.emea.ibm.com\n\t[195.212.29.165]) (Authenticated sender: groug@kaod.org)\n\tby player691.ha.ovh.net (Postfix) with ESMTPSA id CA3A526007F;\n\tTue, 12 Sep 2017 16:50:31 +0200 (CEST)"],"Date":"Tue, 12 Sep 2017 16:50:28 +0200","From":"Greg Kurz ","To":"Laurent Vivier ","Message-ID":"<20170912165028.11ab5489@bahia.lan>","In-Reply-To":"<20170912140149.7692-3-lvivier@redhat.com>","References":"<20170912140149.7692-1-lvivier@redhat.com>\n\t<20170912140149.7692-3-lvivier@redhat.com>","X-Mailer":"Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-redhat-linux-gnu)","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha1;\n\tboundary=\"Sig_/YIvikDq8zcY.vXy0KTjgMs/\";\n\tprotocol=\"application/pgp-signature\"","X-Ovh-Tracer-Id":"17600348819179870502","X-VR-SPAMSTATE":"OK","X-VR-SPAMSCORE":"-100","X-VR-SPAMCAUSE":"gggruggvucftvghtrhhoucdtuddrfeelledrgedvgdejkecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"178.32.96.102","Subject":"Re: [Qemu-devel] [PATCH v3 2/3] hmp: fix \"dump-quest-memory\"\n\tsegfault (arm)","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Peter Maydell , Thomas Huth ,\n\tCornelia Huck , qemu-devel@nongnu.org,\n\t\"Dr . David Alan Gilbert\" ,\n\tqemu-arm@nongnu.org, qemu-ppc@nongnu.org,\n\tDavid Gibson ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]