[{"id":1772761,"web_url":"http://patchwork.ozlabs.org/comment/1772761/","msgid":"","list_archive_url":null,"date":"2017-09-21T12:17:25","subject":"Re: [PATCH] Fix PR82144","submitter":{"id":4338,"url":"http://patchwork.ozlabs.org/api/people/4338/","name":"Richard Biener","email":"rguenther@suse.de"},"content":"On Tue, 12 Sep 2017, Richard Biener wrote:\n\n> \n> The following avoids adding DW_AT_alignment twice by not doing it\n> for incomplete types.\n> \n> Bootstrapped on x86_64-unknown-linux-gnu, testing in progress.\n> \n> Alex, is that ok or do we want DW_AT_alignment for incomplete types as \n> well?\n\nAlex, ping?\n\nThanks,\nRichard.\n\n> 2017-09-12 Richard Biener \n> \n> \tPR middle-end/82144\n> \t* dwarf2out.c (gen_enumeration_type_die): Do not add alignment\n> \tattribute for incomplete types nor twice for complete ones.\n> \n> Index: gcc/dwarf2out.c\n> ===================================================================\n> --- gcc/dwarf2out.c\t(revision 252002)\n> +++ gcc/dwarf2out.c\t(working copy)\n> @@ -21258,8 +21258,6 @@ gen_enumeration_type_die (tree type, dw_\n> else\n> add_AT_flag (type_die, DW_AT_declaration, 1);\n> \n> - add_alignment_attribute (type_die, type);\n> -\n> add_pubtype (type, type_die);\n> \n> return type_die;","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list gcc-patches@gcc.gnu.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=gcc.gnu.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=gcc-patches-return-462695-incoming=patchwork.ozlabs.org@gcc.gnu.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org\n\theader.b=\"hssyusx4\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xybGT6h9mz9s5L\n\tfor ;\n\tThu, 21 Sep 2017 22:17:37 +1000 (AEST)","(qmail 735 invoked by alias); 21 Sep 2017 12:17:29 -0000","(qmail 726 invoked by uid 89); 21 Sep 2017 12:17:28 -0000","from mx2.suse.de (HELO mx1.suse.de) (195.135.220.15) by\n\tsourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP;\n\tThu, 21 Sep 2017 12:17:27 +0000","from relay2.suse.de (charybdis-ext.suse.de [195.135.220.254])\tby\n\tmx1.suse.de (Postfix) with ESMTP id 17D7AAAB2;\n\tThu, 21 Sep 2017 12:17:25 +0000 (UTC)"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id\n\t:list-unsubscribe:list-archive:list-post:list-help:sender:date\n\t:from:to:cc:subject:in-reply-to:message-id:references\n\t:mime-version:content-type; q=dns; s=default; b=x7SRq2KH+Bizapee\n\toH3bWmyk1Q1zvYZGCmauu6XsmWL421u8zw5bBf5doHjDyskQy6dCP/Bsbg2bGa4D\n\t2NANW6ecAZ7r3MZcKI2nIX73olW1bIQvibt+YdtoPP+qfTUsjOCENPz9Aq2tDAzF\n\t3Lawtnf1W44so+zju7LAQlOGqV4=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id\n\t:list-unsubscribe:list-archive:list-post:list-help:sender:date\n\t:from:to:cc:subject:in-reply-to:message-id:references\n\t:mime-version:content-type; s=default; bh=zBDjOHV6CSd1Of7bptamDu\n\tuNfRY=; b=hssyusx4Qg8hay33OglbGjgR/SRi5RrN5yd+6RJFgl3cpEXr2aWv+G\n\tJ1j+zLX4T9mxPvR68/laAdKenwx7uJlcV9zyckmq7Cera7sDn7PLlEcosxlOs1Hj\n\tfJy3oK0lS5Nl7S6ojllq1/x4N7uiAQglOavYlBgptxKPwgLTLqo4w=","Mailing-List":"contact gcc-patches-help@gcc.gnu.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Archive":"","List-Post":"","List-Help":"","Sender":"gcc-patches-owner@gcc.gnu.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-11.9 required=5.0 tests=BAYES_00, GIT_PATCH_2,\n\tGIT_PATCH_3, RP_MATCHES_RCVD,\n\tSPF_PASS autolearn=ham version=3.3.2 spammy=","X-HELO":"mx1.suse.de","Date":"Thu, 21 Sep 2017 14:17:25 +0200 (CEST)","From":"Richard Biener ","To":"gcc-patches@gcc.gnu.org","cc":"aoliva@redhat.com","Subject":"Re: [PATCH] Fix PR82144","In-Reply-To":"","Message-ID":"","References":"","User-Agent":"Alpine 2.20 (LSU 67 2015-01-07)","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII"}},{"id":1773872,"web_url":"http://patchwork.ozlabs.org/comment/1773872/","msgid":"","list_archive_url":null,"date":"2017-09-22T20:37:57","subject":"Re: [PATCH] Fix PR82144","submitter":{"id":2058,"url":"http://patchwork.ozlabs.org/api/people/2058/","name":"Alexandre Oliva","email":"aoliva@redhat.com"},"content":"On Sep 21, 2017, Richard Biener wrote:\n\n> On Tue, 12 Sep 2017, Richard Biener wrote:\n>> \n>> The following avoids adding DW_AT_alignment twice by not doing it\n>> for incomplete types.\n>> \n>> Bootstrapped on x86_64-unknown-linux-gnu, testing in progress.\n>> \n>> Alex, is that ok or do we want DW_AT_alignment for incomplete types as \n>> well?\n\n> Alex, ping?\n\nSorry, still catching up after Cauldron and recovery from the bug I\ncaught at the conference ;-)\n\nSince incomplete enum types are non-standard, there's no standard to\nguide us. Pointers (the primary viable use of such types) generally\nbenefit from alignment information, but I don't see how the alignment\ncould be meaningfully determined for such types. For debug information,\nwe're probably better off leaving any tentative or uninitialized\nalignment information out of the DIE, so the patch looks good to me.\nThanks for your patience!\n\nReviewed-by: Alexandre Oliva \n\n>> PR middle-end/82144\n>> * dwarf2out.c (gen_enumeration_type_die): Do not add alignment\n>> attribute for incomplete types nor twice for complete ones.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list gcc-patches@gcc.gnu.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=gcc.gnu.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=gcc-patches-return-462811-incoming=patchwork.ozlabs.org@gcc.gnu.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org\n\theader.b=\"uf+rLd6K\"; dkim-atps=neutral","sourceware.org; auth=none","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=aoliva@redhat.com"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xzQKn5VYvz9t32\n\tfor ;\n\tSat, 23 Sep 2017 06:38:20 +1000 (AEST)","(qmail 116318 invoked by alias); 22 Sep 2017 20:38:12 -0000","(qmail 116304 invoked by uid 89); 22 Sep 2017 20:38:12 -0000","from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by\n\tsourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP;\n\tFri, 22 Sep 2017 20:38:11 +0000","from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com\n\t[10.5.11.11])\t(using TLSv1.2 with cipher AECDH-AES256-SHA\n\t(256/256 bits))\t(No client certificate requested)\tby\n\tmx1.redhat.com (Postfix) with ESMTPS id 089515D5EA;\n\tFri, 22 Sep 2017 20:38:10 +0000 (UTC)","from freie.home (ovpn04.gateway.prod.ext.phx2.redhat.com\n\t[10.5.9.4])\tby smtp.corp.redhat.com (Postfix) with ESMTPS id\n\t520F660317; Fri, 22 Sep 2017 20:38:08 +0000 (UTC)","from livre (livre.home [172.31.160.2])\tby freie.home\n\t(8.15.2/8.15.2) with ESMTP id v8MKbvdB009128;\n\tFri, 22 Sep 2017 17:37:57 -0300"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id\n\t:list-unsubscribe:list-archive:list-post:list-help:sender:from\n\t:to:cc:subject:references:date:in-reply-to:message-id\n\t:mime-version:content-type; q=dns; s=default; b=tuD/K5Yv/zXROJ91\n\ts3/j/rJnSJydf1FJEpFXK4zoLTSQnHsTKRmEky5yegHekeTWrs0drI0y51JG51Kt\n\trsPuOHWE9d1uNInm0VeXSrvuD2eSHWa9rmYUWFlYMFCoL6HiE4SPbo2P2KJXnI7a\n\tARu+eMr5FJhT8NbcP0nmyLsuGo4=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id\n\t:list-unsubscribe:list-archive:list-post:list-help:sender:from\n\t:to:cc:subject:references:date:in-reply-to:message-id\n\t:mime-version:content-type; s=default; bh=LXKnnMWOzHW72sSFiY/E3c\n\tjl9bU=; b=uf+rLd6KRJfLS2vaayj2PVVQRi6Z39Zxd9v5t9FIldiQxNNPWXW3Di\n\t65rpOk6DhI3DK6vSm4qwWc3K0YVSAmUhHUO3evJBh/7qZdCOs6JFjYr/0PhqCNvM\n\tJDis2YsT3n9UpVAjTV0PPcuLX8wFP90A8PYr2/jC1+XA3ZsRT4BQI=","Mailing-List":"contact gcc-patches-help@gcc.gnu.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Archive":"","List-Post":"","List-Help":"","Sender":"gcc-patches-owner@gcc.gnu.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-1.9 required=5.0 tests=BAYES_00,\n\tRP_MATCHES_RCVD,\n\tSPF_HELO_PASS autolearn=ham version=3.3.2 spammy=patience","X-HELO":"mx1.redhat.com","DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 089515D5EA","From":"Alexandre Oliva ","To":"Richard Biener ","Cc":"gcc-patches@gcc.gnu.org","Subject":"Re: [PATCH] Fix PR82144","References":"\t","Date":"Fri, 22 Sep 2017 17:37:57 -0300","In-Reply-To":"\n\t(Richard\tBiener's message of \"Thu,\n\t21 Sep 2017 14:17:25 +0200 (CEST)\")","Message-ID":"","User-Agent":"Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux)","MIME-Version":"1.0","Content-Type":"text/plain"}},{"id":1774472,"web_url":"http://patchwork.ozlabs.org/comment/1774472/","msgid":"","list_archive_url":null,"date":"2017-09-25T07:25:42","subject":"Re: [PATCH] Fix PR82144","submitter":{"id":4338,"url":"http://patchwork.ozlabs.org/api/people/4338/","name":"Richard Biener","email":"rguenther@suse.de"},"content":"On Fri, 22 Sep 2017, Alexandre Oliva wrote:\n\n> On Sep 21, 2017, Richard Biener wrote:\n> \n> > On Tue, 12 Sep 2017, Richard Biener wrote:\n> >> \n> >> The following avoids adding DW_AT_alignment twice by not doing it\n> >> for incomplete types.\n> >> \n> >> Bootstrapped on x86_64-unknown-linux-gnu, testing in progress.\n> >> \n> >> Alex, is that ok or do we want DW_AT_alignment for incomplete types as \n> >> well?\n> \n> > Alex, ping?\n> \n> Sorry, still catching up after Cauldron and recovery from the bug I\n> caught at the conference ;-)\n> \n> Since incomplete enum types are non-standard, there's no standard to\n> guide us. Pointers (the primary viable use of such types) generally\n> benefit from alignment information, but I don't see how the alignment\n> could be meaningfully determined for such types. For debug information,\n> we're probably better off leaving any tentative or uninitialized\n> alignment information out of the DIE, so the patch looks good to me.\n> Thanks for your patience!\n\nThanks, applied as rev. 253134.\n\nRichard.\n\n> Reviewed-by: Alexandre Oliva \n> \n> >> PR middle-end/82144\n> >> * dwarf2out.c (gen_enumeration_type_die): Do not add alignment\n> >> attribute for incomplete types nor twice for complete ones.\n> \n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list gcc-patches@gcc.gnu.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=gcc.gnu.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=gcc-patches-return-462846-incoming=patchwork.ozlabs.org@gcc.gnu.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org\n\theader.b=\"e9PdFmuB\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y0wc85sgFz9tXM\n\tfor ;\n\tMon, 25 Sep 2017 17:25:56 +1000 (AEST)","(qmail 54446 invoked by alias); 25 Sep 2017 07:25:46 -0000","(qmail 54011 invoked by uid 89); 25 Sep 2017 07:25:45 -0000","from mx2.suse.de (HELO mx1.suse.de) (195.135.220.15) by\n\tsourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP;\n\tMon, 25 Sep 2017 07:25:44 +0000","from relay2.suse.de (charybdis-ext.suse.de [195.135.220.254])\tby\n\tmx1.suse.de (Postfix) with ESMTP id 5D8A6ABFC;\n\tMon, 25 Sep 2017 07:25:42 +0000 (UTC)"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id\n\t:list-unsubscribe:list-archive:list-post:list-help:sender:date\n\t:from:to:cc:subject:in-reply-to:message-id:references\n\t:mime-version:content-type; q=dns; s=default; b=ioCdkOvCmsWr0yr4\n\tP4s5ZsGIPl3RsczlOt8CdKpDD5kaHrlohMeETOTjlvG19ajn4PL22Tn7aqfW7kX7\n\t5visoacf+MhlVayYKQ/dIKNGs5VIjmQCO4YQJOQ36PAfkLAEh85wX9Ex1UgaHSKd\n\t4GekeL00bPwKcGjn0ikaUBy0WqQ=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id\n\t:list-unsubscribe:list-archive:list-post:list-help:sender:date\n\t:from:to:cc:subject:in-reply-to:message-id:references\n\t:mime-version:content-type; s=default; bh=Vdt7rKZP0gINx0MH85NsdZ\n\t/FVNs=; b=e9PdFmuBQ4I+CB4bmemXWzspo3yDn0megWlqDsv0VWkkkC5K9oltS6\n\tUQP09tUWauUlwiWrGQKiw3fS5moidv9vXpDVaTFlkkjezr9+5C7qk9HaeZ9z30fb\n\t/LpM/V9WeZmJiCUENLNtsMuTw+mYfudrLtg9Ek+h7SsbNwkOunf3w=","Mailing-List":"contact gcc-patches-help@gcc.gnu.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Archive":"","List-Post":"","List-Help":"","Sender":"gcc-patches-owner@gcc.gnu.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-1.9 required=5.0 tests=BAYES_00,\n\tRP_MATCHES_RCVD,\n\tSPF_PASS autolearn=ham version=3.3.2 spammy=jane, HRB, Jane,\n\tHTo:U*aoliva","X-HELO":"mx1.suse.de","Date":"Mon, 25 Sep 2017 09:25:42 +0200 (CEST)","From":"Richard Biener ","To":"Alexandre Oliva ","cc":"gcc-patches@gcc.gnu.org","Subject":"Re: [PATCH] Fix PR82144","In-Reply-To":"","Message-ID":"","References":"\n\t\n\t","User-Agent":"Alpine 2.20 (LSU 67 2015-01-07)","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII"}}]