[{"id":1767100,"web_url":"http://patchwork.ozlabs.org/comment/1767100/","msgid":"<1505223085.31639.18.camel@redhat.com>","list_archive_url":null,"date":"2017-09-12T13:31:25","subject":"Re: [Qemu-devel] [PATCH v5 03/12] ui: convert key events to\n\tQKeyCodes immediately","submitter":{"id":589,"url":"http://patchwork.ozlabs.org/api/people/589/","name":"Gerd Hoffmann","email":"kraxel@redhat.com"},"content":"On Tue, 2017-09-12 at 13:37 +0100, Daniel P. Berrange wrote:\n> Always use QKeyCode in the InputKeyEvent struct, by converting key\n> numbers to QKeyCode at the time the event is created.\n> \n> Signed-off-by: Daniel P. Berrange \n\nqmp_input_send_event() must be handled too as patches later in this\nseries depend on never seeing any KEY_VALUE_KIND_NUMBER key events.\n\ncheers,\n Gerd\n\n@@ -157,9 +157,16 @@ void qmp_input_send_event(bool has_device, const\nchar *device,\n     }\n \n     for (e = events; e != NULL; e = e->next) {\n-        InputEvent *event = e->value;\n+        InputEvent *evt = e->value;\n \n-        qemu_input_event_send(con, event);\n+        if (evt->type == INPUT_EVENT_KIND_KEY &&\n+            evt->u.key.data->key->type == KEY_VALUE_KIND_NUMBER) {\n+            KeyValue *key = evt->u.key.data->key;\n+            QKeyCode code = qemu_input_key_number_to_qcode(key-\n>u.qcode.data);\n+            qemu_input_event_send_key_qcode(con, code, evt-\n>u.key.data->down);\n+        } else {\n+            qemu_input_event_send(con, evt);\n+        }\n     }","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=kraxel@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xs6Bn3dtQz9sNV\n\tfor ;\n\tWed, 13 Sep 2017 00:10:25 +1000 (AEST)","from localhost ([::1]:36103 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1drltP-0004di-Hw\n\tfor incoming@patchwork.ozlabs.org; Tue, 12 Sep 2017 10:10:23 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:32869)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1drlsF-0004AE-4d\n\tfor qemu-devel@nongnu.org; Tue, 12 Sep 2017 10:09:12 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1drls9-0008SR-7F\n\tfor qemu-devel@nongnu.org; Tue, 12 Sep 2017 10:09:11 -0400","from mx1.redhat.com ([209.132.183.28]:59586)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1drls9-0008RT-0Z\n\tfor qemu-devel@nongnu.org; Tue, 12 Sep 2017 10:09:05 -0400","from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 8130D5D685\n\tfor ; Tue, 12 Sep 2017 14:09:03 +0000 (UTC)","from sirius.home.kraxel.org (ovpn-117-51.ams2.redhat.com\n\t[10.36.117.51])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 35D536F433;\n\tTue, 12 Sep 2017 14:09:03 +0000 (UTC)","from localhost (localhost [IPv6:::1])\n\tby sirius.home.kraxel.org (Postfix) with ESMTP id 9D56D17532;\n\tTue, 12 Sep 2017 15:31:25 +0200 (CEST)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 8130D5D685","Message-ID":"<1505223085.31639.18.camel@redhat.com>","From":"Gerd Hoffmann ","To":"\"Daniel P. Berrange\" , qemu-devel@nongnu.org","Date":"Tue, 12 Sep 2017 15:31:25 +0200","In-Reply-To":"<20170912123744.14730-4-berrange@redhat.com>","References":"<20170912123744.14730-1-berrange@redhat.com>\n\t<20170912123744.14730-4-berrange@redhat.com>","Content-Type":"text/plain; charset=\"UTF-8\"","Mime-Version":"1.0","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.11","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.39]);\n\tTue, 12 Sep 2017 14:09:03 +0000 (UTC)","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v5 03/12] ui: convert key events to\n\tQKeyCodes immediately","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]