[{"id":1766995,"web_url":"http://patchwork.ozlabs.org/comment/1766995/","msgid":"","list_archive_url":null,"date":"2017-09-12T12:42:02","subject":"Re: [swupdate] [PATCH] tmpdir: fix asprintf return value check","submitter":{"id":5771,"url":"http://patchwork.ozlabs.org/api/people/5771/","name":"Stefano Babic","email":"sbabic@denx.de"},"content":"On 12/09/2017 14:35, Christian Storm wrote:\n> Fix travis's complaint about missing asprintf\n> return value check (-Wunused-result).\n> \n> Signed-off-by: Christian Storm \n> ---\n> core/util.c | 4 +++-\n> 1 file changed, 3 insertions(+), 1 deletion(-)\n> \n> diff --git a/core/util.c b/core/util.c\n> index 8c6b295..821b6df 100644\n> --- a/core/util.c\n> +++ b/core/util.c\n> @@ -71,7 +71,9 @@ const char* get_tmpdir(void)\n> \t\treturn TMPDIR;\n> \t}\n> \n> -\tasprintf(&TMPDIR, \"%s/\", env_tmpdir);\n> +\tif (asprintf(&TMPDIR, \"%s/\", env_tmpdir) == -1) {\n> +\t\tTMPDIR = (char*)\"/tmp/\";\n> +\t}\n> \treturn TMPDIR;\n> }\n> \n> \n\nReviewed-by: Stefano Babic \n\nBest regards,\nStefano Babic","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=googlegroups.com\n\t(client-ip=2a00:1450:400c:c0c::240;\n\thelo=mail-wr0-x240.google.com;\n\tenvelope-from=swupdate+bncbaabbinm37gqkgqezx7cf7y@googlegroups.com;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=googlegroups.com header.i=@googlegroups.com\n\theader.b=\"N5P40Trq\"; dkim-atps=neutral"],"Received":["from mail-wr0-x240.google.com (mail-wr0-x240.google.com\n\t[IPv6:2a00:1450:400c:c0c::240])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xs4b16dTvz9rxl\n\tfor ;\n\tTue, 12 Sep 2017 22:57:49 +1000 (AEST)","by mail-wr0-x240.google.com with SMTP id t76sf951331wrc.12\n\tfor ;\n\tTue, 12 Sep 2017 05:57:48 -0700 (PDT)","by 10.28.165.198 with SMTP id o189ls346507wme.24.canary-gmail; Tue,\n\t12 Sep 2017 05:42:09 -0700 (PDT)","from mail-out.m-online.net (mail-out.m-online.net.\n\t[2001:a60:0:28:0:1:25:1]) by gmr-mx.google.com with ESMTPS id\n\tp70si82422wma.1.2017.09.12.05.42.09 for \n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 12 Sep 2017 05:42:09 -0700 (PDT)","from frontend03.mail.m-online.net (unknown [192.168.6.182])\n\tby mail-out.m-online.net (Postfix) with ESMTP id 3xs4Dx2FTZz1qvnB;\n\tTue, 12 Sep 2017 14:42:09 +0200 (CEST)","from localhost (dynscan3.mnet-online.de [192.168.6.84])\n\tby mail.m-online.net (Postfix) with ESMTP id 3xs4Dx22mXz1qsQ3;\n\tTue, 12 Sep 2017 14:42:09 +0200 (CEST)","from mail.mnet-online.de ([192.168.8.182])\n\tby localhost (dynscan3.mail.m-online.net [192.168.6.84]) (amavisd-new,\n\tport 10024)\n\twith ESMTP id tqWPU9Tj6zS4; Tue, 12 Sep 2017 14:42:07 +0200 (CEST)","from babic.homelinux.org\n\t(host-88-217-136-221.customer.m-online.net [88.217.136.221])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby mail.mnet-online.de (Postfix) with ESMTPS;\n\tTue, 12 Sep 2017 14:42:07 +0200 (CEST)","from localhost (mail.babic.homelinux.org [127.0.0.1])\n\tby babic.homelinux.org (Postfix) with ESMTP id C31B045405CE;\n\tTue, 12 Sep 2017 14:42:06 +0200 (CEST)","from babic.homelinux.org ([127.0.0.1])\n\tby localhost (mail.babic.homelinux.org [127.0.0.1]) (amavisd-new,\n\tport 10024)\n\twith ESMTP id 3_n7KHx3AliB; Tue, 12 Sep 2017 14:42:02 +0200 (CEST)","from [192.168.178.132] (papero.fritz.box [192.168.178.132])\n\tby babic.homelinux.org (Postfix) with ESMTP id B43BA45405CD;\n\tTue, 12 Sep 2017 14:42:02 +0200 (CEST)"],"ARC-Seal":["i=2; a=rsa-sha256; t=1505221066; cv=pass;\n\td=google.com; s=arc-20160816;\n\tb=zO1qoih+2V7unNgnP/Fe43tHnIYS6DZzNcgc7FQS9plWms17pe4mHF4rIc37MPz+Eb\n\tSaz3cX+hciNRTPuoUj8M+DSFnxvf+rxsfneHK4nDkNJEDRN5W2VRlmuJ4Y9HqHGOrEFc\n\tEqnUSrWq0kz8aAuEDI8SiHI6VxugCh57JVuXxYw3JIBcdS/6WCo+8gHXOOa1UbMo0i+H\n\tX4frgATNf6mO1dYsehp4CqcRsFpKbGLQF/hCk+KfvvBz+0l2MVZYlaOseOyY87duJTC9\n\tNoGl2bKEveTMg+hnPFUuKB59VFBeR4Ak5z+gc20F21I+YBW0A8OCRbkk3HnXOO9rQZjt\n\tjHIw==","i=1; a=rsa-sha256; t=1505220129; cv=none;\n\td=google.com; s=arc-20160816;\n\tb=isaqUgpLD+nL6IvFXkeqyCFr8BAPTzmb6n5CdO5GRHjHblaPeLESyu8WCXOCKKaPMJ\n\taXOjIasNGxMspdFwxXHtfTPeCmya82ieSRc761Kaa3D3ccPwNY7TWeWiNAVJfdEB60gn\n\t12BPq/bSL+3h5cx+AFdD/6bHmJLT4/XLlU/1YMdNEj+GN66vnIirRhcXbLWP7UKlSDBz\n\t28odpQsKnjaJThD7lWa0nyVgm52J5PqRzXwHaVKrL93vVH9NyYOJ02FW61Qs9ow1CrAJ\n\ty9F+lDZWFp5uytr07v+0wDjX/OvMDSvjFVcLHZZKmSt92nDABE2zoDS/fJA3GQHqA4Jw\n\tqPag=="],"ARC-Message-Signature":["i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=arc-20160816; \n\th=list-unsubscribe:list-subscribe:list-archive:list-help:list-post\n\t:list-id:mailing-list:precedence:content-language:in-reply-to\n\t:mime-version:user-agent:date:message-id:from:references:to:subject\n\t:arc-authentication-results:arc-message-signature:sender\n\t:dkim-signature:arc-authentication-results;\n\tbh=wgGgUiL7PkriRRYTfJI4ZE0VeHTnExbUrrS6qUrxzsw=;\n\tb=SweVhRKMIsEP8G210CdCuENsA4cV87AEVWVVjd6wQMdwS874ggTAmzwAQuEjqzMk3p\n\t6fTGuxEMBM5cL0yV/Eu/hX7bb90Z7v0U7BmzjAJQogWHkRNm5c7ybCc9FRgTPh+ESUaE\n\tXpTGTQUNml34JjfzzJUACJI4Ua3mszZRQVsn9mG0cShIfVcP72dPSqvrWZYSklqdBOvL\n\tpHNifUnAYY7Rh+XhCVTXIhjMlIU/NfA2GpMK1Cgb+66P3ce6cTaS/x/bSKUAHqk7cVXW\n\tB4qobma7JggIVexYNAsBS+hX93gBt4zCr+XQ/4GZYCt4l9NWuJfWpT4h1t/Bzt16o31s\n\tjz7Q==","i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=arc-20160816; \n\th=content-transfer-encoding:content-language:in-reply-to:mime-version\n\t:user-agent:date:message-id:from:references:to:subject\n\t:arc-authentication-results;\n\tbh=9Ka7n5lOmOMr5hGvrLJ0q7/omqZW19ppjLosn0miaNg=;\n\tb=C7F+utGwOaBV8jV4gHn/kNJSj2AN2QqlC7/kkmOTyMJvFsjw2Z3+1qd/Pu4Yl3vqZo\n\tAwOwOCNJGNPrb8KBhX2hVEdiRFUakyZWgJ0wrjykdT0FC9ztvDHJZ+irilrbr/hj9cTC\n\tV8MonPGKUBVJ8IOi5TUVuCuEzNU7jsjPmO7abVsqYM+SFAXoEryfEbLV5Rq/e2bY24r8\n\t09DgdNGOvtfD1Yi4lfIglnMIBRDgJoFF9eI0qk1hN6B4GLYGOrFOTTeuaQqjlTs3RUOI\n\t4wjzLvW6m23SJaHS2Gxcya0zEEVaXuVJAs0iPfjOgXZHyYvEB1s2e3J/xTN0gtplBiQt\n\thtaA=="],"ARC-Authentication-Results":["i=2; gmr-mx.google.com;\n\tspf=neutral (google.com: 2001:a60:0:28:0:1:25:1 is neither permitted\n\tnor denied by best guess record for domain of sbabic@denx.de)\n\tsmtp.mailfrom=sbabic@denx.de","i=1; gmr-mx.google.com;\n\tspf=neutral (google.com: 2001:a60:0:28:0:1:25:1 is neither permitted\n\tnor denied by best guess record for domain of sbabic@denx.de)\n\tsmtp.mailfrom=sbabic@denx.de"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=googlegroups.com; s=20161025;\n\th=sender:subject:to:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:x-original-sender\n\t:x-original-authentication-results:precedence:mailing-list:list-id\n\t:list-post:list-help:list-archive:list-subscribe:list-unsubscribe;\n\tbh=wgGgUiL7PkriRRYTfJI4ZE0VeHTnExbUrrS6qUrxzsw=;\n\tb=N5P40Trq26mAx4dh5J1ET7GlCqVRr/BDXf+I2nZlXsv0ZD2Eo1x3UFcNSGZoeo8T0N\n\tn4x8WC3gA+cbo92lzuj9Q4M1Bb6qmmuMqGY5Q1QNu6JT/8noHHEy8es4n6/cNn8C5duJ\n\tU0Mhr6vMkVOkqokmB3IrOzUV75GB3Yu2rIRuV6k14RRe2vwMvdL+TwU9JtnMXW3vfUQ6\n\tNE0UioZKgKxvcttaXr9iJhaWOqdVzy/+eD0mAeJ2g3i/Ws72f0H8yX6YtBaJOeGmOCCi\n\tJOBeQytJRWeuW0uVLNySH59ngBT19GnWc45i468DqW6g3LkkY1wY3cCBy6OO77m05KCL\n\t7ltw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=sender:x-gm-message-state:subject:to:references:from:message-id\n\t:date:user-agent:mime-version:in-reply-to:content-language\n\t:x-original-sender:x-original-authentication-results:precedence\n\t:mailing-list:list-id:x-spam-checked-in-group:list-post:list-help\n\t:list-archive:list-subscribe:list-unsubscribe;\n\tbh=wgGgUiL7PkriRRYTfJI4ZE0VeHTnExbUrrS6qUrxzsw=;\n\tb=VXQlkVFBKqWRiL3ZLJdXJWivi9mPz2I6ZpRohvLQjPYUTdda4e7m8tEFFYogs6eF9q\n\tZ6XjaRBio9l2Nu7aGO2vfUAmJoLT0gxbsJWtGAt2Kk9mfr4alNhlckSTfvz7qvkoRtKW\n\tE9Qeb67lp7BajlFXAIKtAi1yEWAlbqzg1rhisiv9dvxBk9M/uUkt8yJnVMbLKTuHb4Ro\n\t0tDgmafH6dH+uxcEIfhM8k43YVjJ2ng+EqZhZUJ4Z4qbaqU7QizlNJZMBSp0qELt4S46\n\trRHK5k5LDrkdOEK7V5DiunuEmuG+wBscVt1dKEU1VUBTnj3DmPCaos5eSqhqpr0/DkMy\n\tJQKA==","Sender":"swupdate@googlegroups.com","X-Gm-Message-State":"AHPjjUjJlrKhkfEBcIBv/hsnHPa/03G2Z49gaDDm1FaO/IVNYxqe3aa5\n\tDfID/+OW0a7lSZjweWsdRAw=","X-Google-Smtp-Source":"AOwi7QDxorV9Mv8MyiOPZxENpek4dWr60DfRi8oeiP7rFPkDDXWxUYfHlnljzBVwT6xHp8z27tI/4g==","X-Received":["by 10.28.109.83 with SMTP id i80mr24312wmc.28.1505220129984;\n\tTue, 12 Sep 2017 05:42:09 -0700 (PDT)","by 10.223.182.165 with SMTP id j37mr828493wre.16.1505220129539; \n\tTue, 12 Sep 2017 05:42:09 -0700 (PDT)"],"X-BeenThere":"swupdate@googlegroups.com","Received-SPF":"neutral (google.com: 2001:a60:0:28:0:1:25:1 is neither\n\tpermitted nor denied by best guess record for domain of\n\tsbabic@denx.de) client-ip=2001:a60:0:28:0:1:25:1; ","X-Virus-Scanned":["amavisd-new at mnet-online.de","Debian amavisd-new at babic.homelinux.org"],"Subject":"Re: [swupdate] [PATCH] tmpdir: fix asprintf return value check","To":"Christian Storm , swupdate@googlegroups.com","References":"<20170912123554.7388-1-christian.storm@siemens.com>","From":"Stefano Babic ","Message-ID":"","Date":"Tue, 12 Sep 2017 14:42:02 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20170912123554.7388-1-christian.storm@siemens.com>","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Language":"de-DE","X-Original-Sender":"sbabic@denx.de","X-Original-Authentication-Results":"gmr-mx.google.com; spf=neutral\n\t(google.com: 2001:a60:0:28:0:1:25:1 is neither permitted nor denied\n\tby best\n\tguess record for domain of sbabic@denx.de)\n\tsmtp.mailfrom=sbabic@denx.de","Precedence":"list","Mailing-list":"list swupdate@googlegroups.com;\n\tcontact swupdate+owners@googlegroups.com","List-ID":"","X-Spam-Checked-In-Group":"swupdate@googlegroups.com","X-Google-Group-Id":"605343134186","List-Post":",\n\t","List-Help":",\n\t","List-Archive":",\n\t","List-Unsubscribe":",\n\t"}}]