[{"id":1769618,"web_url":"http://patchwork.ozlabs.org/comment/1769618/","msgid":"","list_archive_url":null,"date":"2017-09-16T16:24:56","subject":"Re: [Qemu-devel] [PATCH v3 4/7] block: don't use constant 512 as\n\tsector size in crypto driver","submitter":{"id":36836,"url":"http://patchwork.ozlabs.org/api/people/36836/","name":"Max Reitz","email":"mreitz@redhat.com"},"content":"On 2017-09-12 13:28, Daniel P. Berrange wrote:\n> Use the qcrypto_block_get_sector_size() value in the block\n> crypto driver instead of hardcoding 512 as the sector size.\n> \n> Signed-off-by: Daniel P. Berrange \n> ---\n> block/crypto.c | 34 ++++++++++++++++++----------------\n> 1 file changed, 18 insertions(+), 16 deletions(-)\n> \n> diff --git a/block/crypto.c b/block/crypto.c\n> index d68cbac2ac..49d6d4c058 100644\n> --- a/block/crypto.c\n> +++ b/block/crypto.c\n> @@ -392,8 +392,9 @@ block_crypto_co_readv(BlockDriverState *bs, int64_t sector_num,\n> uint8_t *cipher_data = NULL;\n> QEMUIOVector hd_qiov;\n> int ret = 0;\n> + uint64_t sector_size = qcrypto_block_get_sector_size(crypto->block);\n> uint64_t payload_offset =\n> - qcrypto_block_get_payload_offset(crypto->block) / 512;\n> + qcrypto_block_get_payload_offset(crypto->block) / sector_size;\n> assert(payload_offset < (INT64_MAX / 512));\n> \n> qemu_iovec_init(&hd_qiov, qiov->niov);\n> @@ -401,9 +402,9 @@ block_crypto_co_readv(BlockDriverState *bs, int64_t sector_num,\n> /* Bounce buffer because we don't wish to expose cipher text\n> * in qiov which points to guest memory.\n> */\n> - cipher_data =\n> - qemu_try_blockalign(bs->file->bs, MIN(BLOCK_CRYPTO_MAX_SECTORS * 512,\n> - qiov->size));\n> + cipher_data = qemu_try_blockalign(\n> + bs->file->bs, MIN(BLOCK_CRYPTO_MAX_SECTORS * sector_size,\n> + qiov->size));\n> if (cipher_data == NULL) {\n> ret = -ENOMEM;\n> goto cleanup;\n> @@ -417,7 +418,7 @@ block_crypto_co_readv(BlockDriverState *bs, int64_t sector_num,\n> }\n> \n> qemu_iovec_reset(&hd_qiov);\n> - qemu_iovec_add(&hd_qiov, cipher_data, cur_nr_sectors * 512);\n> + qemu_iovec_add(&hd_qiov, cipher_data, cur_nr_sectors * sector_size);\n\ncur_nr_sectors is based on remaining_sectors; which in turn is a\nparameter to this function and comes from the block layer. Therefore\nits unit is BDRV_SECTOR_SIZE and not the crypto driver's sector size.\n\nSame in the hunk below, and in block_crypto_co_writev().\n\n> \n> ret = bdrv_co_readv(bs->file,\n> payload_offset + sector_num,\n\nSame thing here, albeit in a different variation: The unit of this\nparameter of bdrv_co_readv() (start sector index) is a block layer\nsector, whose size is always BDRV_SECTOR_SIZE.\n\nTherefore you cannot divide the result from\nqcrypto_block_get_payload_offset() by the crypto driver's sector size\nand then use it as a sector index here.\n\nSame in block_crypto_co_writev().\n\n\nI assume that you fix this in the next patch, but for now it's just wrong.\n\nMax","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=mreitz@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xvd0t2SR6z9t16\n\tfor ;\n\tSun, 17 Sep 2017 02:25:32 +1000 (AEST)","from localhost ([::1]:57920 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dtFuL-0002vl-OG\n\tfor incoming@patchwork.ozlabs.org; Sat, 16 Sep 2017 12:25:29 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:47933)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dtFty-0002t4-Em\n\tfor qemu-devel@nongnu.org; Sat, 16 Sep 2017 12:25:07 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dtFtx-0005jw-CE\n\tfor qemu-devel@nongnu.org; Sat, 16 Sep 2017 12:25:06 -0400","from mx1.redhat.com ([209.132.183.28]:43608)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dtFts-0005gH-OU; Sat, 16 Sep 2017 12:25:00 -0400","from smtp.corp.redhat.com\n\t(int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 7B616C049D7F;\n\tSat, 16 Sep 2017 16:24:59 +0000 (UTC)","from dresden.str.redhat.com (ovpn-204-52.brq.redhat.com\n\t[10.40.204.52])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id B45B617D2A;\n\tSat, 16 Sep 2017 16:24:57 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 7B616C049D7F","To":"\"Daniel P. Berrange\" , qemu-devel@nongnu.org","References":"<20170912112855.24269-1-berrange@redhat.com>\n\t<20170912112855.24269-5-berrange@redhat.com>","From":"Max Reitz ","Message-ID":"","Date":"Sat, 16 Sep 2017 18:24:56 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170912112855.24269-5-berrange@redhat.com>","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\";\n\tboundary=\"FVNCHNi7jl1c9Kr1KdeImtMxPHOEG4USj\"","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.15","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.31]);\n\tSat, 16 Sep 2017 16:24:59 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","X-Content-Filtered-By":"Mailman/MimeDel 2.1.21","Subject":"Re: [Qemu-devel] [PATCH v3 4/7] block: don't use constant 512 as\n\tsector size in crypto driver","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Kevin Wolf , Stefan Hajnoczi ,\n\tqemu-block@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1770182,"web_url":"http://patchwork.ozlabs.org/comment/1770182/","msgid":"","list_archive_url":null,"date":"2017-09-18T13:57:58","subject":"Re: [Qemu-devel] [PATCH v3 4/7] block: don't use constant 512 as\n\tsector size in crypto driver","submitter":{"id":6591,"url":"http://patchwork.ozlabs.org/api/people/6591/","name":"Eric Blake","email":"eblake@redhat.com"},"content":"On 09/12/2017 06:28 AM, Daniel P. Berrange wrote:\n> Use the qcrypto_block_get_sector_size() value in the block\n> crypto driver instead of hardcoding 512 as the sector size.\n> \n> Signed-off-by: Daniel P. Berrange \n> ---\n> block/crypto.c | 34 ++++++++++++++++++----------------\n> 1 file changed, 18 insertions(+), 16 deletions(-)\n> \n> diff --git a/block/crypto.c b/block/crypto.c\n> index d68cbac2ac..49d6d4c058 100644\n> --- a/block/crypto.c\n> +++ b/block/crypto.c\n> @@ -392,8 +392,9 @@ block_crypto_co_readv(BlockDriverState *bs, int64_t sector_num,\n> uint8_t *cipher_data = NULL;\n> QEMUIOVector hd_qiov;\n> int ret = 0;\n> + uint64_t sector_size = qcrypto_block_get_sector_size(crypto->block);\n> uint64_t payload_offset =\n> - qcrypto_block_get_payload_offset(crypto->block) / 512;\n> + qcrypto_block_get_payload_offset(crypto->block) / sector_size;\n> assert(payload_offset < (INT64_MAX / 512));\n\nIn addition to Max's comments, should the assert be dividing by\nsector_size instead of 512?","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=eblake@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xwnfT23qVz9s7G\n\tfor ;\n\tMon, 18 Sep 2017 23:58:41 +1000 (AEST)","from localhost ([::1]:36768 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dtwZL-0000VW-E8\n\tfor incoming@patchwork.ozlabs.org; Mon, 18 Sep 2017 09:58:39 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:37551)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dtwYq-0000UM-Av\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 09:58:09 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dtwYp-0000SW-D8\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 09:58:08 -0400","from mx1.redhat.com ([209.132.183.28]:58258)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dtwYk-0000Pa-79; Mon, 18 Sep 2017 09:58:02 -0400","from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 2B54781DFE;\n\tMon, 18 Sep 2017 13:58:01 +0000 (UTC)","from [10.10.124.97] (ovpn-124-97.rdu2.redhat.com [10.10.124.97])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 7F56D5C541;\n\tMon, 18 Sep 2017 13:57:59 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 2B54781DFE","To":"\"Daniel P. Berrange\" , qemu-devel@nongnu.org","References":"<20170912112855.24269-1-berrange@redhat.com>\n\t<20170912112855.24269-5-berrange@redhat.com>","From":"Eric Blake ","Openpgp":"url=http://people.redhat.com/eblake/eblake.gpg","Organization":"Red Hat, Inc.","Message-ID":"","Date":"Mon, 18 Sep 2017 08:57:58 -0500","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170912112855.24269-5-berrange@redhat.com>","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\";\n\tboundary=\"f8JBC7WXu5penNlGFCjbuGOXcdkVVdnXS\"","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.16","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.25]);\n\tMon, 18 Sep 2017 13:58:01 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","X-Content-Filtered-By":"Mailman/MimeDel 2.1.21","Subject":"Re: [Qemu-devel] [PATCH v3 4/7] block: don't use constant 512 as\n\tsector size in crypto driver","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Kevin Wolf , Stefan Hajnoczi ,\n\tqemu-block@nongnu.org, Max Reitz ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1770230,"web_url":"http://patchwork.ozlabs.org/comment/1770230/","msgid":"<20170918150213.GJ2951@redhat.com>","list_archive_url":null,"date":"2017-09-18T15:02:13","subject":"Re: [Qemu-devel] [PATCH v3 4/7] block: don't use constant 512 as\n\tsector size in crypto driver","submitter":{"id":2694,"url":"http://patchwork.ozlabs.org/api/people/2694/","name":"Daniel P. Berrange","email":"berrange@redhat.com"},"content":"On Sat, Sep 16, 2017 at 06:24:56PM +0200, Max Reitz wrote:\n> On 2017-09-12 13:28, Daniel P. Berrange wrote:\n> > Use the qcrypto_block_get_sector_size() value in the block\n> > crypto driver instead of hardcoding 512 as the sector size.\n> > \n> > Signed-off-by: Daniel P. Berrange \n> > ---\n> > block/crypto.c | 34 ++++++++++++++++++----------------\n> > 1 file changed, 18 insertions(+), 16 deletions(-)\n> > \n> > diff --git a/block/crypto.c b/block/crypto.c\n> > index d68cbac2ac..49d6d4c058 100644\n> > --- a/block/crypto.c\n> > +++ b/block/crypto.c\n> > @@ -392,8 +392,9 @@ block_crypto_co_readv(BlockDriverState *bs, int64_t sector_num,\n> > uint8_t *cipher_data = NULL;\n> > QEMUIOVector hd_qiov;\n> > int ret = 0;\n> > + uint64_t sector_size = qcrypto_block_get_sector_size(crypto->block);\n> > uint64_t payload_offset =\n> > - qcrypto_block_get_payload_offset(crypto->block) / 512;\n> > + qcrypto_block_get_payload_offset(crypto->block) / sector_size;\n> > assert(payload_offset < (INT64_MAX / 512));\n> > \n> > qemu_iovec_init(&hd_qiov, qiov->niov);\n> > @@ -401,9 +402,9 @@ block_crypto_co_readv(BlockDriverState *bs, int64_t sector_num,\n> > /* Bounce buffer because we don't wish to expose cipher text\n> > * in qiov which points to guest memory.\n> > */\n> > - cipher_data =\n> > - qemu_try_blockalign(bs->file->bs, MIN(BLOCK_CRYPTO_MAX_SECTORS * 512,\n> > - qiov->size));\n> > + cipher_data = qemu_try_blockalign(\n> > + bs->file->bs, MIN(BLOCK_CRYPTO_MAX_SECTORS * sector_size,\n> > + qiov->size));\n> > if (cipher_data == NULL) {\n> > ret = -ENOMEM;\n> > goto cleanup;\n> > @@ -417,7 +418,7 @@ block_crypto_co_readv(BlockDriverState *bs, int64_t sector_num,\n> > }\n> > \n> > qemu_iovec_reset(&hd_qiov);\n> > - qemu_iovec_add(&hd_qiov, cipher_data, cur_nr_sectors * 512);\n> > + qemu_iovec_add(&hd_qiov, cipher_data, cur_nr_sectors * sector_size);\n> \n> cur_nr_sectors is based on remaining_sectors; which in turn is a\n> parameter to this function and comes from the block layer. Therefore\n> its unit is BDRV_SECTOR_SIZE and not the crypto driver's sector size.\n> \n> Same in the hunk below, and in block_crypto_co_writev().\n> \n> > \n> > ret = bdrv_co_readv(bs->file,\n> > payload_offset + sector_num,\n> \n> Same thing here, albeit in a different variation: The unit of this\n> parameter of bdrv_co_readv() (start sector index) is a block layer\n> sector, whose size is always BDRV_SECTOR_SIZE.\n> \n> Therefore you cannot divide the result from\n> qcrypto_block_get_payload_offset() by the crypto driver's sector size\n> and then use it as a sector index here.\n> \n> Same in block_crypto_co_writev().\n> \n> \n> I assume that you fix this in the next patch, but for now it's just wrong.\n\nYeah, in retrospect I should have kept this patch using BDRV_SECTOR_SIZE\nthroughout as previous versions had it, so I'm going to go back to doing\nthat. Only use the encryption sector size in a later patch where we have\nalready switched to doing byte based I/O.\n\n\nRegards,\nDaniel","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx03.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx03.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=berrange@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xwq510CM5z9s4s\n\tfor ;\n\tTue, 19 Sep 2017 01:03:17 +1000 (AEST)","from localhost ([::1]:37136 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dtxZr-0002re-5S\n\tfor incoming@patchwork.ozlabs.org; Mon, 18 Sep 2017 11:03:15 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:37600)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dtxZE-0002oZ-9B\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 11:02:44 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dtxZ4-0002R5-N7\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 11:02:36 -0400","from mx1.redhat.com ([209.132.183.28]:5807)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dtxZ1-0002Q2-EA; Mon, 18 Sep 2017 11:02:23 -0400","from smtp.corp.redhat.com\n\t(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 6A4CE7E438;\n\tMon, 18 Sep 2017 15:02:22 +0000 (UTC)","from redhat.com (unknown [10.42.22.189])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id CF7A961B87;\n\tMon, 18 Sep 2017 15:02:16 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 6A4CE7E438","Date":"Mon, 18 Sep 2017 16:02:13 +0100","From":"\"Daniel P. Berrange\" ","To":"Max Reitz ","Message-ID":"<20170918150213.GJ2951@redhat.com>","References":"<20170912112855.24269-1-berrange@redhat.com>\n\t<20170912112855.24269-5-berrange@redhat.com>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"","User-Agent":"Mutt/1.8.3 (2017-05-23)","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.14","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.27]);\n\tMon, 18 Sep 2017 15:02:22 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v3 4/7] block: don't use constant 512 as\n\tsector size in crypto driver","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"\"Daniel P. Berrange\" ","Cc":"Kevin Wolf , Stefan Hajnoczi ,\n\tqemu-devel@nongnu.org, qemu-block@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]