[{"id":1769620,"web_url":"http://patchwork.ozlabs.org/comment/1769620/","msgid":"<685c90b5-458b-bee5-b543-f748d114873c@redhat.com>","list_archive_url":null,"date":"2017-09-16T16:25:32","subject":"Re: [Qemu-devel] [PATCH v3 2/7] crypto: expose encryption sector\n\tsize in APIs","submitter":{"id":36836,"url":"http://patchwork.ozlabs.org/api/people/36836/","name":"Max Reitz","email":"mreitz@redhat.com"},"content":"On 2017-09-12 13:28, Daniel P. Berrange wrote:\n> While current encryption schemes all have a fixed sector size of\n> 512 bytes, this is not guaranteed to be the case in future. Expose\n> the sector size in the APIs so the block layer can remove assumptions\n> about fixed 512 byte sectors.\n> \n> Signed-off-by: Daniel P. Berrange \n> ---\n> crypto/block-luks.c | 6 ++++--\n> crypto/block-qcow.c | 1 +\n> crypto/block.c | 6 ++++++\n> crypto/blockpriv.h | 1 +\n> include/crypto/block.h | 15 +++++++++++++++\n> 5 files changed, 27 insertions(+), 2 deletions(-)\n\nReviewed-by: Max Reitz ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=mreitz@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xvd2163Glz9s7c\n\tfor ;\n\tSun, 17 Sep 2017 02:26:33 +1000 (AEST)","from localhost ([::1]:57923 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dtFvL-0003JS-Sq\n\tfor incoming@patchwork.ozlabs.org; Sat, 16 Sep 2017 12:26:31 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:48104)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dtFua-0003Ho-25\n\tfor qemu-devel@nongnu.org; Sat, 16 Sep 2017 12:25:44 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dtFuZ-0006CH-BK\n\tfor qemu-devel@nongnu.org; Sat, 16 Sep 2017 12:25:44 -0400","from mx1.redhat.com ([209.132.183.28]:34544)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dtFuS-0006AG-Sq; Sat, 16 Sep 2017 12:25:37 -0400","from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id EC3418763A;\n\tSat, 16 Sep 2017 16:25:35 +0000 (UTC)","from dresden.str.redhat.com (ovpn-204-52.brq.redhat.com\n\t[10.40.204.52])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 76D4C17CDF;\n\tSat, 16 Sep 2017 16:25:34 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com EC3418763A","To":"\"Daniel P. Berrange\" , qemu-devel@nongnu.org","References":"<20170912112855.24269-1-berrange@redhat.com>\n\t<20170912112855.24269-3-berrange@redhat.com>","From":"Max Reitz ","Message-ID":"<685c90b5-458b-bee5-b543-f748d114873c@redhat.com>","Date":"Sat, 16 Sep 2017 18:25:32 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170912112855.24269-3-berrange@redhat.com>","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\";\n\tboundary=\"m1t5GjRdiBKdmUl8Q380SUW4FkvIII6wX\"","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.13","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.26]);\n\tSat, 16 Sep 2017 16:25:36 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","X-Content-Filtered-By":"Mailman/MimeDel 2.1.21","Subject":"Re: [Qemu-devel] [PATCH v3 2/7] crypto: expose encryption sector\n\tsize in APIs","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Kevin Wolf , Stefan Hajnoczi ,\n\tqemu-block@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1770176,"web_url":"http://patchwork.ozlabs.org/comment/1770176/","msgid":"","list_archive_url":null,"date":"2017-09-18T13:53:22","subject":"Re: [Qemu-devel] [PATCH v3 2/7] crypto: expose encryption sector\n\tsize in APIs","submitter":{"id":6591,"url":"http://patchwork.ozlabs.org/api/people/6591/","name":"Eric Blake","email":"eblake@redhat.com"},"content":"On 09/12/2017 06:28 AM, Daniel P. Berrange wrote:\n> While current encryption schemes all have a fixed sector size of\n> 512 bytes, this is not guaranteed to be the case in future. Expose\n> the sector size in the APIs so the block layer can remove assumptions\n> about fixed 512 byte sectors.\n> \n> Signed-off-by: Daniel P. Berrange \n> ---\n> crypto/block-luks.c | 6 ++++--\n> crypto/block-qcow.c | 1 +\n> crypto/block.c | 6 ++++++\n> crypto/blockpriv.h | 1 +\n> include/crypto/block.h | 15 +++++++++++++++\n> 5 files changed, 27 insertions(+), 2 deletions(-)\n> \n\nReviewed-by: Eric Blake ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=eblake@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xwnY41Lhgz9s7G\n\tfor ;\n\tMon, 18 Sep 2017 23:53:59 +1000 (AEST)","from localhost ([::1]:36741 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dtwUm-00065k-Am\n\tfor incoming@patchwork.ozlabs.org; Mon, 18 Sep 2017 09:53:56 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:35154)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dtwUO-00064K-QH\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 09:53:33 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dtwUN-00066I-TQ\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 09:53:32 -0400","from mx1.redhat.com ([209.132.183.28]:42906)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dtwUI-00063t-Dl; Mon, 18 Sep 2017 09:53:26 -0400","from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 3F12281E07;\n\tMon, 18 Sep 2017 13:53:25 +0000 (UTC)","from [10.10.124.97] (ovpn-124-97.rdu2.redhat.com [10.10.124.97])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 7EA2C60BEC;\n\tMon, 18 Sep 2017 13:53:23 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 3F12281E07","To":"\"Daniel P. Berrange\" , qemu-devel@nongnu.org","References":"<20170912112855.24269-1-berrange@redhat.com>\n\t<20170912112855.24269-3-berrange@redhat.com>","From":"Eric Blake ","Openpgp":"url=http://people.redhat.com/eblake/eblake.gpg","Organization":"Red Hat, Inc.","Message-ID":"","Date":"Mon, 18 Sep 2017 08:53:22 -0500","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170912112855.24269-3-berrange@redhat.com>","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\";\n\tboundary=\"2l6R1E36J9g5oFiKofbgahIorHTwR8Fpl\"","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.12","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.25]);\n\tMon, 18 Sep 2017 13:53:25 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","X-Content-Filtered-By":"Mailman/MimeDel 2.1.21","Subject":"Re: [Qemu-devel] [PATCH v3 2/7] crypto: expose encryption sector\n\tsize in APIs","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Kevin Wolf , Stefan Hajnoczi ,\n\tqemu-block@nongnu.org, Max Reitz ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]