[{"id":1769621,"web_url":"http://patchwork.ozlabs.org/comment/1769621/","msgid":"","list_archive_url":null,"date":"2017-09-16T16:25:45","subject":"Re: [Qemu-devel] [PATCH v3 3/7] block: fix data type casting for\n\tcrypto payload offset","submitter":{"id":36836,"url":"http://patchwork.ozlabs.org/api/people/36836/","name":"Max Reitz","email":"mreitz@redhat.com"},"content":"On 2017-09-12 13:28, Daniel P. Berrange wrote:\n> The crypto APIs report the offset of the data payload as an uint64_t\n> type, but the block driver is casting to size_t or ssize_t which will\n> potentially truncate.\n> \n> Most of the block APIs use int64_t for offsets meanwhile, so even if\n> using uint64_t in the crypto block driver we are still at risk of\n> truncation.\n> \n> Change the block crypto driver to use uint64_t, but add asserts that\n> the value is less than INT64_MAX.\n> \n> Signed-off-by: Daniel P. Berrange \n> ---\n> block/crypto.c | 13 +++++++++----\n> 1 file changed, 9 insertions(+), 4 deletions(-)\n\nReviewed-by: Max Reitz ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=mreitz@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xvd2J6Qzlz9s7c\n\tfor ;\n\tSun, 17 Sep 2017 02:26:48 +1000 (AEST)","from localhost ([::1]:57924 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dtFva-0003UB-Sb\n\tfor incoming@patchwork.ozlabs.org; Sat, 16 Sep 2017 12:26:46 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:48157)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dtFul-0003Rt-DZ\n\tfor qemu-devel@nongnu.org; Sat, 16 Sep 2017 12:25:56 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dtFuk-0006G8-Jo\n\tfor qemu-devel@nongnu.org; Sat, 16 Sep 2017 12:25:55 -0400","from mx1.redhat.com ([209.132.183.28]:34648)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dtFug-0006ER-36; Sat, 16 Sep 2017 12:25:50 -0400","from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 2B08F87649;\n\tSat, 16 Sep 2017 16:25:49 +0000 (UTC)","from dresden.str.redhat.com (ovpn-204-52.brq.redhat.com\n\t[10.40.204.52])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 8B39A5C697;\n\tSat, 16 Sep 2017 16:25:47 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 2B08F87649","To":"\"Daniel P. Berrange\" , qemu-devel@nongnu.org","References":"<20170912112855.24269-1-berrange@redhat.com>\n\t<20170912112855.24269-4-berrange@redhat.com>","From":"Max Reitz ","Message-ID":"","Date":"Sat, 16 Sep 2017 18:25:45 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170912112855.24269-4-berrange@redhat.com>","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\";\n\tboundary=\"hb7FVAnKIpPdKGH0XJQUCplslx6o4fD9B\"","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.13","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.26]);\n\tSat, 16 Sep 2017 16:25:49 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","X-Content-Filtered-By":"Mailman/MimeDel 2.1.21","Subject":"Re: [Qemu-devel] [PATCH v3 3/7] block: fix data type casting for\n\tcrypto payload offset","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Kevin Wolf , Stefan Hajnoczi ,\n\tqemu-block@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1770180,"web_url":"http://patchwork.ozlabs.org/comment/1770180/","msgid":"","list_archive_url":null,"date":"2017-09-18T13:56:04","subject":"Re: [Qemu-devel] [PATCH v3 3/7] block: fix data type casting for\n\tcrypto payload offset","submitter":{"id":6591,"url":"http://patchwork.ozlabs.org/api/people/6591/","name":"Eric Blake","email":"eblake@redhat.com"},"content":"On 09/12/2017 06:28 AM, Daniel P. Berrange wrote:\n> The crypto APIs report the offset of the data payload as an uint64_t\n> type, but the block driver is casting to size_t or ssize_t which will\n> potentially truncate.\n> \n> Most of the block APIs use int64_t for offsets meanwhile, so even if\n> using uint64_t in the crypto block driver we are still at risk of\n> truncation.\n> \n> Change the block crypto driver to use uint64_t, but add asserts that\n> the value is less than INT64_MAX.\n> \n> Signed-off-by: Daniel P. Berrange \n> ---\n> block/crypto.c | 13 +++++++++----\n> 1 file changed, 9 insertions(+), 4 deletions(-)\n> \n\nReviewed-by: Eric Blake ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=eblake@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xwncY2RYTz9s7G\n\tfor ;\n\tMon, 18 Sep 2017 23:57:01 +1000 (AEST)","from localhost ([::1]:36760 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dtwXj-0007wK-GX\n\tfor incoming@patchwork.ozlabs.org; Mon, 18 Sep 2017 09:56:59 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:36446)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dtwWy-0007f7-UV\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 09:56:16 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dtwWy-0007Q9-3o\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 09:56:13 -0400","from mx1.redhat.com ([209.132.183.28]:52468)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dtwWs-0007Me-NF; Mon, 18 Sep 2017 09:56:06 -0400","from smtp.corp.redhat.com\n\t(int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id A711181DFC;\n\tMon, 18 Sep 2017 13:56:05 +0000 (UTC)","from [10.10.124.97] (ovpn-124-97.rdu2.redhat.com [10.10.124.97])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id BB2655D6A9;\n\tMon, 18 Sep 2017 13:56:04 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com A711181DFC","To":"\"Daniel P. Berrange\" , qemu-devel@nongnu.org","References":"<20170912112855.24269-1-berrange@redhat.com>\n\t<20170912112855.24269-4-berrange@redhat.com>","From":"Eric Blake ","Openpgp":"url=http://people.redhat.com/eblake/eblake.gpg","Organization":"Red Hat, Inc.","Message-ID":"","Date":"Mon, 18 Sep 2017 08:56:04 -0500","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170912112855.24269-4-berrange@redhat.com>","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\";\n\tboundary=\"Fsr8MKO3E7AQ7dUNHpADdSTIha30CwaJQ\"","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.15","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.25]);\n\tMon, 18 Sep 2017 13:56:05 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","X-Content-Filtered-By":"Mailman/MimeDel 2.1.21","Subject":"Re: [Qemu-devel] [PATCH v3 3/7] block: fix data type casting for\n\tcrypto payload offset","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Kevin Wolf , Stefan Hajnoczi ,\n\tqemu-block@nongnu.org, Max Reitz ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]