[{"id":1767045,"web_url":"http://patchwork.ozlabs.org/comment/1767045/","msgid":"","list_archive_url":null,"date":"2017-09-12T13:33:35","subject":"Re: [PATCH] pinctrl: uniphier: make arrays static, reduces object\n\tcode size","submitter":{"id":65882,"url":"http://patchwork.ozlabs.org/api/people/65882/","name":"Masahiro Yamada","email":"yamada.masahiro@socionext.com"},"content":"2017-09-12 20:21 GMT+09:00 Colin King :\n> From: Colin Ian King \n>\n> Don't populate const arrays on the stack, instead make them\n> static. Makes the object code smaller nearly 1000 bytes. Also\n> line break wide lines to avoid checkpatch warnings.\n>\n> Before:\n> text data bss dec hex filename\n> 13112 1996 0 15108 3b04 pinctrl-uniphier-core.o\n>\n> After:\n> text data bss dec hex filename\n> 11642 2476 0 14118 3726 pinctrl-uniphier-core.o\n>\n> Signed-off-by: Colin Ian King \n\n\nAcked-by: Masahiro Yamada \n\n\nThanks!","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-gpio-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=nifty.com header.i=@nifty.com\n\theader.b=\"pY/YSeAP\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xs5PT73Smz9s5L\n\tfor ;\n\tTue, 12 Sep 2017 23:34:37 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751326AbdILNeg (ORCPT );\n\tTue, 12 Sep 2017 09:34:36 -0400","from conssluserg-03.nifty.com ([210.131.2.82]:41876 \"EHLO\n\tconssluserg-03.nifty.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751313AbdILNef (ORCPT\n\t); Tue, 12 Sep 2017 09:34:35 -0400","from mail-yw0-f178.google.com (mail-yw0-f178.google.com\n\t[209.85.161.178]) (authenticated)\n\tby conssluserg-03.nifty.com with ESMTP id v8CDYH6v002972;\n\tTue, 12 Sep 2017 22:34:17 +0900","by mail-yw0-f178.google.com with SMTP id s62so28244445ywg.0;\n\tTue, 12 Sep 2017 06:34:17 -0700 (PDT)","by 10.37.164.225 with HTTP; Tue, 12 Sep 2017 06:33:35 -0700 (PDT)"],"DKIM-Filter":"OpenDKIM Filter v2.10.3 conssluserg-03.nifty.com v8CDYH6v002972","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com;\n\ts=dec2015msa; t=1505223257;\n\tbh=zvxCCTc74YMKzHL/CNDqDeKLE08TrWB9RL2jAAlyjVY=;\n\th=In-Reply-To:References:From:Date:Subject:To:Cc:From;\n\tb=pY/YSeAPrAhSFW7FX5VHs8Feu8ajyP2/d8woSJwQ4Gcg1U7zPr9eR10TaOS7pW3Bd\n\tYoQ74uvg8dhp8C4ucWr3g8LHhnbYuv5vhCBSaV/nNb82ETrgcimFWTCamWUvOXkpKE\n\tUZ49eWsLXujCc/y8dAdqwtkaCfFAVr5ZFB8yWNlUcJftFPKhb8/M5qNqKveSYJnjMu\n\tUScG/QhA6j0CT3dctQmFuqf6ZjIPqK9zYtl12oXKW4KUNIhIBWGoRzsx3Rt+INb10M\n\t6Nuzu1AAdNPOTRI8Vq0sXV/Byr3DAeFkdUXJc3i/0ZHJvDJbgBzvsQNhsJFCMMPEo4\n\ts2tb83uvVCCQw==","X-Nifty-SrcIP":"[209.85.161.178]","X-Gm-Message-State":"AHPjjUhaQK4YMo9XoI3HsXOXVK92YZkRDAUQml+mLR6QUO+BaymgFzrJ\n\tjavdasAcUQKqPvQ68H86WBb+exq3TA==","X-Google-Smtp-Source":"ADKCNb4U9wXbYIvqowAob0GMzev7Pmw4oGYZ5zCxLYLz5g/NkukWF1tvb6agZj2ZxoEuNK62MI/i71qe8iccaxewxnM=","X-Received":"by 10.129.121.4 with SMTP id u4mr13402870ywc.71.1505223256229;\n\tTue, 12 Sep 2017 06:34:16 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170912112124.1143-1-colin.king@canonical.com>","References":"<20170912112124.1143-1-colin.king@canonical.com>","From":"Masahiro Yamada ","Date":"Tue, 12 Sep 2017 22:33:35 +0900","X-Gmail-Original-Message-ID":"","Message-ID":"","Subject":"Re: [PATCH] pinctrl: uniphier: make arrays static, reduces object\n\tcode size","To":"Colin King ","Cc":"Linus Walleij , linux-gpio@vger.kernel.org,\n\tlinux-arm-kernel ,\n\tkernel-janitors@vger.kernel.org,\n\tLinux Kernel Mailing List ","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"linux-gpio-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-gpio@vger.kernel.org"}},{"id":1767113,"web_url":"http://patchwork.ozlabs.org/comment/1767113/","msgid":"","list_archive_url":null,"date":"2017-09-12T14:19:30","subject":"Re: [PATCH] pinctrl: uniphier: make arrays static, reduces object\n\tcode size","submitter":{"id":7055,"url":"http://patchwork.ozlabs.org/api/people/7055/","name":"Linus Walleij","email":"linus.walleij@linaro.org"},"content":"On Tue, Sep 12, 2017 at 1:21 PM, Colin King wrote:\n\n> From: Colin Ian King \n>\n> Don't populate const arrays on the stack, instead make them\n> static. Makes the object code smaller nearly 1000 bytes. Also\n> line break wide lines to avoid checkpatch warnings.\n>\n> Before:\n> text data bss dec hex filename\n> 13112 1996 0 15108 3b04 pinctrl-uniphier-core.o\n>\n> After:\n> text data bss dec hex filename\n> 11642 2476 0 14118 3726 pinctrl-uniphier-core.o\n>\n> Signed-off-by: Colin Ian King \n\nPatch applied with Masahiro's ACK.\n\nYours,\nLinus Walleij\n--\nTo unsubscribe from this list: send the line \"unsubscribe linux-gpio\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-gpio-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"ECzjQo8b\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xs6PL1QSZz9s0Z\n\tfor ;\n\tWed, 13 Sep 2017 00:19:34 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751420AbdILOTc (ORCPT );\n\tTue, 12 Sep 2017 10:19:32 -0400","from mail-io0-f180.google.com ([209.85.223.180]:33060 \"EHLO\n\tmail-io0-f180.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751337AbdILOTb (ORCPT\n\t); Tue, 12 Sep 2017 10:19:31 -0400","by mail-io0-f180.google.com with SMTP id k101so5886071iod.0\n\tfor ;\n\tTue, 12 Sep 2017 07:19:31 -0700 (PDT)","by 10.79.164.78 with HTTP; Tue, 12 Sep 2017 07:19:30 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=VTGRGqN97aycD7+gXF+2UR/411vu4WL4eOg/FpH0i7A=;\n\tb=ECzjQo8bh8F5S3uH3OKaxIy/GT5IdNsHlXo+g1Njn7nGUVvzOZBBGbrAyXKKqEb5zM\n\twQPaKU8njUGt6CefQFHFclJenSgqLWGT23nPczI8pQhGlXhykLNZeTx5Rr0H+qs1NTsG\n\tA16U+uUXf/d8BtWcajQPDrQEvn4poERAqKZz4=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=VTGRGqN97aycD7+gXF+2UR/411vu4WL4eOg/FpH0i7A=;\n\tb=MOUBayBgZs8DMxPINb05mIT6V+I200Rc9+JA8Qc5qUfRQqvbAl3TmjWRx/Tb3veV4U\n\tCqUTKQ9nlbbfOQYshBBUQNaoXe7gQitVT9nDUlgZWWVSVI2iMXFW8aEXJTfPosx0Gfia\n\trAkgfIgPn0VYlUuIBEnNvv1L2HelvPlG71ErTD7D2kTZJX1IrHN32mUjmWCHhAy5wPTz\n\t2m93JRBOzF+7z2kPcQIAn8H7D8b05MQPP0ZojvOg+xP1WUc/nRO1yi3C3e9wMs8ZZEar\n\t2gN7n2bRh5p8Zg1xZx+oTTfTtfP+Pmi+qwwTmFVvyxZpAtWPMEfNegkO6YP2WYceaxnd\n\tw5Vw==","X-Gm-Message-State":"AHPjjUhZjklUbgKYha2vuf1KGAy1LsxW3pPzad+83ErLGXSdDwj995Lg\n\tFCg1sSzJFUa/1Bb/ljhNcTBR0H2FnykF","X-Google-Smtp-Source":"AOwi7QDJGFFF4XRTjOXSdpakUNk3FNTrfuWm5l1T+qu9Wf1IfP9Ljh2E+eKxr6T3nUIKScbv4zx7/Z9fusYFP3VRosU=","X-Received":"by 10.107.156.21 with SMTP id f21mr22902118ioe.226.1505225971169;\n\tTue, 12 Sep 2017 07:19:31 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170912112124.1143-1-colin.king@canonical.com>","References":"<20170912112124.1143-1-colin.king@canonical.com>","From":"Linus Walleij ","Date":"Tue, 12 Sep 2017 16:19:30 +0200","Message-ID":"","Subject":"Re: [PATCH] pinctrl: uniphier: make arrays static, reduces object\n\tcode size","To":"Colin King ","Cc":"Masahiro Yamada ,\n\t\"linux-gpio@vger.kernel.org\" ,\n\t\"linux-arm-kernel@lists.infradead.org\" \n\t, kernel-janitors@vger.kernel.org,\n\t\"linux-kernel@vger.kernel.org\" ","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"linux-gpio-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-gpio@vger.kernel.org"}}]