[{"id":1767699,"web_url":"http://patchwork.ozlabs.org/comment/1767699/","msgid":"","list_archive_url":null,"date":"2017-09-13T09:15:53","subject":"RE: [PATCH] qed: remove unnecessary call to memset","submitter":{"id":70219,"url":"http://patchwork.ozlabs.org/api/people/70219/","name":"Sudarsana Reddy Kalluru","email":"sudarsana.kalluru@cavium.com"},"content":"-----Original Message-----\nFrom: Himanshu Jha [mailto:himanshujha199640@gmail.com] \nSent: 12 September 2017 16:49\nTo: Mintz, Yuval \nCc: Elior, Ariel ; Dept-Eng Everest Linux L2 ; netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Himanshu Jha \nSubject: [PATCH] qed: remove unnecessary call to memset\n\ncall to memset to assign 0 value immediately after allocating memory with kzalloc is unnecesaary as kzalloc allocates the memory filled with 0 value.\n\nSemantic patch used to resolve this issue:\n\n@@\nexpression e,e2; constant c;\nstatement S;\n@@\n\n e = kzalloc(e2, c);\n if(e == NULL) S\n- memset(e, 0, e2);\n\nSigned-off-by: Himanshu Jha \n---\n drivers/net/ethernet/qlogic/qed/qed_dcbx.c | 1 -\n 1 file changed, 1 deletion(-)\n\ndiff --git a/drivers/net/ethernet/qlogic/qed/qed_dcbx.c b/drivers/net/ethernet/qlogic/qed/qed_dcbx.c\nindex eaca457..8f6ccc0 100644\n--- a/drivers/net/ethernet/qlogic/qed/qed_dcbx.c\n+++ b/drivers/net/ethernet/qlogic/qed/qed_dcbx.c\n@@ -1244,7 +1244,6 @@ int qed_dcbx_get_config_params(struct qed_hwfn *p_hwfn,\n \tif (!dcbx_info)\n \t\treturn -ENOMEM;\n \n-\tmemset(dcbx_info, 0, sizeof(*dcbx_info));\n \trc = qed_dcbx_query_params(p_hwfn, dcbx_info, QED_DCBX_OPERATIONAL_MIB);\n \tif (rc) {\n \t\tkfree(dcbx_info);\n--\n2.7.4\n\nAcked-by: Sudarsana Kalluru ","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=CAVIUMNETWORKS.onmicrosoft.com\n\theader.i=@CAVIUMNETWORKS.onmicrosoft.com header.b=\"GFWDx7iu\"; \n\tdkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=Sudarsana.Kalluru@cavium.com; "],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xsbd63CyYz9sNr\n\tfor ;\n\tWed, 13 Sep 2017 19:16:26 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752053AbdIMJP7 (ORCPT );\n\tWed, 13 Sep 2017 05:15:59 -0400","from mail-sn1nam02on0081.outbound.protection.outlook.com\n\t([104.47.36.81]:32395\n\t\"EHLO NAM02-SN1-obe.outbound.protection.outlook.com\"\n\trhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP\n\tid S1751062AbdIMJPz (ORCPT );\n\tWed, 13 Sep 2017 05:15:55 -0400","from CY4PR07MB3048.namprd07.prod.outlook.com (10.172.116.141) by\n\tCY4PR07MB3093.namprd07.prod.outlook.com (10.172.115.7) with Microsoft\n\tSMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id\n\t15.20.35.12; Wed, 13 Sep 2017 09:15:53 +0000","from CY4PR07MB3048.namprd07.prod.outlook.com ([10.172.116.141]) by\n\tCY4PR07MB3048.namprd07.prod.outlook.com ([10.172.116.141]) with\n\tmapi id 15.20.0035.021; Wed, 13 Sep 2017 09:15:53 +0000"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version;\n\tbh=pg2qwgV53J5qQnbT+O0uKD5rF9hK0UpuOrAl0r4Ncjo=;\n\tb=GFWDx7iuFhNfPtkczxWZsgp+wtvGCyckX4/YtEdauofLPgDDVjPdYuYPhGLDQBcYC8jlmYKf/LE3Sy6OTSpavVCrwZNpEcgRR1b/oV1AXnczqQqsn3HUIH6jTAaWAHrGgyq6AOZOUnhocqN3Vxh+hQk29eNVnYGudeI90r9+haI=","From":"\"Kalluru, Sudarsana\" ","To":"Himanshu Jha ,\n\t\"Mintz, Yuval\" ","CC":"\"Elior, Ariel\" ,\n\tDept-Eng Everest Linux L2 ,\n\t\"netdev@vger.kernel.org\" ,\n\t\"linux-kernel@vger.kernel.org\" ","Subject":"RE: [PATCH] qed: remove unnecessary call to memset","Thread-Topic":"[PATCH] qed: remove unnecessary call to memset","Thread-Index":"AQHTK7kMfvcmlC/520yMWwGw9weCc6KyifwQ","Date":"Wed, 13 Sep 2017 09:15:53 +0000","Message-ID":"","References":"<1505215162-3917-1-git-send-email-himanshujha199640@gmail.com>","In-Reply-To":"<1505215162-3917-1-git-send-email-himanshujha199640@gmail.com>","Accept-Language":"en-IN, en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","authentication-results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=CAVIUMNETWORKS.onmicrosoft.com\n\theader.i=@CAVIUMNETWORKS.onmicrosoft.com header.b=\"GFWDx7iu\"; \n\tdkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=Sudarsana.Kalluru@cavium.com; "],"x-originating-ip":"[114.143.185.87]","x-ms-publictraffictype":"Email","x-microsoft-exchange-diagnostics":"1; CY4PR07MB3093;\n\t6:DSeUSF21kdBkgW5yFXyfC3K12WC7scrqLoD4+azRHmMzoSEYEOjk/gbkmhlQ9df5BfyJVL6E4w4WhNiGpIhnkTUddza4CfzWzHVjwEP6vEW2rdExuNyURhtU869/RxZb8WEj+aPVpOO/0r8OMkPBakudVstfNXv2rRuYiBwUi5+SztQ4CFB0mKexYbgrwGUAP6X5dM52wWeQ60kCC34Zy58whNs7HYAuOx7ncxb4iwhf6v0eGVSM4Z3IyK0I/ttWZkRqvppej+WoGTVoLOY76Lmdmn5jDFrliGTZq/Og2EEt8Jl5EffO1vY7VrIx97t1qk3AgILp4MyttLg6FtkCZw==;\n\t5:Ptpgk/wrwrcMRIHGRkU8iID+cn3AJ5uYps7KFT8gb6bNzHScRkNsXlbO0yfZvb2qS0TDk5xTZWdirkcKe1HKFynowmdMHCU5nNWWHwK7g/vT6XOr5BVynKF9kNPifnwo0iyzKDQJiY2dON6Fzkp8wQ==;\n\t24:CIDGr+jAEb6DDePz3Zlc6fGanNCcoQDkEuxjUjaVQYiBzUNENvnMVD/9VHJh3VtXbHrl0CkqT06EBDBe8rcRsQmzUmIHzJ2Q2y1ebwmtb5w=;\n\t7:tI4GvknHvbT1yA+1KoALg2ggbYjtFEnvo5QamyCjGzu3yieV+Xx3xeVo+sK7ElMmAoh01bRZz3AJKC4c6ouCmny6Z/86SzmyYXepScQMUbhdT+Ic1BXji20ZSHwu5ja0XfAsacya2OXUrIGarflP8bjhTTUEixNyffqbBG/hedFZnvvT4TBVcvKHA3eTOoSRivuxZznHa2o6b/JOkpmwkbJ+XQ4QNmjeKvHNgR0Mv9Y=","x-ms-exchange-antispam-srfa-diagnostics":"SSOS;","x-ms-office365-filtering-correlation-id":"3b544f0a-01b9-42f3-ab37-08d4fa8808b8","x-microsoft-antispam":"UriScan:; BCL:0; PCL:0;\n\tRULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);\n\tSRVR:CY4PR07MB3093; ","x-ms-traffictypediagnostic":"CY4PR07MB3093:","x-exchange-antispam-report-test":"UriScan:(9452136761055);","x-microsoft-antispam-prvs":"","x-exchange-antispam-report-cfa-test":"BCL:0; PCL:0;\n\tRULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(93006095)(93001095)(10201501046)(100000703101)(100105400095)(3002001)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123560025)(20161123564025)(20161123555025)(20161123562025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);\n\tSRVR:CY4PR07MB3093; BCL:0; PCL:0;\n\tRULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);\n\tSRVR:CY4PR07MB3093; ","x-forefront-prvs":"042957ACD7","x-forefront-antispam-report":"SFV:NSPM;\n\tSFS:(10009020)(6009001)(346002)(376002)(366002)(189002)(13464003)(199003)(6116002)(102836003)(66066001)(2906002)(106356001)(189998001)(68736007)(3280700002)(2950100002)(105586002)(97736004)(5660300001)(6636002)(76176999)(4326008)(74316002)(7696004)(86362001)(3846002)(72206003)(478600001)(316002)(25786009)(7736002)(14454004)(3660700001)(50986999)(55016002)(2900100001)(77096006)(9686003)(305945005)(53936002)(99286003)(54906002)(33656002)(39060400002)(8936002)(81156014)(6506006)(53546010)(229853002)(54356999)(81166006)(6246003)(6436002)(101416001)(8676002);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR07MB3093;\n\tH:CY4PR07MB3048.namprd07.prod.outlook.com; FPR:; SPF:None;\n\tPTR:InfoNoRecords; MX:1; A:1; LANG:en; ","received-spf":"None (protection.outlook.com: cavium.com does not designate\n\tpermitted sender hosts)","spamdiagnosticoutput":"1:99","spamdiagnosticmetadata":"NSPM","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"quoted-printable","MIME-Version":"1.0","X-OriginatorOrg":"cavium.com","X-MS-Exchange-CrossTenant-originalarrivaltime":"13 Sep 2017 09:15:53.3805\n\t(UTC)","X-MS-Exchange-CrossTenant-fromentityheader":"Hosted","X-MS-Exchange-CrossTenant-id":"711e4ccf-2e9b-4bcf-a551-4094005b6194","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"CY4PR07MB3093","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1769444,"web_url":"http://patchwork.ozlabs.org/comment/1769444/","msgid":"<20170915.140219.188567213297726189.davem@davemloft.net>","list_archive_url":null,"date":"2017-09-15T21:02:19","subject":"Re: [PATCH] qed: remove unnecessary call to memset","submitter":{"id":15,"url":"http://patchwork.ozlabs.org/api/people/15/","name":"David Miller","email":"davem@davemloft.net"},"content":"From: Himanshu Jha \nDate: Tue, 12 Sep 2017 16:49:22 +0530\n\n> call to memset to assign 0 value immediately after allocating\n> memory with kzalloc is unnecesaary as kzalloc allocates the memory\n> filled with 0 value.\n> \n> Semantic patch used to resolve this issue:\n> \n> @@\n> expression e,e2; constant c;\n> statement S;\n> @@\n> \n> e = kzalloc(e2, c);\n> if(e == NULL) S\n> - memset(e, 0, e2);\n> \n> Signed-off-by: Himanshu Jha \n\nApplied.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xv7C10hNDz9s3w\n\tfor ;\n\tSat, 16 Sep 2017 07:02:37 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751832AbdIOVCY (ORCPT );\n\tFri, 15 Sep 2017 17:02:24 -0400","from shards.monkeyblade.net ([184.105.139.130]:56692 \"EHLO\n\tshards.monkeyblade.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751556AbdIOVCX (ORCPT\n\t); Fri, 15 Sep 2017 17:02:23 -0400","from localhost (74-93-104-98-Washington.hfc.comcastbusiness.net\n\t[74.93.104.98]) (using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\t(Authenticated sender: davem-davemloft)\n\tby shards.monkeyblade.net (Postfix) with ESMTPSA id 4A04D133F640C;\n\tFri, 15 Sep 2017 14:02:22 -0700 (PDT)"],"Date":"Fri, 15 Sep 2017 14:02:19 -0700 (PDT)","Message-Id":"<20170915.140219.188567213297726189.davem@davemloft.net>","To":"himanshujha199640@gmail.com","Cc":"Yuval.Mintz@cavium.com, Ariel.Elior@cavium.com,\n\teverest-linux-l2@cavium.com, netdev@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org","Subject":"Re: [PATCH] qed: remove unnecessary call to memset","From":"David Miller ","In-Reply-To":"<1505215162-3917-1-git-send-email-himanshujha199640@gmail.com>","References":"<1505215162-3917-1-git-send-email-himanshujha199640@gmail.com>","X-Mailer":"Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO)","Mime-Version":"1.0","Content-Type":"Text/Plain; charset=us-ascii","Content-Transfer-Encoding":"7bit","X-Greylist":"Sender succeeded SMTP AUTH, not delayed by\n\tmilter-greylist-4.5.12 (shards.monkeyblade.net\n\t[149.20.54.216]); Fri, 15 Sep 2017 14:02:22 -0700 (PDT)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]