[{"id":1772999,"web_url":"http://patchwork.ozlabs.org/comment/1772999/","msgid":"<20170921171018.GE30097@localhost>","list_archive_url":null,"date":"2017-09-21T17:10:18","subject":"Re: [PATCH 1/5] dmaengine: edma: Implement protection for invalid\n\tmax_burst","submitter":{"id":8232,"url":"http://patchwork.ozlabs.org/api/people/8232/","name":"Vinod Koul","email":"vinod.koul@intel.com"},"content":"On Tue, Sep 12, 2017 at 01:44:20PM +0300, Peter Ujfalusi wrote:\n> Set the device's max_burst to 32767 (CIDX is 16bit signed value) so clients\n> can take this into consideration when setting up the trasnfer.\n\n/s/trasnfer/transfer\n\n> \n> During slave transfer preparation check if the requested maxburst is valid.\n> \n> Signed-off-by: Peter Ujfalusi \n> ---\n> drivers/dma/edma.c | 5 +++++\n> 1 file changed, 5 insertions(+)\n> \n> diff --git a/drivers/dma/edma.c b/drivers/dma/edma.c\n> index 3879f80a4815..6970355abdc9 100644\n> --- a/drivers/dma/edma.c\n> +++ b/drivers/dma/edma.c\n> @@ -891,6 +891,10 @@ static int edma_slave_config(struct dma_chan *chan,\n> \t cfg->dst_addr_width == DMA_SLAVE_BUSWIDTH_8_BYTES)\n> \t\treturn -EINVAL;\n> \n> +\tif (cfg->src_maxburst > chan->device->max_burst ||\n> +\t cfg->dst_maxburst > chan->device->max_burst)\n> +\t\treturn -EINVAL;\n> +\n> \tmemcpy(&echan->cfg, cfg, sizeof(echan->cfg));\n> \n> \treturn 0;\n> @@ -1855,6 +1859,7 @@ static void edma_dma_init(struct edma_cc *ecc, bool legacy_mode)\n> \ts_ddev->dst_addr_widths = EDMA_DMA_BUSWIDTHS;\n> \ts_ddev->directions |= (BIT(DMA_DEV_TO_MEM) | BIT(DMA_MEM_TO_DEV));\n> \ts_ddev->residue_granularity = DMA_RESIDUE_GRANULARITY_BURST;\n> +\ts_ddev->max_burst = SZ_32K - 1; /* CIDX: 16bit signed */\n> \n> \ts_ddev->dev = ecc->dev;\n> \tINIT_LIST_HEAD(&s_ddev->channels);\n> -- \n> 2.14.1\n> \n> \n> Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki\n> \n>","headers":{"Return-Path":"","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org\n\theader.b=\"udvOH051\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xyjhs0ZQ7z9t4r\n\tfor ;\n\tFri, 22 Sep 2017 03:07:25 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dv4wb-0000a0-6N; Thu, 21 Sep 2017 17:07:21 +0000","from mga14.intel.com ([192.55.52.115])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dv4wB-0000VQ-RV for linux-arm-kernel@lists.infradead.org;\n\tThu, 21 Sep 2017 17:06:57 +0000","from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t21 Sep 2017 10:06:30 -0700","from vkoul-udesk7.iind.intel.com (HELO localhost) ([10.223.84.143])\n\tby fmsmga002.fm.intel.com with ESMTP; 21 Sep 2017 10:06:25 -0700"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:\n\tMessage-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=7Jc8CSAGNz67+3fBR/TwKgHr9bwhLSLA34VqXgBIlys=;\n\tb=udvOH0515dl6So\n\tjHPNpSzV6Hrbjw1Yt6/JOPKJr9YwhpcqylkIyHdblubhO6UHLcKmqPwgLeuTmEt75+dpJBYNckN+y\n\tYhMxAIBcR4eHXN5zeCPYx5DBHy9sHrY2McmmcRVDKA0sQfZvObtuOjLuK5GbuZmJlVPSjsT4+99t/\n\tqOqOhQiOHEiSTXD4jYe5a3DroswfjXrLMV/v7+fIROTszz6xFcA9vc/8uCq7l4AEYrdf3ZCgQ/8jY\n\tjmdbSiylb8Pxm11yLVJsueXN+OvS/vI8lW4bSuHZLKseXbXn9WKtHIT1aHIe67y3C6/9nWdeHBG4/\n\tUVGpuBrN03GbROYP/aVg==;","X-ExtLoop1":"1","X-IronPort-AV":"E=Sophos; i=\"5.42,425,1500966000\"; d=\"scan'208\";\n\ta=\"1221994721\"","Date":"Thu, 21 Sep 2017 22:40:18 +0530","From":"Vinod Koul ","To":"Peter Ujfalusi ","Subject":"Re: [PATCH 1/5] dmaengine: edma: Implement protection for invalid\n\tmax_burst","Message-ID":"<20170921171018.GE30097@localhost>","References":"<20170912104424.18495-1-peter.ujfalusi@ti.com>\n\t<20170912104424.18495-2-peter.ujfalusi@ti.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20170912104424.18495-2-peter.ujfalusi@ti.com>","User-Agent":"Mutt/1.5.24 (2015-08-30)","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170921_100655_901504_FC006F69 ","X-CRM114-Status":"GOOD ( 13.98 )","X-Spam-Score":"-6.9 (------)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-6.9 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-5.0 RCVD_IN_DNSWL_HI RBL: Sender listed at http://www.dnswl.org/,\n\thigh trust [192.55.52.115 listed in list.dnswl.org]\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t-0.0 RP_MATCHES_RCVD Envelope sender domain matches handover relay\n\tdomain\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"linux-kernel@vger.kernel.org, t-kristo@ti.com, dmaengine@vger.kernel.org,\n\tdan.j.williams@intel.com, linux-omap@vger.kernel.org,\n\tlinux-arm-kernel@lists.infradead.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-arm-kernel\" ","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}}]