[{"id":1767433,"web_url":"http://patchwork.ozlabs.org/comment/1767433/","msgid":"","list_archive_url":null,"date":"2017-09-12T23:41:50","subject":"Re: [PATCH v4 1/2] ip_tunnel: fix ip tunnel lookup in collect_md\n\tmode","submitter":{"id":68043,"url":"http://patchwork.ozlabs.org/api/people/68043/","name":"Pravin Shelar","email":"pshelar@ovn.org"},"content":"On Tue, Sep 12, 2017 at 2:47 AM, Haishuang Yan\n wrote:\n> In collect_md mode, if the tun dev is down, it still can call\n> ip_tunnel_rcv to receive on packets, and the rx statistics increase\n> improperly.\n>\n> When the md tunnel is down, it's not neccessary to increase RX drops\n> for the tunnel device, packets would be recieved on fallback tunnel,\n> and the RX drops on fallback device will be increased as expected.\n>\n> Fixes: 2e15ea390e6f (\"ip_gre: Add support to collect tunnel metadata.\")\n> Cc: Pravin B Shelar \n> Signed-off-by: Haishuang Yan \nAcked-by: Pravin B Shelar ","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xsLtQ19Z0z9t3J\n\tfor ;\n\tWed, 13 Sep 2017 09:42:06 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751469AbdILXly (ORCPT );\n\tTue, 12 Sep 2017 19:41:54 -0400","from relay2-d.mail.gandi.net ([217.70.183.194]:56673 \"EHLO\n\trelay2-d.mail.gandi.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751105AbdILXlw (ORCPT\n\t); Tue, 12 Sep 2017 19:41:52 -0400","from mail-wm0-f44.google.com (mail-wm0-f44.google.com\n\t[74.125.82.44]) (Authenticated sender: pshelar@ovn.org)\n\tby relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 2258AC5A54;\n\tWed, 13 Sep 2017 01:41:50 +0200 (CEST)","by mail-wm0-f44.google.com with SMTP id 189so3632896wmh.1;\n\tTue, 12 Sep 2017 16:41:50 -0700 (PDT)","by 10.223.150.36 with HTTP; Tue, 12 Sep 2017 16:41:50 -0700 (PDT)"],"X-Originating-IP":"74.125.82.44","X-Gm-Message-State":"AHPjjUhmVsImZcN93TQuvfPy7cZkjES2+1aMzFATkS7dCPzoeWsT7VWo\n\t6jH12Wvr/fScFhQSXdpBoEpGGOVp03lEFeNzDNw=","X-Google-Smtp-Source":"AOwi7QDRsKtdRSYQtCtVCscl7TD3vf1IRt7JzrKsOoKVw9HRYpNRKXrxopKVW3RBDIYx42TSWfGx2yLtVP9FOEUWO4A=","X-Received":"by 10.28.71.135 with SMTP id m7mr784800wmi.84.1505259710680; Tue,\n\t12 Sep 2017 16:41:50 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<1505209677-12728-1-git-send-email-yanhaishuang@cmss.chinamobile.com>","References":"<1505209677-12728-1-git-send-email-yanhaishuang@cmss.chinamobile.com>","From":"Pravin Shelar ","Date":"Tue, 12 Sep 2017 16:41:50 -0700","X-Gmail-Original-Message-ID":"","Message-ID":"","Subject":"Re: [PATCH v4 1/2] ip_tunnel: fix ip tunnel lookup in collect_md\n\tmode","To":"Haishuang Yan ","Cc":"\"David S. Miller\" ,\n\tAlexey Kuznetsov ,\n\tHideaki YOSHIFUJI ,\n\tLinux Kernel Network Developers ,\n\tlinux-kernel@vger.kernel.org, Pravin B Shelar ","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1767531,"web_url":"http://patchwork.ozlabs.org/comment/1767531/","msgid":"<20170912.204551.2114618573326791125.davem@davemloft.net>","list_archive_url":null,"date":"2017-09-13T03:45:51","subject":"Re: [PATCH v4 1/2] ip_tunnel: fix ip tunnel lookup in collect_md\n\tmode","submitter":{"id":15,"url":"http://patchwork.ozlabs.org/api/people/15/","name":"David Miller","email":"davem@davemloft.net"},"content":"From: Haishuang Yan \nDate: Tue, 12 Sep 2017 17:47:56 +0800\n\n> In collect_md mode, if the tun dev is down, it still can call\n> ip_tunnel_rcv to receive on packets, and the rx statistics increase\n> improperly.\n> \n> When the md tunnel is down, it's not neccessary to increase RX drops\n> for the tunnel device, packets would be recieved on fallback tunnel,\n> and the RX drops on fallback device will be increased as expected.\n> \n> Fixes: 2e15ea390e6f (\"ip_gre: Add support to collect tunnel metadata.\")\n> Cc: Pravin B Shelar \n> Signed-off-by: Haishuang Yan \n\nApplied.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xsSHm34ZSz9sNr\n\tfor ;\n\tWed, 13 Sep 2017 13:45:56 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751831AbdIMDpy (ORCPT );\n\tTue, 12 Sep 2017 23:45:54 -0400","from shards.monkeyblade.net ([184.105.139.130]:37294 \"EHLO\n\tshards.monkeyblade.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751381AbdIMDpx (ORCPT\n\t); Tue, 12 Sep 2017 23:45:53 -0400","from localhost (74-93-104-98-Washington.hfc.comcastbusiness.net\n\t[74.93.104.98]) (using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\t(Authenticated sender: davem-davemloft)\n\tby shards.monkeyblade.net (Postfix) with ESMTPSA id 6E86010241E26;\n\tTue, 12 Sep 2017 20:45:52 -0700 (PDT)"],"Date":"Tue, 12 Sep 2017 20:45:51 -0700 (PDT)","Message-Id":"<20170912.204551.2114618573326791125.davem@davemloft.net>","To":"yanhaishuang@cmss.chinamobile.com","Cc":"kuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org,\n\tnetdev@vger.kernel.org, linux-kernel@vger.kernel.org, pshelar@nicira.com","Subject":"Re: [PATCH v4 1/2] ip_tunnel: fix ip tunnel lookup in collect_md\n\tmode","From":"David Miller ","In-Reply-To":"<1505209677-12728-1-git-send-email-yanhaishuang@cmss.chinamobile.com>","References":"<1505209677-12728-1-git-send-email-yanhaishuang@cmss.chinamobile.com>","X-Mailer":"Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO)","Mime-Version":"1.0","Content-Type":"Text/Plain; charset=us-ascii","Content-Transfer-Encoding":"7bit","X-Greylist":"Sender succeeded SMTP AUTH, not delayed by\n\tmilter-greylist-4.5.12 (shards.monkeyblade.net\n\t[149.20.54.216]); Tue, 12 Sep 2017 20:45:52 -0700 (PDT)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]